Commit graph

55 commits

Author SHA1 Message Date
Chris Maynard
647c5c0b27 packet_info's in_error_pkt is now a bitfield like in_gre_pkt.
svn path=/trunk/; revision=39764
2011-11-08 18:39:11 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier
781129806f Fix ex "modeline" so it works;
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748

svn path=/trunk/; revision=39081
2011-09-21 17:49:11 +00:00
Stig Bjørlykke
f282154ab0 Use correct encoding for proto_tree_add_item().
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Jeff Morriss
50e1634f4c Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value()
so that if the start_ptr is NULL the bytes are extracted from the given TVB
using the given offset and length.

Replace a bunch of:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...])

with:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...])

svn path=/trunk/; revision=35896
2011-02-10 16:31:00 +00:00
Stig Bjørlykke
84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly.
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Stig Bjørlykke
db82c54bef Ensure we keep the pkg_data pointer for the init routine to cleanup correctly,
because the ep memory is cleared before the init routine is called.

Fixed the variable name for the no_yes true_false_string.
Update reference to protocol description.

svn path=/trunk/; revision=35626
2011-01-22 18:07:28 +00:00
Jeff Morriss
867bf1477e Use nstime_set_zero() to initialize nstime_t's.
svn path=/trunk/; revision=35622
2011-01-22 15:35:34 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Stig Bjørlykke
710f41b085 Avoid printing double p_mul.pdu_type in custom columns.
svn path=/trunk/; revision=34387
2010-10-05 20:46:34 +00:00
Stig Bjørlykke
539b558f8c Renamed some reassembled data texts.
Removed some check_col().

svn path=/trunk/; revision=31809
2010-02-06 18:20:21 +00:00
Stig Bjørlykke
98df26f3a9 Added protocol name to "Reassembled length" text.
svn path=/trunk/; revision=31774
2010-02-02 22:32:31 +00:00
Stig Bjørlykke
88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Guy Harris
8e236e55de For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.

svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
Stig Bjørlykke
4bcde1958f Add PDU Delay for first data packet.
svn path=/trunk/; revision=31095
2009-11-27 14:29:38 +00:00
Bill Meier
ca1cba6f30 Don't coerce a (void *) to a (guint32 *).
The (void *) pointer in this case may point to
"unaligned" data.

svn path=/trunk/; revision=29378
2009-08-11 13:44:35 +00:00
Gerald Combs
595f9b6630 Convert a GString to an ep_strbuf_t (and squelch a static analysis
warning in the process). Remove an unused variable.

svn path=/trunk/; revision=29308
2009-08-05 19:03:48 +00:00
Bill Meier
65faee6470 Set editor modelines to be consistent between emacs and vi/ex;
Indentation and whitespace cleanup;

svn path=/trunk/; revision=29180
2009-07-23 17:46:09 +00:00
Stig Bjørlykke
d00c2baf5c Remove some check_col() calls.
svn path=/trunk/; revision=28974
2009-07-07 10:07:42 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke
26d30411b6 Adjusted my name to use only ASCII characters.
svn path=/trunk/; revision=27733
2009-03-15 21:13:27 +00:00
Stig Bjørlykke
248ca24f4f Removed mark for unused pinfo, its in use.
svn path=/trunk/; revision=27537
2009-02-25 00:28:19 +00:00
Gerald Combs
6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs
fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Stig Bjørlykke
9168a0a714 Added total time analysis from Address to Ack-Ack PDU.
Renamed previous total time to transmission time.

svn path=/trunk/; revision=26428
2008-10-13 14:59:28 +00:00
Stig Bjørlykke
acd4e734c9 From Mattias Nissler (bug 2936):
Fix some gpointer casts.

svn path=/trunk/; revision=26347
2008-10-03 17:01:08 +00:00
Stig Bjørlykke
6882a5cd1a Several improvements:
- Split SEQ/ACK analysis into SEQ analysis (pr msg) and ACK analysis
  (pr dest/ackinfo entry) to correctly handle multicast messages.
- Improved dump of timestamp (in units of 100ms).
- Show Address PDU with 0 dest entries as Ack-Ack PDU.
- Print correct number of missing sequence numbers in Ack.
- Indicate end of list entry in Ack.
- Message ID is unsigned.

svn path=/trunk/; revision=26345
2008-10-03 14:58:53 +00:00
Stig Bjørlykke
2a4ddda66a Added option to decode as BER encoded ASN.1.
Dump as data if no decoding.

svn path=/trunk/; revision=26339
2008-10-02 15:47:06 +00:00
Bill Meier
5ac2ba6354 Minor changes related to proto_reg_handoff & pref ranges
svn path=/trunk/; revision=26254
2008-09-23 15:03:39 +00:00
Bill Meier
a3e6eb8071 Minor cleanup mostly related to proto_reg_handoff
svn path=/trunk/; revision=26236
2008-09-19 17:39:44 +00:00
Stig Bjørlykke
7cf79249e0 Only use one IP address for seq/ack analysis.
Use correct length for dest entry and ack info entry.
Print correct id list for acks.

svn path=/trunk/; revision=26059
2008-08-22 15:15:56 +00:00
Stig Bjørlykke
6b1c605ca4 Added handling of missing sequence number range in ack.
Add all message ids in ack to the info column.
Changed data types for sequence number and total number of pdus.
Untabify file.

svn path=/trunk/; revision=26031
2008-08-15 07:59:11 +00:00
Stig Bjørlykke
a3e13c0e3a Register dissector by name.
svn path=/trunk/; revision=25180
2008-04-25 19:25:49 +00:00
Stig Bjørlykke
c714042d2f Updated to Version 2.0 Draft 6.
Removed unofficial port numbers.

svn path=/trunk/; revision=24582
2008-03-07 12:22:20 +00:00
Stig Bjørlykke
3590fc0713 Changed to checksum_good and checksum_bad to align with other dissectors.
svn path=/trunk/; revision=24115
2008-01-16 19:16:30 +00:00
Stig Bjørlykke
1c68fd7a75 Added total retransmission time analysis field.
svn path=/trunk/; revision=23924
2007-12-19 11:25:47 +00:00
Stig Bjørlykke
6f9241bca7 - Added first version of P_Mul sequence analysis.
- Added expert info for Discard_Message_PDU.

svn path=/trunk/; revision=23922
2007-12-19 10:05:42 +00:00
Stig Bjørlykke
4e9892cbfd Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23590
2007-11-25 21:30:57 +00:00
Stig Bjørlykke
c787b310eb Added port range.
svn path=/trunk/; revision=23491
2007-11-19 07:26:53 +00:00
Anders Broman
1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Stig Bjørlykke
af2d10d5bf - Added option to use relative message id (MSID)
- Added generated entry for total missing sequence numbers
- Added expert info on invalid ack info length
- Added count of ack in info column

svn path=/trunk/; revision=23079
2007-10-06 11:28:09 +00:00
Stig Bjørlykke
d2bc64938c Added expert info for length issues.
svn path=/trunk/; revision=22648
2007-08-24 23:27:33 +00:00
Stig Bjørlykke
1ac635cd7d When calculating checksum for p_mul the checksum field itself is set to zero.
Ensure this field is inside the buffer before altering it, so we don't 
write outside the allocated buffer.

svn path=/trunk/; revision=22529
2007-08-16 20:54:43 +00:00
Jeff Morriss
3dec62b85c - s/ntohs/g_ntohs
- s/ntohl/g_ntohl
- s/free/g_free
- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string()
- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode()
- Change some tvb_get_string() calls that were clearly memory leaks (like
  atoi(tvb_get_string(...))) into tvb_get_ephemeral_string()

svn path=/trunk/; revision=22515
2007-08-15 22:27:52 +00:00
Stig Bjørlykke
0cab42b465 Use fragment_start_seq_check to start defragmentation when receiving an
Address PDU without adding a empty message fragment.

svn path=/trunk/; revision=22514
2007-08-15 22:26:00 +00:00
Anders Broman
c01f382974 Second step in introducing asn context to BER dissectors just like in PER.
svn path=/trunk/; revision=21753
2007-05-13 20:58:29 +00:00
Stephen Fisher
d565967b58 From Peter Johansson:
Fix warnings


svn path=/trunk/; revision=21214
2007-03-26 21:16:21 +00:00
Graeme Lunt
835fd8749e This patch adds some expert info in P_Mul when:
- Checksum failure
- Missing sequence numbers

http://www.wireshark.org/lists/wireshark-dev/200702/msg00357.html


svn path=/trunk/; revision=20747
2007-02-08 17:15:45 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00