Commit graph

56 commits

Author SHA1 Message Date
Jörg Mayer
c946b6c3a2 Move generated dissctors that are causing problems to DIRTY.
packet-x11.c: hundreds of:

/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h:27994:9: warning: variable ‘f_resource’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext_Reply’:

dissectors/packet-dcerpc-mapi.c: set but not used
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_req’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8592:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_repl’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8617:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_RecipSMTP’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8848:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]


dissecots/packet-dcerpc-drsuapi.c: set but not used
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c: In function ‘drsuapi_dissect_DsGetNCChangesCtr7’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c:2920:17: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]

Btw.: Does it really make sense to use an extra CMakefile for the dcerpc/ dir?
      I'd rather the the idl2wrs.c in tools/ and the generatorstuff in epan/CMake

More files with the same problem.

svn path=/trunk/; revision=39968
2011-11-21 13:52:35 +00:00
Guy Harris
464778ed69 More misspellings of "unknown", for bug 6244.
svn path=/trunk/; revision=38565
2011-08-16 16:26:50 +00:00
Guy Harris
c34b796445 Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
representation.  Use it rather than a raw 0x10.

Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".

Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.

Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().

Clean up white space.

svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Stig Bjørlykke
4244ec0357 Remove Makefile.in when 'make maintainer-clean'.
svn path=/trunk/; revision=37796
2011-06-27 08:02:46 +00:00
Stephen Fisher
42dbbb9090 Fix r35690: tvb_get_unicode_string() takes length in 8-bit bytes, not
16-bit UTF-16 characters as tvb_fake_unicode() did.


svn path=/trunk/; revision=35691
2011-01-28 20:12:12 +00:00
Stephen Fisher
2040a3421d Change tvb_fake_unicode() to tvb_get_unicode_string() in the DCERPC
DRSUAPI dissector.  Updated the packet-dcerpc-drsuapi.c file manually
because it used to be auto-generated, but appears to have had changes
since then.


svn path=/trunk/; revision=35690
2011-01-28 20:07:18 +00:00
Gerald Combs
01568c1709 Make sure some variables are initialized.
svn path=/trunk/; revision=33340
2010-06-27 21:47:06 +00:00
Guy Harris
347e7a0052 More <stdarg.h> cleanup; some are real bugs, some are just "don't do
va_start and va_end unless you're actually going to use the va_list"
(those bring the va_start and va_end closer to the use point, which
makes it a little more obvious that we're using <stdarg.h> correctly and
makes it a little harder to use it incorrectly).

svn path=/trunk/; revision=32963
2010-05-26 02:25:13 +00:00
Jeff Morriss
7575b52df7 Add epan/dissectors/dcerpc/ and epan/dissectors/pidl/ to the source distribution
svn path=/trunk/; revision=32879
2010-05-18 15:58:49 +00:00
Kovarththanan Rajaratnam
82a7293640 Handle fgets() error path
svn path=/trunk/; revision=32867
2010-05-18 08:22:42 +00:00
Jeff Morriss
a21b548200 Set SVN properties
svn path=/trunk/; revision=32809
2010-05-14 17:05:50 +00:00
Jörg Mayer
9ee31d1d0e cmake will now honor -Werror if configured (default: on)
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
Stig Bjørlykke
7b138b5455 Use unsigned int for flags to avoid another warning.
svn path=/trunk/; revision=30615
2009-10-19 13:29:01 +00:00
Stig Bjørlykke
17aae178a9 Various code cleanup:
- Added standard copyright boiler plate
- Made all local functions static
- Added several checks for valid pointers
- Fixed some variable shadowing
- Fixed some printf formats (%p)
- Removed unused variables

svn path=/trunk/; revision=30613
2009-10-19 13:22:45 +00:00
Kovarththanan Rajaratnam
c82f5a7085 Make all global variables static
svn path=/trunk/; revision=30548
2009-10-12 16:59:12 +00:00
Kovarththanan Rajaratnam
913da7cda9 Remove temp files on (clean) exit
svn path=/trunk/; revision=30547
2009-10-12 16:57:23 +00:00
Kovarththanan Rajaratnam
3a0ba6b1cb Let the pidl subdirectory indicate which protocols it contains
svn path=/trunk/; revision=30540
2009-10-12 15:07:56 +00:00
Kovarththanan Rajaratnam
bf2ec50430 Autogenerating epan/dissectors/dcerpc/* now works
svn path=/trunk/; revision=30465
2009-10-10 08:10:28 +00:00
Kovarththanan Rajaratnam
0c8dbe1b49 Only dump to stderr if IDL2WRS_DEBUG is defined
svn path=/trunk/; revision=30464
2009-10-10 08:02:57 +00:00
Kovarththanan Rajaratnam
64e717ee94 First stab at autogenerating budb dissector
svn path=/trunk/; revision=30463
2009-10-10 06:45:04 +00:00
Kovarththanan Rajaratnam
142131917c Compile and link idl2wrs
svn path=/trunk/; revision=30460
2009-10-10 05:35:21 +00:00
Kovarththanan Rajaratnam
49be939059 Add common include file (boiler plate)
svn path=/trunk/; revision=30424
2009-10-09 09:34:07 +00:00
Kovarththanan Rajaratnam
3b20964c84 Update makefiles to use new template names
svn path=/trunk/; revision=30423
2009-10-09 09:16:58 +00:00
Kovarththanan Rajaratnam
3199e524c9 Give the template filenames more uniqueness
svn path=/trunk/; revision=30422
2009-10-09 09:12:59 +00:00
Kovarththanan Rajaratnam
58217b6aa0 Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS
svn path=/trunk/; revision=30419
2009-10-09 08:57:52 +00:00
Kovarththanan Rajaratnam
25fd70c3f1 Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS
svn path=/trunk/; revision=30418
2009-10-09 08:57:10 +00:00
Kovarththanan Rajaratnam
97c5c65bd5 Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS
svn path=/trunk/; revision=30417
2009-10-09 08:55:59 +00:00
Bill Meier
8b251e382c (Trivial) Fix a typo in a comment.
svn path=/trunk/; revision=29901
2009-09-14 16:38:06 +00:00
Anders Broman
e4fea1939c From Kovarththanan Rajaratnam:
- Fix ncp2222.py and all the epan/dissectors/dcerpc dissectors. The
latter required changes to idl2wrs which used variadic macros (not supported in MSVC 6.0).

- Cleanup PIDL conformance files

svn path=/trunk/; revision=28856
2009-06-27 10:31:42 +00:00
Ronnie Sahlberg
171a98950c EFS is generated by PIDL now so we dont need the old idl2wrs folder any more
svn path=/trunk/; revision=19343
2006-09-27 20:56:15 +00:00
Gerald Combs
b15974d094 libethereal -> libwireshark. idl2eth -> idl2wrs. There are a _lot_ of
changes here.  It compiles OK on OS X, but hasn't been tested anywhere else.

svn path=/trunk/; revision=18260
2006-05-31 00:23:01 +00:00
Ronnie Sahlberg
89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Ronnie Sahlberg
1cfe020e5b remove the old dssetup since we now generate it using pidl
svn path=/trunk/; revision=16189
2005-10-11 09:32:49 +00:00
Ronnie Sahlberg
b7f996e628 delete the old dissector
svn path=/trunk/; revision=15819
2005-09-15 10:20:08 +00:00
Jörg Mayer
4f693dfae2 Some warning fixes for "no previous declaration"
Remove svn:executable
Add svn:eol-style native
Add svn:keywords Id


svn path=/trunk/; revision=15179
2005-08-02 05:39:45 +00:00
Ronnie Sahlberg
618724969c convert two other autogenerated dissectors to use FT_GUID
svn path=/trunk/; revision=14913
2005-07-13 08:24:05 +00:00
Ronnie Sahlberg
3905fca8bc make idl2eth generate FT_GUID hf fields for uuid_t and GUID types.
make dissect_dcerpc_uuid_t() accept eitehr FT_STRING (old style) and FT_GUID (new style) hf fields. once all dissectors are modified to use FT_GUID we can remove the FT_STRING support here.

regenerate the DRSUAPI interface with the new FT_GUID support.




svn path=/trunk/; revision=14912
2005-07-13 08:00:15 +00:00
Ronnie Sahlberg
14cd9627b7 make dssetup an autogenerated dissector
and cancel my checkins from an hour ago, but they show the evolvement of the dissector at least. :-)



svn path=/trunk/; revision=14215
2005-04-28 09:50:03 +00:00
Ronnie Sahlberg
1af7ff9672 make idl2eth handle 8bit bitmaps
make atsvc an autogenerated dcerpc dissector


svn path=/trunk/; revision=13808
2005-03-19 14:30:05 +00:00
Ronnie Sahlberg
20d135115b bugfix to idl2eth : handle the case when pointers were not explicitely specified
and we have a pointer to an array of pointers

make the EFS dissector autogenerated by idl2eth



svn path=/trunk/; revision=13806
2005-03-19 09:11:56 +00:00
Ronnie Sahlberg
bfdd246e65 make idl2eth able to handle negative case tags
svn path=/trunk/; revision=13764
2005-03-16 11:39:46 +00:00
Ronnie Sahlberg
525bdb673b decode some more of drsuapi
svn path=/trunk/; revision=13763
2005-03-16 11:29:09 +00:00
Ronnie Sahlberg
b140a83293 more idl2eth and drsuapi updates
svn path=/trunk/; revision=13759
2005-03-15 09:36:18 +00:00
Ronnie Sahlberg
5d7b72fd86 update to idl2eth adding WERROR as a built in type
svn path=/trunk/; revision=13758
2005-03-15 08:24:10 +00:00
Ronnie Sahlberg
1fe0f9022e a lot of people dont specify top level pointers in teh idl and just
cerlare it as a parameter that is a struct/union and not a ref pointer to one.

this is ok since toplevel ref pointers are invisible in the wire encoding anyway.

unfortunatelky  ethereal dce runtime needed to see that pointer to keep track of whisch one was a toplevel and which one wasnt.


implement a new api to call pointers which explicitely specifies whether the pointer is toplevel or embedded.
eventually all dce dissectors will use this new interface and the generic dissect_ndr_pointer() can be retired.



svn path=/trunk/; revision=13755
2005-03-14 20:51:13 +00:00
Ronnie Sahlberg
59b3267d40 updates for drsuapi
svn path=/trunk/; revision=13748
2005-03-14 09:49:58 +00:00
Ronnie Sahlberg
3a26213e88 the previous drsuapi patch showed how idl2eth can handle embedded arrays just fine.
beautifully fine.

this patch overrides the array,   tells idl2eth to not generate code to unmarshall the conformance blob or the data for the array.

a handwritted replacement function is implemented in the template instead which prettifies the output a lot.



svn path=/trunk/; revision=13735
2005-03-12 12:04:44 +00:00
Ronnie Sahlberg
2ee14eef27 refine IDL
svn path=/trunk/; revision=13733
2005-03-12 10:55:50 +00:00
Ronnie Sahlberg
cc6d037933 fix small bug from previous checkin for fixed arrays
svn path=/trunk/; revision=13730
2005-03-12 09:24:54 +00:00
Ronnie Sahlberg
0e3ff62701 initial DRSUAPI dissector
now that we can decrypt DCERPC

the dissection is not complete since idl2eth can not yet handle
all the weird extensions in the idl file yet.


svn path=/trunk/; revision=13729
2005-03-12 09:02:01 +00:00