Commit graph

5011 commits

Author SHA1 Message Date
Guy Harris
78216336d8 From Jeff Morriss: get rid of an unused function argument.
Use -1 rather than "tvb_length(tvb)" as the length for the top-level
protocol item.

Don't initialize "sccp_item" - it's not used if "tree" is null.

svn path=/trunk/; revision=5089
2002-04-02 22:42:11 +00:00
Guy Harris
9971cb529e From Tom Uijldert: comment out an unused function.
svn path=/trunk/; revision=5088
2002-04-02 20:16:19 +00:00
Uwe Girlich
f675fc93c3 code cleanup: removed unused parameter
svn path=/trunk/; revision=5087
2002-04-02 06:29:48 +00:00
Uwe Girlich
73bd3782b6 code cleanup, removed unused parameters, inserted some _U_
svn path=/trunk/; revision=5086
2002-04-02 06:28:16 +00:00
Guy Harris
e363ae0f77 Add in the neighbor probe messages (but without any dissection of the
Neighbors 2 message).

Get rid of the unused "hf_naddr" field.

svn path=/trunk/; revision=5085
2002-04-02 05:12:12 +00:00
Guy Harris
5f948e482c In the tree-printing code, we may be handed a leaf node, so don't
require that "fi->tree_type" be positive.

svn path=/trunk/; revision=5084
2002-04-02 05:07:36 +00:00
Guy Harris
590c3c0f8c Fix a typo.
svn path=/trunk/; revision=5083
2002-04-02 01:34:15 +00:00
Guy Harris
15fc29c820 Fix a bunch of bits of code that used "tvb_get_ntohl()" to fetch IP
addresses and then tried to compensate for that error using "htonl()"
(or didn't bother compensating, in some cases).

svn path=/trunk/; revision=5082
2002-04-02 01:32:46 +00:00
Guy Harris
49de302c84 Use "tvb_memcpy()", not "tvb_get_ptr()" followed by "memcpy()".
svn path=/trunk/; revision=5081
2002-04-02 01:32:11 +00:00
Guy Harris
e6272e1605 Fix a call to "proto_tree_add_ipv4()" that was supposed to be a call to
"proto_tree_add_item()".

svn path=/trunk/; revision=5080
2002-04-02 01:28:14 +00:00
Guy Harris
0a05bfbeff Just use "proto_tree_add_item()" to add IP addresses - don't bother
copying to a variable and then using that.

svn path=/trunk/; revision=5079
2002-04-02 01:25:08 +00:00
Guy Harris
24f5a37e3f Get rid of unused macro.
svn path=/trunk/; revision=5078
2002-04-02 00:18:53 +00:00
Guy Harris
49d51f81e5 Get rid of declarations of routines and structures and function types
that we no longer use as of 0.9.0 (when we got rid of support for
non-tvbuffified dissectors).

svn path=/trunk/; revision=5077
2002-04-02 00:04:18 +00:00
Guy Harris
94a3e0ce9f Make some routines not used outside "packet-rpc.c" static.
svn path=/trunk/; revision=5076
2002-04-01 23:56:41 +00:00
Guy Harris
7f0c93cf5f Use "proto_tree_add_item()" to add IP addresses; that eliminates a bunch
of work *and* gets rid of the incorrect "convert from network to host
byte order and then byte-swap" code.

svn path=/trunk/; revision=5075
2002-04-01 22:40:20 +00:00
Guy Harris
db3328892c Fix to decoding of the AUTHORIZE call, from Mike Frisch.
svn path=/trunk/; revision=5074
2002-04-01 22:30:34 +00:00
Guy Harris
c0565b3fbe From Kikuchi Ayamura: include <ucd-snmp/ucd-snmp-config.h> to fix IRIX
compilation problems.

svn path=/trunk/; revision=5073
2002-04-01 22:00:00 +00:00
Guy Harris
f681e6f92c Bug fix from Mike Frisch.
svn path=/trunk/; revision=5072
2002-04-01 21:17:27 +00:00
Guy Harris
f969aba211 WebDAV support, and rewrite of the method-testing code to compute the
method length and use that in all comparisons, from Blair Cooper.

Fix the check for "M-" to check also whether there are at least two
characters in the line.

svn path=/trunk/; revision=5071
2002-04-01 21:12:31 +00:00
Guy Harris
3d6dc60340 From Andrew Feren: on Windows, in the drop-down list for the "Interface"
field in the "Capture Options" dialog, put the descriptive name of the
device in parentheses after the actual device path.

svn path=/trunk/; revision=5070
2002-04-01 21:09:59 +00:00
Guy Harris
8ae18ded80 From Andrew Feren: on Windows, in the drop-down list for the "Interface"
field in the "Capture Options" dialog, put the descriptive name of the
device in parentheses after the actual device path.

svn path=/trunk/; revision=5069
2002-04-01 03:55:44 +00:00
Guy Harris
5de2533f2d Start assigning ett_ values at 0, rather than 1; get rid of the reserved
ETT_NONE entry.

Initialize the "tree_type" field of a "field_info" structure to -1,
meaning "this has not been given a subtree".  Add checks before using
that field that it's in range.  That way, you have to create a subtree
before putting protocol tree items under another item.

We allocate the "tree_is_expanded" array when we've registered all
dissectors; there's no need to allocate it while we're registering
dissectors and, in fact, doing so means we leak memory (the memory for
the version we allocated while registering dissectors).

svn path=/trunk/; revision=5068
2002-04-01 02:00:53 +00:00
Guy Harris
d1f2aaf8ac Get rid of ett_ values for options with no subtrees.
Show the names of the control characters being mapped by the async
control character map option.

Use "proto_item_add_subtree()" to establish a subtree, so that the ett_
value gets associated with it.  (Unfortunately, "proto_item" and
"proto_tree" are typedefs for the same type, so checks for use of one
when you should be using the other aren't done at compile time.)

Get rid of some extra blanks before colons.

svn path=/trunk/; revision=5067
2002-04-01 00:51:43 +00:00
Guy Harris
f5c5669291 Get rid of unused arguments.
Use the "nb" argument to "redraw_hex_dump()", so we redraw the specified
byte view pane, rather than always redrawing the main window's byte view
pane (and never redrawing the byte view pane of additional packet
windows, so that the font for them doesn't change if you change the font
preference).

svn path=/trunk/; revision=5066
2002-03-31 23:11:04 +00:00
Guy Harris
48214be46f Get rid of an unused argument to "set_active_all()".
Mark as unused arguments that are now unused as a result of not passing
them to "set_active_all()".

svn path=/trunk/; revision=5065
2002-03-31 22:58:27 +00:00
Guy Harris
d535c27d4a The variables in question are only used if old unused code is present.
Fix the #ifdef.

svn path=/trunk/; revision=5064
2002-03-31 22:50:34 +00:00
Guy Harris
2963d86afd (Conditionally) mark unused variables as such.
svn path=/trunk/; revision=5063
2002-03-31 22:43:47 +00:00
Guy Harris
7212bcc1e9 Mark unused arguments as such.
svn path=/trunk/; revision=5062
2002-03-31 22:43:03 +00:00
Guy Harris
57294d193a Mark unused variables with _U_ if they can't be eliminated.
Use the "optp" argument in more option dissectors, and set the name of
the option in the table entries for those options - and for one option
where that name *was* being used.

Get rid of unused variables.

svn path=/trunk/; revision=5061
2002-03-31 22:37:09 +00:00
Guy Harris
d5f04f86bf Get rid of an unused variable.
svn path=/trunk/; revision=5060
2002-03-31 22:17:37 +00:00
Guy Harris
a955f48784 Get rid of unused arguments.
svn path=/trunk/; revision=5059
2002-03-31 22:12:45 +00:00
Guy Harris
e4cd1b156c Get rid of an unused argument.
Use the reported length, not the captured length, of a tvbuff when
scanning through it.

Mark unused arguments that can't be eliminated as unused.

svn path=/trunk/; revision=5058
2002-03-31 21:43:51 +00:00
Guy Harris
4872882127 Get rid of an unused variable.
#ifdef out definitions of variables used only if the #ifdef is true.

svn path=/trunk/; revision=5057
2002-03-31 21:38:47 +00:00
Guy Harris
cb4e9ba54b Get rid of an unused argument.
svn path=/trunk/; revision=5056
2002-03-31 21:36:05 +00:00
Guy Harris
4e2a32d091 Get rid of an unused variable.
svn path=/trunk/; revision=5055
2002-03-31 21:33:51 +00:00
Guy Harris
2429666433 Put the LANE packet type in the Info column for ATM LANE traffic.
Get rid of an unused variable.

svn path=/trunk/; revision=5054
2002-03-31 21:23:47 +00:00
Guy Harris
8ed5e80e14 From Joerg Mayer: get rid of unused function arguments.
svn path=/trunk/; revision=5053
2002-03-31 21:09:00 +00:00
Guy Harris
2eb1990b0b From Joerg Mayer: mark function arguments as unused.
svn path=/trunk/; revision=5052
2002-03-31 21:05:47 +00:00
Guy Harris
6bc1cb1c7d From Joerg Mayer: mark function arguments as unused.
svn path=/trunk/; revision=5051
2002-03-31 20:59:47 +00:00
Guy Harris
63e8447614 From Joerg Mayer: get rid of unused arguments, and mark those that can't
be eliminated (because the function is called through a pointer, and
other functions called through the same pointer *do* use the argument)
as unused.

svn path=/trunk/; revision=5050
2002-03-31 20:57:02 +00:00
Guy Harris
a412a0cec5 From Joerg Mayer: mark function arguments as unused.
svn path=/trunk/; revision=5049
2002-03-31 20:39:08 +00:00
Guy Harris
e321fcbaf5 From Dinesh Dutt: get rid of unused variables, and fix a bug in the way
the device type is determined (create the hash entry regardless of
whether a protocol tree is being built).

svn path=/trunk/; revision=5048
2002-03-31 20:28:41 +00:00
Gerald Combs
98d6968b59 Update NEWS to release 0.9.3.
svn path=/trunk/; revision=5047
2002-03-30 17:43:31 +00:00
Ronnie Sahlberg
25972db6bb copylen should be unsigned when we check the range since tvb_memcpy will be upset if a negative value is passed as len
svn path=/trunk/; revision=5044
2002-03-29 21:55:05 +00:00
Ronnie Sahlberg
9ededb6b99 len and max_len were swapped in the UNICODE_STRING dissector
svn path=/trunk/; revision=5043
2002-03-29 04:35:48 +00:00
Gerald Combs
dade8cbf56 Bump the version to 0.9.3. Update NEWS to be current to
http://www.ethereal.com/lists/ethereal-cvs/200203/msg00175.html (the
rest will be added later).

svn path=/trunk/; revision=5042
2002-03-29 03:33:59 +00:00
Gerald Combs
df166b9d44 Periodic update.
svn path=/trunk/; revision=5041
2002-03-29 01:45:42 +00:00
Gerald Combs
395cace9a7 From Jakob Schlyter: add "PRACK" and "SPRACK" methods.
Change the behavior of the dissector to treat anything matching
"^.* .+:.+ SIP/2.0$" as a SIP request.  Methods that don't match our list
are labelled "unknown".

Convert some tabs to spaces to match the rest of the code.

svn path=/trunk/; revision=5040
2002-03-29 01:25:57 +00:00
Ashok Narayanan
018dce8c50 Changed TBA GMPLS object numbers to proposed IETF numbers.
svn path=/trunk/; revision=5039
2002-03-29 00:41:54 +00:00
Guy Harris
66e39af899 From Michael Tuexen: update to draft-ietf-sigtran-m3ua-12.
svn path=/trunk/; revision=5038
2002-03-28 21:48:46 +00:00