Use -1 rather than "tvb_length(tvb)" as the length for the top-level
protocol item.
Don't initialize "sccp_item" - it's not used if "tree" is null.
svn path=/trunk/; revision=5089
method length and use that in all comparisons, from Blair Cooper.
Fix the check for "M-" to check also whether there are at least two
characters in the line.
svn path=/trunk/; revision=5071
field in the "Capture Options" dialog, put the descriptive name of the
device in parentheses after the actual device path.
svn path=/trunk/; revision=5070
field in the "Capture Options" dialog, put the descriptive name of the
device in parentheses after the actual device path.
svn path=/trunk/; revision=5069
ETT_NONE entry.
Initialize the "tree_type" field of a "field_info" structure to -1,
meaning "this has not been given a subtree". Add checks before using
that field that it's in range. That way, you have to create a subtree
before putting protocol tree items under another item.
We allocate the "tree_is_expanded" array when we've registered all
dissectors; there's no need to allocate it while we're registering
dissectors and, in fact, doing so means we leak memory (the memory for
the version we allocated while registering dissectors).
svn path=/trunk/; revision=5068
Show the names of the control characters being mapped by the async
control character map option.
Use "proto_item_add_subtree()" to establish a subtree, so that the ett_
value gets associated with it. (Unfortunately, "proto_item" and
"proto_tree" are typedefs for the same type, so checks for use of one
when you should be using the other aren't done at compile time.)
Get rid of some extra blanks before colons.
svn path=/trunk/; revision=5067
Use the "nb" argument to "redraw_hex_dump()", so we redraw the specified
byte view pane, rather than always redrawing the main window's byte view
pane (and never redrawing the byte view pane of additional packet
windows, so that the font for them doesn't change if you change the font
preference).
svn path=/trunk/; revision=5066
Use the "optp" argument in more option dissectors, and set the name of
the option in the table entries for those options - and for one option
where that name *was* being used.
Get rid of unused variables.
svn path=/trunk/; revision=5061
Use the reported length, not the captured length, of a tvbuff when
scanning through it.
Mark unused arguments that can't be eliminated as unused.
svn path=/trunk/; revision=5058
be eliminated (because the function is called through a pointer, and
other functions called through the same pointer *do* use the argument)
as unused.
svn path=/trunk/; revision=5050
Change the behavior of the dissector to treat anything matching
"^.* .+:.+ SIP/2.0$" as a SIP request. Methods that don't match our list
are labelled "unknown".
Convert some tabs to spaces to match the rest of the code.
svn path=/trunk/; revision=5040