7537b3afa3
Add missing backslash.
...
svn path=/trunk/; revision=21579
2007-04-26 01:11:24 +00:00
bba0b00392
Rename HASH_ADDRESS to ADD_ADDRESS_TO_HASH, to make it clearer what it
...
does (i.e., it will add the address bytes to the value that's already
there - it will not initialize the value, so you have to clear it before
doing any hashing).
svn path=/trunk/; revision=21578
2007-04-26 01:01:27 +00:00
1ed26d317c
Add a macro for hashing the bytes of an address into a hash value.
...
Use it in the IAX2 dissector and in the conversation code.
svn path=/trunk/; revision=21577
2007-04-26 00:51:33 +00:00
41cafa2212
The data pointer of an address structure is a void *; convert it to a
...
guint8 * in order to look at the raw bytes of the address.
svn path=/trunk/; revision=21576
2007-04-26 00:03:41 +00:00
2a48544203
Check to make sure the address really *is* an IPv4 address.
...
If it is, convert the "void *" data pointer to a "guint8 *", so we can
look at the first byte.
svn path=/trunk/; revision=21575
2007-04-26 00:01:29 +00:00
e077465aa4
The data pointer in an address structure is a void *; if the address is
...
a MAC address, convert it to a guint8 * in order to look at the bytes of
the address.
svn path=/trunk/; revision=21574
2007-04-25 23:58:43 +00:00
ef5b370850
Use "address_to_str()" to format an address, rather than assuming it's
...
an IPv4 address.
svn path=/trunk/; revision=21573
2007-04-25 23:56:46 +00:00
9439c19e31
The data field of an address structure is a void *, so we can't look at
...
what it points to. Stop doing that in the code to check for source
routing.
svn path=/trunk/; revision=21572
2007-04-25 23:54:54 +00:00
17b1c57ec9
Fix the previous fix.
...
svn path=/trunk/; revision=21571
2007-04-25 23:31:22 +00:00
f5bd20cacf
Check that the addresses are FC addresses before looking at them.
...
If the address is an FC address, convert the data pointer to a guint8 *,
as it's a void *.
svn path=/trunk/; revision=21570
2007-04-25 23:11:22 +00:00
20611f65e4
Fail if the addresses being checked aren't Ethernet addresses.
...
svn path=/trunk/; revision=21569
2007-04-25 23:09:58 +00:00
e7fc05410d
Use "address_to_str()" to format an address, rather than assuming it's
...
an IPv4 address.
svn path=/trunk/; revision=21568
2007-04-25 22:33:47 +00:00
e26198a1f7
The data field of an address structure is now a void *; convert it as
...
appropriate.
Also, throw in a check for the types of the addresses.
svn path=/trunk/; revision=21567
2007-04-25 22:04:46 +00:00
2361eb46de
The data field of an address structure is now a void *; convert it as
...
appropriate.
svn path=/trunk/; revision=21566
2007-04-25 21:37:15 +00:00
7acd23c938
The "data" field of an address structure is a "void *"; when looking at
...
a MAC address, convert it to a "guint8 *".
svn path=/trunk/; revision=21565
2007-04-25 20:14:41 +00:00
99c0698b95
From Dustin Johnson:
...
- A-MSDU updates
- Secondary Channel Offset tag updates
- A-MPDU parameter updates
- Lots of string fixes updates
Fixup whitespace.
svn path=/trunk/; revision=21564
2007-04-25 19:38:47 +00:00
c3ac6f1e71
Some types of addresses are data structures; make the address data
...
pointer in an address structure a "void *", to indicate that it can
point to some arbitrary type of object, rather than a "guint8 *", which
indicates that it points to an array of bytes.
For any address type where the address is a structure, this removes some
alignment warnings; the author of the code to handle a particular
address type has the responsibility of making sure you don't set up the
address structure with misaligned data. (Yes, it matters, at least on
SPARC.)
svn path=/trunk/; revision=21563
2007-04-25 19:28:56 +00:00
cde0384abc
From Stig Bjørlykke:
...
Fix break placement for control frames in dissect_ieee80211_common()
svn path=/trunk/; revision=21562
2007-04-25 17:39:38 +00:00
dfcfaeeaa9
fread() return value can not match file size on Windows due CR/LF conversion - do not check it
...
svn path=/trunk/; revision=21560
2007-04-25 10:16:33 +00:00
70f0c88ea1
proto_tree_add_bits -> iuup_proto_tree_add_bits as discussed
...
on wireshark-dev to make it compile again
svn path=/trunk/; revision=21558
2007-04-24 21:26:40 +00:00
55507800aa
extraInfo was not propperly tagged causing ber decoding errors.
...
Fixes Bug 1554
svn path=/trunk/; revision=21557
2007-04-24 19:28:12 +00:00
fea883ebec
Add a new proto function proto_tree_add_bits() which adds bits to the tree
...
starting at the bit offset given for the number of bits indicated which wll also return
the value of the bits.
Experimental and for review, documentation to be updated.
svn path=/trunk/; revision=21556
2007-04-24 19:24:14 +00:00
8ff20a50ce
Fix definition of tvb_memcpy() to match declaration.
...
svn path=/trunk/; revision=21555
2007-04-24 17:12:29 +00:00
6f8cee8acd
"memcpy()" takes void *'s as arguments and returns a void *; have
...
tvb_memcpy() be similar, to avoid unnecessarily alignment warnings.
Do the same with "ep_tvb_memdup()".
svn path=/trunk/; revision=21554
2007-04-24 11:54:18 +00:00
0be322bad8
Try to squelch an alignment warning (we put "int"s into the array, so we
...
know the pointer's aligned appropriately for an array of "int"s).
svn path=/trunk/; revision=21552
2007-04-24 06:43:01 +00:00
3a0cdfb42b
add a missing change from the previous commit
...
svn path=/trunk/; revision=21548
2007-04-24 05:09:53 +00:00
1f80370b85
Add tracking of uid->domain/account mappings for SMB by tapping the ntlmssp tap for the information from the authentication messages
...
Improve the tid tracking by putting the host/share information on the tid expansion line so one can see it without opening the expansion
svn path=/trunk/; revision=21547
2007-04-24 05:09:00 +00:00
6386eda24c
Addt'l fixes so suite-unittests will run under windows
...
svn path=/trunk/; revision=21546
2007-04-24 03:43:08 +00:00
1b2cecda53
Need to include <epan/pint.h> to get pletohl() defined.
...
svn path=/trunk/; revision=21544
2007-04-23 22:34:31 +00:00
c0dc340d5d
From Florent DROUIN:
...
I have made some changes to the final patch to have the operation code decoded
as ForwardSM. A change for TCAP is included too, to be sure that the
application context is not overwritten by the User Info OID (this was the case,
when a MAP open dialog was included in the request).
Fix bug:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1498
svn path=/trunk/; revision=21543
2007-04-23 21:26:27 +00:00
d6fc852779
byteReverse assumes its argument is aligned on a 32-bit boundary; make
...
it a pointer to a guint32. Also, use pletohl() to fetch a 32-bit
little-endian quantity.
svn path=/trunk/; revision=21542
2007-04-23 21:23:30 +00:00
5a4771d9cb
The "in" array in an MD5 context is expected to be aligned on a 4-byte
...
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary
casts.
(Missed on the previous checkin.)
svn path=/trunk/; revision=21541
2007-04-23 21:12:04 +00:00
0acc6bc5b8
The "in" array in an MD5 context is expected to be aligned on a 4-byte
...
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary
casts.
svn path=/trunk/; revision=21540
2007-04-23 20:47:07 +00:00
cd66fcfe16
Remove a relic from experimental code.
...
svn path=/trunk/; revision=21539
2007-04-23 20:30:31 +00:00
b65e5b390a
TCAP: Fix up indentation a bit.
...
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.
svn path=/trunk/; revision=21538
2007-04-23 20:21:31 +00:00
d07a92f8bc
TCAP: Fix up indentation a bit.
...
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.
svn path=/trunk/; revision=21537
2007-04-23 20:20:46 +00:00
8e32c1e739
Get rid of no-longer-needed, and warning-generated, casts.
...
svn path=/trunk/; revision=21536
2007-04-23 18:30:29 +00:00
adcccbcdee
More const cleanup.
...
svn path=/trunk/; revision=21535
2007-04-23 18:18:08 +00:00
cdb59eed63
Make Mk16_le() work on both big-endian and little-endian processors and
...
on processors that don't support unaligned loads - just use pletohs().
svn path=/trunk/; revision=21534
2007-04-23 18:11:12 +00:00
6f4a938c64
Dissector table names should be pointed to by const pointers.
...
svn path=/trunk/; revision=21533
2007-04-23 17:40:33 +00:00
0e7e1ba0aa
Fix type cast to match target of assignment.
...
svn path=/trunk/; revision=21532
2007-04-23 17:38:56 +00:00
56fcbf41be
The "needles" argument of guint8_pbrk() needs to be const, as that's
...
what's passed to it.
svn path=/trunk/; revision=21531
2007-04-23 17:37:36 +00:00
877db595ff
Don't assume byte pointers can be safely cast to more aligned pointers;
...
the compiler now warns of that.
svn path=/trunk/; revision=21530
2007-04-23 17:33:29 +00:00
f010b46419
decode_as_dt's argument points to a dissector table name, so it should be
...
a const pointer.
svn path=/trunk/; revision=21529
2007-04-23 16:49:24 +00:00
552fff182e
Don't assume a pointer to UCHAR is necessarily aligned; that now
...
generates a warning.
svn path=/trunk/; revision=21528
2007-04-23 16:41:31 +00:00
90f8b1a080
From Paolo Abeni:
...
(from -dev list)
On Sun, 2007-04-22 at 23:06 +0200, Joerg Mayer wrote:
> Can someone please have a look at uand fix the following warning:
>
> cc1: warnings being treated as errors
> packet-ssl.c: In function 'ssl_parse':
> packet-ssl.c:334: warning: ignoring return value of 'fread', declared
> with attribute warn_unused_result
The attached patch fix the issue. It also try to fix a bit the
indentation.
Me: Move size_t nbytes up to top of function and fix typo expeted->expected
svn path=/trunk/; revision=21527
2007-04-23 16:22:34 +00:00
1bc049906a
Add some GCC warnings to the standard set, and add some others to the
...
--enable-extra-gcc-checks set.
If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.
Constify a bunch of stuff, and make some other changes, to get rid of
warnings.
Clean up some indentation.
svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
7dc9df5f26
Just use -1 to go to the end of a tvbuff.
...
svn path=/trunk/; revision=21525
2007-04-23 10:57:34 +00:00
20a3a52951
Mark all the items for TCAP statistics as generated
...
svn path=/trunk/; revision=21524
2007-04-23 10:45:00 +00:00
c84eda3a80
add request/response matching for ctdb
...
svn path=/trunk/; revision=21523
2007-04-23 09:44:13 +00:00
Guy Harris