Commit Graph

57 Commits

Author SHA1 Message Date
Bill Meier 96a24cc79f Fix spelling/typos found using a list of commonly misspelled words.
The misspellings were mostly in comments but some were
in text strings visible to the user.


svn path=/trunk/; revision=47899
2013-02-26 04:42:26 +00:00
Michael Mann 4f9707469d replaced decode_boolean_bitfield calls with itemized filters
added tfs_no_yes to tfs.[ch]

svn path=/trunk/; revision=45115
2012-09-25 01:00:41 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Bill Meier 6fbb09d50b General Cleanup including:
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);

svn path=/trunk/; revision=42678
2012-05-17 14:35:11 +00:00
Alexis La Goutte ff30e7df57 From jingzhang via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6590
Make wireshark to support SKINNY new version

Current wireshark version can not support the new skinny packets when the header version == "14 00 00 00". It should be the same handling process with "12 00 00 00"(CM7_MSG_TYPE_B), So we added the same function to support CM7_MSG_TYPE_C(we defined it by ourselves, just want to keep the consistency with CM7_MSG_TYPE_B).

From me :
Fix encoding attribut (via fix-encoding.args.pl)

svn path=/trunk/; revision=40263
2011-12-21 15:03:39 +00:00
Alexis La Goutte c2dbdb6f42 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=40262
2011-12-21 14:58:07 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Jörg Mayer 44b0026d68 Unify my address entry
svn path=/trunk/; revision=38750
2011-08-27 09:23:12 +00:00
Jörg Mayer 18735eaba5 Replace TRUE/FALSE with the new ENCAP stuff where appropriate
svn path=/trunk/; revision=38746
2011-08-26 17:02:33 +00:00
Alexis La Goutte 43b6279966 Fix a checkhf Warning
Unused entry: epan/dissectors/packet-skinny.c, hf_skinny_modifyConfRes

svn path=/trunk/; revision=37750
2011-06-22 12:30:07 +00:00
Alexis La Goutte ccd94a3e88 From mtwire via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6041
Added party numbers and party names in message CM5CallInfoMessage

svn path=/trunk/; revision=37748
2011-06-22 08:09:55 +00:00
Bill Meier d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Jeff Morriss 211b659885 From Mathieu Parent via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5826 :
Attached patch fixes dissection of ServiceURLStatMessage.

svn path=/trunk/; revision=36900
2011-04-27 15:23:20 +00:00
Anders Broman 312ad4e850 From Mathieu Parent:
- use 4-bytes hex for messages ids
- reorder skinny messages ids
- remove obsolete C-comments about status
- rewrite field names (from camel case to plain words)

From me:
Replaced meaningless hf blurbs with NULL

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5824

svn path=/trunk/; revision=36638
2011-04-14 06:07:42 +00:00
Anders Broman 7e17419e6c From Mathieu Parent:
packet-skinny:Add DialedPhoneBookMessage and DialedPhoneBookAckMessage

Replaced meaningless hf blurbs with NULL

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5823

svn path=/trunk/; revision=36637
2011-04-14 05:37:58 +00:00
Jaap Keuter 15a032af98 Fix for bug 3933:
Decode TCP port 2443 as Secure Skinny (SCCPS).

svn path=/trunk/; revision=36187
2011-03-14 07:49:05 +00:00
Jörg Mayer 77047f4ea4 Previously 1 byte TCP payload to port 2000 got interpreted as malformed Skinny
svn path=/trunk/; revision=35950
2011-02-15 12:06:39 +00:00
Jaap Keuter bc1832599b From Ania:
Patch enables decoding CM 7.1(3b) messages and CM5 CallInfoMessage (0x14A).

svn path=/trunk/; revision=35948
2011-02-14 22:52:14 +00:00
Jaap Keuter fdca1ea223 Make sure RTP conversations are created.
svn path=/trunk/; revision=35947
2011-02-14 20:51:40 +00:00
Jaap Keuter 13a1233484 From Mathieu Parent:
* Support for XMLAlarmMessage (0x015A)
* every xml data is parsed using the XML dissector

svn path=/trunk/; revision=35226
2010-12-20 07:49:56 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 9675740701 Use value_string_ext fcns to access certain value_string arrays;
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34766
2010-11-03 22:08:49 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Jaap Keuter 9892b8f6f4 From Mathieu Parent:
* Added LineInstance and CallId to keypadButton-, stimulus-, offHook-, onHook-,
  startTone-, stopTone-, setRingerMessage
* Added RingMode to setRingerMessage
* Added displayName to LineStatMessage

svn path=/trunk/; revision=32692
2010-05-06 19:16:45 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Jaap Keuter cb80f883f7 From Carlos Mendioroz:
Enhanced the skinny dissector to expose a tap, and added SKINNY call control
protocol support to gtk/call_voip to show those calls.

svn path=/trunk/; revision=27332
2009-01-30 21:25:52 +00:00
Jaap Keuter f3ad87485b Fix for bug 3192:
Version 17 of the Skinny protocol seems to report its version number in a previously reserved
header field. The dissector now accepts this, even though it can't dissect all new messages yet.

svn path=/trunk/; revision=27258
2009-01-18 12:43:37 +00:00
Stig Bjørlykke e6a22e689e Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26648
2008-10-31 15:34:00 +00:00
Bill Meier 3e347bb88c Minor cleanups related to proto_reg_handoff
svn path=/trunk/; revision=26277
2008-09-26 17:04:01 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Sebastien Tandel 68ad2f4b9b fix MacOSX gcc-3.3 warnings about unused tfs/value_string variables
most have been tagged unused (few have been deleted if dissector has not been
modified since a long time)

move packet-ssl-utils.c to DISSECTOR_SRC


svn path=/trunk/; revision=21431
2007-04-14 14:01:53 +00:00
Jaap Keuter a7271dd2c0 Fix for bug 1523. Offset handling was off in DialedNumberMessage presentation.
svn path=/trunk/; revision=21343
2007-04-05 23:42:44 +00:00
Jeff Morriss 382517930c If we found that the packet does not belong to Skinny (new style dissector), there's no need to call call_dissector(data_handle, ...) before returning FALSE.
svn path=/trunk/; revision=19988
2006-11-26 13:36:03 +00:00
Ronnie Sahlberg 2d1bb39121 change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.
there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size



svn path=/trunk/; revision=19751
2006-10-31 09:29:07 +00:00
Ronnie Sahlberg f8c939e218 from Jeff Morriss
The attached patch makes the Skinny dissector "new style".  Please
consider it for inclusion.




svn path=/trunk/; revision=18781
2006-07-22 03:06:32 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00
Anders Broman d4e37349e7 Fix Bug 642, use col_set_fence() not to owerwrite column info if several Skinny messages are in one frame.
svn path=/trunk/; revision=16880
2005-12-22 07:11:21 +00:00
Jörg Mayer 87768c664f Start the function name on a new line to make it easier to search
svn path=/trunk/; revision=16757
2005-12-11 22:53:25 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Guy Harris 9cb86fda9c Squelch various signed vs. unsigned warnings by:
making pointers to byte data be "guint8 *" rather than "char *",
	and making buffers holding byte data arrays of "guint8" rather
	than arrays of "char";

	making pointers to text strings "char *" rather than "guchar *";

	appropriately casting pointers (cast to "guint8 *" when passing
	to routines expecting "guint8 *" or when assigning to "guint8
	*");

	making port-number preferences "guint";

	making enum preferences "gint";

	making hf_ variables "int".

Clean up white space.

svn path=/trunk/; revision=14884
2005-07-09 00:53:17 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Ronnie Sahlberg cb859703ca make skinny compile again
svn path=/trunk/; revision=13948
2005-03-27 22:56:32 +00:00