use the pointer to iscsi_Session as conversation index for the exchange tracking for now, it works just as well and will be replaced with better exchange tracking shortly anyway
svn path=/trunk/; revision=17831
it is silly that scsi has to track these things itself when all the transports
already keep track of exchanges.
the scsi transports should all use the fc_exchange_data structure to pass lun to scsi and where scsi kan store the opcode between requests and data/response packets
svn path=/trunk/; revision=17829
this is semi-temporary though since FCP will always sit ontop of FC which also tracks the same conversations so there is no need to do a redundant conversation tracking in fcp itself.
svn path=/trunk/; revision=17822
dissect smb2 break responses used by a server to break an oplock
these unsolicited responses are sent with a commandseqnum of -1 so mark these in the header as unsolicited as well
svn path=/trunk/; revision=17820
This patch fixes the decode problem mentioned in this bug report:
"3. Frames 9 and 13 are only partially decoded and show up as "Packet size limited during capture" It looks like the decode chokes on the DQ-RI line."
DQ-RI is a localconnectionoptions parameter and shouldn't appear as a top-level parameter. This patch makes sure that all of the single-character top-level parmeter codes are followed immediately by a ':'.
svn path=/trunk/; revision=17816
The attached patch adds support for the Japan SS7 variants (TTC/NTT) to
the MTP3, MTP3MG, SCCP, and SCCPMG dissectors. It's not as thoroughly
implemented nor tested as I'd like, but it does a good job of at least
the basic dissection and I'm out of time for now.
It also fixes bug I found in the SCCP dissector where it would show an
End of Optional parameter even when the Optional pointer was 0.
svn path=/trunk/; revision=17815
call the scsi response dissector as well
(so that eventually we can do things like SRT for SCSI)
it doesnt work yet since fcp is using some incredibly broken logic to
track state between frames.
the cdata stuff can just not ever work exscept for single scan tethereal dissection.
is there noone at all looking at these protocols wioth ethereal?
has noone noticed it is completely broken yet?
sigh, soon i think i will be able to add the originally estimated trivial to implement SCSI SRT
svn path=/trunk/; revision=17811
add missing flags to the dissection and during refactoring fix several things that just can not have worked previously.
svn path=/trunk/; revision=17805
remove the port preference setting and replace it with strong heuristics instead
(attempt but fail to set a conversation dissector when the heuristics and the dissection match)
use tcp_dissect_pdus() for reassembly and pdu tracking and get rid of the try-to-step-through-the-pdu-to-find-where-the-next-pdu-starts thing.
svn path=/trunk/; revision=17804
issued by ms kdc contains a PA_DATA structure with a salt that contains an
nt_status code explaining why the client was not allowed to get a (tgt) ticket
svn path=/trunk/; revision=17796
by dumpcap and Ethereal (so that, on UN*X, the child process can report
a detailed "can't exec dumpcap" error).
Rename most of the "sync_pipe_XXX_to_parent()" routines, as they're also
in Tethereal, which doesn't have a sync pipe.
svn path=/trunk/; revision=17789
add dissection of two additional bits and the respdataformat bitvield
add booleans for the filter fields
make all the fields filterable
svn path=/trunk/; revision=17787
even if doing a live capture; just print the packets without saving
them.
In dumpcap:
default to the capturing the entire packet;
don't do the "Press any key" stuff when debugging on UN*X;
do console logging (to the standard error) even when we're
running as the capture child (the sync pipe should only be the
standard output, not the standard error).
svn path=/trunk/; revision=17786
instead of the allocation length from the data pdu since sometimes the datapdu will be completely empty and thus we cant extract it from the data pdu.
(unclear if this is really allowed by scsi but anyway)
this should make the scsi transfer length checking more correct.
update mmc getconfiguration and spc inquiry to use these macros
and flag these packets that are short due to a too small alloc_len
as truncated due to scsi and not being short/malformed packets.
at the same time, get rid of a few horrible offset+x in the inquiry dissector and replace with proper offset incrementation instead.
svn path=/trunk/; revision=17784
put useful info like type,mode,uid,gid on the expansion lines so we dont have to open the expansion to see these values.
allow it to push this info multiple expansion lines upward
and optionally (such as for GETATTR replies) put this info in the info column as well
svn path=/trunk/; revision=17783
Removes the use of the deprecated proto_tree_add_item_hidden() function
I was adding the 'msmms.command.unknown' field in lots of places (a
habit of mine in my own dissectors), but this probably isn't useful.
svn path=/trunk/; revision=17782
Ronnie Sahlberg