Commit Graph

34 Commits

Author SHA1 Message Date
Bill Meier 900c2412cd Improve the text of some value_strings.
svn path=/trunk/; revision=41906
2012-04-03 15:38:27 +00:00
Bill Meier 02b9c6460c Use correct values for "alt screen size" for 327x-3 and 327x-4 terminals.
Slightly improve code which tries to keep track of "screen size".
Add a comment as to what is really required to properly keep track
 of the screen size "state".


svn path=/trunk/; revision=41891
2012-04-01 23:06:21 +00:00
Bill Meier 3052f47326 Remove a bad (unterminated) comment; Fixes Buildbot compile error.
svn path=/trunk/; revision=41890
2012-04-01 21:48:17 +00:00
Bill Meier b27ca5bf7e Fix some bugs related to the use of proto_tree_add_bits_item();
Improve details pane display of a few TN3270 fields.

svn path=/trunk/; revision=41889
2012-04-01 21:31:51 +00:00
Bill Meier c782bbd1e4 Define numerous arrays as static rather than dynamic
so they are initialized only once rather than each time a
 function using the array is executed.
Re-arrange the code slightly so much of the dissection can be
 put under 'if (tree)'.

svn path=/trunk/; revision=41885
2012-04-01 16:06:39 +00:00
Bill Meier eb24f600d7 Extensive rework to clean up code and to fix a number of issues with tn3270 dissection;
Also: do reformatting and symbol renaming for readability.

See Bug #6854 for several examples typical of the issues fixed:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6854

svn path=/trunk/; revision=41763
2012-03-25 23:14:23 +00:00
Chris Maynard 58cab4f107 Fix some duplicate display filter names.
svn path=/trunk/; revision=40672
2012-01-23 20:42:54 +00:00
Chris Maynard b3ee0e1295 Set encoding to ENC_BIG_ENDIAN instead of the incorrect encoding of TRUE.
svn path=/trunk/; revision=40270
2011-12-22 01:57:20 +00:00
Bill Meier 54b72021bb Fix encoding arg for various fcn calls:
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
Guy Harris 053c583fda Add some additional routine variants that handle string encodings, and
make FT_STRING and FT_UINT_STRING handle string encodings.

Get rid of FT_EBCDIC in favor of FT_STRING with ENC_EBCDIC.

Add some URLs for DRDA.

Clean up some stuff in TN3270 and TN5250, including using ENC_ values
for proto_tree_add_item().

svn path=/trunk/; revision=37909
2011-07-05 23:59:23 +00:00
Bill Meier d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Anders Broman 6a4ed4f4c3 From Michael Mann.
Part of "display filters with redundancies of PROTABBREV in them."
The ones left outs should be fixed differently I think.
Rename som ndps hf variables while at it.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794

svn path=/trunk/; revision=37406
2011-05-26 06:32:51 +00:00
Guy Harris f780211ade Put the query list items under the top-level query list item (which
should've been done in the previous checkin).

Display the "request type" field in a Read Partition request correctly
(only the upper 2 bits matter, and they're an enumerated value).

svn path=/trunk/; revision=35336
2011-01-03 08:31:45 +00:00
Guy Harris 0841456fd7 A Query List has more than one has multiple QCODEs; you cannot handle
that by doing the entire list as a single FT_UINT8 field, you must
handle each QCODE, in a loop, as that field.

svn path=/trunk/; revision=35319
2010-12-31 22:28:57 +00:00
Bill Meier 626b802ba3 Define global variables ROWS, COLS, MAXROWS, MAXCOLS as static;
Also: Define a few functions as static.

svn path=/trunk/; revision=34407
2010-10-07 21:09:29 +00:00
Jeff Morriss b151952474 Change a couple of hf abbreviations so they're not the name of the hf variable.
Use . as the separator (after PROTOABBREV) in the hf abbreviations.

svn path=/trunk/; revision=34397
2010-10-06 21:51:07 +00:00
Jeff Morriss 9238e29ae3 Don't use an abbreviation as the name of an hf entry.
svn path=/trunk/; revision=34241
2010-09-24 20:28:00 +00:00
Jeff Morriss cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Jeff Morriss 4749e0f19f Move most of the contents of the header file into the .c file.
svn path=/trunk/; revision=32840
2010-05-17 03:01:03 +00:00
Guy Harris 68ee036bd2 We already have a link to the IBM version of the 3270 manual; just refer
to that.

svn path=/trunk/; revision=32800
2010-05-14 00:16:59 +00:00
Guy Harris dcf49bf092 Handle the Set Buffer Address command differently; this gets rid of the
macro with the "give credit" license, so back that out of COPYING.

svn path=/trunk/; revision=32798
2010-05-13 23:56:31 +00:00
Jeff Morriss 729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Jeff Morriss e5372ffb44 Remove some unused hf_ entries
svn path=/trunk/; revision=32786
2010-05-13 15:22:55 +00:00
Jeff Morriss acc410ae87 From Robert Hogan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4257 :
Correctly decode and display the buffer address in SBA orders.


Note: This includes a macro with a new license which is added to COPYING.

svn path=/trunk/; revision=32785
2010-05-13 15:19:40 +00:00
Bill Meier e0064797fb Use more unique names for certain enum constants.
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

svn path=/trunk/; revision=31572
2010-01-19 19:37:03 +00:00
Jaap Keuter caeca294d6 From Robert Hogan:
Not incrementing tvb offset in two places in tn3270 dissector.

svn path=/trunk/; revision=30813
2009-11-04 06:58:42 +00:00
Jaap Keuter 75f1e13c12 Cleanup header fields.
svn path=/trunk/; revision=30394
2009-10-07 23:08:22 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Bill Meier 095f4a5c12 From Robert Hogan: "no need to register tn3270 for 'decode-as'".
svn path=/trunk/; revision=29134
2009-07-17 19:41:34 +00:00
Bill Meier 891d655e8a Minor changes: Move protocol_register & etc to end;
Use find_dissector instead of create_dissector_handle.

svn path=/trunk/; revision=29132
2009-07-17 14:25:56 +00:00
Jaap Keuter f9177273d8 From Robert Hogan:
I'm working on a tn3270 dissector. 
See: http://roberthogan.net/stuff/tn3270-dissector/

svn path=/trunk/; revision=29129
2009-07-17 06:49:58 +00:00