61ccc8baf1
various capture code cleanup and fixes:
...
display filename in statusbar while capturing
print_usage banner fixed
cf_cb_live_capture_prepare no longer needed
rename sync_pipe_do_capture -> sync_pipe_start
bugfix: sync_pipe_input_wait_for_start replaced by former implementation
fix cleanup of old file in capture_input_new_file
fix a tempfile detection bug (named file showed up as tempfile after capture)
svn path=/trunk/; revision=14053
2005-04-11 18:57:19 +00:00
fbace0592c
fix some error handling
...
fflush new output file (to have at least the pcap header on disk) before sending the corresponding message to the capture parent
svn path=/trunk/; revision=14052
2005-04-11 18:39:31 +00:00
2bc81b2a48
Major speed improvement for filtering and dissection.
...
It should not dump core as far as all my tests are concerned and Menu_Statistics/ProtocolHierStats work
It needs more testing and there might still be cases where it will crash that will need to be fixed but I feel it will be worth it since it will decrease the time to filter very large capture files dramatically.
Real significant performance boost for very large captures.
(If we cant fix all the problems we can just revert this patch)
svn path=/trunk/; revision=14051
2005-04-11 08:43:51 +00:00
c9be421b16
Add a note about testing to the "Robustness" section.
...
svn path=/trunk/; revision=14050
2005-04-11 01:57:00 +00:00
018cde2a41
add some missing menu items, describe changes in the -b ring buffer command line parameter.
...
svn path=/trunk/; revision=14049
2005-04-11 00:10:50 +00:00
cd67d1fcf8
Remove debugging printf()s.
...
svn path=/trunk/; revision=14048
2005-04-10 23:17:05 +00:00
af118c9e12
disable /View/Resize Columns menu item, if no packets available
...
svn path=/trunk/; revision=14047
2005-04-10 23:13:35 +00:00
c8ff864b00
Add an option to Editcap that adds various types of errors to the capture
...
file.
svn path=/trunk/; revision=14046
2005-04-10 23:12:48 +00:00
5625c461d0
bugfix: call to cf_cb_live_capture_..._started with correct parameter
...
svn path=/trunk/; revision=14045
2005-04-10 21:03:31 +00:00
163f2b61a8
fix statusbar messages by splitting into update and fixed messages between capture and main
...
svn path=/trunk/; revision=14044
2005-04-10 19:36:56 +00:00
adc2bf61a8
bugfix: hide panes if a non "Update" capture had no packets captured (hopefully it's working correct now...)
...
svn path=/trunk/; revision=14043
2005-04-10 17:36:36 +00:00
63047dfdd5
bugfix: call cf_cb_live_capture_finished *if* some packets were captured
...
svn path=/trunk/; revision=14042
2005-04-10 17:18:45 +00:00
70f1945084
fix a typo
...
svn path=/trunk/; revision=14041
2005-04-10 17:08:32 +00:00
7b7f7e7f9a
Win32 only bugfix: as using TerminateProcess is the brute force way and sometimes clipped packets in the middle, now using a pipe called signal_pipe from the parent to the child for this.
...
On unix we're using kill() for this, which simply signals the child, but this isn't available on win32.
svn path=/trunk/; revision=14040
2005-04-10 16:43:22 +00:00
78a7b0bcc0
bugfix: when no packets were captured, don't call cf_cb_live_capture_finished after closing the capture file
...
svn path=/trunk/; revision=14039
2005-04-10 15:35:41 +00:00
3ee155a90a
refactoring of the capture startup (while the capture parent waits for the child to start)
...
svn path=/trunk/; revision=14038
2005-04-10 14:29:12 +00:00
96a1fab95e
fix descriptive texts, so they fit into the window
...
svn path=/trunk/; revision=14037
2005-04-10 13:43:07 +00:00
5341ad2bba
Clean up indentation.
...
svn path=/trunk/; revision=14036
2005-04-10 08:55:56 +00:00
5e096c5c19
Clean up white space, and tweak a comment slightly ("message" in the
...
error message case referred to the error message text, not the message
on the pipe).
svn path=/trunk/; revision=14035
2005-04-10 08:51:46 +00:00
39836021f7
Fix indentation.
...
svn path=/trunk/; revision=14034
2005-04-10 08:31:27 +00:00
8881cec2df
Make it slightly clearer that the bitwise AND operator evaluates to a
...
Boolean value that's true if any of the bits in question are set and
false if none of them are, not to an integer or slice value with the
only the bits set in both values set.
svn path=/trunk/; revision=14033
2005-04-10 08:28:08 +00:00
b803431715
KRB_ERROR can be returned and it is not encapsulated
...
svn path=/trunk/; revision=14032
2005-04-09 01:28:23 +00:00
05ae084f5b
Fix brokenness from previous patch.
...
svn path=/trunk/; revision=14031
2005-04-08 20:28:24 +00:00
caf66bb8dd
Add a length check.
...
svn path=/trunk/; revision=14030
2005-04-08 19:14:05 +00:00
388c7e2da9
Add a length check, fix up some comments.
...
svn path=/trunk/; revision=14029
2005-04-08 19:09:46 +00:00
a574ef6b88
From Martin M
...
updates to MGCP
checked in per Anders B request hope it compiles
svn path=/trunk/; revision=14028
2005-04-08 11:25:18 +00:00
a55085054c
From Neil Kettle
...
Fix two potential buffer overflow bugs in fc els
svn path=/trunk/; revision=14027
2005-04-08 10:28:44 +00:00
df98534657
From Didier:
...
optimization for COLUMNS to make ethereal faster when filtering
optimization to make the slow find_protocol_by_id() fast.
(idea from Didier, implementation modified by me to be less intrusive)
svn path=/trunk/; revision=14026
2005-04-07 12:00:03 +00:00
412e592a12
updating Mark C Browns information
...
svn path=/trunk/; revision=14025
2005-04-07 10:04:50 +00:00
4eb8b88421
make the ip ip field we use as the reassembly key a bit more
...
"unique" by mixing in the source and destination address.
svn path=/trunk/; revision=14024
2005-04-07 09:44:58 +00:00
6ac7c99cc5
From Francisco Alcoba
...
Very cool ASCII art version of viop graphs
svn path=/trunk/; revision=14023
2005-04-07 09:14:35 +00:00
3fbcc50513
From Greg Morris
...
Fix the breakage from my previous patch
svn path=/trunk/; revision=14022
2005-04-07 08:32:49 +00:00
396d51fce3
add Ilya Konstantinov
...
svn path=/trunk/; revision=14021
2005-04-06 21:28:02 +00:00
37f7683cd1
from Ilya Konstantinov: fixed a bug as DND wasn't working with GNOME, I've also added a comment how GNOME handles these things
...
svn path=/trunk/; revision=14020
2005-04-06 21:24:00 +00:00
eb98d35922
use proto_item_appent_text() instead of proto_item_append_string() since the hf field is not neccessarily a FT_STRING value always.
...
svn path=/trunk/; revision=14019
2005-04-05 20:20:21 +00:00
c92c1df4a4
Try not to call proto_tree_add_text() with negative lengths in error messages.
...
svn path=/trunk/; revision=14018
2005-04-05 14:40:59 +00:00
573ba4ee40
From Francisco Alcoba
...
patch for viop analysis to fix the breakage from the tap reordering patch
svn path=/trunk/; revision=14017
2005-04-05 08:14:58 +00:00
b170e98255
Add length checks so that we don't overflow buffers.
...
svn path=/trunk/; revision=14016
2005-04-04 21:44:53 +00:00
79b30e6df5
From Lars Ruoff
...
Make it possible to tap 4 PDUs from one frame
svn path=/trunk/; revision=14015
2005-04-04 20:12:18 +00:00
8b95cd38d5
Don't generate a "dissector bug" warning in cases where a dissector calls
...
proto_tree_add_*(tree, tvb, offset, 0, ...);
and "offset" is greater than the length remaining in the tvbuff.
svn path=/trunk/; revision=14014
2005-04-04 18:10:42 +00:00
f16afe28a9
From Cvetan Ivanov
...
Updates to Q931, SM and ISUP
svn path=/trunk/; revision=14013
2005-04-04 07:40:07 +00:00
38fd4be564
the definition of tcp address structure changed between version 3 and version 4
...
make version 4 dissect tcp addr structure properly
svn path=/trunk/; revision=14012
2005-04-04 05:56:57 +00:00
882f734f34
From Kenny Shumard
...
Update for IAX2
svn path=/trunk/; revision=14011
2005-04-04 05:10:45 +00:00
088f70bb53
From Martin Mathieson
...
small update for SIP request/response matching.
svn path=/trunk/; revision=14010
2005-04-04 04:51:47 +00:00
d430320b6a
the netware dissector is the only dissector that accesses fvalue_ functions directly.
...
this made it crash for some packets when the filter speedup patch was enabled, since some of these finfo nodes did no longer exist.
as far as i can tell the only other instances of fvalue_ usage is from some tap based functions but all those do take care to make sure that the fields being accessed are all part of a filter, and will thus never be optimized away.
The patch does two things
1, refactor the code but do not change the logic to reduce the number of places where the external fvalue_ functions are called from.
2, add code to force the tree to be visible (and thus change the code) so that the speedup patch will not optimize these fiuelds away.
svn path=/trunk/; revision=14009
2005-04-04 04:14:41 +00:00
f52c3c3a14
Add a couple of length checks.
...
svn path=/trunk/; revision=14008
2005-04-04 03:01:40 +00:00
9f0d946003
Fix up the table of encapsulation type strings to match the new set of
...
encapsulation types.
svn path=/trunk/; revision=14007
2005-04-03 12:05:05 +00:00
466c3e9c8d
Make editcap use wtap_read(); that eliminates the last user of
...
wtap_loop(), so eliminate wtap_loop().
svn path=/trunk/; revision=14006
2005-04-03 11:00:49 +00:00
951b7c9aaa
From Tim Endean:
...
1) Return errors.
2) Return rejects.
Numerous other bugs fixed.
svn path=/trunk/; revision=14005
2005-04-02 18:51:38 +00:00
72f015771b
From Tim Endean:
...
1) Return errors.
2) Return rejects.
Numerous other bugs fixed.
svn path=/trunk/; revision=14004
2005-04-02 18:50:57 +00:00
Ulf Lamping