Commit graph

29 commits

Author SHA1 Message Date
Guy Harris
1980fa5dbf Pass ESD_BTN_OK rather than NULL as a second argument to
"simple_dialog()"; NULL might be #defined to be a pointer expression on
some platforms, causing compiler warnings (and, on platforms where a
null pointer doesn't have all its bits 0, possibly causing misbehavior,
although I don't think there are any such platforms on which Ethereal
runs).

Don't allow 0 as button mask argument to "simple_dialog()".

Squelch a compiler warning.

Report fatal problems as errors, not warnings.

Report file I/O errors with "file_open_error_message()".

Report file write errors (including those reported by "close()", e.g.
some errors writing to an NFS server) when saving raw packet data to a
file.

svn path=/trunk/; revision=9915
2004-01-31 03:22:42 +00:00
Ulf Lamping
c890e29a99 apply automatically generated filters strings to the recent dropdown list,
e.g. when applying a "Follow TCP stream",
fix a bug in the recent function, discarding the newest entries when
saving a full list (now discarding the oldest).

svn path=/trunk/; revision=9849
2004-01-25 18:51:26 +00:00
Guy Harris
a093c75b59 Use "retap_packets()" rather than "redissect_packets()".
svn path=/trunk/; revision=9660
2004-01-13 22:49:15 +00:00
Guy Harris
b8eae38ada From Ronnie Sahlberg: when the user selects a filter from the popup
dialog, make the main window come to the front.

svn path=/trunk/; revision=9292
2003-12-16 05:04:11 +00:00
Guy Harris
4f5d2ddcda From Ronnie Sahlberg: fix a crash on Win32 when we resort a column in
the conversation list and then create/apply a filter from the
conversation list popup.

svn path=/trunk/; revision=9284
2003-12-14 10:28:20 +00:00
Guy Harris
64bc566ea8 In GTK+ 2.x, "gtk_entry_get_text()" returns a "const gchar *"; assign
its value to pointer-to-const variables.

svn path=/trunk/; revision=9161
2003-12-04 00:45:39 +00:00
Guy Harris
e779676e07 Include "gtk/color_dlg.h" to declare "color_display_with_filter()", and
include "color.h" to declare "color_filter_t", which "gtk/color_dlg.h"
requires.

svn path=/trunk/; revision=8639
2003-10-07 17:29:45 +00:00
Ronnie Sahlberg
0897a7cfbb Update to endpoint talkers,
endpoint talkers now have an extra submenu on the popup where one can select :
Colorize Conversation.
This opens up the create color filter dialog with the filter preset to the
selected conversation.

svn path=/trunk/; revision=8637
2003-10-07 10:07:47 +00:00
Ronnie Sahlberg
d6a720dd17 Add Find Next/Find Previous submenu to conversation lists.
By using Find Next/Previous you will jump to the next/previous matching packet in the ethereal main window.

I could not get CTRL-N / CTRL-B to work and was too lazy to research.
It would be nice if CTRL-N / CTRL-P would invoke the same thing as selecting
/Find Frame/Find Next/EP1 <-> EP2
or
/Find Frame/Find Previous/EP1 <-> EP2
from the menu.
I could not figure out how to get gtk to do this.
The person that adds CTRL-N/CTRL-B here will be a hero.

svn path=/trunk/; revision=8635
2003-10-07 09:30:34 +00:00
Ronnie Sahlberg
beb5e5e4e6 Update ipx and conversation list to make it possible to select and filter for ipx conversations from the conversation list popup menu
svn path=/trunk/; revision=8599
2003-10-03 09:09:35 +00:00
Guy Harris
f56d16abab Add a routine to return the display name for a "capture_file" structure,
rather than constructing that name when a capture file is opened and
putting a pointer to it in that structure.

svn path=/trunk/; revision=8476
2003-09-15 22:16:08 +00:00
Guy Harris
673e47d4a9 Keep a "display name" as part of a capture_file structure; for live
capture temporary files, it's "<capture", and for saved capture files,
it's the last component of the pathname of the file.  Use that in
various places when displaying the file name.

svn path=/trunk/; revision=8474
2003-09-15 20:37:37 +00:00
Guy Harris
7bfaf8caf3 From Graeme Hewson:
Don't crash if "-z" is used on the command line when a live
	capture is being done (e.g., with "-k -S" - in that case,
	"cfile.filename" is null when the window is created), just don't
	display the file name in the title.

	Don't set the title of a non-existent window - create the window
	first.

svn path=/trunk/; revision=8472
2003-09-15 19:05:01 +00:00
Ronnie Sahlberg
764972414c Add a Find Frame item to the popup menu for the conversation list
that will open the find frame dialogue and preload the filter string
with the conversation and the direction the user selected from the menu.

svn path=/trunk/; revision=8386
2003-09-05 06:16:10 +00:00
Ronnie Sahlberg
509c97f79d For endpoint conversations change how Endpoint1 and Endpoint two are selected.
Make the selction of what is endpoint 1 and what is endpoint 2
first check the port (if a port is present it will be !=0) and if
the ports are present set the lowest port as endpoint2.

If the prots are not present or the ports are identical  then compare the addresses instead.

The idea is that low port numbers usually refer to server daemons
and this sorting thus usually puts the client as endpoint 1 and the server as endpoint 2.
It is much more intuitive and makes the table much more readable.

svn path=/trunk/; revision=8381
2003-09-05 01:11:12 +00:00
Ronnie Sahlberg
e3cde3715e Update to the conversations list.
Rename it from Endpoint Talkers to : Conversation List

Change command line arguments to both tethereal and ethereal
to be -z conv,<type>
to reflect the new name Conversations

This is the last time the tethereal cmd line arg is changed.  But now it has a
proper intuitive name at least.

io,users was weird
talkers was too close to names used in other tools

svn path=/trunk/; revision=8379
2003-09-04 23:37:45 +00:00
Ronnie Sahlberg
4f893552d0 fix our-of-bounds bug in teh port to string conversion routine
svn path=/trunk/; revision=8378
2003-09-04 23:12:46 +00:00
Ronnie Sahlberg
b4f94f13b6 Update to endpoint talkers. move lots of duplicated code into teh helper endpoint_talkers_table.c
svn path=/trunk/; revision=8377
2003-09-04 23:11:03 +00:00
Ronnie Sahlberg
188a4e8d81 Uglify endpoint_talkers_table.c
make it know how to build the filter strings, address and port hf_ fields properly so TCP and UDP works and is agnostic on whether ipv4 or ipv6 is used as transport

svn path=/trunk/; revision=8368
2003-09-04 11:07:51 +00:00
Ronnie Sahlberg
b0bec4d79a When putting the filename in the titlebar
just put the filename there and not the full path to the file.

svn path=/trunk/; revision=8329
2003-09-02 08:27:43 +00:00
Guy Harris
f11ef57387 Include "tap.h" to get "remove_tap_listener()" declared.
svn path=/trunk/; revision=8322
2003-08-31 00:31:05 +00:00
Ronnie Sahlberg
82c1757345 Remove the individual reset functions and replace with a common one in the helpers file.
cleanup part 5?

svn path=/trunk/; revision=8320
2003-08-30 01:18:16 +00:00
Ronnie Sahlberg
1b81e773a7 step two in endpoint talkers cleanup
move the windows destroy function to the common helpers file

svn path=/trunk/; revision=8318
2003-08-30 00:53:15 +00:00
Guy Harris
2d71f3589d Use "GPOINTER_TO_INT()" to convert the return value of
"gtk_clist_get_row_data()" to an "int", to squelch compiler warnings.

svn path=/trunk/; revision=8286
2003-08-27 23:01:10 +00:00
Ronnie Sahlberg
a7d0d4bf16 update to the talkers popup list.
hopefully it will now create the filter for the actual conversation
we selected.

add EP1 <-> ANY and EP2 <-> ANY fitlers

svn path=/trunk/; revision=8283
2003-08-27 21:54:36 +00:00
Ronnie Sahlberg
d3562c0480 Updates for the endpoint talkers thing
The table now has a popup menu with
   Match display filter
         Selected
               EP1 <-> EP2
               EP1 --> EP2
               EP1 <-- EP2
               EP1 --> ANY
               EP1 <-- ANY
               EP2 --> ANY
               EP2 <-- ANY
          Not Selected
               ...
          ...
    Prepare Display Filter
          ...

Self explanatory.

Now the bad news.
I set the display filter box in the main window and i call redissect_packet
which redissects the packet list   but the displayfilter does not take
or affect the main window until i click  the apply button.

Some signal needs to be raised to some object me thinks.

Please feel free to fix it if you know what is missing.

svn path=/trunk/; revision=8279
2003-08-27 12:10:21 +00:00
Guy Harris
f91af72c55 All endpoint talkers table taps use "address_to_str()" as the routine to
use to translate addresses to strings - wire that into
"endpoint_talkers_table.c", don't pass the function as an argument to
"init_ett_table()".

svn path=/trunk/; revision=8263
2003-08-26 01:46:23 +00:00
Guy Harris
1edf69590f Cast arguments to "g_free()" to avoid compiler warnings (those are known
to be mallocated, so it's safe to cast them).

Use "%u", not "%d", for unsigned values.

svn path=/trunk/; revision=8231
2003-08-24 01:39:04 +00:00
Ronnie Sahlberg
ba74395cbe New feature. Statistics/EndpointTalkjers can now present a sortable table with a list of all seen conversations of a certain type.
Supported types are Ethernet/TokenRing/IP/UDP and TCP.
Will add FibreChannel soon.

The framework for this feature needs to be enhanced in the future so that by selecting one entry and click the right mousebutton, this will bring up a menu with  Prepare/Match options  with suboptions for AnyDirection, ForwardOnly or ReverseOnly   which updates the display filter accordingly.

Had to update some of the taps as well to change them to use a proper address structure for the address fields.
We should now be able to to these stats correctly even for ip tunneled over ip tunnelled over ip ...

svn path=/trunk/; revision=8222
2003-08-23 09:09:35 +00:00