Read in the entire packet, including the padding, and just tell our
caller about the non-padding part; that avoids doing a "file_seek()"
("fseek()"s are inefficient on some platforms, as they flush the
standard I/O buffers and do an "lseek()"), and would also let us supply
the padding to the caller if it turns out it's an FCS rather than
padding.
svn path=/trunk/; revision=5107
Clean up some case statements - instead of having most branches do
"return 0", and the default branch just break, with code after the case
statement handing that case and then returning 0, pull the code after
the case statement into the default case, and have the other cases just
break, with the "return 0" after the case statement.
Initialize some ett_ values that weren't getting initialized.
svn path=/trunk/; revision=5104
Create a protocol tree item for the fixed part of the WTP header.
Don't assign the value of "proto_tree_add_XXX" routines to a variable if
you're not going to use the value.
svn path=/trunk/; revision=5103
before.
Display which info level a getprinter response contains in COL_INFO.
Fixed some bugs in dissecting devicemodes - the device name and form name
live in a 64-byte buffer instead of a NULL terminated unicode string.
svn path=/trunk/; revision=5102
Handle an address family of 0; that means that the address wasn't
specified in the request, which is used for a "send me the whole routing
table" request.
Replace some "proto_tree_add_XXX" calls with "proto_tree_add_item"
calls.
Use FALSE, rather than TRUE, as the byte order argument in one
"proto_tree_add_item" call, for consistency with other calls; the field
is a string, so the byte order doesn't matter.
svn path=/trunk/; revision=5099
Use -1 rather than "tvb_length(tvb)" as the length for the top-level
protocol item.
Don't initialize "sccp_item" - it's not used if "tree" is null.
svn path=/trunk/; revision=5089
method length and use that in all comparisons, from Blair Cooper.
Fix the check for "M-" to check also whether there are at least two
characters in the line.
svn path=/trunk/; revision=5071
field in the "Capture Options" dialog, put the descriptive name of the
device in parentheses after the actual device path.
svn path=/trunk/; revision=5070
field in the "Capture Options" dialog, put the descriptive name of the
device in parentheses after the actual device path.
svn path=/trunk/; revision=5069
ETT_NONE entry.
Initialize the "tree_type" field of a "field_info" structure to -1,
meaning "this has not been given a subtree". Add checks before using
that field that it's in range. That way, you have to create a subtree
before putting protocol tree items under another item.
We allocate the "tree_is_expanded" array when we've registered all
dissectors; there's no need to allocate it while we're registering
dissectors and, in fact, doing so means we leak memory (the memory for
the version we allocated while registering dissectors).
svn path=/trunk/; revision=5068
Show the names of the control characters being mapped by the async
control character map option.
Use "proto_item_add_subtree()" to establish a subtree, so that the ett_
value gets associated with it. (Unfortunately, "proto_item" and
"proto_tree" are typedefs for the same type, so checks for use of one
when you should be using the other aren't done at compile time.)
Get rid of some extra blanks before colons.
svn path=/trunk/; revision=5067
Use the "nb" argument to "redraw_hex_dump()", so we redraw the specified
byte view pane, rather than always redrawing the main window's byte view
pane (and never redrawing the byte view pane of additional packet
windows, so that the font for them doesn't change if you change the font
preference).
svn path=/trunk/; revision=5066
Use the "optp" argument in more option dissectors, and set the name of
the option in the table entries for those options - and for one option
where that name *was* being used.
Get rid of unused variables.
svn path=/trunk/; revision=5061
Guy Harris