Commit Graph

911 Commits

Author SHA1 Message Date
Guy Harris 6b7afbb593 From Tomas Kukosa: radio button groups are GSLists, which means that the
radio button group for a button changes when new buttons are added to it
(adding to the beginning of a singly-linked list takes constant time,
adding to the end takes time linear in the length of the list, and a
GSList * points to the beginning of the list).  Re-fetch the radio
button group each time through the loop that adds new radio buttons to a
radio button group for a preference.

svn path=/trunk/; revision=8591
2003-10-02 21:18:38 +00:00
Guy Harris 301bc24c43 Don't put an entry for a protocol into the Preferences dialog if it
doesn't have any settable preferences (for example, if it has only
obsolete preferences).

svn path=/trunk/; revision=8590
2003-10-02 21:06:11 +00:00
Jörg Mayer 243d1ea197 use mkstemp instead of tmpnam
svn path=/trunk/; revision=8569
2003-09-29 19:20:51 +00:00
Jörg Mayer 89a62a712c Whitespace changes in order to make diff produce more readable results
svn path=/trunk/; revision=8568
2003-09-29 19:18:44 +00:00
Olivier Abad 11c747bd5f - in show_relations() : select the first row of the relation_list when
using gtk+ v2.
- get rid of some unused variables.

svn path=/trunk/; revision=8565
2003-09-29 06:41:46 +00:00
Ronnie Sahlberg 8b7b1ff28e Update to SMB service response time stats.
For short packets, we might not have enough of the payload to decode
the transaction info levels  and thus that data structure is NULL.

check the pointer to this struct first before we try to dereference it.

svn path=/trunk/; revision=8558
2003-09-28 00:00:36 +00:00
Guy Harris 4e5896fed7 From Nathan Jennings:
update the CList as you enter/modify options;

	give Windows users OS descriptions in the displayed devices
	list;

	display at least 5 rows in the lists;

	get rid of the "extra" CList for storing edited values.

svn path=/trunk/; revision=8552
2003-09-26 23:11:17 +00:00
Guy Harris e16c1c8bcf Get the RTP payload types from rtp_pt.h rather than defining them
ourselves.

svn path=/trunk/; revision=8551
2003-09-26 22:29:42 +00:00
Guy Harris 59938a45fe Assorted GUI cleanups.
svn path=/trunk/; revision=8544
2003-09-26 02:09:44 +00:00
Guy Harris 87d87ace4e RTP analysis updates from Lars Ruoff:
- can now handle streams with different payload types
	- detects payload changes
	- detects comfort noise (PT=13 and 19)
	- status line now shows: sequence errors, payload changes,
	  comfort noise (if any)
	- uses colours for lines with status != "Ok"
	- new button "next": jumps to next line with status != "Ok"
	  (starting from selected line)
	- fixed: wrong jitter calculation (bug from tap_rtp)
	- fixed: marker was not shown on first packet or erroneous
	  packets (bug from tap_rtp)
	- code refactored to improve readability and reuse

svn path=/trunk/; revision=8543
2003-09-25 19:35:14 +00:00
Guy Harris f94108245d From Laurent Rabret:
handle 802.1Q frames;

	catch the destroy signal on the main Ethereal window and destroy
	our windows (avoids a crash).

Get the PPP type value for IP from "ppptypes.h" rather than defining it
ourselves.

svn path=/trunk/; revision=8537
2003-09-25 00:37:51 +00:00
Guy Harris d0d3f842bb Add a "file_selection_new()" routine that does all the positioning (GTK+
2.x) and transient-for setting that's done for other dialogs, and use it
for dialogs that come from the main window or from children of the main
window.

svn path=/trunk/; revision=8531
2003-09-24 08:43:34 +00:00
Guy Harris 14d13e3401 From Lars Ruoff: rewritten RTP analysis module.
svn path=/trunk/; revision=8529
2003-09-24 07:48:12 +00:00
Olivier Abad 959850bf16 In packet_list_button_pressed_cb (gtk2 version) :
- put back the event_button->window == GTK_CLIST(w)->clist_window test
  now that we use the correct structure definition for GtkCList (from
  the right include file, not from our version of gtkclist.h).

svn path=/trunk/; revision=8528
2003-09-24 06:18:20 +00:00
Olivier Abad 0d49ad4d84 Renamed gktclist.[ch] to gtkclist_v12.[ch] to avoid conflicts with the
real gtkclist.h file when building the gtk+ v2 gui.

svn path=/trunk/; revision=8527
2003-09-24 06:15:53 +00:00
Guy Harris 4e64afcb25 Pass a pointer to a "capture_file" structure to
"set_menus_for_selected_packet()" and
"set_menus_for_selected_tree_row()", and have them decide whether to
enable or disable menu items based on whether that structure indicates
that a packet or field is selected and, if one is, on its properties.

Pass to the "selected packet enabled" routine for a menu item the
"frame_data" and "edt" members of the "capture_file" structure, and pass
to the "selected tree row enabled" routine the "field_info" member of
that structure.

Clear "cf->current_frame" if no packet is selected.

svn path=/trunk/; revision=8525
2003-09-24 02:36:35 +00:00
Guy Harris dd628e00c7 Make "finfo_selected" a member of a "capture_file" structure rather than
an independent global variable.

svn path=/trunk/; revision=8524
2003-09-24 00:47:37 +00:00
Guy Harris 8e523e0744 The relation list is always displayed (that's been true for a while) -
we don't need to support making it visible or not depending on the
selected field.

svn path=/trunk/; revision=8517
2003-09-23 18:09:36 +00:00
Olivier Abad 1ba0dfec6f Temporary patch for the packet_list column resize problem in gtk2.
We should use the same test (event_button->window == GTK_CLIST(w)->clist_window)
we already use in gtk v1.2 code but in doesn't seem to work in gtk2.

svn path=/trunk/; revision=8515
2003-09-23 06:25:10 +00:00
Ronnie Sahlberg 6ac634b8f0 Update the menu text for Time Reference and give it a hot-key : ctrl-T
svn path=/trunk/; revision=8512
2003-09-22 09:08:42 +00:00
Gerald Combs d47426ec58 Remove a bunch of duplicate semicolons.
svn path=/trunk/; revision=8509
2003-09-21 20:06:02 +00:00
Guy Harris d532ea7b17 From Giles Scott:
in GTK+ 2.x, center dialogs on the parent;

	make the file selection dialogs transient for the main window,
	just as other dialogs are.

Update Gerald's e-mail address.

svn path=/trunk/; revision=8503
2003-09-20 04:59:43 +00:00
Guy Harris e8e9f1bdfe Provide a mechanism by which a tap can arrange to have its menu enabled
or disabled based on a currently-selected packet (or lack of same) or a
currently-selected protocol tree item (or lack of same).  Not currently
used, but necessary if we ever make the TCP graph stuff a tap.  API is
tentative and subject to change.

Also, enable and disable taps based on whether we have any packets to
process.

svn path=/trunk/; revision=8498
2003-09-19 07:24:39 +00:00
Guy Harris 1513888c99 Have "register_tap_menu_item()" put the item under Tools, not
Tools/Statistics; change the taps to put things under Statistics
themselves.  That allows taps to go elsewhere if appropriate.

svn path=/trunk/; revision=8488
2003-09-17 19:39:34 +00:00
Guy Harris 0cf18ffba8 Handle PPP with a pseudo-header.
svn path=/trunk/; revision=8486
2003-09-16 20:41:17 +00:00
Guy Harris f3dd4b5eec Clean up an error message.
svn path=/trunk/; revision=8481
2003-09-15 23:20:34 +00:00
Guy Harris 2e98c97118 Don't pop up tap windows specified with "-z" options until we have a
capture file open.

svn path=/trunk/; revision=8480
2003-09-15 23:15:32 +00:00
Guy Harris 14509164fc Rename various capture file routines to have names starting with "cf_".
svn path=/trunk/; revision=8479
2003-09-15 22:48:42 +00:00
Guy Harris 1332b99a2a Get rid of a bunch of unnecessary #includes.
svn path=/trunk/; revision=8478
2003-09-15 22:32:21 +00:00
Guy Harris ca9ff2abdd Get rid of a no-longer-relevant comment.
svn path=/trunk/; revision=8477
2003-09-15 22:17:25 +00:00
Guy Harris f56d16abab Add a routine to return the display name for a "capture_file" structure,
rather than constructing that name when a capture file is opened and
putting a pointer to it in that structure.

svn path=/trunk/; revision=8476
2003-09-15 22:16:08 +00:00
Guy Harris 0d87da9c92 Don't allow -k and a capture file to both be specified on the command
line - either we're doing a live capture or we're reading a saved
capture file, we can't do both at the same time.

svn path=/trunk/; revision=8475
2003-09-15 20:45:19 +00:00
Guy Harris 673e47d4a9 Keep a "display name" as part of a capture_file structure; for live
capture temporary files, it's "<capture", and for saved capture files,
it's the last component of the pathname of the file.  Use that in
various places when displaying the file name.

svn path=/trunk/; revision=8474
2003-09-15 20:37:37 +00:00
Guy Harris 7bfaf8caf3 From Graeme Hewson:
Don't crash if "-z" is used on the command line when a live
	capture is being done (e.g., with "-k -S" - in that case,
	"cfile.filename" is null when the window is created), just don't
	display the file name in the title.

	Don't set the title of a non-existent window - create the window
	first.

svn path=/trunk/; revision=8472
2003-09-15 19:05:01 +00:00
Ronnie Sahlberg 007d873671 Added TimeReference frames.
One can now select a packet and mark it as a TimeReference packet using the menu.
A TimeReference packet will be indicated by having all timestamp related column entries replaced by the string *REF*
A TimeReference packet will always be displayed in the packet pane, and overrides any display filters.

When a frame is a TimeReference frame, all later frames will calculate the TimeRelativeToFirstPacket  relative to the timestamp of the TimeReference frame instead of the first frame of the capture.

You can have any number of TimeReference frames you like.

svn path=/trunk/; revision=8459
2003-09-12 02:48:23 +00:00
Guy Harris 3e1a532413 When saving packets, we have a "Save only marked packets" option; label
the option to print only marked packets similarly, rather than as
"Suppress unmarked packets" (for consistency, and because the latter
isn't unlike a double negative).

svn path=/trunk/; revision=8451
2003-09-10 22:23:58 +00:00
Jörg Mayer e020bc8964 Albert Chin:
- AM_PROC_LIBTOOL is just an alias for AC_PROG_LIBTOOL, which is
	  called earlier.
	- Use AM_CPPFLAGS instead of CFLAGS and CPPFLAGS to add inlude
	  directories

svn path=/trunk/; revision=8445
2003-09-10 07:17:21 +00:00
Guy Harris ce166e6dfb If there's no saved interface name, set the interface name in the
Capture Options dialog box to the first string in the combo box, not to
the first interface name in the list, so we get the description.

svn path=/trunk/; revision=8444
2003-09-10 07:02:25 +00:00
Guy Harris 29ea42f868 If we have no interfaces, don't set the popdown list for interface combo
boxes.

svn path=/trunk/; revision=8443
2003-09-10 06:55:28 +00:00
Guy Harris 27ea7816ee Have "get_interface_list()" return a list of "if_info_t" structures
containing a pointer to an interface name and possibly a pointer to an
interface description (although that pointer might be null if no
description is available), rather than having the Windows version glue
together the name and description into a single string.

Supply for the Linux "any" device the same description that libpcap's
"pcap_findalldevs()" returns.

svn path=/trunk/; revision=8440
2003-09-10 05:35:26 +00:00
Guy Harris 935a07c593 From Nathan Jennings: fix a problem with empty descriptions.
svn path=/trunk/; revision=8435
2003-09-09 18:27:49 +00:00
Guy Harris ba400ac5fe From Nathan Jennings: give the "Edit..." window for the capture options
dialog the right icon, and make ESC cancel it.

svn path=/trunk/; revision=8422
2003-09-09 04:44:57 +00:00
Gerald Combs 4c19deb206 In the Find dialog add periods or dashes to the list of allowed hex
separator characters.  Update the Ethereal man page accordingly.

svn path=/trunk/; revision=8420
2003-09-09 02:41:00 +00:00
Guy Harris 81fc518ec6 From Nathan Jennings:
support for user-supplied interface descriptions;

	support for hiding interfaces in drop-down list in capture
	dialog.

Clean up comments written to preferences file.

svn path=/trunk/; revision=8419
2003-09-08 21:44:42 +00:00
Guy Harris 31bce668bd More int vs. uint.
svn path=/trunk/; revision=8409
2003-09-07 00:59:07 +00:00
Guy Harris f6c0519c0a Support string dissector tables in the Tethereal "decode as" stuff.
Make the Ethereal "decode as" stuff not blow up with string dissector
tables.

Selectors for uint dissector tables are unsigned, not signed.

svn path=/trunk/; revision=8408
2003-09-07 00:47:57 +00:00
Guy Harris d66f162b71 From Brian K. Teravskis: add an option to save the data in CSV form.
svn path=/trunk/; revision=8405
2003-09-06 08:30:26 +00:00
Guy Harris 807e75690b Include <string.h> to get "strcmp()" declared.
svn path=/trunk/; revision=8393
2003-09-05 20:00:02 +00:00
Ronnie Sahlberg 95b3b8ca6d Add a popup to the ServicveResponseTime tables where the user can select
Prepare/Match/FindFrame similar to chat the ConversationList has.

Only enabled for SMB and ONC-RPC at this point

svn path=/trunk/; revision=8391
2003-09-05 10:26:44 +00:00
Guy Harris dd2080a646 Don't try to align the field filter name and name - the font would
probably be variable-width, so that doesn't work.  Just put a dash
between them.

Boost the size of the buffer used for the field text to 256 characters.

In GTK+ 1.2[.x], put the entries for fields (rather than protocols) in
as leaf nodes.

svn path=/trunk/; revision=8388
2003-09-05 06:59:38 +00:00