Commit Graph

34776 Commits

Author SHA1 Message Date
Jeff Morriss 5a2a122942 Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 760-761.

svn path=/trunk/; revision=36404
2011-03-29 21:39:15 +00:00
Anders Broman 645cfe9ef2 Add a missing break.
CID 487

svn path=/trunk/; revision=36403
2011-03-29 21:20:36 +00:00
Anders Broman ce248d9ea9 Add a missing break.
CID 488

svn path=/trunk/; revision=36402
2011-03-29 21:11:26 +00:00
Anders Broman 2b81b097e5 Add a missing break.
CID 490

svn path=/trunk/; revision=36401
2011-03-29 21:08:34 +00:00
Anders Broman bc0fbb792a Added FALLTHRU comment to avoid a "missing break" warning.
CID 489

svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
Chris Maynard 83dc9446ec From Alexis La Goutte via bug 5790: Add partial bit flag in query.
svn path=/trunk/; revision=36399
2011-03-29 20:58:57 +00:00
Chris Maynard a8c78f0562 Grab URL from frame info value instead of from tvb. Fixes bug 5780.
svn path=/trunk/; revision=36398
2011-03-29 20:05:33 +00:00
Jeff Morriss 607d944d02 Don't put a 196808 byte variable on the stack: instead, malloc/free it.
Coverity 789-790.

Since we've been keeping track of how many bytes we put in the buffer,
use that value instead of calling strlen() find it again.

Also, some white space/indentation cleanup.

svn path=/trunk/; revision=36397
2011-03-29 14:29:45 +00:00
Anders Broman ba8a739f4c Remove check_col().
svn path=/trunk/; revision=36396
2011-03-29 14:23:21 +00:00
Martin Mathieson 7356320a2a Don't assign proto_item pointers that are not used.
Coverity 1174

svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
Jeff Morriss ce392b5764 Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 791-794.

Also, some white space/indentation cleanup.

svn path=/trunk/; revision=36394
2011-03-29 14:05:28 +00:00
Stig Bjørlykke 9e5a9badda Guard against NULL return from find_protocol_by_id().
svn path=/trunk/; revision=36393
2011-03-29 11:09:59 +00:00
Stig Bjørlykke f7c84ad094 From Pascal Quantin:
Added guard against proto_name's not resolved as protocols.

svn path=/trunk/; revision=36392
2011-03-29 11:08:15 +00:00
Tomas Kukosa 7c083c0966 RTP: display payload type name from dynamic payload type table
H.223: use just one protocol for bot dissectors for more clear protocol disabling 

svn path=/trunk/; revision=36391
2011-03-29 10:56:30 +00:00
Jeff Morriss 892d734975 Prohibit (memory-unsafe) g_sprintf() and g_vsprintf().
svn path=/trunk/; revision=36390
2011-03-29 01:27:20 +00:00
Chris Maynard d69a7dac79 Cast to guint to avoid a Windows compiler warning.
svn path=/trunk/; revision=36389
2011-03-28 22:22:05 +00:00
Chris Maynard c91893191d Move -D option into "pre-scan" group as there's no need to start gtk+ for it.
svn path=/trunk/; revision=36388
2011-03-28 22:12:53 +00:00
Chris Maynard 42d40ee494 Use fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).
svn path=/trunk/; revision=36387
2011-03-28 22:10:41 +00:00
Stephen Fisher d4649392d8 Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.
svn path=/trunk/; revision=36386
2011-03-28 20:53:20 +00:00
Jeff Morriss a2393ea239 Use g_ascii_strdown instead of g_strdown
svn path=/trunk/; revision=36385
2011-03-28 19:44:41 +00:00
Guy Harris 173708364c More updates to the wtap_open_offline() comment.
svn path=/trunk/; revision=36384
2011-03-28 17:23:06 +00:00
Chris Maynard 10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
Chris Maynard 15503bf4aa Don't use prohibited strncpy(). In this case, use g_strlcat() instead.
svn path=/trunk/; revision=36382
2011-03-28 16:42:25 +00:00
Jeff Morriss c977007591 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :
Fix a Clang warning, add email address, and add some stuff to COL_INFO.

svn path=/trunk/; revision=36381
2011-03-28 15:28:03 +00:00
Jeff Morriss c39c25ce9c From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :
Register the reload-framing dissector by name.  Needed when RELOAD is not used
over udp/tcp (but tls, for example)

svn path=/trunk/; revision=36380
2011-03-28 15:23:27 +00:00
Jeff Morriss 569c3d9014 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 5

Enchance MySQL : 
* Add expert info of when undecoded data 
* Fix some white space

svn path=/trunk/; revision=36379
2011-03-28 15:20:16 +00:00
Chris Maynard ba9dc9f45f Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
the value="..." attribute.  Fixes bug 1520.

svn path=/trunk/; revision=36378
2011-03-28 14:53:35 +00:00
Stig Bjørlykke b95c4cb6a2 Added payload, header and trailer information to the DLT tree entry.
svn path=/trunk/; revision=36377
2011-03-28 14:18:29 +00:00
Anders Broman 08f71f1232 Update a comment.
svn path=/trunk/; revision=36376
2011-03-28 13:09:47 +00:00
Guy Harris 5749270c56 If there are more than 4 billion characters in the printable form of a
network address, we have bigger problems.  Cast the result of strlen()
to int to squelch a compiler warning with MSVC++.

svn path=/trunk/; revision=36375
2011-03-27 17:26:21 +00:00
Bill Meier 0da2042447 Fix Coverity 393: "DEADCODE"; Add an XXX comment
svn path=/trunk/; revision=36373
2011-03-27 16:15:19 +00:00
Gerald Combs 941666d525 Add "-z hosts", which dumps name resolution information in hosts format.
svn path=/trunk/; revision=36372
2011-03-27 16:06:03 +00:00
Gerald Combs 8cc32fd535 Add the IPv4 address, not the first 4 bytes of its name, to the
resolution table.

svn path=/trunk/; revision=36370
2011-03-27 15:58:52 +00:00
Bill Meier 7a77cdf0f1 1. Fix bug in dissection of a field; Add two missing lines of code.
2. #if 0 if test "which will never be true"; Add XXX comment

svn path=/trunk/; revision=36369
2011-03-27 15:39:06 +00:00
Gerald Combs a4f03a1101 [Automatic manuf, services and enterprise-numbers update for 2011-03-27]
svn path=/trunk/; revision=36368
2011-03-27 15:03:43 +00:00
Bill Meier 7c41d527fd Removed uneeded 'continue'.
Fixes Coverity 815 ("UNREACHABLE").

svn path=/trunk/; revision=36367
2011-03-27 14:34:19 +00:00
Stig Bjørlykke e43c9a35e4 Added a FALLTHRU comment to avoid a "missing break" warning.
Coverity 472.

svn path=/trunk/; revision=36366
2011-03-27 14:11:40 +00:00
Anders Broman 129f07a949 Added FALLTHRU comment to avoid a "missing break" warning.
svn path=/trunk/; revision=36365
2011-03-27 14:02:42 +00:00
Stig Bjørlykke 3c533baf45 Added a missing break.
Coverity 452.

svn path=/trunk/; revision=36364
2011-03-27 13:56:53 +00:00
Stig Bjørlykke 71c369611a Added a missing break.
Coverity 461.

svn path=/trunk/; revision=36363
2011-03-27 13:54:53 +00:00
Stig Bjørlykke 473b25301e Added some missing breaks.
Coverity 462 & 463.

svn path=/trunk/; revision=36362
2011-03-27 13:51:47 +00:00
Stig Bjørlykke c9468a80be Added some missing breaks.
Coverity 443 & 444.

svn path=/trunk/; revision=36361
2011-03-27 13:40:54 +00:00
Stig Bjørlykke 8ce65d5dee Added some missing breaks.
Coverity 447.

svn path=/trunk/; revision=36360
2011-03-27 13:35:30 +00:00
Stig Bjørlykke 31b37eec2d Added a FALLTHRU comment to avoid a "missing break" warning.
Coverity 458.

svn path=/trunk/; revision=36359
2011-03-27 13:33:28 +00:00
Stig Bjørlykke d79ac3d6b8 Added some missing breaks.
Coverity 466.

svn path=/trunk/; revision=36358
2011-03-27 13:30:39 +00:00
Stig Bjørlykke 58df865db5 Added a missing break.
Coverity 491.

svn path=/trunk/; revision=36357
2011-03-27 13:16:50 +00:00
Stig Bjørlykke a39c0d9577 Added a missing break.
Coverity 492.

svn path=/trunk/; revision=36356
2011-03-27 13:15:14 +00:00
Bill Meier 21d34d05b9 Don't assign to a proto_item* if the value won't be used: Coverity 895-897
Also: Fix some indentation & whitespace.

svn path=/trunk/; revision=36355
2011-03-26 16:39:30 +00:00
Jaap Keuter 391b328a6b From Alexis La Goutte:
A patch to add ATM over TCP Dissector.
The dissector dissect only the ATMTCP header (VCI, VPI, Payload Length) 
The data are not yet dissect, it is necessary to add a "UAT" (As with the K12
dissector) to indicate the type (ILMI, AAL, ATM...) of data (based on VCI/VPI)

svn path=/trunk/; revision=36354
2011-03-26 16:07:30 +00:00
Stig Bjørlykke ff40ab2174 Added a sanity check to remove a coverity warning.
Coverity 537.

svn path=/trunk/; revision=36353
2011-03-26 15:59:57 +00:00