call, and using ep_address_to_str(), so it can handle any address type,
including AT_NONE if the source address isn't available.
svn path=/trunk/; revision=40196
protocol.
Point to an HP document o the protocol, and discuss the two ways to hook
up the dissector.
Don't bother checking the destination address - either the OUI/PID
suffices, or the MAC address is both necessary and, presumably,
sufficient and we need to introduce a heuristic dissector table for SNAP
frames. What's more, there's no guarantee that the destination address
is a MAC address - it might be absent, e.g. because you're capturing on
the Linux "any" device and are getting the "Linux cooked" header, with
only a destination address.
Don't put the source address into the Info column - it's already in the
source column *if* it exists (which it might not, for packets captured
from the "any" device and sent by the machine doing the capturing).
svn path=/trunk/; revision=40195
we're given null pointers.
Put in comments clarifying that some routines intentionally do *not*
null terminate the strings they produce.
svn path=/trunk/; revision=40194
dissector bug exception in cases where a null pointer was passed, as
those really *are* dissector bugs (and I have a fix for the bug in
question in the HP Teaming heartbeat dissector, which I'll be checking
in later).
svn path=/trunk/; revision=40193
Actual problem:
A REAL_DATA tvbuff wasn't being added to the "data_sources"
for a frame. When displaying the frame, when a field referencing the tvb was selected
for display there was no 'hex bytes' tab for the field and so bytes ended up being
highlighted in the currently displayed hex bytes tab (thus highlighting bytes in a pane
not related to the field).
Consider: Add some code in field creation (proto_tree_add...) to at least warn if
a field is being created using a tvb whose data_source is not in the
data_sources list for the frame ?
svn path=/trunk/; revision=40182
uninitialised. The warnings are bogus, but could have been avoided, as the test
to see if we're using a compression profile is redundant/will always be TRUE
in those functions...
Also removed some unnecessary braces from switch cases (no local variables were defined).
svn path=/trunk/; revision=40181
form of corruption/bogosity in a file, including in a file header as
well as in records in the file. Change the error message
wtap_strerror() returns for it to reflect that.
Use it for some file header problems for which it wasn't already being
used - WTAP_ERR_UNSUPPORTED shouldn't be used for that, it should only
be used for files that we have no reason to believe are invalid but that
have a version number we don't know about or some other
non-link-layer-encapsulation-type value we don't know about.
svn path=/trunk/; revision=40175
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.
There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.
The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658
svn path=/trunk/; revision=40157