osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
28662 commits 26 branches 0 tags 795 MiB
Commit graph

11091 commits

Author SHA1 Message Date
Martin Mathieson
8760a6b49d Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants). 
svn path=/trunk/; revision=29420
 2009-08-15 01:29:29 +00:00
Kovarththanan Rajaratnam
80a6d3fbcf Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic. 
svn path=/trunk/; revision=29404
 2009-08-13 19:42:46 +00:00
Kovarththanan Rajaratnam
97fda7386c Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893

svn path=/trunk/; revision=29403
 2009-08-13 12:17:20 +00:00
Tomas Kukosa
e7ed279da9 fix build failure without GnuTLS 
svn path=/trunk/; revision=29402
 2009-08-13 11:12:35 +00:00
Tomas Kukosa
ae5e82dc11 use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVC 
svn path=/trunk/; revision=29401
 2009-08-13 10:36:53 +00:00
Tomas Kukosa
ebc78f0a07 Fix SSL decryption failure if client and server have the same TCP port 
svn path=/trunk/; revision=29400
 2009-08-13 09:07:03 +00:00
Anders Broman
6aed88fadc From Gerasimos Dimitriadis: 
DTAP decoding of Mobile Station Classmark 3 (R7 and R8)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891

svn path=/trunk/; revision=29399
 2009-08-13 07:56:13 +00:00
Anders Broman
088110624e From Gerasimos Dimitriadis: 
DTAP decoding of Mobile Station Classmark 3 (R6).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886

svn path=/trunk/; revision=29398
 2009-08-12 22:40:13 +00:00
Kovarththanan Rajaratnam
8fd6301ddc White space changes 
svn path=/trunk/; revision=29397
 2009-08-12 19:32:54 +00:00
Kovarththanan Rajaratnam
9eec025c49 DISSECTOR_ASSERT on FT_PCRE in construct_match_selected_string(). 
svn path=/trunk/; revision=29396
 2009-08-12 18:24:49 +00:00
Kovarththanan Rajaratnam
5bd6d8eaaf From William Preston via. 3549: 
A typo in 2 of the field names causes the apn not to be displayed.

svn path=/trunk/; revision=29394
 2009-08-12 15:12:19 +00:00
Balint Reczey
181f4c8364 Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test 
svn path=/trunk/; revision=29393
 2009-08-12 12:55:27 +00:00
Tomas Kukosa
cb5415d399 fix memoryleak causing crash with long SSL traces 
svn path=/trunk/; revision=29392
 2009-08-12 06:10:08 +00:00
Jaap Keuter
7267ec9782 Complete the fix in r29389. 
svn path=/trunk/; revision=29390
 2009-08-11 23:52:04 +00:00
Gerald Combs
4bfcd5993a Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel 
is unknown. Fixes bug 3864.

svn path=/trunk/; revision=29389
 2009-08-11 23:44:22 +00:00
Gerald Combs
1f3776bf8b Add some length checks. 
svn path=/trunk/; revision=29388
 2009-08-11 23:29:21 +00:00
Balint Reczey
80fbe4959a From Ivan Sy (with minor modifications): 
Show Teredo Connectivity tests.
Fix offset of ICMPv6 sequence number.

svn path=/trunk/; revision=29387
 2009-08-11 23:20:03 +00:00
Anders Broman
07900e7a1a From swapnil: 
Small Bug in TFT (Flow label) and ULI.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3876

svn path=/trunk/; revision=29386
 2009-08-11 21:27:36 +00:00
Gerald Combs
f625c7131d Use the right size for FT_UINT16. 
svn path=/trunk/; revision=29385
 2009-08-11 21:11:12 +00:00
Gerald Combs
809fb769b4 Add some length checks. Fixes a few recent fuzz bugs. 
svn path=/trunk/; revision=29384
 2009-08-11 20:58:36 +00:00
Gerald Combs
0ff1dd7142 Add a bunch of length checks. Fixes bug 3826. 
svn path=/trunk/; revision=29383
 2009-08-11 18:37:59 +00:00
Kovarththanan Rajaratnam
e1c5ffd553 (Trivial change) move ensure_contiguous() to reflect call hierarchy 
svn path=/trunk/; revision=29382
 2009-08-11 18:28:10 +00:00
Kovarththanan Rajaratnam
158827a5e7 Turn a comment in fast_ensure_contiguous() into a DISSECTOR_ASSERT() to make the implied requirement explicit. 
svn path=/trunk/; revision=29381
 2009-08-11 18:16:55 +00:00
Kovarththanan Rajaratnam
261a8406bc TRY_TO_FAKE_THIS_ITEM now fakes FT_PROTOCOL per default. If there are any users (e.g. proto_hier_stats.c, others?) that relies on FT_PROTOCOL nodes being created they'll now need to call the newly introduced epan_dissect_fake_protocols() to disable this optimization. 
Also make use of TRY_TO_FAKE_THIS_ITEM in proto_tree_add_text_node(), proto_tree_add_none_format() and proto_tree_add_protocol_format().

svn path=/trunk/; revision=29380
 2009-08-11 18:08:03 +00:00
Gerald Combs
8b9d2f7490 Be a little more explicit in our description of tvb_get_ptr. 
svn path=/trunk/; revision=29379
 2009-08-11 17:53:39 +00:00
Bill Meier
ca1cba6f30 Don't coerce a (void *) to a (guint32 *). 
The (void *) pointer in this case may point to
"unaligned" data.

svn path=/trunk/; revision=29378
 2009-08-11 13:44:35 +00:00
Anders Broman
6c2c08c082 From Gerasimos Dimitriadis: 
DTAP decoding of Mobile Station Classmark 3 (R4 and R5).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3866

svn path=/trunk/; revision=29377
 2009-08-11 12:22:00 +00:00
Anders Broman
bae780d14b From swapnil: 
Bugs Fixed in ULI in packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3860

svn path=/trunk/; revision=29376
 2009-08-11 10:32:46 +00:00
Kovarththanan Rajaratnam
e0e33ca74b We now expose the following environment variables: 
* WIRESHARK_DEBUG_EP_NO_CHUNKS
 * WIRESHARK_DEBUG_SE_NO_CHUNKS
 * WIRESHARK_DEBUG_EP_NO_CANARY
 * WIRESHARK_DEBUG_SE_NO_CANARY

This allows us to enable/disable memory chunks and canaries at runtime _without_ needing to recompile.

svn path=/trunk/; revision=29375
 2009-08-11 09:24:56 +00:00
Anders Broman
a8fbd4577f From swapnil: 
Another Minor Bug for ULI in Packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3862

svn path=/trunk/; revision=29374
 2009-08-11 07:41:46 +00:00
Guy Harris
c6893212f1 For TLV items that are a single integral value and thus must have a 
certain length:

	attach the expert item to the length field if we're showing it,
	otherwise put in a text item for the malformed TLV and attach
	the expert item to that;

	don't give up, as we'll just skip the bad item and move on to
	the next item.

svn path=/trunk/; revision=29373
 2009-08-10 22:15:22 +00:00
Bill Meier
a8533d84e5 Initialize a variable to keep GCC happy .... 
svn path=/trunk/; revision=29372
 2009-08-10 21:46:30 +00:00
Bill Meier
d7ecb89489 Validate two tag field lengths before attempting to do proto_tree_add_item(); 
Fixes bug #3841.

svn path=/trunk/; revision=29371
 2009-08-10 21:07:15 +00:00
Anders Broman
ca335d25cb From Kovarththanan Rajaratnam: 
- Compute and cache color/custom filters dynamically.
- Delay column construction.

svn path=/trunk/; revision=29370
 2009-08-10 20:52:56 +00:00
Anders Broman
72d8e6ad54 From Steve Osselton: 
GIOP dissector update for MIOP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3847

svn path=/trunk/; revision=29369
 2009-08-10 19:53:12 +00:00
Anders Broman
6c352a2959 From Gerasimos Dimitriadis: 
DTAP decoding of Mobile Station Classmark 3.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3819

svn path=/trunk/; revision=29368
 2009-08-10 19:48:42 +00:00
Bill Meier
41aa8b4ed7 (Quick) fix for bug #3836; 
Allow the DIR ("direction") AVP to be of variable length
 (in the absence of any documentation for this protocol).
 See the source for further comments.

svn path=/trunk/; revision=29367
 2009-08-10 18:45:47 +00:00
Kovarththanan Rajaratnam
7702b8766d Use ! defined(EP_DEBUG_FREE) && ! defined(SE_DEBUG_FREE) to guard canary code to get things compiling after r29358. 
svn path=/trunk/; revision=29365
 2009-08-10 16:36:44 +00:00
Gerald Combs
842d1be224 Fix the build. 
svn path=/trunk/; revision=29363
 2009-08-10 15:33:54 +00:00
Jörg Mayer
1e7031f1c0 Ivan Sy <ivan_jr@yahoo.com> via bug 3814 
TTL-Check for local network group addresses: Normally the
only valid TTL is 1. Add a check for VRRP and GLBP, where
the only valid TTL is 255.

Me: change the logic so the funtion returns the valid ttl
    instead of true/false.


svn path=/trunk/; revision=29362
 2009-08-10 14:55:47 +00:00
Kovarththanan Rajaratnam
3f4f8b0b94 Add unsigned int typecast 
svn path=/trunk/; revision=29361
 2009-08-09 21:10:04 +00:00
Kovarththanan Rajaratnam
39b1eb1015 g_error() requires a string literal. 
svn path=/trunk/; revision=29360
 2009-08-09 20:28:38 +00:00
Kovarththanan Rajaratnam
50c9dbca26 Split common parts of ep_free_all and se_free_all into emem_free_all. 
svn path=/trunk/; revision=29359
 2009-08-09 20:10:19 +00:00
Kovarththanan Rajaratnam
ecb5ee8e91 Split common parts of se_alloc and ep_alloc into emem_alloc. 
svn path=/trunk/; revision=29358
 2009-08-09 19:23:13 +00:00
Kovarththanan Rajaratnam
4e177a23c7 Use PITEM_FINFO. 
svn path=/trunk/; revision=29357
 2009-08-09 18:15:36 +00:00
Kovarththanan Rajaratnam
fa940d3366 Use PTREE_FINFO. 
svn path=/trunk/; revision=29356
 2009-08-09 18:05:44 +00:00
Kovarththanan Rajaratnam
083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible. 
svn path=/trunk/; revision=29355
 2009-08-09 17:57:31 +00:00
Kovarththanan Rajaratnam
3512e485ca Add PNODE_FINFO. We've been using PITEM_FINFO on proto_node's. This works because proto_item is typedefed to proto_node. We shouldn't rely on this since this is an implementation detail. 
svn path=/trunk/; revision=29354
 2009-08-09 17:33:23 +00:00
Bill Meier
dd2a488581 g_error() if registering a subtree item type already registered (or not initialized to -1). 
svn path=/trunk/; revision=29352
 2009-08-09 15:49:02 +00:00
Gerald Combs
cdb8e2c6b7 [Automatic manuf and enterprise-numbers update for 2009-08-09] 
svn path=/trunk/; revision=29348
 2009-08-09 15:03:28 +00:00
Kovarththanan Rajaratnam
c1fea16295 Don't use DISSECTOR_ASSERT to check source/destination address type. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3825

svn path=/trunk/; revision=29347
 2009-08-09 10:50:30 +00:00
Kovarththanan Rajaratnam
ac463d2697 Don't guard col_clear with col_check 
svn path=/trunk/; revision=29346
 2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29345
 2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam
0a5b014cec Don't guard col_clear with col_check 
svn path=/trunk/; revision=29344
 2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
5d5a5442d6 Don't guard col_set_str (COL_RES_DL_SRC/COL_RES_DL_DST) with col_check 
svn path=/trunk/; revision=29343
 2009-08-09 07:14:16 +00:00
Kovarththanan Rajaratnam
4b6090e576 Don't guard col_set_str (COL_INFO) with col_check 
svn path=/trunk/; revision=29342
 2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam
24ca3c44c9 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29341
 2009-08-09 06:47:24 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Guy Harris
fc067ab910 Don't use DISSECTOR_ASSERT() to check a packet's content. Fixes bug 
3827.

svn path=/trunk/; revision=29339
 2009-08-09 01:23:09 +00:00
Kovarththanan Rajaratnam
ced157e4b7 Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658

svn path=/trunk/; revision=29336
 2009-08-08 09:57:07 +00:00
Jaap Keuter
4f501b3655 From Ivan Sy: 
Fixed IPv6 malformed packet when ip6_nxt (Next Header) is equal to "59". as per section 4.7 RFC 2460.

svn path=/trunk/; revision=29334
 2009-08-08 04:51:42 +00:00
Gerald Combs
7cf4114654 If we have a format error, don't try adding something to the 
tree. Fixes bug 3822.

svn path=/trunk/; revision=29331
 2009-08-08 00:27:31 +00:00
Gerald Combs
7110e957f6 From Matt P via bug 3774: 
Patch utilizes techniques incorporated in the packet-ieee8023.c dissect_802_3()
routine to dynamically calculate the remaining payload length.  This is then
compared to the length included in the CCSDS header.

svn path=/trunk/; revision=29329
 2009-08-07 21:53:40 +00:00
Jörg Mayer
952cbd7902 * Tue May 26 2009 cmorve69@yahoo.es 
- made it compile with --as-needed

This patch was taken from the opensuse wireshark.spec file.
No thanks go to the author and the package maintainers of
this package for not sending this upstream - it would have
made it into 1.2.0.

svn path=/trunk/; revision=29326
 2009-08-07 18:47:56 +00:00
Jörg Mayer
d9531723b5 - Add rfc number comments on not-yet-decoded options 
- Decode autoconfigure option

svn path=/trunk/; revision=29325
 2009-08-07 18:45:06 +00:00
Gerald Combs
367bcb7abd Clean up the last two DIRTY_DISSECTOR_SRC entries. 
svn path=/trunk/; revision=29321
 2009-08-07 00:15:35 +00:00
Bill Meier
3c1bc8f251 Fix some individual cases of 'if (unsigned) < 0' 
svn path=/trunk/; revision=29320
 2009-08-06 23:51:45 +00:00
Bill Meier
4acb789917 'if (curr_len <= 0)' won't work as desired when curr_len is declared as unsigned. 
The fix: change to 'if ((signed)curr_len <= 0)'.
This is a bit of a hack but I think it works.
See the comment in this file (packet-gsm_a_common.h).

svn path=/trunk/; revision=29319
 2009-08-06 23:47:21 +00:00
Guy Harris
c3aaf166c6 Those items are 32 bits or longer, so the cast should be safe; add an 
additional cast in the hopes that they squelch "dereferencing
type-punned pointer" warnings.

svn path=/trunk/; revision=29318
 2009-08-06 23:26:24 +00:00
Michael Tüxen
8fcdcbd14f packet-sctp.c seems to be clean (at least it is on Mac OS X). 
svn path=/trunk/; revision=29317
 2009-08-06 22:26:05 +00:00
Michael Tüxen
191709f6af Get it compiling when HAVE_LIBGCRYPT is not defined. 
svn path=/trunk/; revision=29315
 2009-08-06 21:55:10 +00:00
Bill Meier
b38516fbd9 Fix some indentation and spacing 
svn path=/trunk/; revision=29314
 2009-08-06 21:42:40 +00:00
Gerald Combs
85f68c7461 Fix compilation warnings in a few dissectors and try moving them to the 
"clean" list.

svn path=/trunk/; revision=29313
 2009-08-06 20:55:04 +00:00
Bill Meier
21d8e2d3e1 Prevent possible (benign ?) array references with an array index of -1. 
svn path=/trunk/; revision=29312
 2009-08-06 18:44:38 +00:00
Bill Meier
eba5297683 Remove inadvertantly committed comments re issue yet to be fixed ... 
svn path=/trunk/; revision=29311
 2009-08-06 16:13:31 +00:00
Bill Meier
413e64f1a6 Register ett[] subtree array only once. 
svn path=/trunk/; revision=29310
 2009-08-06 16:10:29 +00:00
Bill Meier
7f7161f819 Register ett[] subtree array only once. 
svn path=/trunk/; revision=29309
 2009-08-06 16:06:11 +00:00
Gerald Combs
595f9b6630 Convert a GString to an ep_strbuf_t (and squelch a static analysis 
warning in the process). Remove an unused variable.

svn path=/trunk/; revision=29308
 2009-08-05 19:03:48 +00:00
Jaap Keuter
b5aa261da6 From Gerasimos Dimitriadis: 
Fixes/enhances the decoding of the Mobile Identity IE for type of identity
"TMGI and optional MBMS Session Identity".

svn path=/trunk/; revision=29307
 2009-08-05 18:42:45 +00:00
Jaap Keuter
8787b8ecc8 Fix for bug 3811: 
Add missing shorthand application/vnd.ms-sync besides application/vnd.ms-sync.wbxml.

svn path=/trunk/; revision=29306
 2009-08-05 18:21:52 +00:00
Jaap Keuter
5c57e015d4 From Ivan Sy: 
Add support for Support for DHCID RR (RFC 4701).

svn path=/trunk/; revision=29305
 2009-08-05 18:17:18 +00:00
Martin Mathieson
92b2bcf28a Show power headroom report inside its own subtree. 
svn path=/trunk/; revision=29303
 2009-08-05 08:02:12 +00:00
Jaap Keuter
203269175e Fix for bug 3806: 
Add presentation of Block Ack Bitmap.

svn path=/trunk/; revision=29302
 2009-08-05 07:33:44 +00:00
Gerald Combs
931a750908 Add a couple of pointer checks. 
svn path=/trunk/; revision=29301
 2009-08-05 00:36:27 +00:00
Jaap Keuter
c9e3f66d14 Optimize empty strings to NULL pointers. 
svn path=/trunk/; revision=29298
 2009-08-04 21:05:38 +00:00
Bill Meier
d0f569953d Fix benign double subtree registration of an ett_... variable. 
svn path=/trunk/; revision=29297
 2009-08-04 19:29:42 +00:00
Bill Meier
cb7dac7100 Initialize several ett_... variables to -1 
svn path=/trunk/; revision=29295
 2009-08-04 18:52:01 +00:00
Bill Meier
90e865cc54 Init ett_... variables to -1 
svn path=/trunk/; revision=29294
 2009-08-04 18:48:45 +00:00
Bill Meier
8ffaa3b880 Remove duplicate entry from ett[] 
svn path=/trunk/; revision=29293
 2009-08-04 18:46:51 +00:00
Guy Harris
b6660d06bf Clean up white space a bit - use 2-space indenting. 
Put a bunch of code that does nothing unless data_val is non-null inside
"if (data_val)", and get rid of the individual tests.

svn path=/trunk/; revision=29292
 2009-08-04 18:39:43 +00:00
Gerald Combs
49c58bc1a4 Miscellaneous cleanups. 
svn path=/trunk/; revision=29291
 2009-08-04 17:59:48 +00:00
Martin Mathieson
fef272347b Show number of predefined bytes in info column. 
svn path=/trunk/; revision=29290
 2009-08-04 10:41:08 +00:00
Jörg Mayer
45ab8d50d2 Warning fix: comma at end of enum 
svn path=/trunk/; revision=29289
 2009-08-04 07:50:49 +00:00
Gerald Combs
87c095780a Rework an assignment to keep static analyzers from complaining. 
svn path=/trunk/; revision=29287
 2009-08-03 23:51:13 +00:00
Guy Harris
bd97aecdd3 Clean up indentation somewhat. 
svn path=/trunk/; revision=29281
 2009-08-03 21:17:30 +00:00
Jaap Keuter
2c9c96744d From Gerasimos Dimitriadis: 
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.

svn path=/trunk/; revision=29280
 2009-08-03 21:12:41 +00:00
Guy Harris
f3944baaf0 Thou shalt terminate thy value_string arrays with {0, NULL}. 
svn path=/trunk/; revision=29279
 2009-08-03 21:07:08 +00:00
Gerald Combs
8224d4e436 Add a null pointer check. Remove some unused variables. 
svn path=/trunk/; revision=29278
 2009-08-03 19:50:35 +00:00
Jaap Keuter
e0336d1243 From Ivan Sy: 
Support for Host Identity Protocol (HIP) Domain Name System (DNS) Extension.

svn path=/trunk/; revision=29277
 2009-08-03 18:23:04 +00:00
Bill Meier
aed6451fff Remove 1 commented-out #include inadvertantly committed. 
svn path=/trunk/; revision=29276
 2009-08-03 18:06:36 +00:00
Bill Meier
d8297e8312 Add some debug code (commented out) to check for duplicate dissector port registrations, 
svn path=/trunk/; revision=29275
 2009-08-03 17:25:17 +00:00
Bill Meier
d4e1095f54 Reword some help text slightly. 
svn path=/trunk/; revision=29274
 2009-08-03 16:21:55 +00:00
Bill Meier
1792c7d1a4 Do find_dissector_table() in proto_reg_handoff(). 
svn path=/trunk/; revision=29272
 2009-08-03 15:18:44 +00:00
Bill Meier
41a9e1c16f (Trivial) Fix two typos. 
svn path=/trunk/; revision=29271
 2009-08-03 14:17:31 +00:00
Stig Bjørlykke
dd79032722 Added missing packet-usb-hid.h 
svn path=/trunk/; revision=29270
 2009-08-03 09:58:14 +00:00
Stig Bjørlykke
7714e602c8 Handle usb_hid_item_usage_vals as range_string. 
svn path=/trunk/; revision=29269
 2009-08-03 08:05:44 +00:00
Bill Meier
2602c42fcb Do dissector_add() only if port non-zero; register dissector for "decode-as". 
svn path=/trunk/; revision=29268
 2009-08-02 19:54:33 +00:00
Bill Meier
3a61b43a42 packet-stun2 registers for TCP & UDP port 3478 so packet-stun need not register for same. 
svn path=/trunk/; revision=29267
 2009-08-02 19:20:20 +00:00
Bill Meier
fa3443bbc1 Change default range from 1401,1401 to 1401 so that the port isn't double-registered. 
svn path=/trunk/; revision=29266
 2009-08-02 19:17:09 +00:00
Bill Meier
1ab1e3889c Don't do dissector_add twice on TCP port 3689; 
packet-daap requests registration on that port via http_dissector_add
 and thus packet-http does not need to do a default registration on that port.
Also: fix a typo in a comment.

svn path=/trunk/; revision=29265
 2009-08-02 19:09:36 +00:00
Gerald Combs
bd3795cb29 [Automatic manuf and enterprise-numbers update for 2009-08-02] 
svn path=/trunk/; revision=29262
 2009-08-02 15:03:29 +00:00
Bill Meier
082db3982a Remove unneeded #include <epan/emem.h>; fix some indentation. 
svn path=/trunk/; revision=29261
 2009-08-02 12:58:57 +00:00
Jaap Keuter
672a9f6e62 Add additional cypher types. 
svn path=/trunk/; revision=29260
 2009-08-02 12:53:14 +00:00
Jaap Keuter
18478a63bc Fix for bug 3800: 
Correctly track the size of Feedback Control Information in Payload specific RTCP feedback packet.

svn path=/trunk/; revision=29259
 2009-08-02 12:11:38 +00:00
Martin Mathieson
ed930bece3 Remember Msg3 bytes and compare with Msg4 Contention Resolution bodies. 
svn path=/trunk/; revision=29258
 2009-08-01 09:52:12 +00:00
Guy Harris
f846e15d40 Fix indentation, get rid of a comment that might no longer apply (dump 
*what* as hex?  The stuff we now display as generic fields?).

svn path=/trunk/; revision=29257
 2009-07-31 23:38:02 +00:00
Gerald Combs
62b8aa0837 From Adam Nielsen via bug 3659: 
Here is a patch against SVN that implements preliminary support for USB HID
devices.  At the moment it only dissects the initial set up packets (which you
will see if you hotplug a keyboard or mouse.)

The patch also fixes a minor bug in the USB dissector code which reported
certain packets as malformed due to miscounting bytes, and it reports control
packet data and padding data in a more user-friendly manner.

svn path=/trunk/; revision=29256
 2009-07-31 22:16:29 +00:00
Guy Harris
99bd70035d Completely remove an unused variable, don't just comment it out 
(especially with a C++/C99-style comment that not all compilers used to
compile Wireshark accept).

svn path=/trunk/; revision=29255
 2009-07-31 20:13:53 +00:00
Gerald Combs
ee5d2e8788 From Holger Freyther via bug 3776: 
Part 1:
Rename packet-gsm_abis_ip.c to packet-gsm_ipa.c.

Part 2:
Rename to the content to match the filename.

Part 3:
Add GSM A/SCCP support to the packet-gsm_ipa.c dissector

Adjusted patch to take laforge's comment into account. Use guint16 for the
length and use the ntohs routine to convert the length.

svn path=/trunk/; revision=29254
 2009-07-31 19:19:25 +00:00
Gerald Combs
dd28a00a78 From Ivan Sy via bug 3797: 
Support for SPF RR (RFC 4408)

- this has the same format as TXT RR (see section 3.1.1) below.
Currently wireshark 1.2.1 shows this as Unknown type 99

svn path=/trunk/; revision=29253
 2009-07-31 16:37:53 +00:00
Jaap Keuter
08b2e76773 From Ivan Sy: 
Add support for SSHFP RR (RFC 4255).

svn path=/trunk/; revision=29252
 2009-07-31 07:05:43 +00:00
Jaap Keuter
0553926fcc From Ivan Sy: 
NAPTR RR (RFC 3403) replacement MUST be a fully qualified domain-name.

svn path=/trunk/; revision=29250
 2009-07-31 06:51:27 +00:00
Gerald Combs
9a35ed601d Remove more unused variables. 
svn path=/trunk/; revision=29249
 2009-07-30 23:47:36 +00:00
Guy Harris
db0698fd0a Fix warnings: 
the behavior of x = x++ is undefined by the ANSI C standard -
	they obviously just meant x++;

	get rid of unused variables.

svn path=/trunk/; revision=29248
 2009-07-30 21:40:22 +00:00
Anders Broman
532f424f33 From swapnil: 
Packet-gtpv2.c dissector extended to support more IE's.

svn path=/trunk/; revision=29247
 2009-07-30 21:11:26 +00:00
Gerald Combs
6c99cf5519 From Kovarththanan Rajaratnam via bug 3506: 
The exception throwing code in except.c/h should be annotated with
"noreturn" to indicate that they never return. Running static analysis
on Wireshark without this annotation causes a lot of false positives
since these analyzers assume that the exception handling code are
ordinary functions that will eventually return.

svn path=/trunk/; revision=29246
 2009-07-30 17:54:58 +00:00
Gerald Combs
b249ff0487 Remove a couple of unused variables. 
svn path=/trunk/; revision=29245
 2009-07-30 17:22:00 +00:00
Martin Mathieson
0abc55b7fc Show backoff indicator value in subheader tree root. 
svn path=/trunk/; revision=29244
 2009-07-30 16:53:33 +00:00
Gerald Combs
e951661130 Remove some unused variable assignments. 
svn path=/trunk/; revision=29243
 2009-07-30 16:17:46 +00:00
Gerald Combs
0cceb40317 Remove some unused variables. 
svn path=/trunk/; revision=29242
 2009-07-30 00:40:32 +00:00
Bill Meier
62a8504eda Function dissect_zcl_attr_data_type() unused: comment it out 
svn path=/trunk/; revision=29240
 2009-07-29 22:54:28 +00:00
Bill Meier
6de62aee00 Fix a potential crash and do various other minor changes: 
- Fix an hf[] entry which had an invalid "strings" field which could cause a crash;
- Remove unneeded #includes;
- Make most functions & etc static;
- Remove declarations for functions never defined;
- Fix certain comments to refer to the correct function names;
- Change global variable to be local to proto_reg_handoff...
- ...

svn path=/trunk/; revision=29239
 2009-07-29 22:33:08 +00:00
Bill Meier
ad74edb139 From Chris Costa: Fix Bug 3786: "NDMP fragmentation fails when final fragment is very small". 
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3786)

svn path=/trunk/; revision=29236
 2009-07-29 20:24:10 +00:00
Guy Harris
512a32889c Add packet-zbee-zcl.h to the source tarball. 
svn path=/trunk/; revision=29235
 2009-07-29 19:39:17 +00:00
Jaap Keuter
d779b4f96f From Neil Piercy: 
The Cert Authority hashes in the IKEv2 Cert Request are not dissected properly:
the display offset is not correctly moved on, so the same info is displayed for
all Cert Authority fields.

svn path=/trunk/; revision=29234
 2009-07-29 18:26:55 +00:00
Ronnie Sahlberg
148263ebf0 zigbee cluster dissector, 
modified from entry in bug 3765 so it compiles cleanly


svn path=/trunk/; revision=29232
 2009-07-29 11:29:53 +00:00
Ronnie Sahlberg
ad942553b3 start describing ReportEventW in the IDL and make use of the "bitmap" 
for EventTypes.

This addresses also bug 3552 with the until now unusued code.


The eventlog dissector is very incomplete.
While the protocol specification is available now, what is lacking is 
example capture files to test with when implementing more of the IDL 
definitions.




svn path=/trunk/; revision=29231
 2009-07-29 10:59:31 +00:00
Ronnie Sahlberg
e5f6cb05da Fixup the correct names of the parameters for OpenEventLogW 
svn path=/trunk/; revision=29230
 2009-07-29 10:41:24 +00:00
Ronnie Sahlberg
1899a11f3f update the idl to correctly dissect the read eventlog w flags as a 
bitmap and not as a uint32

this addresses bug 3691 (that was already manually addressed by hand 
in the generated dissector)



svn path=/trunk/; revision=29229
 2009-07-29 10:28:10 +00:00
Ronnie Sahlberg
a3355a0949 Break the aes set ket/decrypt/encrypt out from airpdcap_raindoll into 
its own crypt-aes.

change the integer types to glib style integers


this may/will be helpful if/when we implement our own version of 
kerberos 
aes decryption of dcerpc since the existing libraries can not (yet) 
handle when header signing is used.

we should implement our own decryption of this for cfx+aes just as we 
did for classic+arcfour





svn path=/trunk/; revision=29228
 2009-07-29 10:01:14 +00:00
Tomas Kukosa
f56e93d1a5 Support for IPv6 addresses in URI 
svn path=/trunk/; revision=29227
 2009-07-29 09:13:03 +00:00
Jaap Keuter
cde25ec6a2 From Ivan Sy: 
Support for DLV RR (RFC 4431) and SHA-256 Digest for DS RR (RFC 4509).

svn path=/trunk/; revision=29226
 2009-07-29 07:10:02 +00:00
Ronnie Sahlberg
cfc60e805d update samr.idl and remove a keyword we no longer support in pidl 
regenerate samr and frstrans with the new version of pidl


svn path=/trunk/; revision=29219
 2009-07-28 14:11:08 +00:00
Ronnie Sahlberg
77fc0c9451 From Stefan Metzmacher 
add generated FRSTRANS dissectors and add them to the build


svn path=/trunk/; revision=29217
 2009-07-28 13:53:10 +00:00
Ronnie Sahlberg
3c1de7c38e From Stefan Metzmacher : 
Add IDL file for FRSTRANS


svn path=/trunk/; revision=29216
 2009-07-28 13:50:22 +00:00
Ronnie Sahlberg
4802884629 regenerate SAMR using the new version of pidl 
svn path=/trunk/; revision=29215
 2009-07-28 13:39:42 +00:00
Ronnie Sahlberg
f8cf2d2c83 When we passed the crytobuffer to krb5_c_decrypt() we never actually 
verified that we did have enough data in the buffer/tvb, which could 
lead to a SEGV.
(for example if we enable KRB5 decryption but we do NOT use TCP 
reassembly, and the encrypted data goes beyong the end of the current 
segment)


Change the signature to decrypt_krb5_data() to take a TVB instead of a 
buffer+length.
Actually check that we do have the entire encrypted PDU before calling 
out to the kerberos libraries.



svn path=/trunk/; revision=29213
 2009-07-28 13:01:41 +00:00
Anders Broman
2a80b47ce4 Whitespace change. 
svn path=/trunk/; revision=29211
 2009-07-28 09:26:18 +00:00
Ronnie Sahlberg
ac1b52a838 From: Matthieu Patou <mat+Informatique.Samba@matws.net> 
Date: Mon, 27 Jul 2009 08:55:55 +0000 (+0200)
Subject: patch_ldap_260709

Add a few additional LDAP OIDs
and increase the maximum SASL blob size to be 1M instead of 256kb



svn path=/trunk/; revision=29210
 2009-07-28 07:18:05 +00:00
Bill Meier
dece30a6ce Improve defragmentation: 
1. Prevent tcpencap (ipsec-tcp) from incorrectly dissecting NDMP PDU fragments;
    (Essentially: register NDMP as the dissector for the conversation);
   Allows correct NDMP fragment reassembly whether or not the 
    TCP "Try heuristic sub-dissectors first" preference is enabled.
   Fixes Bug #3755 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3755)
2. Use a registered init routine to init the fragment and reassembled tables 
   each time a complete capture dissection is (re)started.
   Fixes a crash.
3. Don't register on TCP port 10000 since the tcpencap dissector needs to own this
   port. (The NDMP dissector is a heuristic dissector).
4. Strengthen the heuristic checking slightly.
5. Other minor changes.

svn path=/trunk/; revision=29208
 2009-07-27 21:59:01 +00:00