osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
34,066 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

34066 Commits

Author SHA1 Message Date
Jeff Morriss 5695d835f5 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 : 
A small patch to add color rules for ICMPv6 Error (some error as ICMP(v4)..)

With this patch, Wireshark is ready for IPv6 Day ;)

svn path=/trunk/; revision=35611
 2011-01-21 17:12:02 +00:00
Jeff Morriss 4eb43096b1 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 : 
Following the discussion on the dev mailing list about ett_ value in subtree
http://www.wireshark.org/lists/wireshark-dev/201101/msg00039.html

a small to update the Readme Developer Guide !

svn path=/trunk/; revision=35610
 2011-01-21 17:08:35 +00:00
Anders Broman 4374c0b0b7 - Wrong element type used. 
- Use match_strval_idx_ext.

svn path=/trunk/; revision=35609
 2011-01-21 14:03:42 +00:00
Anders Broman dd1ab4b227 Use EXTRANEOUS_DATA_CHECK_EXPERT 
svn path=/trunk/; revision=35608
 2011-01-21 09:31:25 +00:00
Anders Broman 83c29e1672 Move sgsap_elem_idx_t to packet-gsm_a_common.h 
Dissect Global-CN-Id

svn path=/trunk/; revision=35607
 2011-01-21 09:26:29 +00:00
Anders Broman 6956ad46d5 CN-Id is two bytes. 
svn path=/trunk/; revision=35606
 2011-01-21 09:24:43 +00:00
Anders Broman fe68c6f1d2 From Tobias Klauser: 
Fix standard to IEC62439 Part 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5599

svn path=/trunk/; revision=35605
 2011-01-21 06:30:55 +00:00
Anders Broman 531317a178 Fix typos 
svn path=/trunk/; revision=35604
 2011-01-21 06:27:08 +00:00
Jeff Morriss f53744b59d There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().
   
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

svn path=/trunk/; revision=35603
 2011-01-21 03:00:31 +00:00
Jeff Morriss 6e0fcb7ab5 Introduce, and start using, tvb_eth_to_str(). 
Export tvb_*_to_str() and put them in alphabetical order.

svn path=/trunk/; revision=35602
 2011-01-21 02:48:55 +00:00
Jeff Morriss 03066d0820 Use tvb_ip_to_str() 
svn path=/trunk/; revision=35601
 2011-01-21 02:25:30 +00:00
Sake Blok 6e74ad9097 Adress => Address corrections (also in comments). 
(see bug 5600)


svn path=/trunk/; revision=35600
 2011-01-21 00:19:03 +00:00
Jaap Keuter 9e1d1e0e13 Allow presentation of Gauge32 values larger than 0x7FFFFFFF. 
svn path=/trunk/; revision=35599
 2011-01-20 20:04:39 +00:00
Stephen Fisher fc7b0c019b Fix the dead initialization warnings found by clang's static analysis 
("Value stored to 'xxx' during its initialization is never read")


svn path=/trunk/; revision=35598
 2011-01-20 18:56:11 +00:00
Anders Broman 9c04eb9b2c Fix typos 
svn path=/trunk/; revision=35597
 2011-01-20 14:03:13 +00:00
Anders Broman fbde1c7130 Update a comment. 
svn path=/trunk/; revision=35596
 2011-01-20 13:19:26 +00:00
Anders Broman 3112035ad2 In MM context the container contains IE:s not a complete 
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

svn path=/trunk/; revision=35595
 2011-01-20 13:05:17 +00:00
Jaap Keuter 3ff6167958 Allow for expert items to be actually attached somewhere. 
svn path=/trunk/; revision=35594
 2011-01-20 08:58:03 +00:00
Jeff Morriss 705f2ede5d Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead 
of going through a temporary variable).  This just makes it more obvious which
add_bytes_format() calls are or are not being given pointers into the TVB.

Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots.

svn path=/trunk/; revision=35593
 2011-01-20 03:49:44 +00:00
Stephen Fisher 573b4d449f Add a note to the top about r35589's change of the ADDCARRY(x) macro. 
svn path=/trunk/; revision=35592
 2011-01-19 22:57:19 +00:00
Jaap Keuter 969b5a240e Don't stop calling subdissectors when there's no tree. 
svn path=/trunk/; revision=35591
 2011-01-19 22:55:53 +00:00
Jaap Keuter c5c0a0d943 Use Wireshark standard marking for unused parameters. 
svn path=/trunk/; revision=35590
 2011-01-19 22:53:46 +00:00
Stephen Fisher c732e15d77 Change the ADDCARRY(x) macro to eliminate clang warning about unused 
result from the ADDCARRY portion of the REDUCE macro.

-#define ADDCARRY(x)  (x > 65535 ? x -= 65535 : x)
+#define ADDCARRY(x)  {if ((x) > 65535) (x) -= 65535;}

The new code is from in_cksum.c in the Tahoe/CGI port of 4.4BSD-Lite2 (we're
using the "Portable Version" copy otherwise).


svn path=/trunk/; revision=35589
 2011-01-19 22:53:38 +00:00
Stephen Fisher 32f6ab2248 Simply this: 
#define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN ((gint)strlen (SIP2_HDR))

To this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN 7


svn path=/trunk/; revision=35588
 2011-01-19 21:51:30 +00:00
Stephen Fisher 316cd69642 Fix warning found by clang... 
packet-dcerpc.c:4056:19: error: comparison of integers of different signs:
      'guint32' (aka 'unsigned int') and 'int' [-Wsign-compare]
    for (i = 0; i < (int) commands_nb; ++i) {
                ~ ^ ~~~~~~~~~~~~~~~~~

... by removing the "(int)" cast


svn path=/trunk/; revision=35587
 2011-01-19 21:45:54 +00:00
Jaap Keuter 5c7ec8729a From Alexis La Goutte: 
A patch to enhance the ICMPv6 dissector
- Make ICMP Type (sub)field filterable
- Add Inverse Neighbor Discovery (RFC 3122)
- Remove dependency to packet-ipv6.h
- Cleanup packet-ipv6.h
- Update RFC Draft to draft-ietf-roll-rpl-17 (with make a sub dissector
  for RPL Control and add Secure RPL...)
- Replace tvb_get_ipv6/ip6_to_str by new function tvb_ip6_to_str
- and other enchancements.....

svn path=/trunk/; revision=35586
 2011-01-19 20:57:39 +00:00
Stephen Fisher fb645f7e28 Cast the returned value from strlen() to an int to make the Windows 64-bit 
buildbot happy.


svn path=/trunk/; revision=35585
 2011-01-19 19:42:00 +00:00
Stephen Fisher 347d0a77bf From Cal Turney via enhancement bug #5587: In hex or string searches of the 
packet data highlight the target rather than the entire field.


svn path=/trunk/; revision=35584
 2011-01-19 18:21:21 +00:00
Stephen Fisher 30b047223a From Cal Turney via bug #5585: When searching in packet bytes, the field and 
bytes are not immediately shown.


svn path=/trunk/; revision=35583
 2011-01-19 17:58:53 +00:00
Anders Broman bc80cd8155 Fix the broken Edit Menu when UImanager is used. 
(UnmarkAllDisplayedPackets)

svn path=/trunk/; revision=35582
 2011-01-19 14:55:15 +00:00
Anders Broman feea97e6aa packet-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function 
svn path=/trunk/; revision=35581
 2011-01-19 09:49:36 +00:00
Anders Broman 3c491eee6b Cleaned up splitt between old and new dissection style. 
A lot of conversion still needed.

svn path=/trunk/; revision=35580
 2011-01-19 09:35:34 +00:00
Anders Broman 6b24548858 Add the RAI value to "add_string" 
svn path=/trunk/; revision=35579
 2011-01-19 06:43:28 +00:00
Anders Broman 0119e04527 Try to enhance output at ValueError to ease debugging. 
svn path=/trunk/; revision=35578
 2011-01-19 06:33:33 +00:00
Anders Broman 4a3eda9862 Updated to OMA-TS-ULP-V2_0-20100806-D 
with asn1 files from eyimjia.
Files hand edited to pass as2wrs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5593
(Does not fix the bug)

svn path=/trunk/; revision=35577
 2011-01-19 06:27:50 +00:00
Anders Broman f785ee57ff Introduce EXTRANEOUS_DATA_CHECK_EXPERT 
which adds an expert item.

svn path=/trunk/; revision=35576
 2011-01-18 20:16:56 +00:00
Jörg Mayer 6e4b5cac5e dumpcap failed to link - add glib2 and wsutil libraries to fix this. 
svn path=/trunk/; revision=35575
 2011-01-18 17:49:41 +00:00
Gerald Combs 9fe5b9af3f Add another item. 
svn path=/trunk/; revision=35574
 2011-01-17 22:23:35 +00:00
Anders Broman cbc7cbd1b2 Handle two length octets correctly in TELV. 
svn path=/trunk/; revision=35573
 2011-01-17 21:12:30 +00:00
Anders Broman 821f91f278 - append TLLI value. 
- Whitespace changes.

svn path=/trunk/; revision=35572
 2011-01-17 21:10:54 +00:00
Bill Meier 8d272fb165 (Until Anders comletes work): use #if 0 instead of //; init a variable; 
svn path=/trunk/; revision=35571
 2011-01-17 16:51:31 +00:00
Bill Meier 180bb0c13f Remove redundant test for a non-null pointer; 
svn path=/trunk/; revision=35570
 2011-01-17 16:36:52 +00:00
Jeff Morriss fa16c931e1 Actually use proto_tree_add_item() instead of proto_tree_add_ether(). I hope I didn't miss more of these... 
svn path=/trunk/; revision=35569
 2011-01-17 15:22:11 +00:00
Martin Mathieson 7205313026 - Use correct data pointer during a comparison. 
- Add expert info to show when DRX command is received
- Get rid of some tabs


svn path=/trunk/; revision=35568
 2011-01-17 15:01:22 +00:00
Anders Broman fe7213590b Restore dissection of Mobile Identity(revert the code). 
svn path=/trunk/; revision=35567
 2011-01-17 14:18:54 +00:00
Anders Broman 71d02b5455 - Remove debug printout. 
- Enhance dissection a bit.
- add new true_false_strings

svn path=/trunk/; revision=35566
 2011-01-17 13:09:08 +00:00
Bill Meier 7089b9c780 Do Windows compile with /WX flag: treat warnings as errors. 
svn path=/trunk/; revision=35565
 2011-01-16 23:47:05 +00:00
Bill Meier 483b52c8e7 Compile text2pcap.c,mergecap.c,capinfos.c,editcap.c, & version_info.c with -WX; 
(Treat warnings as errors);
Done by simplifing the dependency line for the objects so that the
 default .c.obj inference rule is used.

svn path=/trunk/; revision=35564
 2011-01-16 23:24:15 +00:00
Bill Meier ba48c5061e Fix a Windows compiler warning; 
Minor whitespace cleanup.

svn path=/trunk/; revision=35563
 2011-01-16 23:04:33 +00:00
Jeff Morriss 884d5491b1 Actually use proto_tree_add_item instead of proto_tree_add_bytes. Fixes bug 5588. 
svn path=/trunk/; revision=35562
 2011-01-16 22:52:17 +00:00