Use SET_ADDRESS in some dissectors that weren't using it (so that the hf field
is correctly initialized).
Introduce a COPY_ADDRESS_SHALLOW (which copies an address without copying the
contents of the data field).
svn path=/trunk/; revision=46602
(or at least the complaints from Valgrind; I couldn't reproduce the crash).
What part of:
~~~
* If you're thinking of using tvb_get_ptr, STOP WHAT YOU ARE DOING
* IMMEDIATELY. Go take a break. Consider that tvb_get_ptr hands you
* a raw, unprotected pointer that you can easily use to create a
* security vulnerability or otherwise crash Wireshark. Then consider
* that you can probably find a function elsewhere in this file that
* does exactly what you want in a much more safe and robust manner.
~~~
did someone not read?
Use tvb_get_ephemeral_stringz() instead of adding (apparently not sufficiently
checked!) offsets to the result of tvb_get_ptr() and assuming that the result
is a) in bounds and b) a NULL-terminated string.
svn path=/trunk/; revision=46577
Add SSL segment data and SSL reassmebled data fields and improve readability of the hex/ASCII data blocks written to the SSL debug log
svn path=/trunk/; revision=46572
not going to put anything into it. And don't try to finalize the composite
if we didn't create it or put anything in it.
svn path=/trunk/; revision=46569
[MS-FSCC].pdf section 2.4.15 gives us the correct format of the structure currently know and file_info_0f.
The unknown byte is actually the second byte of the EA Value Len.
svn path=/trunk/; revision=46562
instead of storing the requests in an se_tree (keyed by hop-by-hop-id),
store an se_tree which is itself keyed by frame number. When looking for
a matching request, first find the tree of pdus (by hop-by-hop-id) and then
look for the largest frame number less than or equal to the answer's frame
number. Also verify that the end-to-end-id matches.
Move the conversation structure out of packet-diameter.h: it's only used in
packet-diameter.c
svn path=/trunk/; revision=46553
Allow Raw Data dissector to dissect TCP packets with Riverbed Transparency options if sport dissector (found only in Riverbed) is not found.
#BACKPORT
svn path=/trunk/; revision=46544
packet-h248_3gpp.c: In function ‘dissect_3gcsd_plmnbc’:
packet-h248_3gpp.c:168: error: cast to pointer from integer of different size
make[5]: *** [libdissectors_la-packet-h248_3gpp.lo] Error 1
I guess the last parameter of dissect_3gcsd_plmnbc() is a pointer to a
boolean variable. Call it implicit_param, not implicit, as there's
already a global variable 'implicit'.
Feel free to correct the fix if I got it wrong.
svn path=/trunk/; revision=46534
- Fix instance of offset changed under 'if (tree)' and used after 'if (tree)';
- Create/use some extended value strings;
- #if 0 an unused value_string array;
- Localize some variables & remove some uneeded initializers;
- Fix some whitespace & long lines.
svn path=/trunk/; revision=46516
Cause、RAB Context、PDU Numbers in packet-gtpv2.c are not dissected correctly. fixed in the patch.
The patch did not apply cleanly to trunk, applied by hand.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8079
svn path=/trunk/; revision=46497
Adds new values and fixes an incorrect value in the previous value_string array.
Note: names used as specified (with capitalization) in the document.
(Previously all the names in the value_string array were lower case).
Also: rename the value_string array to have a less generic name.
svn path=/trunk/; revision=46490