Commit Graph

91 Commits

Author SHA1 Message Date
pascal acc2a3706b Fix RVALS() macro usage
svn path=/trunk/; revision=42720
2012-05-19 19:05:36 +00:00
Guy Harris 9f925a618f The trial period is arguably over - no need for packet-ansi_map.c to
have its own #if 0'ed out definition of dgt_set_t.

svn path=/trunk/; revision=42020
2012-04-11 00:35:53 +00:00
Guy Harris dd4cb8424b Get rid of redundant Dgt1_9_bcd digit set - passing NULL as the digit
set uses tvb_bcd_dig_to_ep_str()'s default digit set, which is the same.

Clean up white space (no 4-space tab characters).

svn path=/trunk/; revision=42019
2012-04-11 00:34:13 +00:00
Stig Bjørlykke b71ce5d268 Do not assign a value to itself.
svn path=/trunk/; revision=41482
2012-03-11 14:03:13 +00:00
Alexis La Goutte 95cc98f92c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41211
2012-02-27 16:50:27 +00:00
Chris Maynard e799efeed9 Fix some duplicate display filter names.
svn path=/trunk/; revision=40568
2012-01-18 21:07:53 +00:00
Anders Broman faea2d624c Get rid of Warnings.
svn path=/trunk/; revision=39951
2011-11-19 22:42:51 +00:00
Anders Broman 1b7b2dd067 Use tvb_bcd_dig_to_ep_str().
svn path=/trunk/; revision=39929
2011-11-18 07:01:10 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier a6e35df202 Do some more conversions of proto_tree_add_item() 'encoding' arg
(previously missed).

svn path=/trunk/; revision=39451
2011-10-18 00:39:20 +00:00
Bill Meier 31abdcb584 Convert asn1 template files proto_tree_add_item() 'encoding' arg for field types FT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. Always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).

svn path=/trunk/; revision=39428
2011-10-15 19:48:19 +00:00
Bill Meier 6142dd287b Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

 Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39332
2011-10-10 01:38:20 +00:00
Bill Meier e2996ceabe Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39294
2011-10-06 16:50:13 +00:00
Jeff Morriss 80c1ef3811 Fix a couple (value) mistakes in value_strings. Found by Martin's patch on the -dev list.
svn path=/trunk/; revision=37259
2011-05-18 20:06:17 +00:00
Anders Broman 01ef9f73ef Remove debug printouts.
svn path=/trunk/; revision=35834
2011-02-05 14:37:52 +00:00
Anders Broman b723ccb30c Introduce preferences to set the strictness of Invoke/response
tracking.

svn path=/trunk/; revision=35822
2011-02-04 16:12:59 +00:00
Anders Broman 735709bee6 Add tvb_bcd_dig_to_ep_str()
/*
 * Given a tvbuff, an offset into the tvbuff, and a length that starts
 * at that offset (which may be -1 for "all the way to the end of the
 * tvbuff"), fetch BCD encoded digits from a tvbuff starting from either 
 * the low or high half byte, formating the digits according to an input digit set, 
 * if NUll a default digit set of 0-9 returning "?" for overdecadic digits will be used.
 * A pointer to the EP allocated string will be returned.
 * Note a tvbuff content of 0xf is considered a 'filler' and will end the conversion.
 */

svn path=/trunk/; revision=35286
2010-12-28 12:36:26 +00:00
Bill Meier 491f05b16e Use value_string_ext fcns to access several value_string arrays;
Minor whitespace cleanup.

svn path=/trunk/; revision=34900
2010-11-16 15:20:33 +00:00
Bill Meier 9ade30a7b1 #include <string.h> and/or #include <stdio.h> not needed.
svn path=/trunk/; revision=32417
2010-04-07 16:54:29 +00:00
Bill Meier f8b92f8d0b #include <stdio.h> not needed.
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Guy Harris b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron:
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
Anders Broman 1661212158 Dissect NumberPortabilityRequest return result.
svn path=/trunk/; revision=31306
2009-12-18 06:26:20 +00:00
Anders Broman b1f6df534a From Michael Lum:
The attached patch calls the tap to allow the number
of each type of message to be counted.

The patch does not fix the "size"/number of octets
column that is all zeroes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4253

svn path=/trunk/; revision=31027
2009-11-19 21:44:28 +00:00
Anders Broman 0d6239a976 Mobile On Channel carries no data.
svn path=/trunk/; revision=30998
2009-11-17 20:48:04 +00:00
Jeff Morriss 7a91a5b053 Don't call check_col(). Add a space at the end of each COL_INFO entry to make the column more readable when SCTP bundles multiple messages together.
svn path=/trunk/; revision=29922
2009-09-15 15:16:15 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke f8166804a8 From Kovarththanan Rajaratnam:
More asn1/* header field info cleanup

svn path=/trunk/; revision=28826
2009-06-24 01:40:54 +00:00
Anders Broman 27026d0eb1 Add dissection of:
- SMSDeliveryPointToPointAck
- InterSystemSMSDeliveryPointToPoint
- QualificationRequest2

svn path=/trunk/; revision=27991
2009-04-08 06:28:34 +00:00
Bill Meier 0f9f5caf9d As suggested by Jakub Zawadzki: g_free() is NULL safe, so we don't need check against it.
Also (from me): Clean up spacing

svn path=/trunk/; revision=27727
2009-03-15 15:40:55 +00:00
Bill Meier 35e5fa9bc1 #include <epan/conversation.h> and/or #include <epan/emem.h> not req'd ...
svn path=/trunk/; revision=27390
2009-02-07 14:33:47 +00:00
Anders Broman 9636044d74 From Michael Lum:
ANSI MAP digits type decode and bitmask corrections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3233

svn path=/trunk/; revision=27379
2009-02-05 18:09:00 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Anders Broman 3d0e9d7e34 From Michael Lum:
- new service options
- one comment was incorrect
- Expanded a profile in one of the messages

svn path=/trunk/; revision=26905
2008-12-03 06:46:23 +00:00
Anders Broman 49ce0c4edf Bug fixes:
- Put QualificationDirectiveRes in the tree.
- Use correct tag value for messageWaitingNotificationType (145)
- analogRedirectRecord is OPTIONAL.

svn path=/trunk/; revision=26877
2008-11-29 21:21:16 +00:00
Bill Meier 868200ca6f Fix bug wherein proto_reg_handoff... wasn't being called during dissector init;
(definition of proto_reg_hand_off... wasn't left-justified and thus was not
  found when generating register.c)
Also: slight changes related to proto_reg_handoff and proto_register:
  Use find_dissector;
  gboolean for intiialized flag;
  localize saved range pref;
  

svn path=/trunk/; revision=26718
2008-11-06 22:05:59 +00:00
Anders Broman ac85993e58 Invalid code in range_delete_callback.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3041

svn path=/trunk/; revision=26715
2008-11-06 21:41:49 +00:00
Anders Broman 9b9c51873b From shmulikB:
1. ansi map fail to parser BCD digits when Numbering Plan: Telephony Numbering
(ITU-T Rec. E.164,E.163) (2)

2. fix dissector_try_port if sms-TeleserviceIdentifier RECIEVE BEFORE
sms-BearerData.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2989

svn path=/trunk/; revision=26521
2008-10-23 05:56:28 +00:00
Stig Bjørlykke 677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Anders Broman d38d7348e0 Wrong string used in g_hash_table_lookup().
Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2154

svn path=/trunk/; revision=24000
2008-01-03 13:00:56 +00:00
Guy Harris b2f28fb370 Get rid of non-ASCII character in a value_string table. (They might
upset MSVC++ if the wrong code page is selected, and there's no
guarantee that all forms of output of dissected packets are in any
particular character encoding.)

svn path=/trunk/; revision=23819
2007-12-09 21:10:25 +00:00
Jeff Morriss 980f624770 (Again, this time for ANSI MAP) From Florent Drouin: malloc the size of the structure, not the size of a pointer to the structure. Hopefully this will fix bug 1844.
svn path=/trunk/; revision=22892
2007-09-17 17:58:49 +00:00
Anders Broman 30e64dade4 Try to protect the hash table...
svn path=/trunk/; revision=22866
2007-09-13 20:20:11 +00:00
Anders Broman 120a0759b3 Warning fixes.
svn path=/trunk/; revision=22855
2007-09-12 18:12:18 +00:00
Anders Broman c4daf58278 Use the new ANSI TCAP dissector.
svn path=/trunk/; revision=22854
2007-09-12 16:45:53 +00:00
Stig Bjørlykke 2fc59fcc43 Fixed a warning: 'j' may be used uninitialized in this function.
svn path=/trunk/; revision=22815
2007-09-06 22:26:09 +00:00
Anders Broman 10f5c61bf3 Get rid of get_ber_last_reated_item() and fix dissection of wIN-TriggerList.
svn path=/trunk/; revision=22807
2007-09-06 16:27:17 +00:00
Anders Broman 108f4f347c Fix the asn1 code for WIN-TriggerList and systemMyTypeCode plus
a copy-paste error in the hf fields.

svn path=/trunk/; revision=22796
2007-09-05 22:24:40 +00:00