Commit Graph

32 Commits

Author SHA1 Message Date
Stig Bjørlykke 1f108b02a0 Allocate correct size of range.
Coverity 718.

svn path=/trunk/; revision=36262
2011-03-22 18:58:32 +00:00
Ronnie Sahlberg ea9e664fc9 Coverity 420
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.



svn path=/trunk/; revision=36238
2011-03-22 09:05:26 +00:00
Bill Meier 17281958a2 Add a comment about some "unreachable code" indicating possible incorrect code someplace.
Fix some spelling..

svn path=/trunk/; revision=35710
2011-01-30 22:42:06 +00:00
Bill Meier 1341fcd87e Fix some gcc -Wshadow warnings.
svn path=/trunk/; revision=31722
2010-01-28 21:49:30 +00:00
Stig Bjørlykke 221225e0f3 From Kovarththanan Rajaratnam via bug 3719:
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.

From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.

svn path=/trunk/; revision=29137
2009-07-18 20:10:14 +00:00
Bill Meier 9a3563e807 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Guy Harris 768b822f9b Use GINT_TO_POINTER() to cast integral values to gpointer in
g_hash_table_lookup() calls, in the hopes of suppressing warnings on
platforms with 32-bit ints and 64-bit pointers.

svn path=/trunk/; revision=26149
2008-09-06 17:27:20 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Stephen Fisher 6625e7503f Fix warnings on Linux/gcc 4.1.1
svn path=/trunk/; revision=21330
2007-04-03 21:17:13 +00:00
Sebastien Tandel c136927420 revert back (void*) -> (void**) which will stop free-warning compilation with
gcc-4.1.2


svn path=/trunk/; revision=21282
2007-03-30 12:04:40 +00:00
Sebastien Tandel 8405f21ea2 strict aliasing warnings fix : replace (void**) by (void*)
svn path=/trunk/; revision=21274
2007-03-29 22:58:02 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Luis Ontanon 088ffa504e - add Debug and Default declarations.
- supress unwanted console printouts.


svn path=/trunk/; revision=16769
2005-12-12 23:23:32 +00:00
Ulf Lamping 6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Luis Ontanon dbe55501fc at this point mate should be working as it did before the grammar
- pdu transports were upside down (ip/tcp vs tcp/ip)
 - the gop to gog index was not being populated
 - tell svn to ignore generated c files


svn path=/trunk/; revision=14416
2005-05-22 00:44:34 +00:00
Luis Ontanon bf1117c4c9 Transforms and Pdus are working already, Gops start to work.
svn path=/trunk/; revision=14376
2005-05-16 17:16:52 +00:00
Luis Ontanon 047baf2c38 MATE has a grammar.
Although not yet fully implemented I want this version as a reference. 


svn path=/trunk/; revision=14373
2005-05-16 13:28:35 +00:00
Luis Ontanon 2cd67ce468 Adds Payload AVP to PduDef AVPLs simmetric to the Transport AVP
allows to fetch fields also from ranges that are the payload of the Proto

svn path=/trunk/; revision=13427
2005-02-18 22:33:16 +00:00
Luis Ontanon f152359ac3 avoid freeing the gop_key more than once and do not reregister the tap at every reload
svn path=/trunk/; revision=13382
2005-02-11 00:04:25 +00:00
Anders Broman bc04baef42 From LEGO:
- fixes a leak in analize_pdu()
 - fixes a typo in analize_pdu()
 - fixes a crash in scs_unsubscribe() 
 - save a malloc and a free in get_pdu_fields()

svn path=/trunk/; revision=13335
2005-02-07 08:54:24 +00:00
Anders Broman c3440553eb From: LEGO
- fix a bug at gog reinit that disabled gogs after reload of a file.
- fix some crashes when Debug_GoG>0
- cleanup the debug output (no CR at the end is needed)
- Gops start when no GopStart is given and match an existing GogKey

svn path=/trunk/; revision=13318
2005-02-06 20:37:02 +00:00
Lars Roland 4bf362f863 A new patch for mate from Luis Ontanon:
- move mate_packet into packet-mate.c and remove it frome mate.h
  - supressed some warnings

svn path=/trunk/; revision=13190
2005-01-28 13:53:14 +00:00
Lars Roland f7a9907702 From Luis Ontanon for Mate:
- supress some solaris compiler warnings
- adds GopExpiration, GopIdleTimeout and GopLifetime parameters

svn path=/trunk/; revision=13154
2005-01-21 19:11:59 +00:00
Lars Roland 2b88200a3a One more patch for mate:
- renamed analyze_frame() into mate_analyze_frame().
- prepare mate to be statically linked
- use report_open_failure() , report_read_failure() and
report_failure() in case there's an error while loading the config
- some cleanup in mate_util.c
- some fixes and cleanup in examples and matelib

svn path=/trunk/; revision=13001
2005-01-10 02:37:19 +00:00
Lars Roland ccf44f7fb1 From Luis Ontanon:
Fix some MSVC warnings in MATE

svn path=/trunk/; revision=12969
2005-01-06 23:21:10 +00:00
Lars Roland b7642931ad From Luis Ontanon:
Another patch for mate:
 - adds a "GopTree={TRUE|FALSE}" attribute to Gogs
 - changes "ShowPduTree={NoTree|PduTree|FrameTree}"
 - adds "implicit stop" to Gops with no Stop declared

svn path=/trunk/; revision=12968
2005-01-06 12:39:54 +00:00
Lars Roland 2ce1e037f6 From Luis Ontanon for Mate:
- moved gop and gog indexes into gopcfgs, which is a propedeutic
change for upcoming changes in the way gops are to be grouped
-  changed the way gog-keys are kept in memory
- every gopkey attribute is copied into the gop->extras to avoid
redundancy in the configuration
- added timers to gogs mate.gog_type.StartTime and mate.gog_type.Time
- fixed a bug in scs_subscribe that mangled some strings
- minor interface improvement to scs propedeutic to having types avp
values in a future
- changed medium and large into mate_medium and mate_large in the
scs_collection
- fixed Mode=Replace in Transforms, now it works
- fixed a crash at reinit due to impropper initialization of mate_items

svn path=/trunk/; revision=12902
2004-12-31 14:27:38 +00:00
Lars Roland 5474c91d65 Fixes for Mate from Luis Ontanon:
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- scs_subscribe doesn't use g_malloc anymore. it uses GMemChunks
(I had to rename two GMemChunks to make MSVC happy)
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- fixed few things at reinit:
     - reset last_id 
     - remove the nodes in the items hash tables 

svn path=/trunk/; revision=12820
2004-12-23 08:27:30 +00:00
Lars Roland af8041a316 Patch for Mate Plugin.
From Luis Ontanon:
- moves mate configuration from proto_register to proto_register_handoff
- add the config file protocol preference
- every item (gop,gog,pdu) has it's own ett
- the tap doesn't do nothing, it just primes the tree
- analyze_frame()  what once was the tap now is called by the dissector
- should work with tethereal now (to be tested)

svn path=/trunk/; revision=12763
2004-12-16 19:36:23 +00:00
Lars Roland 04a6f55e4c Update for Mate from Luis Ontanon:
- make rd static (no purpose for it to be global)
- remove outdated comments
- add "PduCriteria" feature (as already stated in the wiki)
- add "DiscardUnassignedPdu" feature (as already stated in the wiki)
- removed ".Id" from abbrev for "mate.item_name"

- in radius.mate:  Don't use the port to determine the Gop key.

svn path=/trunk/; revision=12735
2004-12-12 23:40:44 +00:00
Lars Roland 62506c09d6 Fixes for Mate Plugin:
As suggested by Martin Regner:
- Use strtod() instead of strtof()

From Luis Ontanon:
- changes the id of mate items to be integer (the old string ID
imposed a lenght limit and as mate fileds had become dynamic it makes
no more sense anymore)

- fixes a huge avp leak on reinit (every avp object was leaked when a
new file was loaded)

- adds the "Lib" AVP to the Action=Include AVPL to include definitions
>from matelib

- rename mate.[dll/so] to zzmate.[dll/so] so it gets initialized as
the very last protocol (so that fields from every dissector can be
used).

svn path=/trunk/; revision=12728
2004-12-12 16:58:59 +00:00
Lars Roland 86d7ed9bae New Plugin from Luis Ontanon:
MATE -- Meta Analysis and Tracing Engine

Won't be compiled by default.

It is still not possible to link the plugin on Win32.

svn path=/trunk/; revision=12716
2004-12-11 01:00:17 +00:00