Commit Graph

3190 Commits

Author SHA1 Message Date
Stig Bjørlykke 6a31f43f8b Always return a valid profile name from get_profile_name().
svn path=/trunk/; revision=24175
2008-01-24 17:06:22 +00:00
Bill Meier dc0b8a0727 One of fixes in SVN #24173 incomplete; Undo it for now
svn path=/trunk/; revision=24174
2008-01-24 05:39:48 +00:00
Bill Meier b01c07bcdd Fix two very minor memory leaks
svn path=/trunk/; revision=24173
2008-01-24 04:20:07 +00:00
Gerald Combs 690f8f51f8 Arrange things so that if '-o "capture.auto_scroll: FALSE"' is passed to
Wireshark on the command line, auto-scroll is actually disabled.

svn path=/trunk/; revision=24172
2008-01-24 01:23:19 +00:00
Bill Meier a054ed6040 Fix a minor memory leak; Remove some unused variables
svn path=/trunk/; revision=24168
2008-01-23 14:07:40 +00:00
Bill Meier 6bb8b5f9b9 Fix minor memory leak
svn path=/trunk/; revision=24167
2008-01-23 14:05:22 +00:00
Jaap Keuter 56222aed0e Fix for bug 1920:
Avoid double free, causing crash, and stop memory leak via normal code path.

svn path=/trunk/; revision=24152
2008-01-21 07:35:16 +00:00
Stig Bjørlykke edf727387f Fixed crash when save IO Graphs (bug 2126).
The problem was that configure_event() is called each time the window size
changes, and each time the pixmap buffer is recreated and a new signal added
to the save button.

svn path=/trunk/; revision=24145
2008-01-20 16:53:53 +00:00
Stig Bjørlykke 27db1b2798 Added "copy as CSV" button to IO Graphs.
svn path=/trunk/; revision=24143
2008-01-20 12:24:14 +00:00
Jaap Keuter d3e52cc1fe Cleanup the whitespace.
svn path=/trunk/; revision=24137
2008-01-19 07:46:52 +00:00
Stig Bjørlykke 1621224a86 Free allocated data in prefs_reset, removed need for uat_reload_all and
made some cleanups in profile_dlg.

svn path=/trunk/; revision=24136
2008-01-19 01:18:35 +00:00
Stig Bjørlykke cd259ecb55 I can't find any reason to unselect the current package only when an entry
in the packet details view is selected.  I suppose unselecting the field is
more correct.  The previous behaviour lead to some strange errors:

 Select a packet and an entry in the packet details.  Add a new column
 and change a protocol preference.  Observe the selected package is
 unselected and packet 1 is selected, which I think is wrong.

 Do the same as above with one of the following exceptions:
  - without selecting an entry in the packet details.
  - without adding a new column.
  - without changing a protocol preference.
 Observe the selected package is still selected, which is correct.

The correct behaviour here happens because of the cf_goto_frame call in
redraw_hex_dump_all, which causes the field to be unselected before
packet_list_set_sel_browse is called, and then the cf_unselect_package
is never called.  

Maybe someone with a deeper knowledge should have a look at this...

svn path=/trunk/; revision=24135
2008-01-18 22:51:37 +00:00
Jaap Keuter 44ea74a5da Move libsmi settings from virtual mibs protocol page to name resolution page.
svn path=/trunk/; revision=24131
2008-01-18 07:18:32 +00:00
Jaap Keuter 32e4818641 Whitespace cleanup of AIRPCAP code.
svn path=/trunk/; revision=24127
2008-01-17 22:28:31 +00:00
Jaap Keuter 2e0f8088c3 From Jim Young:
This patch provides a new RTP Player preferences dialog.  It allows one to
select the maximum number of visable channels in the RTP Player window.  The
default is four (4) channels which is the maximum number of usable channels 
that the RTP Player can display and still have access to the bottom row buttons 
on a 1024*768 resolution display.  Specifying a value less than 1 or greater than 
10 will be result in the RTP Player displaying the default 4 channels.

svn path=/trunk/; revision=24112
2008-01-16 07:36:34 +00:00
Stig Bjørlykke ac7dfec61d Changed to use GTK stock icon for preferences in the toolbar.
svn path=/trunk/; revision=24094
2008-01-15 00:24:59 +00:00
Stig Bjørlykke c6ab78409f Save the changes also when selecting a profile from the list.
svn path=/trunk/; revision=24092
2008-01-14 21:58:45 +00:00
Stig Bjørlykke ba3f5057b1 Several profile enhancements:
- Give initial focus to the profiles list
- Enter in the profiles list selects the profile
- Give focus to the profile name when creating a new profile

svn path=/trunk/; revision=24091
2008-01-14 21:43:10 +00:00
Stig Bjørlykke a6c7284e3b Added cast of argument to isspace.
svn path=/trunk/; revision=24090
2008-01-14 19:19:47 +00:00
Stig Bjørlykke a2d1e9005d This patch adds support for configuration profiles, which can be used to
configure and use more than one set of preferences and configuration files.

This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A.  It's also possible to start wireshark
and tshark with a named profile by using the "-C ProfileName" option.
A new status pane in the main window will show the current profile.

The configuration files currently stored in the Profiles are:
- Preferences
- Capture Filters
- Display Filters
- Coloring Rules
- Disabled Protocols
- User Accessible Tables

The recent data are by design not added to the profile.

Planned future enhancements:
- make a more convenient function to switch between profiles
- add a "clone profile" button to copy an existing profile
- make the profiles list active and accept return as OK
- save users "Decode as" in the profile
- make new, clone and deletion of profiles more secure
- make some of the recent values available in the profile

This patch also fixes:
- setting default status pane sizes
- a bug setting status pane for packets when not having main lower pane.

svn path=/trunk/; revision=24089
2008-01-14 16:40:23 +00:00
Stig Bjørlykke 8b4e80384a Fixed a few "statement not reached" warnings and a "assignment type mismatch" warning.
svn path=/trunk/; revision=24085
2008-01-14 09:39:55 +00:00
Stephen Fisher 9463667692 Fix for bug #2017: VoIP trace crashes Wireshark when specific RTP Player
buttons are clicked


svn path=/trunk/; revision=24073
2008-01-13 04:24:24 +00:00
Bill Meier addba66749 Use glib equivalent of ntohs
svn path=/trunk/; revision=24056
2008-01-10 14:42:55 +00:00
Stephen Fisher 430866e511 To ease troubleshooting of bug #2017 and for code clarity in the future, use
two different variables for types voip_rtp_stream_info_t (strinfo) and
voip_calls_info_t (callsinfo) instead of using strinfo for both.


svn path=/trunk/; revision=24038
2008-01-09 08:34:58 +00:00
Stig Bjørlykke eef80786a8 Fixed some small typos.
svn path=/trunk/; revision=24035
2008-01-08 23:14:13 +00:00
Stig Bjørlykke 6d4a2e7ebf Changed email address for Gerald from zing.org to wireshark.org
in a lot of files, which I suppose is correct.

svn path=/trunk/; revision=24034
2008-01-08 22:54:51 +00:00
Jaap Keuter 670e46f78b Make RTP player G.729 Annex B compatible.
svn path=/trunk/; revision=24032
2008-01-08 13:04:50 +00:00
Stig Bjørlykke 56bf2afc04 Never print x axis values outside the graph (we now have "view as time of day").
Fixed calculating first_interval (the scrollbar issue in bug 1763).

svn path=/trunk/; revision=23989
2008-01-03 01:17:47 +00:00
Stig Bjørlykke ddac83a322 Initialize io->view_as_time.
svn path=/trunk/; revision=23988
2008-01-02 20:09:20 +00:00
Stig Bjørlykke cb1448416f Fix a cut'n'paste error for GTK_VERSION < 2 in last commit.
Fixed some indentation.

svn path=/trunk/; revision=23975
2007-12-29 23:20:14 +00:00
Stig Bjørlykke 1776029a7c Add an option to view the X axis as time of day instead of seconds since
start of capture.

svn path=/trunk/; revision=23974
2007-12-29 20:57:15 +00:00
Stig Bjørlykke 69be72052c Add a warning in the IO Graph if too many elements.
svn path=/trunk/; revision=23973
2007-12-29 20:53:10 +00:00
Tomas Kukosa 487792b348 save RTP in 16-bit linear PCM instead of 8-bit G.711 u-Law
(preparation for more codecs support via codec plugins)

svn path=/trunk/; revision=23961
2007-12-28 13:01:55 +00:00
Jaap Keuter 789d4770d5 Fix menu sensitivity even for text only nodes.
svn path=/trunk/; revision=23936
2007-12-21 22:22:19 +00:00
Guy Harris 0cadc40746 Temporarily #if 0 out code that was causing crashes.
svn path=/trunk/; revision=23893
2007-12-16 22:33:03 +00:00
Sake Blok 9a2d18d386 Changes the name of the menu item "View/Reset Coloring" to
"View/Reset Coloring 1-10" and adds sensitivity to it so that
it will be greyed out when none of the temporary color filters
are used.

(as per discussion on wireshark-dev some time ago)


svn path=/trunk/; revision=23879
2007-12-15 23:38:29 +00:00
Jaap Keuter a629334be6 With increasing number of dissectors, heuristics cause sometimes false hits on packets. It's a pain to go through the menu / enabled protocols dialog to temporarily disable such dissector. This change adds an option to the packet detail menu to do a point-and-click style temporary disable of such protocol.
svn path=/trunk/; revision=23873
2007-12-15 13:26:09 +00:00
Jaap Keuter 14141c3275 Source code cleanup.
svn path=/trunk/; revision=23860
2007-12-14 07:06:22 +00:00
Stig Bjørlykke 74c6f15a03 Do not use calc_field unless in advanced y axis (bug 1763).
Register new tap listener (new filter) when going from advanced y axis.
Add parantheses to the filters to ensure they are correct when concatenated.

svn path=/trunk/; revision=23844
2007-12-12 09:31:02 +00:00
Ronnie Sahlberg 757e72e177 If not building for gtk 2.4.0, if out a function that is only used when
building for 2.4.0


svn path=/trunk/; revision=23830
2007-12-10 20:40:31 +00:00
Bill Meier 2b73cb3e19 Fix conversions so compiles for both 32-bit and 64-bit
svn path=/trunk/; revision=23826
2007-12-10 18:09:52 +00:00
Bill Meier df4f2f604e Fix Bug #2055: "File Save not working properly";
Change SVN #23487 patch to not use signal_connect each time the
the function of the save button is changed since that
results in multiple callbacks attached to the save button.
Intead: associate data with the save button which species its
current function.
(It sure would be nice if the original problem causing the 
 blank spot on the toolbar could be resolved; the work-around 
is starting to get messy).

svn path=/trunk/; revision=23821
2007-12-10 03:27:40 +00:00
Guy Harris d4672d13f5 Add macros for various filter actions and types, and to combine them
into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23816
2007-12-09 09:04:58 +00:00
Guy Harris 7c03d14d60 Add macros for various filter actions, types, and directions, and to
combine them into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23815
2007-12-09 09:04:39 +00:00
Guy Harris 88adb489c3 Add extra parenthesization, tweak name of argument to some macros to
more accurately reflect what it is.

svn path=/trunk/; revision=23814
2007-12-09 09:02:14 +00:00
Ronnie Sahlberg b57ce9e48f some updates to make it compile with gtk/glib < 2
svn path=/trunk/; revision=23810
2007-12-08 22:45:30 +00:00
Bill Meier 01ec87aee5 Revert SVN #23728 since change (to fix a Windows issue) is in code not used on Windows
and thus does not actually fix anything.
See Bug #2055 for further info.

svn path=/trunk/; revision=23809
2007-12-08 20:59:15 +00:00
Stig Bjørlykke 4783f12c08 Added "Apply as filter"/"Prepare a filter"/"Find frame"/"Colorize Protocol"
menu.  Simplified getting the Display filter.

svn path=/trunk/; revision=23786
2007-12-06 18:10:35 +00:00
Gerald Combs e66660cd84 Make sure the "auto scroll in live capture" toolbar button and menu item
correctly reflect the auto scroll state. Re-enable the ability to use
the auto scroll toolbar button and menu item during a live capture.

svn path=/trunk/; revision=23777
2007-12-05 23:50:28 +00:00
Stig Bjørlykke 11c616f11e Do not redraw graph and goto frame 1 if selecting an "item" outside the list
in Graph Analysis list.

svn path=/trunk/; revision=23770
2007-12-05 13:32:09 +00:00