Commit Graph

8285 Commits

Author SHA1 Message Date
Ronnie Sahlberg 4f893552d0 fix our-of-bounds bug in teh port to string conversion routine
svn path=/trunk/; revision=8378
2003-09-04 23:12:46 +00:00
Ronnie Sahlberg b4f94f13b6 Update to endpoint talkers. move lots of duplicated code into teh helper endpoint_talkers_table.c
svn path=/trunk/; revision=8377
2003-09-04 23:11:03 +00:00
Guy Harris 7826e4db4a From Olivier Biot: decode the Push-Flag WSP header.
svn path=/trunk/; revision=8376
2003-09-04 19:12:38 +00:00
Guy Harris d4c4975571 From Anders Broman: add translation of SI values to strings.
svn path=/trunk/; revision=8375
2003-09-04 19:06:19 +00:00
Guy Harris 5e2b3906d3 From Olivier Biot:
cleanup the reassembly code;

	add a new preference to enable/disable subdissection on the 1st
	fragment of an unreassembled message;

	update the comments to note that the reassembly code is even
	able to reassemble short message fragments across distinct SMPP
	connections.

svn path=/trunk/; revision=8374
2003-09-04 18:59:21 +00:00
Guy Harris 49009cdc8e From Anders Broman: display T35 manufacturer codes as strings.
svn path=/trunk/; revision=8373
2003-09-04 18:55:54 +00:00
Michael Tüxen ab48db4a47 Update for version 09 of the ID.
svn path=/trunk/; revision=8372
2003-09-04 14:32:34 +00:00
Michael Tüxen fad6cc2fd0 Indicate the version in the protocol column only if multiple versions are supported.
svn path=/trunk/; revision=8371
2003-09-04 14:32:01 +00:00
Michael Tüxen 16d75dc6fe Indicate the Standard (ITU, ANSI, Chin. ITU) in the protocol column.
svn path=/trunk/; revision=8370
2003-09-04 14:30:18 +00:00
Michael Tüxen 11274846f9 - Fixed a bug regaring DRST messages.
- Updates for version 15 of the ID.

svn path=/trunk/; revision=8369
2003-09-04 13:33:22 +00:00
Ronnie Sahlberg 188a4e8d81 Uglify endpoint_talkers_table.c
make it know how to build the filter strings, address and port hf_ fields properly so TCP and UDP works and is agnostic on whether ipv4 or ipv6 is used as transport

svn path=/trunk/; revision=8368
2003-09-04 11:07:51 +00:00
Guy Harris 4f01e65223 Put in a note telling people how to add a new libpcap encapsulation
type, and telling them how it should *NOT* be done, i.e. you should ask
tcpdump-workers for a new DLT_ value, you should not just pick a value
on your own, and you should especially not reuse a value that's already
in use!

Put in comments about reserved values in the current CVS libpcap.

svn path=/trunk/; revision=8367
2003-09-04 06:40:45 +00:00
Guy Harris 3af28de032 Back out the previous change - sometimes the newlines should be mapped
to "\n", and other control characters should be, as the strings are
text, not binary.  We really need our own routines to do the formatting
of SNMP variable values ourselves....

svn path=/trunk/; revision=8366
2003-09-04 05:16:18 +00:00
Guy Harris 6d5d22162e If you get a read error while doing a search, go back to the frame where
we started.

svn path=/trunk/; revision=8365
2003-09-03 23:40:06 +00:00
Guy Harris d7c622e309 Check for "wtap_seek_read()" failing.
svn path=/trunk/; revision=8364
2003-09-03 23:32:40 +00:00
Guy Harris 4a4d2dcf7e Check for "wtap_seek_read()" failing.
svn path=/trunk/; revision=8363
2003-09-03 23:15:40 +00:00
Guy Harris ea4ff6a749 From Josef Korelus <jkor [AT] quick.cz>: GPRS Network
Service-over-Frame-Relay support, including preference for Frame Relay
to select FRF 3.2/Cisco HDLC encapsulation or encapsulation of GPRS NS
PDUs.

svn path=/trunk/; revision=8362
2003-09-03 22:26:38 +00:00
Guy Harris afd3103ba2 Don't include <epan/conversation.h> if you don't need it.
svn path=/trunk/; revision=8361
2003-09-03 20:58:09 +00:00
Guy Harris e78ac968d7 Get rid of stuff not used in Q.933.
svn path=/trunk/; revision=8360
2003-09-03 18:27:55 +00:00
Ronnie Sahlberg b9ce30cd35 And for Cal,
Ethereal presents   a column to display culmulative bytes into the capture.

A new column type is added : Culmulative Bytes.
While PacketLength column type specifies the number of bytes in the current packet,
Culmulative Bytes specifies the culmulative number of bytes from the start of the capture.

svn path=/trunk/; revision=8359
2003-09-03 10:49:03 +00:00
Ronnie Sahlberg bb21d8c03c fix to various stats tables.
The code used to rely on min_time==0 to determine whether this was the first
packet or not and whereby we had to initialize min_time to the current value.

This obviously does not work for capture files with poor timestamp resolution
where the response time is actually, according to the capture file, 0
and we got all sorts of weird effects like average response time being less than the minimum response time.

note, the bug only affected the minimum response time in the tables and not max or average response time.
it would "miss" tose minimum response times that were ==0 and display the minumin response time in the capture that were >0

svn path=/trunk/; revision=8358
2003-09-03 10:10:18 +00:00
Ronnie Sahlberg e2ec56553e UDP tap fix.
Must queue the data to the udp tap before calling any subdissectors
or else, if the packet is short and there is an exception, we wont call the tap at all.

svn path=/trunk/; revision=8357
2003-09-03 09:52:07 +00:00
Ronnie Sahlberg 33662264ed Update to LSA LookupPrivilegeDisplayName
svn path=/trunk/; revision=8356
2003-09-03 09:48:50 +00:00
Richard Sharpe fd9f317fa0 Fix the documentation that I forgot to fix when I fixed --with-ucd-snmp.
Thanks to Tom Uijldert <Tom.Uijldert@logicacmg.com>.

svn path=/trunk/; revision=8355
2003-09-03 07:11:31 +00:00
Guy Harris 28c86073ec Use "rpc_item", rather than "rpc_tree", as the argument to
"proto_item_append_text()" (they have the same value, and the same
underlying type, but it's cleaner).

Even if there already is a conversation when we're dissecting a call,
make the conversation dissector for the conversation the RPC dissector -
the conversation might've been created by the TCP dissector, or by us in
order to do fragment reassembly.

svn path=/trunk/; revision=8354
2003-09-03 07:11:13 +00:00
Guy Harris 50a0e0a834 From Anders Broman: use a value_string table rather than a switch to
translate MEGACO error codes to descriptions, and show the media
descriptor differently.

"tvb_new_subset(tvb,0,tvb_length(tvb),-1)" returns a tvbuff equivalent
to "tvb"; don't bother calling "tvb_new_subset()".

svn path=/trunk/; revision=8353
2003-09-03 06:48:45 +00:00
Guy Harris 4815aadacf As with the Cisco OUI, so with the Nortel OUI.
svn path=/trunk/; revision=8352
2003-09-03 06:38:15 +00:00
Guy Harris 1721593973 Fix up the API for adding support for new OUI's to the LLC dissector.
Use that API to create the table for the Cisco OUI 00:00:0C.

svn path=/trunk/; revision=8351
2003-09-03 06:27:03 +00:00
Guy Harris e076cb925f Q.933 dissector. (Not complete.)
svn path=/trunk/; revision=8350
2003-09-03 05:39:21 +00:00
Guy Harris 48e75dda62 Fix the bit mask for the parity level 1 information.
svn path=/trunk/; revision=8349
2003-09-03 05:28:16 +00:00
Guy Harris b58b71ec66 The first of those Trillium URLs referred to a collection of
specifications for their Frame Relay software products, not protocol
specifications.

svn path=/trunk/; revision=8348
2003-09-02 23:42:01 +00:00
Guy Harris 61deaa76a1 Fix up references to stuff on the Trillium Web site.
The control field is extended in Frame Relay (i.e., I and S frames have
two-byte control fields).

svn path=/trunk/; revision=8347
2003-09-02 23:37:48 +00:00
Guy Harris fdfd8b58af The code in an HTTP reply is a response code, not a response method.
svn path=/trunk/; revision=8346
2003-09-02 23:09:11 +00:00
Guy Harris 75ae0e30c7 From Jean-Michel Fayard: BOOTP/DHCP, HTTP, and WSP statistics taps.
svn path=/trunk/; revision=8345
2003-09-02 22:47:59 +00:00
Guy Harris 71034c5a3f From Jean-Michel Fayard: show in Tools:Summary window statistics about
packets that passed the current display filter, as well as about the
entire capture.

Document the Tools:Summary item in the man page.

Update Gerald's e-mail address.

svn path=/trunk/; revision=8344
2003-09-02 22:10:32 +00:00
Guy Harris a3a1ee8850 From Andreas Sikkema: Facility for H.245 to display short message types
instead of long ones (introduces new preference, default is off):
  OpenLogicalChannel OpenLogicalChannel OpenLogicalChannel OpenLogicalChannel
  OLC OLC OLC OLC

svn path=/trunk/; revision=8343
2003-09-02 21:40:34 +00:00
Guy Harris 8946ac347e From Andreas Sikkema: improved Info column output for multiple H.225
messages and faststart ( I think, lost track, kind of).

svn path=/trunk/; revision=8342
2003-09-02 21:37:44 +00:00
Guy Harris ecb9143eac "tvb_new_subset(tvb, 0, tvb_length(tvb), -1)" is equivalent to
"tvb_new_subset(tvb, 0, -1, -1)", which is equivalent to just "tvb" -
it's creating a "subset" that includes the entire tvbuff.  Don't bother
with the "tvb_new_subset()" call.

svn path=/trunk/; revision=8341
2003-09-02 21:26:22 +00:00
Guy Harris 4db8a31785 From Anders Broman: add a preference option to enable the display of the
whole SIP message as text lines, as well as showing the dissected
message.

svn path=/trunk/; revision=8340
2003-09-02 21:23:43 +00:00
Guy Harris 42c646eeb4 From Joakim Wiberg: change additional status display to word array
instead of byte array.

svn path=/trunk/; revision=8339
2003-09-02 21:17:31 +00:00
Guy Harris 5f0c445718 From Anders Broman: add a few more user IDs to the M3UA Service Indicator.
svn path=/trunk/; revision=8338
2003-09-02 21:14:43 +00:00
Guy Harris cad432d183 From Dinesh Dutt:
use the value_string tables for SOF and EOF values, rather than
	the string tables, and get rid of the string tables;

	add another desegmentation check;

	other cleanups.

svn path=/trunk/; revision=8337
2003-09-02 21:10:54 +00:00
Guy Harris 79697e6fe4 As noted earlier, Q.922 doesn't really specify the NLPID-based
encapsulation, so don't tag the packet as having "Q.922 Encapsulation"
if it has NLPID-based encapsulation.  Don't tag it with "Cisco
Encapsulation", either - both of those can be inferred from the dissection.

svn path=/trunk/; revision=8336
2003-09-02 21:06:16 +00:00
Guy Harris 454806eeff Use "dissect_xdlc_control()" to dissect the control field of Frame Relay
packets that have one.  Add an argument to "dissect_xdlc_control()" to
indicate whether it should append the information to the Info field or
just put it in the Info field.

Use the #defines for the DLCI bitfields to extract the DLCI bits when
constructing the DLCI.

svn path=/trunk/; revision=8335
2003-09-02 19:18:52 +00:00
Guy Harris 7cb23da0fb Don't show the DTE/DCE direction indicators if they're not supplied.
svn path=/trunk/; revision=8334
2003-09-02 18:45:06 +00:00
Guy Harris 8aee4ddf4a Q.933 doesn't define the use of an NLPID in the payload of a Frame Relay
packet (Q.922 doesn't really do so, either, but...).

Do a full dissection of the octets of the address field, don't just
assume a 2-octet address field.

Clear the Info column.

svn path=/trunk/; revision=8333
2003-09-02 18:33:11 +00:00
Gerald Combs 9d603ccc2c Make sure the color selection dialog displays a color selection widget.
Tweak the button layout slightly.

svn path=/trunk/; revision=8332
2003-09-02 18:27:50 +00:00
Michael Tüxen 20188db349 Fixed a typo.
svn path=/trunk/; revision=8331
2003-09-02 11:05:55 +00:00
Michael Tüxen 7730201e97 Fixed a bug regarding the summary of in/outbound streams in INIT/INIT-ACK chunks.
svn path=/trunk/; revision=8330
2003-09-02 11:03:59 +00:00
Ronnie Sahlberg b0bec4d79a When putting the filename in the titlebar
just put the filename there and not the full path to the file.

svn path=/trunk/; revision=8329
2003-09-02 08:27:43 +00:00