Commit Graph

15 Commits

Author SHA1 Message Date
Alexis La Goutte 13513a187b HTTP2 : Max value for type is now 0x0B (BLOCKED type), update the heuristic
Change-Id: I8de7b63ca90803f8fc6333bbe43aeb94459e6363
Reviewed-on: https://code.wireshark.org/review/1918
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-02 16:23:02 +00:00
Pascal Quantin a92d6bdbf4 HTTP2: try to please OSX 10.6 x64 buildbot
Change-Id: I79e7a619b5dadb68b70f8b057494cc970a655cc7
Reviewed-on: https://code.wireshark.org/review/1903
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-31 19:00:07 +00:00
Alexis La Goutte af10e83167 HTTP2: Showing decompressed headers
Decode the HTTP/2 header block using nghttp2 HPACK decoder

In this patch, We use nghttp2 HPACK decoder to decompress HTTP/2 header
block.  To make HPACK decompressor work, we need to track down HTTP/2
connection from the beginning.  If we see the HTTP/2 magic (connection
preface), we initialize HPACK decompressor objects.  We actually use 2
HPACK decompressor for both client and server.  HPACK decompressor
objects are stored in hash tables using TCP stream index as a key.

Most code by: Tatsuhiro Tsujikawa

Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Signed-off-by: Pascal Quantin <pascal.quantin@gmail.com>

Change-Id: Idb4dd4b0a200924820cb0b34db664cc37518168d
Reviewed-on: https://code.wireshark.org/review/1527
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-05-31 18:32:58 +00:00
Alexis La Goutte 218b8c9ad9 HTTP2 enhance display when priority flag is set
* Add bitmask and fix length for exclusive flag
* Add missing bitmask for stream dependency
* Add fielder with calcultated weight value (weight+1, see spec for more information)

Change-Id: I7a6e97be068a80caa7355f593d9497c431c681ed
Reviewed-on: https://code.wireshark.org/review/1625
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-13 16:38:38 +00:00
Alexis La Goutte f9647404e3 Enhance HTTP2 dissector
* Add missing padding for CONTINUATION frame
* Add filter for generated padding length
* add unused flags

Change-Id: I98ff759595d3018f11b6d3ec9ea298e92e032d73
Reviewed-on: https://code.wireshark.org/review/1604
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-05-13 09:10:33 +00:00
Evan Huus 1a7e5c9e28 tvb_reported_length_remaining() returns gint
not size_t, which was giving 64/32 conversion errors on some platforms

Change-Id: Idf81dc98f8921a92840731d742d6e46a40e1387f
Reviewed-on: https://code.wireshark.org/review/1405
Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-28 03:17:41 +00:00
Daniel Stenberg c35870b0af packet-http2: updated to http2 draft-12
From Alexis La Goutte
Fix warning found by pre-commit

Partial-Bug: 10054
Change-Id: I976884a240a55bb2287a802d72668a2c845179c0
Reviewed-on: https://code.wireshark.org/review/1295
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-04-27 20:23:27 +00:00
Alexis La Goutte 296591399f Remove all $Id$ from top of file
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Martin Kaiser 0566944f17 correct http2 detection
check the input tvb's length before doing tvb_get_guint8(tvb,2)
reject a short packet, don't throw an exception

svn path=/trunk/; revision=54376
2013-12-23 09:42:10 +00:00
Jakub Zawadzki c45475ab45 Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54135
2013-12-15 23:44:12 +00:00
Alexis La Goutte 93594d61b2 Upgrade to HTTP2 draft-09
Add HTTP2 to Decode as

svn path=/trunk/; revision=54131
2013-12-15 19:07:40 +00:00
Alexis La Goutte 9252681be6 Add also heuristic for HTTP
svn path=/trunk/; revision=53781
2013-12-04 13:55:53 +00:00
Alexis La Goutte 110795132b Add HTTP2 heuristic when it is encapsulated in SSL
the heuristic may be leak (only check if type > 10...)

svn path=/trunk/; revision=53638
2013-11-29 08:02:09 +00:00
Michael Mann 8081cf1d90 Add data parameter to tcp_dissect_pdus() as well as convert it to using "new" style dissectors.
Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that?

Should tcp_dissect_pdus return length (bytes consumed)?  There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb).  Seems like that could all be rolled into one.

svn path=/trunk/; revision=53198
2013-11-09 17:46:28 +00:00
Alexis La Goutte c42a4f7706 From me and Stephen Ludin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9042 Add HTTP2 Dissector Based on draft-ietf-httpbis-http2-06
TODO :
* Support HTTP Header Compression (draft-ietf-httpbis-header-compression)
* Enhance display of Data
* Reassembling of continuation frame (and other frame)
* Add same tap and ping/pong time response

svn path=/trunk/; revision=51591
2013-08-30 11:14:09 +00:00