Commit graph

8256 commits

Author SHA1 Message Date
Guy Harris
0d12a3aec7 Fix up --with messages that include square brackets.
Put --with-plugins on the left margin, as the rest of the messages are.

Fix up the description of --with-net-snmp.

svn path=/trunk/; revision=8199
2003-08-21 07:06:48 +00:00
Guy Harris
d4c0daceee The MaxCountHigh field in a READ_ANDX is given as a ULONG, i.e. 32 bits,
in the SNIA CIFS spec, although it's probably a 16-bit MaxCountHigh and
a 16-bit reserved field (it's a 32-bit timeout field in an earlier SMB
spec).

Call the MaxCount and MaxCountHigh fields in a READ_ANDX "Max Count Low"
and "Max Count High", rather than "Data Length Low" and "Data Length
High".

svn path=/trunk/; revision=8198
2003-08-21 05:42:47 +00:00
Guy Harris
ea62b178d2 Don't do a check inside an AC_MSG_CHECKING/AC_MSG_RESULT pair - the
output looks bad if you do.  Split the check for "should I check for an
SNMP library?" into "should I check for NET-SNMP?" and "should I check
for UCD SNMP?" (which makes sense because they're controlled by
different configure script options).

svn path=/trunk/; revision=8197
2003-08-20 22:05:08 +00:00
Ronnie Sahlberg
09179e8820 The length and offset for large file support for LockingAndX was broken.
We treated this as just a normal 64bit integer in LittleEndian format.
However, this is actually 2   32 bit integers, each in LittleEndian format
but the two 32 bit fields are stored in BigEndian format relative to each other.

Since we dont do 64 bit aritmetic I had to convert the field to FT_STRING as well
so sorry, no creative len>xxx    filters anymore.   but at least we present
the data in the correct way in the tree pane.

We didnt see this one earlier since most locking_andx requests are probably for offset : 0   and length: -

Funnily enough it seems that certain popular commercial products have the same bug as ethereal had up until 5 minutes ago.

svn path=/trunk/; revision=8196
2003-08-20 10:32:23 +00:00
Richard Sharpe
68d7f5d47f packet-dcerpc-lsa had some idea that EnumDomainsEx had a funny NDR rep for
the array of domain info stuff returned. Removing the offending bit
fixed the dissection, at least of a capture we have.

svn path=/trunk/; revision=8195
2003-08-20 00:09:36 +00:00
Guy Harris
23f105da58 Construct the About box ourselves, so it has the title "About Ethereal"
and doesn't have a message-box-type icon.

This might want to be tweaked further, to more closely resemble various
desktop environments' About boxes (although what's appropriate might
depend on the environment).

svn path=/trunk/; revision=8194
2003-08-19 20:35:33 +00:00
Guy Harris
ce24750abc Void functions don't return values, even though GCC likes to pretend
that they do.

svn path=/trunk/; revision=8193
2003-08-19 18:30:44 +00:00
Ronnie Sahlberg
4ea90cdabc Update to the Response Time Statistics taps.
SMB/FC/ONC-RPC/DCE-RPC now all use the default tap filter string as the
same filter string as is used in the main window instead of using a default
NULL filter string.

The idea is that if you have applied a certain filter to your main window, it
is likely that if you want to invoke the response time statistics feature you
probably want to do the response time statistics over the same set of packets, i.e. the ones you see in the main window.

svn path=/trunk/; revision=8192
2003-08-19 10:09:20 +00:00
Ronnie Sahlberg
4ee16a83eb Update to the SMB dissector so that the HighLen 16 bit integer is decoded
instead of as being represented as RESERVED.
This updates the ReadAndX and WriteAndX calls and replies.

This should really try to keep track of the negotiation of the conversation to make sure we only do it for those sessions where LARGE file io has been negotiated.  Currently it does it for all Read/Write AndX calls.
It is probably safe to do so since for those clients where this is not supported these bytes are RESERVED and MBZ anyway.

svn path=/trunk/; revision=8191
2003-08-19 09:58:54 +00:00
Guy Harris
6f4508de8c Define GCC_GLIB_CFLAGS as a GCC equivalent of GLIB_CFLAGS, and use it
instead of -I$(GLIB_DIR) when running GCC to generate the xyzzy file, so
that the right -I flags are used.

svn path=/trunk/; revision=8190
2003-08-19 02:16:26 +00:00
Guy Harris
b24a5b39af Get plugins/README.interface into the source tarball.
svn path=/trunk/; revision=8189
2003-08-18 21:43:21 +00:00
Ronnie Sahlberg
710f08b09f From Richard Urwin a great enhancement to the color filter dialogue to
make it possible to import/export color filters

svn path=/trunk/; revision=8188
2003-08-18 21:27:11 +00:00
Guy Harris
7e212dd179 Check in Xass-list, so the CVS tree can be built on Windows without
having GCC.

Check in updated versions of the other X* files.

svn path=/trunk/; revision=8187
2003-08-18 20:21:19 +00:00
Guy Harris
e7c8d1f5a0 From Matthijs Melchior:
move the initialization of the addresses in the plugin interface
	structure from run-time to link time;

	don't attempt to rebuild the X* files automatically, just warn
	that they're out of date and show the command used to rebuild
	them (not everybody has GCC installed, but it's required in
	order to rebuild them).

Get rid of the checked-in Xepan_plugins.c, as it's no longer generated
or used.

Fix Makefile.am now that Xepan_plugins.c has been replaced by Xass-list.

Give plugin_gen.py an RCS ID.

svn path=/trunk/; revision=8186
2003-08-18 20:17:55 +00:00
Guy Harris
8649fcf232 From Gisle Vanem: MingW declares "rint()" in <math.h> and defines it in
a library, and declares "mode_t" in <sys/types.h>.

svn path=/trunk/; revision=8185
2003-08-18 18:41:25 +00:00
Guy Harris
718b853b53 From Gisle Vanem: <ws2tcpip.h> is needed for INET6 code in epan/resolv.c
(at least with MingW + gcc 3.3.1).

svn path=/trunk/; revision=8184
2003-08-18 18:40:10 +00:00
Guy Harris
c927dec391 Add checks for read errors in "read_prefs()".
svn path=/trunk/; revision=8183
2003-08-18 18:35:21 +00:00
Guy Harris
908dcdf491 From Tony Lindstrom: updates of DHCPV6 dissector to
draft-ietf-dhc-dhcpv6-28,
draft-ietf-dhc-dhcpv6-opt-prefix-delegation-04, and
draft-ietf-dhc-dhcpv6-opt-dnsconfig-03, and addition of NIS and time
configuration option drafts draft-ietf-dhc-dhcpv6-opt-nisconfig-02 and
draft-ietf-dhc-dhcpv6-opt-timeconfig-02.

svn path=/trunk/; revision=8182
2003-08-18 18:20:11 +00:00
Guy Harris
3098690bfc From Greg Morris: SRVLOC-over-TCP support.
svn path=/trunk/; revision=8181
2003-08-18 18:06:06 +00:00
Gerald Combs
1a749a84c5 Change a NULL to an empty string in order to appease "[t]ethereal -G fields".
svn path=/trunk/; revision=8180
2003-08-18 01:40:16 +00:00
Ronnie Sahlberg
f7a26c1bed Prettifying the RPC and NFS (v3) layer.
Add more text to the COL_INFO line as well as the protocol trees for NFS and RPC

svn path=/trunk/; revision=8179
2003-08-17 21:34:22 +00:00
Ronnie Sahlberg
a6d080537b Update to SMB
Change the AndX command fields  to only place a filterable field in the tree when smb.cmd is NOT 0xff
If smb.cmd is 0xFF just place a text entry in the field instead.

This makes it more intuitive for users that try to use filters such as
smb.cmd!=0xXY   since the filter will no longer behave "unexpectedly" and fail to filter out any of the AndX commands.

Yes,   they should really use !smb.cmd==0xXY instead but one cant explain this to every single user.

I dont think anyone would ever want to filter for smb.cmd==0xFF anyway

svn path=/trunk/; revision=8178
2003-08-17 21:21:50 +00:00
Ronnie Sahlberg
efaebc3ded Update authors with the author of h225 h245 and the per support
svn path=/trunk/; revision=8177
2003-08-17 21:16:06 +00:00
Guy Harris
36aabc7c1d From Erwin Rol:
Update e-mail address.

	Register the ARP dissector, as the RT-Net dissector tries to
	find it.

svn path=/trunk/; revision=8176
2003-08-17 01:05:21 +00:00
Guy Harris
add318fc93 From Shiang-Ming Huang: STUN (RFC 3489) support.
svn path=/trunk/; revision=8175
2003-08-17 00:54:25 +00:00
Guy Harris
e956aac299 Sigh. I think I once tried making the last argument to "col_set_str()"
be a "const gchar *", and it ended up being like pulling a thread out of
a sweater - more things had to change, which meant still more things had
to change, and I might've even run into something that didn't change
very well at all.  (Or perhaps that was constifying something else.)

For now, we just cast away the constness in calls to "col_set_str()";
the column code won't actually overwrite the string.

svn path=/trunk/; revision=8174
2003-08-17 00:52:03 +00:00
Guy Harris
bf258889fb From Joakim Wiberg: various fixes and cleanups, including fixes to
malformed packets caused by unconnected send and support for connected
class 3 data.

svn path=/trunk/; revision=8173
2003-08-16 01:53:41 +00:00
Guy Harris
45208cd1d5 From Ronnie Sahlberg: patch to set up conversations to use RTP and RTCP
based on H.245 information.

svn path=/trunk/; revision=8172
2003-08-16 00:51:04 +00:00
Guy Harris
1c66a793f3 There's no such function as "delete_giop_user_module()", so don't put it
in the list of exported functions.

svn path=/trunk/; revision=8171
2003-08-16 00:38:28 +00:00
Guy Harris
20d2c86dc1 Get rid of an unused variable.
svn path=/trunk/; revision=8170
2003-08-16 00:31:16 +00:00
Guy Harris
c45515079b From Alfred Koebler:
add interpretation of chain position;

	add a preference to interpret the new file format used by fw
	monitor options -u/-s.

svn path=/trunk/; revision=8169
2003-08-16 00:29:15 +00:00
Gerald Combs
4b8a07fe42 Make the AH and ESP sequence numbers BASE_DEC, since no one objected to
http://www.ethereal.com/lists/ethereal-dev/200308/msg00189.html.

svn path=/trunk/; revision=8168
2003-08-16 00:11:07 +00:00
Guy Harris
76d14c168e In "dissect_transaction2_request_parameters()", "bc" gets decremented as
we go through the data, so we can't compare it with the current offset
minus the starting offset - we should just test, and use, its value
directly, as, at the end, it reflects the amount of data left.

svn path=/trunk/; revision=8167
2003-08-15 23:57:52 +00:00
Tim Potter
439c6381a7 Some fixes for UNIX CIFS extensions. There's still a problem in the trans2
find response and we end up displaying malformed frame even though all data
has been dissected.

svn path=/trunk/; revision=8166
2003-08-15 03:23:31 +00:00
Richard Sharpe
26285280d0 Apply Greg Morris' buffer overflow prevention patch to the find enhancements.
svn path=/trunk/; revision=8165
2003-08-14 22:32:45 +00:00
Tim Potter
06e38e5c2c Removed references to CIFS TR section numbers from various value_strings.
The strings are now in COL_INFO and the section numbers were cluttering it
up.

svn path=/trunk/; revision=8164
2003-08-14 00:24:13 +00:00
Tim Potter
c690c5cb76 Make some abbreviations to some value_strings to save COL_INFO real estate:
transaction -> trans, information -> info.

Put value_string data in COL_INFO for trans2 query{path,file}info.

svn path=/trunk/; revision=8163
2003-08-13 04:03:11 +00:00
Tim Potter
eea3681c62 Fixes for testing all variations of query fsinfo. There were a few
transpositions of subcommand numbers, and the query object id case was not
implemented.  I'm not sure about the query fs label info as it doesn't seem
to exist as a server procedure except in Samba.

svn path=/trunk/; revision=8162
2003-08-13 00:05:00 +00:00
Tim Potter
50765130a6 Put CLDAP instead of LDAP in COL_INFO for LDAP over UDP.
svn path=/trunk/; revision=8161
2003-08-12 20:14:05 +00:00
Tim Potter
3f6e918109 Save and restore the value of pinfo->current_proto when calling a
dissector in call_dissector_through_handle().

svn path=/trunk/; revision=8160
2003-08-12 20:09:38 +00:00
Gerald Combs
bb9f332da6 Change the control message names, error codes, and result codes to more
closely match what's in RFC 2637.

svn path=/trunk/; revision=8159
2003-08-12 02:05:41 +00:00
Richard Sharpe
2f8c75aed1 Applied the "Updated find capabilities...." from Greg Morris.
svn path=/trunk/; revision=8158
2003-08-11 22:41:10 +00:00
Guy Harris
f2faba5cf2 From Lars Roland:
enable decoding of fastStart elements;

	make the output in the Protocol and Info columns look like the
	old plugin's output.

svn path=/trunk/; revision=8157
2003-08-10 19:43:25 +00:00
Guy Harris
e3ba589cbe Put an item into the protocol tree for the non-ESP marker.
Set the protocol tree item for IPSEC-over-UDP to the length of the
IPSEC-over-UDP header - i.e., don't include the actual ISAKMP or ESP
data in that item.

svn path=/trunk/; revision=8156
2003-08-10 19:08:02 +00:00
Guy Harris
f430e35c13 Register the dissector by name - the "UDP Encapsulation of IPsec
Packets" dissector uses it.

svn path=/trunk/; revision=8155
2003-08-08 23:08:02 +00:00
Guy Harris
97c3b27852 Handle NAT-keepalive packets.
Clear the Info column before dissecting.

Use "proto_tree_add_item()" to create the top-level entry - the string
used in the "proto_tree_add_protocol_format()" call was the protocol's
long name, so "proto_tree_add_item()" would use it.

Don't register the dissector by name - nobody uses it.

svn path=/trunk/; revision=8154
2003-08-08 23:06:47 +00:00
Guy Harris
82ead653d3 Change Lo�c Minier's e-mail address.
svn path=/trunk/; revision=8153
2003-08-08 22:49:00 +00:00
Guy Harris
3b40c7efcb From Niels Koot: fix to SUA subdissection code:
do subdissection even if no protocol tree is being built;

	don't put subdissection data in global variables.

svn path=/trunk/; revision=8152
2003-08-08 18:05:03 +00:00
Guy Harris
3395cda0ec The InterSwitch Link Frame Format document on the Cisco site moved.
svn path=/trunk/; revision=8151
2003-08-08 17:57:44 +00:00
Guy Harris
663a127b5d A bufsize of 0 makes no sense in either "tvb_get_nstringz()" or
"tvb_get_nstringz0()", as it means there's no room even for the
terminating NUL; abort if "_tvb_get_nstringz()" is passed a bufsize of
0.

Don't throw an exception in "tvb_get_nstringz0()" if
"_tvb_get_nstringz()" returns 0 - that just means we have an empty
string.

svn path=/trunk/; revision=8150
2003-08-08 08:19:50 +00:00