being complete and for fragmentation being trivial (i.e., the packet in
question is both the first and last fragment). Have its callers *not*
do that check - this lets "process_reassembled_data()" put in the
"Reassembled in" item for fragments other than the last fragment.
Add a "Reassembled in" field to TDS.
svn path=/trunk/; revision=8295
and it means we only dissect the reassembled data for the last frame (so
code running through the packet list, and humans clicking on frames, see
only one instance of the reassembled data, not multiple instances that
might look like retransmissions).
svn path=/trunk/; revision=8292
given OUI; the field is used when the PID for that OUI is put into the
protocol tree, and the dissector table is used to find a dissector for
that PID.
Not yet used, thus not yet tested; API is subject to change.
(Eventually, several of the cases in the big switch statement in
"dissect_llc()" should be handled by registering information for those
OUIs.)
svn path=/trunk/; revision=8291
registers itself - it's just imported by name. Get rid of the
"create_dissector_handle()" call, as the resulting dissector handle
isn't ever used.
svn path=/trunk/; revision=8287
use Export and Import for the buttons in GTK+ 2.x as well;
get rid of a duplicate fclose;
other fixes.
Update the description of color filters in the Ethereal man page to
reflect the change, clean up the formatting (use =item), and add the
global and personal color filters files to the FILES section; refer to
them as "color filters" files rather than "colorfilters" files, as the
FILES section gives the "colorfilters" file name so you don't have to
use that as the name.
Clean up white space.
svn path=/trunk/; revision=8285
hopefully it will now create the filter for the actual conversation
we selected.
add EP1 <-> ANY and EP2 <-> ANY fitlers
svn path=/trunk/; revision=8283
The table now has a popup menu with
Match display filter
Selected
EP1 <-> EP2
EP1 --> EP2
EP1 <-- EP2
EP1 --> ANY
EP1 <-- ANY
EP2 --> ANY
EP2 <-- ANY
Not Selected
...
...
Prepare Display Filter
...
Self explanatory.
Now the bad news.
I set the display filter box in the main window and i call redissect_packet
which redissects the packet list but the displayfilter does not take
or affect the main window until i click the apply button.
Some signal needs to be raised to some object me thinks.
Please feel free to fix it if you know what is missing.
svn path=/trunk/; revision=8279
use WTAP_ENCAP_ATM_PDUS as the default encapsulation for ATM;
don't use ULL constants, as not all C compilers that support
gint64 support them, and as there's no need to make them ULL
constants.
svn path=/trunk/; revision=8278
Extract the FCS decoding section of the PPP_HDLC dissector to
allow the CHDLC dissector to use the same routine.
The ppp_options used for preferences has been renamed to
fcs_options and exported via packet-ppp.h so CHDLC gets a
separate (but identical) FCS preference.
This means prefs.h has to be included before packet-ppp.h so a
couple of ppp related files (packet-{gtp,null,raw,vj}.c) had
their includes slightly re-arranged.
From me: make the PPP/CHDLC FCS code use "crc32()" to check the 32-bit
FCS.
svn path=/trunk/; revision=8271
expression information if the address type is AT_NONE -
"address_to_str_buf()" panics if passed an AT_NONE address, as there's
nothing sensible one can do with them. (A null string wouldn't be
appropriate here, as a dissector might have set the address columns to a
string.)
svn path=/trunk/; revision=8269
Extract the FCS decoding section of the PPP_HDLC dissector to
allow the CHDLC dissector to use the same routine.
The ppp_options used for preferences has been renamed to
fcs_options and exported via packet-ppp.h so CHDLC gets a
separate (but identical) FCS preference.
This means prefs.h has to be included before packet-ppp.h so a
couple of ppp related files (packet-{gtp,null,raw,vj}.c) had
their includes slightly re-arranged.
From me: make the PPP/CHDLC FCS code use "crc32()" to check the 32-bit
FCS.
svn path=/trunk/; revision=8266
use to translate addresses to strings - wire that into
"endpoint_talkers_table.c", don't pass the function as an argument to
"init_ett_table()".
svn path=/trunk/; revision=8263
which fills in a caller-supplied buffer.
Create "_buf()" versions of various "to_str" routines for various
address types, and create a routine to map SNA FIDs to strings, and use
them to finish up "address_to_str_buf()".
Get rid of the declaration of "sna_fid_type_4_addr_to_str()" in
"packet-sna.h", as that routine has been swallowed up in
"sna_fid_to_str()".
svn path=/trunk/; revision=8260
1. Added support for defragmentation of NDS packets
2. The packet signature fixes seemed to never been applied. I
have been using this code to dissect reply packets with packet
signatures for quite some time and have never experienced any
problems with it. Without these changes then reply packets
containing signatures will not be decoded properly. It was
recommended by Guy to not use public variables to track the
signatures but it has been my experience that if signatures are
enabled then it is enabled in the whole environment and would be
valid for all NCP packets within the trace. I could change this
but it would add additional code to build a memory table to
track this. If for some reason it is determined to not add this
part of the code then I will have to go back and add this table.
svn path=/trunk/; revision=8258
1. Added support for defragmentation of NDS packets
2. Moved the run_info_string logic outside of the
pinfo->fd->flags->visited because of the dissection of info
strings is not processed on subsequent decodes then the
find/string/info will not locate info string values. By moving
this outside then when the find logic runs a tvb_dissect_new
then the info string gets processed again and all data is
visible. Otherwise only info column data that is processed by
the NCP dissector is visible not any data from ncp2222.py
processed by the info string function.
svn path=/trunk/; revision=8257
1. Added Secret Store Services group
2. Added a number of NCP return values
3. Added support for NDS defragmentation
4. Fixed type from file to bindery on ncp's 23/20, 23/21, 23/22, 23/24,
23/27, 23/28, 23/29, 23/30, and 23/31
5. Fixed type from comm to nmas on ncp 91
6. Fixed ncp 92 to include 92/01, 92/02, 92/03, 92/04, 92/05, 92/06,
92/07, 92/08, 92/09, and 92/10
7. Added return value for 104/02
8. Fixed reply structures for NCP 123/60 and NCP 123/79
svn path=/trunk/; revision=8256
make the "Help" menu the rightmost menu item, as is done in
recent versions of Windows;
Mac OS X;
recent versions of KDE;
recent versions of GNOME;
rather than making it an item on the far right side.
Make the "Protocol" display in the help mention the number of
entries, and give it has 3 columns, starting with the one that
was used to sort this list.
Make the "Display Filters" display mention the number of fields
for each protocol and at the end the total number of fields.
Give it 4 columns, including the 'blurb'.
List all fields with the correct protocol.
svn path=/trunk/; revision=8253
to make it easier to navigate when having multiple instances of ethereal
and io-stat open
at the same time.
Updates to all endpoint talkers and service response time windows to do this as well.
Bonus, when the user opens a new capture file when having these windows open,
the title bar will be updated to reflect the name of the new capture file.
svn path=/trunk/; revision=8251
The heuristic for RPC detection sometimes mistakenly decodes something as RPC when in reality it is payload.
Since the heuristics is based on the PDU suze as specified in the record marker
make this limit settable from the preferences.
Arbitrary limit of 256kb is choosen as default instead of the original limit of 2mb.
(face it, the largest common oncrpc pdus are those for nfs read/write anyway and these seldom go above 32kb.)
svn path=/trunk/; revision=8250