Commit graph

849 commits

Author SHA1 Message Date
Guy Harris
fdfd8b58af The code in an HTTP reply is a response code, not a response method.
svn path=/trunk/; revision=8346
2003-09-02 23:09:11 +00:00
Guy Harris
75ae0e30c7 From Jean-Michel Fayard: BOOTP/DHCP, HTTP, and WSP statistics taps.
svn path=/trunk/; revision=8345
2003-09-02 22:47:59 +00:00
Guy Harris
71034c5a3f From Jean-Michel Fayard: show in Tools:Summary window statistics about
packets that passed the current display filter, as well as about the
entire capture.

Document the Tools:Summary item in the man page.

Update Gerald's e-mail address.

svn path=/trunk/; revision=8344
2003-09-02 22:10:32 +00:00
Gerald Combs
9d603ccc2c Make sure the color selection dialog displays a color selection widget.
Tweak the button layout slightly.

svn path=/trunk/; revision=8332
2003-09-02 18:27:50 +00:00
Ronnie Sahlberg
b0bec4d79a When putting the filename in the titlebar
just put the filename there and not the full path to the file.

svn path=/trunk/; revision=8329
2003-09-02 08:27:43 +00:00
Gerald Combs
d87e75c585 Make the capitalization of the "Name Resolution" frame consistent with the
other frames.

svn path=/trunk/; revision=8327
2003-09-01 01:49:20 +00:00
Guy Harris
f11ef57387 Include "tap.h" to get "remove_tap_listener()" declared.
svn path=/trunk/; revision=8322
2003-08-31 00:31:05 +00:00
Ronnie Sahlberg
82c1757345 Remove the individual reset functions and replace with a common one in the helpers file.
cleanup part 5?

svn path=/trunk/; revision=8320
2003-08-30 01:18:16 +00:00
Ronnie Sahlberg
ce8477a3ed step 3 in endpoint talkers cleanup
get rid of the draw_packets wrapper in the individual endpoint files

svn path=/trunk/; revision=8319
2003-08-30 01:05:03 +00:00
Ronnie Sahlberg
1b81e773a7 step two in endpoint talkers cleanup
move the windows destroy function to the common helpers file

svn path=/trunk/; revision=8318
2003-08-30 00:53:15 +00:00
Ronnie Sahlberg
7789678033 step one in endpoint talkers cleanup
svn path=/trunk/; revision=8317
2003-08-30 00:47:43 +00:00
Ronnie Sahlberg
4135309cbd Add endpoint talkers support for FDDI to ethereal and tethereal
Welcome FDDI into the endpoint talkers family.

Nobody gets left behind!

svn path=/trunk/; revision=8310
2003-08-29 10:59:12 +00:00
Ronnie Sahlberg
19a99f8a34 Make the hex to string conversion code in find_dlg.c handle ':' characters
such as you might find when doing "prepare" on a FT_BYTES field.

So one need not delete the ':' characters manually

svn path=/trunk/; revision=8309
2003-08-29 09:32:16 +00:00
Guy Harris
56664b9b77 Make the CList of character sets non-editable, so you only get to choose
from what we offer.  (XXX - should it be an option menu, instead?)

svn path=/trunk/; revision=8308
2003-08-29 04:56:46 +00:00
Guy Harris
1cf6565adc Get rid of the EBCDIC stuff in the find dialog - it's not supported yet,
so we shouldn't torment the users by offering it.

Check the string type and convert it to an internal representation in
the GUI code; have the search code deal only with the internal
representation.

Save the case-sensitivity flag, and the indication of where string
searches look, along with other search parameters.

Upper-casify the string, for case-insensitive searches, in the GUI code;
don't save the upper-casified string, so it doesn't SHOUT at you when
you next pop up a "find" dialog.

Convert the hex value string to raw binary data in the GUI code, rather
than doing so in the search code.  Check that it's a valid string.

Connect the signals to the radio buttons after the pointers have been
attached to various GUI items - the signal handlers expect some of those
pointers to be attached, and aren't happy if they're not.

Have "find_packet()" contain a framework for searching, but not contain
the matching code; instead, pass it a pointer to a matching routine and
an opaque pointer to be passed to the matching routine.  Have all the
routines that do different types of searching have their own matching
routines, and use the common "find_packet()" code, rather than
duplicating that code.

Search for the Info column by column type, not by name (the user can
change the name).

When matching on the protocol tree, don't format the entire protocol
tree into a big buffer - just have a routine that matches the text
representation of a protocol tree item against a string, and, if it
finds a match, sets a "we found a match flag" and returns; have that
routine not bother doing any more work if that flag is set.
(Unfortunately, you can't abort "g_node_children_foreach()" in the
middle of a traversal.)

Free the generated display filter code after a find-by-display-filter
finishes.

svn path=/trunk/; revision=8306
2003-08-29 04:03:46 +00:00
Guy Harris
2af6770410 From Greg Morris: put borders around the options to delimit them and
indicate where they apply, and give tooltips to some of the options.
Disable the "Filter:" button unless we're searching with a display filter.

Use "Frame data" instead of "Hex" for the option to search the raw frame
data, use "Decoded packet" instead of "Decode" for the option to search
the strings in the protocol tree display, and use "Packet summary"
instead of "Summary" for the option to search the Info column in the
packet list display, to make it a bit clearer what's being searched.

svn path=/trunk/; revision=8303
2003-08-28 23:25:55 +00:00
Olivier Abad
0c678f74c7 Marking packets with the middle mouse button works now with GTK2.
svn path=/trunk/; revision=8301
2003-08-28 20:33:14 +00:00
Guy Harris
2d71f3589d Use "GPOINTER_TO_INT()" to convert the return value of
"gtk_clist_get_row_data()" to an "int", to squelch compiler warnings.

svn path=/trunk/; revision=8286
2003-08-27 23:01:10 +00:00
Guy Harris
115700bc62 From Richard Urwin:
use Export and Import for the buttons in GTK+ 2.x as well;

	get rid of a duplicate fclose;

	other fixes.

Update the description of color filters in the Ethereal man page to
reflect the change, clean up the formatting (use =item), and add the
global and personal color filters files to the FILES section; refer to
them as "color filters" files rather than "colorfilters" files, as the
FILES section gives the "colorfilters" file name so you don't have to
use that as the name.

Clean up white space.

svn path=/trunk/; revision=8285
2003-08-27 22:55:51 +00:00
Ronnie Sahlberg
a7d0d4bf16 update to the talkers popup list.
hopefully it will now create the filter for the actual conversation
we selected.

add EP1 <-> ANY and EP2 <-> ANY fitlers

svn path=/trunk/; revision=8283
2003-08-27 21:54:36 +00:00
Gilbert Ramirez
52338a3baf Add a "contains" operator for byte-strings, strings, and tvbuffs (protocols).
The search uses a naive approach; more work is required to add a
Boyer-Moore Search algorithm.

svn path=/trunk/; revision=8280
2003-08-27 15:23:11 +00:00
Ronnie Sahlberg
d3562c0480 Updates for the endpoint talkers thing
The table now has a popup menu with
   Match display filter
         Selected
               EP1 <-> EP2
               EP1 --> EP2
               EP1 <-- EP2
               EP1 --> ANY
               EP1 <-- ANY
               EP2 --> ANY
               EP2 <-- ANY
          Not Selected
               ...
          ...
    Prepare Display Filter
          ...

Self explanatory.

Now the bad news.
I set the display filter box in the main window and i call redissect_packet
which redissects the packet list   but the displayfilter does not take
or affect the main window until i click  the apply button.

Some signal needs to be raised to some object me thinks.

Please feel free to fix it if you know what is missing.

svn path=/trunk/; revision=8279
2003-08-27 12:10:21 +00:00
Guy Harris
f91af72c55 All endpoint talkers table taps use "address_to_str()" as the routine to
use to translate addresses to strings - wire that into
"endpoint_talkers_table.c", don't pass the function as an argument to
"init_ett_table()".

svn path=/trunk/; revision=8263
2003-08-26 01:46:23 +00:00
Guy Harris
e22b6afeb7 From Matthijs Melchior:
make the "Help" menu the rightmost menu item, as is done in

		recent versions of Windows;

		Mac OS X;

		recent versions of KDE;

		recent versions of GNOME;

	rather than making it an item on the far right side.

	Make the "Protocol" display in the help mention the number of
	entries, and give it has 3 columns, starting with the one that
	was used to sort this list.

	Make the "Display Filters" display mention the number of fields
	for each protocol and at the end the total number of fields.
	Give it 4 columns, including the 'blurb'.

	List all fields with the correct protocol.

svn path=/trunk/; revision=8253
2003-08-25 21:42:33 +00:00
Ronnie Sahlberg
cd016e69a9 Update to IO-Stat to put the capture filename on the titlebar
to make it easier to navigate when having multiple instances of ethereal
and io-stat open
at the same time.

Updates to all endpoint talkers and service response time windows to do this as well.

Bonus, when the user opens a new capture file when having these windows open,
the title bar will be updated to reflect the name of the new capture file.

svn path=/trunk/; revision=8251
2003-08-25 11:06:32 +00:00
Guy Harris
e4e0150ffa From Matthijs Melchior:
support for registering fields after all the protocol
	    registration routines are called (i.e., adding fields to the
	    named field tree as they're registered);

	fix the GTK 2.x version of the field list dialog to show the
	    correct name.

svn path=/trunk/; revision=8248
2003-08-25 00:15:02 +00:00
Guy Harris
7540493b20 Get rid of the wrappers around "address_to_str()".
svn path=/trunk/; revision=8245
2003-08-24 22:34:32 +00:00
Ronnie Sahlberg
0f9440cb55 The IPX endpoint talkers implementation
svn path=/trunk/; revision=8241
2003-08-24 05:39:05 +00:00
Ronnie Sahlberg
38e52de283 Add endpoint talker support for IPX
svn path=/trunk/; revision=8240
2003-08-24 05:38:23 +00:00
Ronnie Sahlberg
bcfc2719b9 Update address_to_str to handle FC and ETH addresses as well.
Update the fc and eth and tr  endpoint talker list to use the new api

svn path=/trunk/; revision=8235
2003-08-24 03:00:11 +00:00
Ronnie Sahlberg
521db7b61f Add a new function address_to_str to to_str.c
Implement conersion from address to string for IPv4 and IPv6
and update the conversation tables to use the new interface.

svn path=/trunk/; revision=8234
2003-08-24 02:50:32 +00:00
Guy Harris
03ff66eefb Cast the argument to "ip6_to_str()" to avoid compiler warnings.
Use "%u", not "%d", for unsigned values.

svn path=/trunk/; revision=8232
2003-08-24 01:39:55 +00:00
Guy Harris
1edf69590f Cast arguments to "g_free()" to avoid compiler warnings (those are known
to be mallocated, so it's safe to cast them).

Use "%u", not "%d", for unsigned values.

svn path=/trunk/; revision=8231
2003-08-24 01:39:04 +00:00
Guy Harris
5b70103557 Use "ip_to_str_buf()" to turn a pointer to an IP address to a string.
svn path=/trunk/; revision=8230
2003-08-24 01:37:34 +00:00
Ronnie Sahlberg
7f0f29dced Write Token Ring as Token Ring and not TokenRing
svn path=/trunk/; revision=8225
2003-08-23 13:58:54 +00:00
Ronnie Sahlberg
cb92d3284b Update the UDP and the TCP conversation list tool so that it can handle IPv6 as well.
Make no distinction between UDP/TCP over IPv4 and UDP/TCP over IPv6
and present them in the same list.

svn path=/trunk/; revision=8224
2003-08-23 13:56:40 +00:00
Ronnie Sahlberg
5cf0634041 Add FibreChannel to the types of protocols we can show a conversation list for
svn path=/trunk/; revision=8223
2003-08-23 13:35:06 +00:00
Ronnie Sahlberg
ba74395cbe New feature. Statistics/EndpointTalkjers can now present a sortable table with a list of all seen conversations of a certain type.
Supported types are Ethernet/TokenRing/IP/UDP and TCP.
Will add FibreChannel soon.

The framework for this feature needs to be enhanced in the future so that by selecting one entry and click the right mousebutton, this will bring up a menu with  Prepare/Match options  with suboptions for AnyDirection, ForwardOnly or ReverseOnly   which updates the display filter accordingly.

Had to update some of the taps as well to change them to use a proper address structure for the address fields.
We should now be able to to these stats correctly even for ip tunneled over ip tunnelled over ip ...

svn path=/trunk/; revision=8222
2003-08-23 09:09:35 +00:00
Guy Harris
1208c206f7 From Lars Roland:
A scrollable GtkCList is used now for both GTK1 and GTK2.

	Removed "overall" line from statistics table. It is not useful.

	"Response Time Delay" was renamed into "Service Response Time".

	Menu Item moved to "Service Response Time" folder.

	As Ronnie suggested, the active display filter is now used as
	default statistics filter.

svn path=/trunk/; revision=8205
2003-08-21 17:48:04 +00:00
Guy Harris
23f105da58 Construct the About box ourselves, so it has the title "About Ethereal"
and doesn't have a message-box-type icon.

This might want to be tweaked further, to more closely resemble various
desktop environments' About boxes (although what's appropriate might
depend on the environment).

svn path=/trunk/; revision=8194
2003-08-19 20:35:33 +00:00
Ronnie Sahlberg
4ea90cdabc Update to the Response Time Statistics taps.
SMB/FC/ONC-RPC/DCE-RPC now all use the default tap filter string as the
same filter string as is used in the main window instead of using a default
NULL filter string.

The idea is that if you have applied a certain filter to your main window, it
is likely that if you want to invoke the response time statistics feature you
probably want to do the response time statistics over the same set of packets, i.e. the ones you see in the main window.

svn path=/trunk/; revision=8192
2003-08-19 10:09:20 +00:00
Ronnie Sahlberg
710f08b09f From Richard Urwin a great enhancement to the color filter dialogue to
make it possible to import/export color filters

svn path=/trunk/; revision=8188
2003-08-18 21:27:11 +00:00
Guy Harris
8649fcf232 From Gisle Vanem: MingW declares "rint()" in <math.h> and defines it in
a library, and declares "mode_t" in <sys/types.h>.

svn path=/trunk/; revision=8185
2003-08-18 18:41:25 +00:00
Richard Sharpe
2f8c75aed1 Applied the "Updated find capabilities...." from Greg Morris.
svn path=/trunk/; revision=8158
2003-08-11 22:41:10 +00:00
Guy Harris
ddf6a8acf2 From Michael Lum: add the ability to have a preferences file containing
a list of disabled protocols, and to save that list from the Edit >
Protocols dialog box.

Add checks for read errors in "read_prefs()".

Clean up white space.

svn path=/trunk/; revision=8144
2003-08-07 00:41:28 +00:00
Guy Harris
d2e2149ff9 From Greg Morris: add support for case-insensitive full-text searches.
svn path=/trunk/; revision=8132
2003-08-05 00:01:27 +00:00
Guy Harris
90bf936ffa From Chris Heath: fix up the check for printable ASCII done on Windows
not to include DEL as printable ASCII.

Also change the check in strutil.c to do it by redefining "isprint()",
as is done in "gtk/gtkglobals.h", rather than by #ifdeffing the point at
which the test is done.

svn path=/trunk/; revision=8118
2003-08-01 01:39:01 +00:00
Gilbert Ramirez
c91b8e713f Fix signed/unsigned comparison warnings.
svn path=/trunk/; revision=8084
2003-07-25 04:11:51 +00:00
Gilbert Ramirez
086774b71f Add to the fundamental types passed between the scanner and the parser.
Besides "STRING", there is now "UNPARSED_STRING", where the distinction
is that "STRING" was a double-quoted string and "UNPARSED_STRING" is just
a sequence of characters that the scanner didn't know how to scan/parse,
so it's up to the Ftype to parse it.

This gives us more flexibility and prepares the dfilter parsing engine
for the upcoming addition of the "contains" operator.

In the process of doing this, I also re-did the double-quoted string
support in the scanner, so that instead of the naively-simple support we
used to have, double-quoted strings now can have embedded dobule-quotes,
embedded octal sequences, and embedded hexadecimal sequences:
    "\""    embedded double-quote
    "\110"  embedded octal
    "\x48"  embedded hex

Enhance the dfilter unit test script to be able to run a single collection
of tests instead of having to run all of them all the time.

svn path=/trunk/; revision=8083
2003-07-25 03:44:05 +00:00
Guy Harris
487d0def6b From Greg Morris: code to support searches for text or raw binary data
in a frame in Find Frame.

svn path=/trunk/; revision=8067
2003-07-22 23:08:48 +00:00