osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
38102 commits 26 branches 0 tags 795 MiB
Commit graph

13046 commits

Author SHA1 Message Date
Bill Meier
34c16b8c17 From Yaniv Kaul: Some enhancements, some fixes, to the Spice dissector: 
- SASL authentication support - improved (and correct) state machine.
- indention, tab fixes
- macro to fetch PDU, simplifying the code (and improving its readability)
- properly show the length of agent messages and align them under the right tree.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6589

From me: Fix some indentation & remove some trailing whitespace.

svn path=/trunk/; revision=39972
 2011-11-21 16:43:01 +00:00
Martin Mathieson
ab9ede8e8f Add the system frame number (SFN) to the context fields logged along with LTE MAC frames. 
svn path=/trunk/; revision=39971
 2011-11-21 16:18:33 +00:00
Jörg Mayer
c946b6c3a2 Move generated dissctors that are causing problems to DIRTY. 
packet-x11.c: hundreds of:

/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h:27994:9: warning: variable ‘f_resource’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext_Reply’:

dissectors/packet-dcerpc-mapi.c: set but not used
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_req’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8592:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_repl’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8617:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_RecipSMTP’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8848:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]


dissecots/packet-dcerpc-drsuapi.c: set but not used
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c: In function ‘drsuapi_dissect_DsGetNCChangesCtr7’:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c:2920:17: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable]

Btw.: Does it really make sense to use an extra CMakefile for the dcerpc/ dir?
      I'd rather the the idl2wrs.c in tools/ and the generatorstuff in epan/CMake

More files with the same problem.

svn path=/trunk/; revision=39968
 2011-11-21 13:52:35 +00:00
Jörg Mayer
ffc843e501 Another case of written to only variable. 
svn path=/trunk/; revision=39967
 2011-11-21 12:13:36 +00:00
Jörg Mayer
80ec54b369 new_offset was was written to but never read. 
svn path=/trunk/; revision=39966
 2011-11-21 12:11:35 +00:00
Chris Maynard
f2e8579ba3 Fix potential infinite loop introduced with r39961 and find by the buildbot. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6599 
svn path=/trunk/; revision=39963
 2011-11-21 02:01:59 +00:00
Chris Maynard
3c8e31e055 Fix bug 6561: IPv4 UDP/TCP Checksum incorrect if routing header present. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6561

svn path=/trunk/; revision=39961
 2011-11-20 15:47:14 +00:00
Anders Broman
62866c78a0 Get rid of Warnings. 
svn path=/trunk/; revision=39957
 2011-11-20 12:43:04 +00:00
Anders Broman
8fdb6af097 Remove export. 
svn path=/trunk/; revision=39956
 2011-11-20 10:27:26 +00:00
Anders Broman
03b2005957 See if this fixes it, why it worked on my system is anybodys guess. 
svn path=/trunk/; revision=39955
 2011-11-20 09:51:03 +00:00
Anders Broman
42b44648c8 Get rid of Warnings. 
svn path=/trunk/; revision=39954
 2011-11-20 08:59:19 +00:00
Guy Harris
8f06e3af4b The URI parameter parser always has to advance current_offset in the 
loop, otherwise you get stuck in an infinite loop.

(Where in RFC 3261 does it mention the use of commas in URI parameters?)

Should fix bug 6598.

svn path=/trunk/; revision=39952
 2011-11-19 22:57:13 +00:00
Anders Broman
faea2d624c Get rid of Warnings. 
svn path=/trunk/; revision=39951
 2011-11-19 22:42:51 +00:00
Guy Harris
00884a10f2 Clean up indentation. 
svn path=/trunk/; revision=39950
 2011-11-19 20:49:15 +00:00
Anders Broman
4b2aa811e1 Fix Warnings. 
svn path=/trunk/; revision=39948
 2011-11-19 17:21:35 +00:00
Anders Broman
87eafedef0 Revert 39946 
svn path=/trunk/; revision=39947
 2011-11-19 16:24:19 +00:00
Anders Broman
3d13938fa4 See if this fixes "warning: initializer element is not computable at load time" 
svn path=/trunk/; revision=39946
 2011-11-19 16:15:07 +00:00
Anders Broman
b431591727 Get rod of " warning: identifier ‘class’ conflicts with C++ keyword" 
svn path=/trunk/; revision=39945
 2011-11-19 09:08:50 +00:00
Martin Mathieson
4ad5ff513b From Pascal Quantin: 
For status Bitmap, don't show FSN in the info column twice.

svn path=/trunk/; revision=39937
 2011-11-18 13:42:55 +00:00
Martin Mathieson
556a0558b9 Make it easier to see: 
- bitmap entries
- MRW and MRW-ACK
- RESET and RESET-ACK
- when the Poll bit is set for data

svn path=/trunk/; revision=39936
 2011-11-18 12:45:50 +00:00
Anders Broman
1b7b2dd067 Use tvb_bcd_dig_to_ep_str(). 
svn path=/trunk/; revision=39929
 2011-11-18 07:01:10 +00:00
Bill Meier
f52525e40c Use extended value strings. 
svn path=/trunk/; revision=39918
 2011-11-17 21:58:09 +00:00
Bill Meier
9f328a08d3 Remove some unneeded #includes; 
Move proto_reg_handoff...() to the end of the file as per convention;
Do some whitespace cleanup.

svn path=/trunk/; revision=39916
 2011-11-17 20:51:07 +00:00
Anders Broman
9518cb7c7c Add a dissector table for National operation codes. 
svn path=/trunk/; revision=39912
 2011-11-17 20:05:03 +00:00
Anders Broman
71039b37c6 Fix "With the current changes NAS messages with the "null ciphering algorithm" EEA0 are not handled." 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6348

svn path=/trunk/; revision=39911
 2011-11-17 20:03:36 +00:00
Martin Mathieson
4eaa48f8db Make it easier to see RLIST details. 
svn path=/trunk/; revision=39906
 2011-11-17 16:47:22 +00:00
Bill Meier
365ca9c805 Undo some incorrect (but benign) FALSE->ENC_BIG_ENDIAN conversions done in SVN 37080. 
svn path=/trunk/; revision=39905
 2011-11-17 16:42:18 +00:00
Chris Maynard
0ef4ff0ce7 Add missing copyright and license. 
svn path=/trunk/; revision=39904
 2011-11-17 16:21:54 +00:00
Chris Maynard
e550884d5e distribute -> redistribute. 
svn path=/trunk/; revision=39903
 2011-11-17 16:10:02 +00:00
Martin Mathieson
67d0be7973 Show meaning of special length indication values in the LI root. 
svn path=/trunk/; revision=39901
 2011-11-17 12:08:50 +00:00
Anders Broman
befe8805a6 Add a missing IE number. 
svn path=/trunk/; revision=39897
 2011-11-17 06:46:34 +00:00
Chris Maynard
8a630d8e37 Avoid using "POINT" as it causes compiler errors on some systems. Add modelines that match the current file's format. This dissector is now ready to be spiceistributed. 
svn path=/trunk/; revision=39890
 2011-11-16 21:27:30 +00:00
Chris Maynard
356c6ab416 Don't assign the return value of proto_tree_add_item to a variable if it isn't going to be used. Fixes Coverity CID 1327. 
svn path=/trunk/; revision=39889
 2011-11-16 20:18:51 +00:00
Chris Maynard
934c2ce1a2 Move FI_RESET_FLAG and PROTO_ITEM_SET_VISIBLE macros to proto.h and fix the FI_RESET_FLAG macro, being sure to use the 1's complement operator, '~', instead of the logical negation operator, '!'. (Fixes Coverity CID 1326). 
svn path=/trunk/; revision=39888
 2011-11-16 20:09:49 +00:00
Anders Broman
6328122ba3 Dissect national Opcode. 
svn path=/trunk/; revision=39887
 2011-11-16 19:52:00 +00:00
Martin Mathieson
43bf2f8ba6 Show more sequence numbers in info column, and in root nodes. 
svn path=/trunk/; revision=39881
 2011-11-16 16:32:40 +00:00
Tomas Kukosa
bc5301e114 Fix handling of empty OpenType at the end of PDU 
svn path=/trunk/; revision=39880
 2011-11-16 08:55:02 +00:00
Anders Broman
f3c5620c3b - Resorted the IEs in numerical order for easier comparison with the list of constants. 
- Added two missing IEs

Solves LPPa embedded payloads not shown within LCS-AP
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6478

svn path=/trunk/; revision=39879
 2011-11-16 05:54:44 +00:00
Bill Meier
1941fd1680 Cleanup & reformatting: whitespace & long-lines. 
svn path=/trunk/; revision=39874
 2011-11-16 01:59:15 +00:00
Guy Harris
017c9eff05 Thou shalt not use proto_tree_add_string() with an FT_BYTES field. 
svn path=/trunk/; revision=39873
 2011-11-16 01:56:58 +00:00
Chris Maynard
28e5ff6098 Delete pointless orig_offset variable, initialize speech_data_len[], use tvb_reported_length() instead of tvb_length(), and protect against a possible buffer overflow. This should fix the Clang warning, "packet-evrc.c:364:41: warning: The right operand of '>=' is a garbage value", among other things. 
svn path=/trunk/; revision=39872
 2011-11-16 01:37:32 +00:00
Bill Meier
2103e7f38a tvb_[reported_]length_remaining can return -1 
svn path=/trunk/; revision=39870
 2011-11-15 21:22:01 +00:00
Bill Meier
3b387d1b8e Remove unneeded #include 
svn path=/trunk/; revision=39869
 2011-11-15 21:07:37 +00:00
Bill Meier
c8a2b19e2b (Trivial) Reformat some long lines & do some whitespace cleanup. 
svn path=/trunk/; revision=39868
 2011-11-15 20:49:40 +00:00
Anders Broman
8921bb17b5 Check the return value of dissect_sip_name_addr_or_addr_spec() 
Should fix the recent fuzz failures.
Thanks Chris for isolating the offending packet.

svn path=/trunk/; revision=39867
 2011-11-15 20:14:51 +00:00
Guy Harris
519b219ae8 Squelch a warning. (This code probably needs a review; we really need a 
better general framework for parsing text-based protocols.)

svn path=/trunk/; revision=39866
 2011-11-15 19:44:24 +00:00
Chris Maynard
e7e9d3d8b7 Rename channel_type enums to avoid possible naming conflicts. 
svn path=/trunk/; revision=39865
 2011-11-15 19:37:16 +00:00
Guy Harris
6dd27d049e More indentation cleanup. 
svn path=/trunk/; revision=39864
 2011-11-15 19:35:13 +00:00
Guy Harris
e102876289 Clean up indentation. 
svn path=/trunk/; revision=39863
 2011-11-15 19:33:14 +00:00
Anders Broman
a586241e06 packet-sip.c:1469: warning: unused variable 'contact_param_end_offset' 
svn path=/trunk/; revision=39862
 2011-11-15 19:25:17 +00:00
Anders Broman
f6f12af894 Restore dissection of contact parameters. 
svn path=/trunk/; revision=39861
 2011-11-15 19:03:39 +00:00
Bill Meier
36be9da221 Remove unneeded #includes; 
Move proto_reg_handoff...() to the end of the file as per convention.

svn path=/trunk/; revision=39860
 2011-11-15 19:00:08 +00:00
Bill Meier
199850a52b Move proto_reg_handoff...() to the end of the file as per convention; 
Do other minor reformatting and cleanup.

svn path=/trunk/; revision=39859
 2011-11-15 18:31:11 +00:00
Martin Mathieson
ed5ac34224 Append important details from LI and SURI trees to root item. 
Show some SNs in the info column.

svn path=/trunk/; revision=39852
 2011-11-15 15:36:39 +00:00
Bill Meier
49a47e9745 Fix some svn properties 
svn path=/trunk/; revision=39850
 2011-11-15 15:16:37 +00:00
Martin Mathieson
62d16f0fbb UMTS RLC: 
- add lookup for "unknown" channel type dissector (mode is known)
- set length extent for SUFI root item
- show data frames in the info column (at least for AM...)

DCT:
- call RLCDCH with "unknown" channel type (as don't know whether IP or RRC)
- support R9

svn path=/trunk/; revision=39846
 2011-11-15 12:03:52 +00:00
Alexis La Goutte
9edf24f1ef Enhance CPHA dissector 
* Remove struct and sizeof
* Replace proto_tree_add_* by proto_tree_add_item
* Replace CPHA function (report2str, opcode2str...) by standard Wireshark functions
* and minor bug fix

svn path=/trunk/; revision=39844
 2011-11-15 07:56:06 +00:00
Anders Broman
47bc2af5fd From Michael Mann: 
Bugfixes for both Buildbot issues:
1. seg-fault with multiple_service_packet
2. infinite loop

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6519

svn path=/trunk/; revision=39843
 2011-11-15 07:18:39 +00:00
Guy Harris
c8283d1291 Rewrite some odd code. Clang Cat does not want: 
packet-reload.c:2875:13: warning: Although the value stored to
	'local_offset' is used in the enclosing expression, the value is
	never actually read from 'local_offset'

although as I read the C90 spec the code is doing pretty much what it
should be doing and the rewritten code does the same thing.  However,
it's also a bit more complicated and harder to read than the rewritten
code.

svn path=/trunk/; revision=39840
 2011-11-15 05:25:17 +00:00
Guy Harris
0c530d222a At least as I read the code, there can be up to 3 receive channels (the 
number of channels is XXX & 0x03, hence in the range 0-3.

Thanks and a tip of the hat to Clang Cat for catching this.

svn path=/trunk/; revision=39839
 2011-11-15 05:10:56 +00:00
Chris Maynard
91398db56b Append each op name to the operations sub-tree so you don't necessarily have to expand the tree to see which ops are present. I think it makes more sense to append the names here rather than at the top level which was done to resolve bug 6078, but for now, I leave them appended in both places. 
svn path=/trunk/; revision=39837
 2011-11-14 20:38:05 +00:00
Bill Meier
47c4f27e0e Remove uneeded #includes, forward refs & check_col(); 
tvb_reported_length_remaining() can return -1;
Localize a variable.

svn path=/trunk/; revision=39836
 2011-11-14 20:04:04 +00:00
Bill Meier
5f73d64e50 'guint8=tvb_get_guint8() + 2' can wrap. Use 'gint=...' instead. ditto for 'gint16=...' 
Also:
 - remove unneeded #include;
 - Remove unneeded check_col();
 - use val_to_str_const() in several cases.

svn path=/trunk/; revision=39835
 2011-11-14 19:58:12 +00:00
Chris Maynard
5facddf760 The Originator protocol identifier is not present in the "provisioning actions operation -61", only the "session management operatin -60". Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6570. 
svn path=/trunk/; revision=39834
 2011-11-14 19:57:45 +00:00
Anders Broman
f5ca06136a From Martin Kaiser: 
DVB-CI / CI+ dissect X.509 certificates.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6575

svn path=/trunk/; revision=39832
 2011-11-14 19:16:47 +00:00
Guy Harris
bbed650915 Do some more length checking to avoid a dissector bug error. Should fix 
bug 6564.

svn path=/trunk/; revision=39831
 2011-11-14 18:42:11 +00:00
Bill Meier
eed8e49aff Very minor cleanup: remove some unneeded #includes & some trailing whitespace 
svn path=/trunk/; revision=39830
 2011-11-14 18:19:14 +00:00
Anders Broman
34ea886454 [-Wunused-but-set-variable] 
svn path=/trunk/; revision=39829
 2011-11-14 17:35:04 +00:00
Anders Broman
fa5c7f85aa packet-sip.c:1412: warning: 'uri_param_end_offset' may be used uninitialized in this function 
svn path=/trunk/; revision=39828
 2011-11-14 17:27:18 +00:00
Anders Broman
c46bda538d From Johan Wåhl: 
- dissect Route and Via header.
- Dissect URI parameters.

svn path=/trunk/; revision=39827
 2011-11-14 17:10:49 +00:00
Martin Mathieson
8df10bb4b5 Add remaining UMTS RLC primitive parameters preceding RLC payload. 
svn path=/trunk/; revision=39826
 2011-11-14 12:22:54 +00:00
Anders Broman
75afa0bd3f Fix Id tag. 
svn path=/trunk/; revision=39824
 2011-11-14 08:24:47 +00:00
Bill Meier
a42a82ed1d Don't use generic shared function/typedef/struct names; 
Remove unneeded #includes;
Cleanup trailing whitespace.

svn path=/trunk/; revision=39823
 2011-11-13 23:33:47 +00:00
Guy Harris
c32a5e7d8b As we're no longer checking whether we're constructing the Info column, 
we can't bail out early on dissection merely because we're not
constructing the protocol tree, as that would mean we wouldn't construct
the Info column unless we're constructing a protocol tree.

Clean up indentation.

svn path=/trunk/; revision=39821
 2011-11-13 22:44:51 +00:00
Guy Harris
833908d49b The sum of a guint16 and 2 does not necessarily fit in a guint16. Put 
it into a gint, instead.  This should fix bug 6572, by preventing an
infinite loop if the sum in question is 0 modulo 2^16.

svn path=/trunk/; revision=39817
 2011-11-13 01:38:46 +00:00
Bill Meier
9b715d6a99 Various additional fixes .... 
svn path=/trunk/; revision=39815
 2011-11-12 23:25:29 +00:00
Bill Meier
d9e9f429da Fix a formatting error. 
svn path=/trunk/; revision=39814
 2011-11-12 23:03:30 +00:00
Bill Meier
29986f07ed Fix some compile errors and rework some code. 
svn path=/trunk/; revision=39813
 2011-11-12 22:26:06 +00:00
Michael Tüxen
0f1ddc857b Fix compilation if HAVE_LIBGCRYPT is not defined. 
svn path=/trunk/; revision=39812
 2011-11-12 22:03:55 +00:00
Guy Harris
5692f59337 Update URL. 
svn path=/trunk/; revision=39811
 2011-11-12 21:16:43 +00:00
Bill Meier
d38970f73f Remove some unneeded 'if(pinfo)' tests; 
Remove some unneeded forward refs.

svn path=/trunk/; revision=39809
 2011-11-12 20:17:43 +00:00
Bill Meier
f5d913ac84 Fix 2 typos. 
svn path=/trunk/; revision=39808
 2011-11-12 20:14:26 +00:00
Bill Meier
ba8f3f4195 Remove unneeded code. 
svn path=/trunk/; revision=39807
 2011-11-12 19:45:21 +00:00
Bill Meier
cbb32e6b00 Fix 2 typos 
svn path=/trunk/; revision=39806
 2011-11-12 19:27:07 +00:00
Anders Broman
af25c3e77b From Holger Pfrommer: 
Enhancement of Hilscher Analyzer Dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6082

svn path=/trunk/; revision=39804
 2011-11-12 18:01:38 +00:00
Anders Broman
fa7ea2ea34 fix [-Wunused-but-set-variable] 
svn path=/trunk/; revision=39803
 2011-11-12 12:37:38 +00:00
Anders Broman
264975e29c Add a cast. 
svn path=/trunk/; revision=39801
 2011-11-12 11:27:41 +00:00
Alexis La Goutte
292a5b6f93 From Mariusz Okrój and Sebastien Vincent via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6225 
Enhance XMPP Dissector

XMPP is communication protocol that is based on XML.

Existing Jabber dissector has only few filtering possibilities and displays packets in inconvenient way.

This dissector is a result of cooperation with Jitsi community as Google Summer of Code project (http://www.jitsi.org/index.php/GSOC2011/XmppWireshark).

From me :
Add Mariusz Okrój in AUTHORS File
Add Modelines information

svn path=/trunk/; revision=39799
 2011-11-12 10:51:01 +00:00
Guy Harris
ac507aa5e7 Add some checks for "character not found"; this should fix some 
fuzz-testing failures we're seeing.

svn path=/trunk/; revision=39795
 2011-11-11 19:07:11 +00:00
Stig Bjørlykke
a0cbfab6bf Fixed abbrev for "Channel rate and type". 
Bug reported by damker.

svn path=/trunk/; revision=39794
 2011-11-11 13:25:48 +00:00
Guy Harris
c356d4f2c1 Get rid of an unused function (dissect_hnbap_AccessResult()). 
svn path=/trunk/; revision=39789
 2011-11-10 23:28:28 +00:00
Anders Broman
ec8806bc8e Set info col for new messages. 
svn path=/trunk/; revision=39787
 2011-11-10 21:44:46 +00:00
Anders Broman
06419848af Update HNBAP to V10.1.0 (2011-06) 
svn path=/trunk/; revision=39786
 2011-11-10 21:38:15 +00:00
Anders Broman
1f9b1347d6 From Martin Kaiser: 
RSASSA-PSS support for X.509 certificates.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6541

svn path=/trunk/; revision=39785
 2011-11-10 20:52:44 +00:00
Anders Broman
e5de258768 packet-sip.c:1442: warning: 'c' may be used uninitialized in this function 
svn path=/trunk/; revision=39783
 2011-11-10 20:38:07 +00:00
Anders Broman
5d97a01889 -Improve dissection of auth items 
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6553)
- Add parameter items to the tree for some  often trunkated lines.

svn path=/trunk/; revision=39782
 2011-11-10 20:16:17 +00:00
Anders Broman
4c379bc979 From Dirk: 
CAPWAP dissector tries to allocate -1 bytes of memory during reassembly.
- changed to return offset.

svn path=/trunk/; revision=39779
 2011-11-10 06:07:16 +00:00
Bill Meier
30cee99009 Fix a number of proto_tree_add_item() encoding args. 
svn path=/trunk/; revision=39774
 2011-11-09 17:33:18 +00:00
Bill Meier
a25e421a10 Fix some [-Wunused-but-set-variable] warnings 
(in some cases by changing proto_tree_add_item() to use
  what appears to be the correct 'tree' arg);
Do whitespace cleanup.

svn path=/trunk/; revision=39772
 2011-11-09 02:48:51 +00:00
Bill Meier
9799f94861 Fix some [-Wunused-but-set-variable] warnings; 
Trailing whitespace cleanup.

svn path=/trunk/; revision=39771
 2011-11-09 01:35:26 +00:00