Commit graph

29 commits

Author SHA1 Message Date
Martin Mathieson
996dc0ad13 Add more packet highlights to the info column.
svn path=/trunk/; revision=39988
2011-11-22 17:57:25 +00:00
Martin Mathieson
4ad5ff513b From Pascal Quantin:
For status Bitmap, don't show FSN in the info column twice.

svn path=/trunk/; revision=39937
2011-11-18 13:42:55 +00:00
Martin Mathieson
556a0558b9 Make it easier to see:
- bitmap entries
- MRW and MRW-ACK
- RESET and RESET-ACK
- when the Poll bit is set for data

svn path=/trunk/; revision=39936
2011-11-18 12:45:50 +00:00
Martin Mathieson
4eaa48f8db Make it easier to see RLIST details.
svn path=/trunk/; revision=39906
2011-11-17 16:47:22 +00:00
Martin Mathieson
67d0be7973 Show meaning of special length indication values in the LI root.
svn path=/trunk/; revision=39901
2011-11-17 12:08:50 +00:00
Martin Mathieson
43bf2f8ba6 Show more sequence numbers in info column, and in root nodes.
svn path=/trunk/; revision=39881
2011-11-16 16:32:40 +00:00
Chris Maynard
e7e9d3d8b7 Rename channel_type enums to avoid possible naming conflicts.
svn path=/trunk/; revision=39865
2011-11-15 19:37:16 +00:00
Martin Mathieson
ed5ac34224 Append important details from LI and SURI trees to root item.
Show some SNs in the info column.

svn path=/trunk/; revision=39852
2011-11-15 15:36:39 +00:00
Martin Mathieson
62d16f0fbb UMTS RLC:
- add lookup for "unknown" channel type dissector (mode is known)
- set length extent for SUFI root item
- show data frames in the info column (at least for AM...)

DCT:
- call RLCDCH with "unknown" channel type (as don't know whether IP or RRC)
- support R9

svn path=/trunk/; revision=39846
2011-11-15 12:03:52 +00:00
Martin Mathieson
ec748afa3a First go at calling UMTS RLC dissector from IxCatapult logs.
Had to change some #defines in the header file (for UDP-framed/heuristic
dissector) - will need to update example sending program later on tonight.

svn path=/trunk/; revision=39656
2011-10-28 18:36:20 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Jeff Morriss
a413376abc From Pascal Quantin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6468 :
The attached patch fixes a memory corruption of the ep_allocated buffer when
building the decoded bitmap.

From me: some reformatting.

svn path=/trunk/; revision=39464
2011-10-19 00:37:52 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman
86878844b6 Show if per packet info is missing.
svn path=/trunk/; revision=39087
2011-09-22 08:59:24 +00:00
Bill Meier
d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Anders Broman
735f48f551 From Pascal Quantin:
allowing Length Indicator 0x7ffb for RLC AM PDUs.

svn path=/trunk/; revision=37644
2011-06-10 08:30:17 +00:00
Anders Broman
318e86e2d7 From Pascal Quantin:
Add the following enhancements to the UMTS RLC dissector
(as specified in 3GPP 25.322 v9.2.0):
- UDP framing protocol to allow dissection of RLC PDUs over UDP (like what is
done for LTE MAC/RLC/PDCP protocols)
- 15 bits Length Indicator support (both with variable and fixed LI size)
- Poll type SUFI
- enhanced dissection of LIST, Relative List and Bitmap SUFI
- dissection of Reset and Reset Ack Control PDU
- an option to decode RLC headers only
- an option to skip SDU reassembly

svn path=/trunk/; revision=37576
2011-06-06 20:01:53 +00:00
Anders Broman
ffae0f912d From Neil Piercy:
Adds BMC protocol, including adding support for MAC and RLC CTCH channels to carry it.
From me:
Removed hf blurbs = def and removed check_col added tp CMakeList.

svn path=/trunk/; revision=36662
2011-04-16 12:22:16 +00:00
Stig Bjørlykke
a39c0d9577 Added a missing break.
Coverity 492.

svn path=/trunk/; revision=36356
2011-03-27 13:15:14 +00:00
Martin Mathieson
b47c36a4bd Don't assign proto_item pointers that are not used.
Coverity CIDs 1021 & 1022.

svn path=/trunk/; revision=36286
2011-03-23 10:58:24 +00:00
Martin Mathieson
f6ee7d8d4f From Tobias Witek (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5283)
epan/dissectors/packet-umts_fp.c
* Added mac subdissector (MAC) call to HSDSCH TYPE2 frames

epan/dissectors/packet-umts_mac.c
* Added support for HSDSCH TYPE2 frames by means of
        not nibble-shifting (4 bits) the SDU if MAC-ehs is used

epan/dissectors/packet-rlc.c
* Added support for "Use special value of the HE field" (3gpp 25.332-7a0 
9.2.2.7) commonly used for Release 7 HSDPA.
        REMARK: although the specification mandates that the
        special value is only allowed when activated by higher
        layers (RRC), it is interpreted unconditionally. We assume
        this is OK, because a different use in future specifications
        is very unlikely.

epan/dissectors/packet-fp_hint.c
* Added decoding of MAC-ehs indicator for HSDSCH frames
* Bumped fpi->release from 6 to 7 to enable proper
        HSDSCH TYPE2 frame decoding in the UTMS MAC parser.
        In general, this appears not to affect decoding
        of (conformant) FP frames of pevious releases.

svn path=/trunk/; revision=34433
2010-10-08 11:03:08 +00:00
Bill Meier
b9b7b1a57a Keep gcc happy.
svn path=/trunk/; revision=31901
2010-02-16 21:22:55 +00:00
Bill Meier
ae429401e6 Fix a (small) memory leak.
svn path=/trunk/; revision=31899
2010-02-16 20:44:39 +00:00
Guy Harris
7aeb317c1d Squelch more warnings.
svn path=/trunk/; revision=30860
2009-11-08 07:28:39 +00:00
Guy Harris
be5c1a9e27 Squelch compiler warnings.
svn path=/trunk/; revision=30858
2009-11-07 19:56:13 +00:00
Anders Broman
b35647bb57 From Tobias Witek:
Enables correct RRC decoding from RLC.

svn path=/trunk/; revision=30843
2009-11-06 12:09:12 +00:00
Anders Broman
54aa776069 From Tobias Witek:
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

svn path=/trunk/; revision=30838
2009-11-05 21:54:06 +00:00
Bill Meier
d23ecf8afb hf[]: Use NULL for "blurb" instead of dup or empty text string;
#include <stdio.h>, <stdlib.h> not needed.

svn path=/trunk/; revision=30429
2009-10-09 15:22:38 +00:00
Anders Broman
46aa5c44de From Tobias Witek:
New protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321).
This does not currently compile cleanly but checking it in to be worked on.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

svn path=/trunk/; revision=30414
2009-10-09 06:37:48 +00:00