osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
38102 commits 26 branches 0 tags 795 MiB
Commit graph

53 commits

Author SHA1 Message Date
Bill Meier
54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier
293049dfba Do some conversions of proto_tree_add_item() 'encoding' arg. 
(previously missed).

    57   FT_BOOLEAN:       FALSE-->ENC_BIG_ENDIAN
    31   FT_BOOLEAN:       TRUE-->ENC_LITTLE_ENDIAN

    10   FT_BYTES:         ENC_BIG_ENDIAN-->ENC_NA
     1   FT_BYTES:         ENC_LITTLE_ENDIAN-->ENC_NA
    21   FT_BYTES:         FALSE-->ENC_NA
     2   FT_BYTES:         TRUE-->ENC_NA

     2   FT_IPXNET:        ENC_BIG_ENDIAN-->ENC_NA

     6   FT_IPv6:          ENC_BIG_ENDIAN-->ENC_NA
     1   FT_IPv6:          FALSE-->ENC_NA

     6   FT_NONE:          ENC_BIG_ENDIAN-->ENC_NA
    19   FT_NONE:          FALSE-->ENC_NA
     3   FT_NONE:          TRUE-->ENC_NA

     1   FT_STRING:        ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA
     1   FT_STRING:        ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA
     5   FT_STRING:        FALSE-->ENC_ASCII|ENC_NA
     1   FT_STRING:        TRUE-->ENC_ASCII|ENC_NA

     4   FT_STRINGZ:       ENC_NA-->ENC_ASCII|ENC_NA
     8   FT_STRINGZ:       FALSE-->ENC_ASCII|ENC_NA

     1   FT_INT32:         FALSE-->ENC_BIG_ENDIAN
     1   FT_INT32:         TRUE-->ENC_LITTLE_ENDIAN

    11   FT_UINT8:         0-->ENC_BIG_ENDIAN
   111   FT_UINT8:         FALSE-->ENC_BIG_ENDIAN
    17   FT_UINT8:         TRUE-->ENC_LITTLE_ENDIAN
     1   FT_UINT16:        0-->ENC_BIG_ENDIAN
    68   FT_UINT16:        FALSE-->ENC_BIG_ENDIAN
    18   FT_UINT16:        TRUE-->ENC_LITTLE_ENDIAN
     4   FT_UINT24:        FALSE-->ENC_BIG_ENDIAN
    70   FT_UINT32:        FALSE-->ENC_BIG_ENDIAN
     1   FT_UINT32:        TRUE-->ENC_LITTLE_ENDIAN
     4   FT_UINT64:        FALSE-->ENC_BIG_ENDIAN
     1   FT_UINT64:        TRUE-->ENC_LITTLE_ENDIAN

     1   FT_UINT_STRING:   FALSE-->ENC_ASCII|ENC_BIG_ENDIAN


svn path=/trunk/; revision=39442
 2011-10-16 23:38:49 +00:00
Bill Meier
126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier
20aa78a1d2 Fix a benign bug: Use correct proto_tree_add_item() encoding arg. 
svn path=/trunk/; revision=39384
 2011-10-12 15:02:11 +00:00
Bill Meier
67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
 2011-10-10 00:39:31 +00:00
Bill Meier
4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Martin Mathieson
5aeb03334c Use val_to_str_const(). 
svn path=/trunk/; revision=39109
 2011-09-23 17:02:56 +00:00
Jeff Morriss
339136d1d0 Based on patch from Denis Ovsienko via 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 :

Fix typo: s/unkown/unknown/

svn path=/trunk/; revision=38561
 2011-08-16 13:16:33 +00:00
Martin Mathieson
c2dadba8f4 From Pascal Quantin (bug 6159). 
When decoding drb payload, call IPv4, IPv6 or data dissector as appropriate.

Am slightly concerned that we always dereference the first byte of the frame - is it safe to assume that the length can't be 0?

svn path=/trunk/; revision=38199
 2011-07-25 13:47:26 +00:00
Martin Mathieson
be1334ed8f Fix bug 6160. 
Use correct string to search for RRC BCH dissectors.

svn path=/trunk/; revision=38198
 2011-07-25 13:34:40 +00:00
Martin Mathieson
7d7f7d870e Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP. 
svn path=/trunk/; revision=38131
 2011-07-20 12:19:22 +00:00
Martin Mathieson
33a21986f1 Trivial: add a couple of newlines. 
svn path=/trunk/; revision=37941
 2011-07-08 16:10:25 +00:00
Bill Meier
91191c6c00 Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings; 
(Code commented out since it may be required in the future (at least in some cases).

svn path=/trunk/; revision=37723
 2011-06-20 01:13:21 +00:00
Jakub Zawadzki
ed59c450f4 Cleanup: replace se_alloc+memcpy combo with single se_memdup(). 
svn path=/trunk/; revision=36996
 2011-05-05 06:55:12 +00:00
Martin Mathieson
b138ffa9e7 Avoid some unnecessary assignments (as reported by clang). 
svn path=/trunk/; revision=36204
 2011-03-16 23:18:59 +00:00
Martin Mathieson
4d3d029e09 Remove some instances of _U_ where the parameter is now used. 
svn path=/trunk/; revision=36148
 2011-03-06 23:10:28 +00:00
Martin Mathieson
7d5ffdb44b Show some top-level info about PDCP frame in protocol root. 
Especially useful when PDCP is called from RLC.

svn path=/trunk/; revision=35815
 2011-02-04 11:47:38 +00:00
Jeff Morriss
61317d2dbd Remove an unreached return. 
svn path=/trunk/; revision=35390
 2011-01-05 22:33:25 +00:00
Martin Mathieson
fa74c2694c Add current list of ROHC profile names, taken from: 
http://www.iana.org/assignments/rohc-pro-ids/rohc-pro-ids.txt

As raised by bug 5536, we now at least show which profile is present.
Supporting all of the specific message types is another matter...

svn path=/trunk/; revision=35314
 2010-12-31 00:24:50 +00:00
Martin Mathieson
77cf0462dc From Pascal Quantin: 
I just found a small bug in LTE PDCP dissector with current top of tree.
If global preference global_pdcp_dissect_user_plane_as_ip is set to true, the dissector will try to decode an IP frame even with signalling plane.
PDCP-LTE
    ...0 0000 = Seq Num: 0
    Signalling Data: 0800183aa808
    MAC: 0x00000000 (0)
[Malformed Packet: IP]
    [Expert Info (Error/Malformed): Malformed Packet (Exception occurred)]

With the attached patch, I get the correct output for both signalling and user plane PDUs.

svn path=/trunk/; revision=35076
 2010-11-30 15:10:17 +00:00
Martin Mathieson
74a74645b1 Add sequence analysis for PDCP, based upon RLC/UM. 
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).

svn path=/trunk/; revision=35000
 2010-11-22 13:28:49 +00:00
Martin Mathieson
76bc0e537b Pass ueid + channel-info into PDCP dissector. 
This will allow me soon to track per-channel sequence numbers...

svn path=/trunk/; revision=34793
 2010-11-05 18:00:35 +00:00
Martin Mathieson
3c5b012771 Don't allocate context struct until/unless heuristic signature string matches. 
svn path=/trunk/; revision=34752
 2010-11-02 15:17:58 +00:00
Jeff Morriss
f5d3a16225 Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts. 
svn path=/trunk/; revision=34725
 2010-10-30 18:18:12 +00:00
Bill Meier
4d56c5b57b Define a variable as static; Minor code simplification. 
svn path=/trunk/; revision=34461
 2010-10-10 20:28:22 +00:00
Jeff Morriss
cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34230
 2010-09-24 02:51:40 +00:00
Jeff Morriss
0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Martin Mathieson
28681e2200 From Pascal Quantin: Add offset of 1 to FMS. 
svn path=/trunk/; revision=33467
 2010-07-07 17:13:53 +00:00
Martin Mathieson
97df849b98 Add new strings/dissector function for signalling RRC messages that will add 
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

svn path=/trunk/; revision=33251
 2010-06-18 07:07:55 +00:00
Martin Mathieson
f1f528deeb From Pascal Quantin: fid some LTE MAC and PDCP typos 
svn path=/trunk/; revision=31661
 2010-01-25 16:45:46 +00:00
Stig Bjørlykke
c198fc6546 From Didier Gautheron via bug 4419: 
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
 2010-01-25 11:47:39 +00:00
Martin Mathieson
63fc401318 From Pascal Quantin: add PDCP framing method over UDP. 
svn path=/trunk/; revision=31243
 2009-12-11 14:31:40 +00:00
Martin Mathieson
1a46552674 Allow LTE RRC dissector to call PDCP/RRC dissectors as appropriate for signalling PDUs. 
svn path=/trunk/; revision=30971
 2009-11-16 15:35:56 +00:00
Martin Mathieson
af67d9d1d8 Status report bitmap can be empty, so add test. 
svn path=/trunk/; revision=30555
 2009-10-13 13:52:23 +00:00
Kovarththanan Rajaratnam
633bb05380 Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL 
svn path=/trunk/; revision=30088
 2009-09-23 14:43:23 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining() 
svn path=/trunk/; revision=29446
 2009-08-16 12:36:22 +00:00
Martin Mathieson
29d6ae0ed5 Remove calls to check_col(). 
svn path=/trunk/; revision=29079
 2009-07-13 11:23:40 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Martin Mathieson
ab7a96c2e6 Trivial: add spaces to info column string text. 
svn path=/trunk/; revision=28703
 2009-06-11 14:05:31 +00:00
Martin Mathieson
4e6962056a Don't dissect IP-ID and UDP checksum for IR, IR-DYN frames. 
Name hf items and filter strings to consistently include "rohc"

svn path=/trunk/; revision=28539
 2009-05-31 12:11:44 +00:00
Martin Mathieson
8315e941ac Add a few more missing ROHC RTP fields. 
svn path=/trunk/; revision=28413
 2009-05-19 17:26:14 +00:00
Martin Mathieson
4dda12f0be - add direction filter to PDCP 
- fix PDCP fields ("pdcp.*" -> "pdcp-lte.*")
- improve PDCP info column output (to be more like RLC)

svn path=/trunk/; revision=28342
 2009-05-13 09:36:42 +00:00
Martin Mathieson
ea18cc4095 Enable preference to call LTE RRC for data inside PDCP frames. 
svn path=/trunk/; revision=28329
 2009-05-11 15:19:51 +00:00
Martin Mathieson
76332049f8 Rename lis to fms & some ROHC feedback format improvements. 
svn path=/trunk/; revision=28322
 2009-05-08 23:29:42 +00:00
Bill Meier
79a1441582 FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...). 
svn path=/trunk/; revision=28317
 2009-05-08 20:35:57 +00:00
Martin Mathieson
7bff5bf554 The abbreviation is "TOHC", not "RoHC". 
svn path=/trunk/; revision=27700
 2009-03-11 12:04:58 +00:00
Martin Mathieson
e6662f6223 Set and use 'plane' more carefully. 
svn path=/trunk/; revision=27488
 2009-02-20 10:17:52 +00:00
Martin Mathieson
34423cbcc3 From Vincent Helfre: 
#define some constants, and move constants into header files.
Hopfully this will make it easier for these dissectors to be reused.

svn path=/trunk/; revision=27487
 2009-02-19 22:25:36 +00:00