Commit graph

2987 commits

Author SHA1 Message Date
Martin Mathieson
0426247b20 Add 422 "Session Timer Too Small" response code from RFC 4028
svn path=/trunk/; revision=22222
2007-06-29 10:47:46 +00:00
Stephen Fisher
ce7d9544ce Fix a bug where you couldn't save individual packets from a file type that
Wireshark doesn't support writing to.  The default in the drop-down menu
was libpcap, but since gtk_option_menu_set_history() doesn't send the
activate signal we set up earlier, you would have to manually click on the
drop-down and reselect libpcap for it to work.  Now it works as expected.


svn path=/trunk/; revision=22214
2007-06-27 23:26:24 +00:00
Gerald Combs
12b9651ce9 In the wireless key management dialog, apply the 802.11 preferences when
the "OK," "Apply," or "Cancel" buttons are pressed.  Remove some duplicate
code.  Add a comment about "Cancel" not working as expected.

svn path=/trunk/; revision=22211
2007-06-27 21:03:25 +00:00
Gerald Combs
4345560f29 If we have problems with "Save All" in the HTTP object list, show a single
error dialog instead of one dialog per unsaved file.

svn path=/trunk/; revision=22198
2007-06-27 05:39:13 +00:00
Stephen Fisher
1f786cac31 Updates to initial check-in of pixmap saving feature:
- Bump minimum GTK version from 2.4 to 2.6 in code and users manual
 - Free some strings after we're done with them 
 

svn path=/trunk/; revision=22170
2007-06-23 05:58:01 +00:00
Stephen Fisher
0ba44094e6 Fix enhancement bug #1337: Export IO Graphs
This new code adds a save button to the Statistics IO Graphs window and
is also reusable by any other code that uses GDK Pixmaps to draw graphs.
The Gdk-pixbuf library included in GTK is used for this save function.


svn path=/trunk/; revision=22166
2007-06-22 22:22:10 +00:00
Ronnie Sahlberg
946af07b3a gtk1 does not have gtk_window_get_modal
svn path=/trunk/; revision=22120
2007-06-17 19:57:47 +00:00
Ronnie Sahlberg
cf1eb444f4 column_entry_changed_cb is not used by the GTK1 code. ifdef it out for
gtk1


svn path=/trunk/; revision=22119
2007-06-17 19:51:20 +00:00
Stephen Fisher
c4ba5ad2b0 Fix bug #1334 and a problem where a user couldn't interact with the
filter dialog's add expression dialog when going to it through file->open
or file->merge (because dialogs in between are set to modal).


svn path=/trunk/; revision=22115
2007-06-17 00:54:58 +00:00
Jaap Keuter
db0a89220f Just keep it simple.
svn path=/trunk/; revision=22081
2007-06-12 18:43:24 +00:00
Gerald Combs
e9f1a0b692 One more step in privilege separation.
Add a capture_interface_list(), which works similar to
get_interface_list() except that it forks dumpcap instead of calling
the pcap routines directly.  Use it in the GUI.

Add a "-I" flag to dumpcap, which prints out verbose interface
information.

Tested under Windows and Linux.

svn path=/trunk/; revision=22071
2007-06-11 03:58:58 +00:00
Stephen Fisher
d1d72fd232 Fix for bug #93: changes to the columns has no effect until restart
These changes allow the packet list clist to be destroyed and recreated
with the new column titles/values/order that the user changed in the
preferences without restarting Wireshark. 


svn path=/trunk/; revision=22038
2007-06-04 20:15:10 +00:00
Bill Meier
a6dab6d644 (Minor) Use _WIN32 (instead of WIN32) like the rest of Wireshark
svn path=/trunk/; revision=22030
2007-06-03 16:07:07 +00:00
Stephen Fisher
2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00
Stephen Fisher
c638ab8e6d Fix bug #1530 this time for GTK1 builds.
svn path=/trunk/; revision=22009
2007-05-30 19:43:33 +00:00
Stephen Fisher
d3454df68a Update to revision 22000: change #if GTK_MAJOR_VERSION > 2 to >= 2
svn path=/trunk/; revision=22001
2007-05-30 03:28:12 +00:00
Stephen Fisher
6049eda556 Wrap call to gtk_window_set_destroy_with_parent() within check for GTK_MAJOR_VERSION > 2 to get the Windows build-bot going again. This means that bug #1530 has to be reopened awaiting a fix that covers GTK1 also.
svn path=/trunk/; revision=22000
2007-05-30 02:37:37 +00:00
Stephen Fisher
5eb2b42d30 Fix for bug #1530: Graph Analysis window misbehaves if Flow Window that
created it is closed.

The fix is to close the graph analysis window when the flow graph setup
window is closed since closing the flow graph window first destroys all
of the data structures.


svn path=/trunk/; revision=21994
2007-05-29 23:09:09 +00:00
Guy Harris
5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris
d2ac4f7133 Check for G_GINT64_MODIFIER in Wireshark as we do in Wiretap.
In all the places where a cast to "long long" or "unsigned long long"
was done, use G_GINT64_MODIFIER and get rid of the cast, as

	1) there's no guarantee that "%ll" works

and

	2) there's no guarantee that "long long" works

(the latter definitely does *NOT* work with MSVC++; the former doesn't
work with regular printf in MSVC++, but it might work with the GLib
printf-based functions).

svn path=/trunk/; revision=21978
2007-05-29 06:56:07 +00:00
Sebastien Tandel
76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Sebastien Tandel
d3d3f9bc68 fix warnings for gcc 4.2
svn path=/trunk/; revision=21974
2007-05-29 02:29:38 +00:00
Guy Harris
944d2e5487 Squelch some qualifier (const vs. non-const) warnings.
svn path=/trunk/; revision=21938
2007-05-25 19:13:49 +00:00
Gerald Combs
b6408d1673 As Martin pointed out, we were comparing the wrong variable against our
modifier mask (and using the wrong bitwise operator to boot).

svn path=/trunk/; revision=21937
2007-05-25 17:24:35 +00:00
Luis Ontanon
11f06217ce Have editcap and capinfos loading the wiretap plugins.
epan/filesystem.c
   have get_plugin_dir() calling init_plugin_dir() if necessary

epan/epan.c and epan/report_err.c
   move the report_failure family into the new report_err.c file, have epan_init() calling the initializer

epan/plugins.h and epan/proto.c
   do not have init_plugins() calling the proto_reg functions instead do it in init_proto()

gtk/main.c and tshark.c
   init_plugin_dir() has become suprefluous

capinfos.c and editcap.c
   load the wiretap plugins

Makefiles
   do what's needed to build withe the above changes.




svn path=/trunk/; revision=21935
2007-05-25 17:22:32 +00:00
Luis Ontanon
c22f70ec1b - epan/uat.h: change the UAT_PROTO_DEF macro to handle both the name of the dissector and the handle
- packet-user_encap.c: use the new UAT_PROTO_DEF
- gtk/uat_gui.c:  change the order of "containment" of the widgets to have the clist fields sized to the scrolledwindow instead of the whole window


svn path=/trunk/; revision=21934
2007-05-25 16:47:22 +00:00
Luis Ontanon
869732d121 Prepare wireshark and tshark for wiretap plugins
svn path=/trunk/; revision=21928
2007-05-24 22:26:51 +00:00
Bill Meier
eb61e72efd When computing average: use 0 as avg if divisor=0
svn path=/trunk/; revision=21922
2007-05-24 16:18:33 +00:00
Guy Harris
f33ec96669 Use the same workaround for the absence of rint() in MSVC++ that's used
by the TCP graph code.

svn path=/trunk/; revision=21915
2007-05-24 02:10:49 +00:00
Bill Meier
d4b111408b Fix 'Analyze ! Enabled_Protocols' search to search on correct column.
svn path=/trunk/; revision=21913
2007-05-24 01:05:08 +00:00
Gerald Combs
f4f8079986 Add shortcuts for expanding/collapsing the packet detail.
svn path=/trunk/; revision=21910
2007-05-23 17:12:01 +00:00
Anders Broman
52346caa9c Put in some more, hopfully correct casts.
svn path=/trunk/; revision=21903
2007-05-23 05:27:17 +00:00
Guy Harris
a275df06ba Handle characters with the 8th bit set.
svn path=/trunk/; revision=21902
2007-05-23 01:27:57 +00:00
Guy Harris
f28467c325 Put back some more missing casts.
svn path=/trunk/; revision=21901
2007-05-23 00:28:59 +00:00
Guy Harris
ee3d6b43d5 Put back some casts, and don't use rint() on Windows, in the hopes of
clearing up at least some buildbot errors on Windows.

svn path=/trunk/; revision=21900
2007-05-22 23:56:52 +00:00
Gerald Combs
4b43b48b2c Don't set the focus on the display filter entry when we're passed a
contorl- or alt-modified character.  Fixes bug 1610.

Fixup whitespace.

svn path=/trunk/; revision=21898
2007-05-22 23:06:22 +00:00
Michael Tüxen
ab125d0d43 From Irene Ruengeler: Fix TSN handling in graphs.
svn path=/trunk/; revision=21894
2007-05-22 21:16:30 +00:00
Guy Harris
b66228d28b Don't explicitly set the main window name unless you're changing the
state to "no packets", "file open", or "live capture in progress".

Instead, to update the main window title when the user-specified prefix
for the title changes:

	save the un-decorated title as a data value attached to the main
	window in set_main_window_name();

	have a new routine to update the title, which fetches the
	un-decorated title, decorates it, and sets the title to the
	decorated value.

This fixes bug 1608.

svn path=/trunk/; revision=21876
2007-05-22 02:21:01 +00:00
Stephen Fisher
bd148a7335 Fix bug #1600 in the Win32 file dialog (it was fixed for the GTK file dialog in SVN revision 21807).
svn path=/trunk/; revision=21872
2007-05-22 00:33:46 +00:00
Guy Harris
6559749cd1 Have the follow code keep track of whether there's any data in the TCP
stream, and, if there isn't, pop up a dialog indicating that there isn't
any data in the stream.  This fixes bug 1604.

svn path=/trunk/; revision=21870
2007-05-22 00:00:09 +00:00
Guy Harris
a3d3282e64 Have init_progfile_dir() also check whether
WIRESHARK_RUN_FROM_BUILD_DIRECTORY is set and, if so and we weren't run
with special privileges, set the running_in_build_directory_flag.  Have
it do the same if it finds ".libs" in the pathname of the program and we
weren't run with special privileges, as that means it was probably run
from the libtool wrapper script and presumably thus isn't an installed
binary.

This means that get_credential_info() has to be called before
init_progfile_dir().

Clean up some indentation.

svn path=/trunk/; revision=21866
2007-05-21 20:31:45 +00:00
Guy Harris
11d553e9ce Convert the arguments to if_list_comparator_alph() to if_info_t *'s
early on, and use the converted versions.

#if 0 out the error dialog for CANT_GET_AIRPCAP_INTERFACE_LIST, rather
than commenting it out - it's a bit easier to un-out the code, and you
don't have to worry about whether there's a comment in the stuff being
xxx-outed.

svn path=/trunk/; revision=21838
2007-05-19 22:00:09 +00:00
Jaap Keuter
3e0d91c307 Get the build going.
svn path=/trunk/; revision=21833
2007-05-19 10:59:44 +00:00
Gerald Combs
55d2b928c2 From Dustin Johnson:
- Update the wireless/AirPcap GUI code to support 802.11n as well as
    some related upcoming code changes.
  - Remove airpcap.h from the repository, since it exists in the AirPcap
    devpack (and will be superseded Real Soon Now).
  - Show the individual channel flag bits in radiotap.
  
Fix the 802.11n MCS set display.

This is a partial checkin, so hopefully nothing is broken.

svn path=/trunk/; revision=21831
2007-05-18 21:06:20 +00:00
Gerald Combs
17271f0879 When saving an RTP stream, don't insert silence if our packet has a
wrong timestamp.  Place a cap on the amount of silence that we do
insert.  This should fix bug 1580.

Update the release notes.

svn path=/trunk/; revision=21818
2007-05-17 18:41:07 +00:00
Gerald Combs
a779f0cfd7 Queue a redraw event in packet_list_clear(). This seems to fix the
incorrect redraw behavior when the packet list length is less than the
widget height.

svn path=/trunk/; revision=21816
2007-05-17 17:38:11 +00:00
Gerald Combs
997b60df05 Decrease the refresh time to 100ms. This seems to make the splash
screen updates a little more smooth without affecting the startup
time for remote sessions.

svn path=/trunk/; revision=21815
2007-05-17 17:15:51 +00:00
Stephen Fisher
9a0ecd31d1 Fix bug #1548: call of "Protocol Preferences" results in GTK error msg
at the command line


svn path=/trunk/; revision=21808
2007-05-16 21:45:02 +00:00
Stephen Fisher
dba14a4f17 Fix bug #1600: Merge feature from File menu does'nt do what it should
(append vs prepend)


svn path=/trunk/; revision=21807
2007-05-16 20:19:30 +00:00
Ronnie Sahlberg
0491f613c8 dont use g_time_add_val() since it is not available in gtk1
svn path=/trunk/; revision=21798
2007-05-16 00:55:47 +00:00