Commit Graph

724 Commits

Author SHA1 Message Date
Gilbert Ramirez cb61bf1ede Fixed segfault with combination of new dfilter struct usage, rfcode,
and File | Open option.

svn path=/trunk/; revision=489
1999-08-14 18:51:26 +00:00
Gilbert Ramirez 2287f6de4e Added dfilter-int.h to list of deliverables.
svn path=/trunk/; revision=488
1999-08-14 06:42:36 +00:00
Gilbert Ramirez 8030084e93 Modified YACC grammar to use non-yy symbols, to avoid conflicts with
libpcap's that were compiled with symbols beginning with 'yy'.

svn path=/trunk/; revision=487
1999-08-14 06:24:27 +00:00
Guy Harris 6572382f9a Have the "delta" format for time stamps show the time delta between a
packet and the previous *displayed* packet, rather than the previous
packet in a capture.

svn path=/trunk/; revision=486
1999-08-14 04:23:22 +00:00
Guy Harris c7a00d29f8 Fix up the code that changes the "command-line-specified" time format to
handle a display with a display filter.

(Also, don't have it recompute the time stamps - they were computed when
the packet was added to the packet list in the first place.)

svn path=/trunk/; revision=485
1999-08-14 03:36:30 +00:00
Guy Harris edb0a778ed Enable the "Display/Options" menu item when we're capturing with "-S",
so you can change the time stamp column while you're capturing.

svn path=/trunk/; revision=484
1999-08-14 01:33:29 +00:00
Guy Harris fa50f8aa46 In "change_time_formats()", you have to set "fd->cinfo" before you can
use "check_col()", otherwise "check_col()" always fails, and the time
column never gets changed.  (How did I manage to break that?)

svn path=/trunk/; revision=483
1999-08-14 01:27:29 +00:00
Gilbert Ramirez 719c7f3ab2 Removed unneeded 'color' field from header_field_info.
svn path=/trunk/; revision=482
1999-08-14 01:26:39 +00:00
Gilbert Ramirez cd55daeefa Added Brad's <brad@openbsd.org> patch to fix compilation from
separate directory.

svn path=/trunk/; revision=481
1999-08-13 23:52:49 +00:00
Gilbert Ramirez ab6490398c Moved global memory alloction used in display filters (which was stored
in dfilter-grammar.y) to a new struct dfilter. Display filters now have
their own struct, rather than simply being GNode's. This allows multiple
display filters to exist at once, aiding John McDermott in his
work on colorization.

svn path=/trunk/; revision=480
1999-08-13 23:47:43 +00:00
Guy Harris a5acc58fe3 Create a "dfilter-int.h" file, containing stuff used internally to the
display filter code but not outside it (and not static to one of the
modules in the display filter code), with most of that stuff moved there
from "dfilter.h".

Add a declaration of "byte_str_to_guint8_array()" to "dfilter-int.h".

svn path=/trunk/; revision=479
1999-08-12 21:16:32 +00:00
Gilbert Ramirez 6c9276f03c One small regex change, just to be safe.
svn path=/trunk/; revision=478
1999-08-12 15:20:18 +00:00
Gilbert Ramirez 336b94f506 Fixed two bugs in display filter parsing.
1. Some IP addresses (like 0.0.0.0) would be interpreted as byte ranges.
2. Parens were being ignored.

Thanks to Guy for pointing these out to me.

svn path=/trunk/; revision=477
1999-08-12 15:10:48 +00:00
Guy Harris 2fd7555110 "file_sel_ok_cb()" isn't used except with the "File/Open" dialog box;
rename it to "file_open_ok_cb()", move it next to the routine to create
that dialog box, and make it static.

svn path=/trunk/; revision=476
1999-08-12 07:36:41 +00:00
Gilbert Ramirez f5d36ff3cd Added Ashok's fix for RSVP and support for RSVP+.
svn path=/trunk/; revision=475
1999-08-12 05:19:06 +00:00
Guy Harris 0b424dc9b9 The "-R" command-line filter is applied when reading the capture file;
it's not a display filter (packets that don't match the filter are
discarded completely, not just filtered out of the display), although it
has the same syntax as a display filter.

svn path=/trunk/; revision=473
1999-08-11 20:10:38 +00:00
Guy Harris d31ad7cb55 The changes to file loading decreased file loading time rather than
increasing it.

svn path=/trunk/; revision=472
1999-08-11 20:08:32 +00:00
Gilbert Ramirez 499eff7b0d Changed two #include <>'s to #include "" 's, for stylistic reasons only.
svn path=/trunk/; revision=471
1999-08-11 17:02:28 +00:00
Gilbert Ramirez d42b2df23f Fixed packaging problem (the list of deliverables in the doc/ directory).
Updated NEWS file.
Moved version to 0.7.2 for imminent release.

svn path=/trunk/; revision=470
1999-08-11 16:42:51 +00:00
Gilbert Ramirez 8b3ee0f761 Modified the flex scanner to use symbols that start with "dfilter_"
instead of "yy". (dfilter-grammar.y was modified to #define yylex as
dfilter_lex).

VERSION is no longer needed since the doc/Makefile now uses @VERSION@,
passed to it from 'configure'.

svn path=/trunk/; revision=469
1999-08-11 16:25:07 +00:00
Gilbert Ramirez c0fa3841ee Modified autoconf/automake files for doc subdirectory so that all of
Ethereal can be compiled in a build directory separated from the source
directory.

svn path=/trunk/; revision=468
1999-08-11 16:05:19 +00:00
Guy Harris 0d5e441ea0 Display counts of NetBEUI/NBF frames as "NetBIOS".
svn path=/trunk/; revision=467
1999-08-10 20:13:21 +00:00
Guy Harris 37ddd5f5ed Jeff Foster's changes to add support for NetBEUI/NBF (NetBIOS atop 802.2
LLC, the original NetBIOS encapsulation).

svn path=/trunk/; revision=466
1999-08-10 20:06:39 +00:00
Laurent Deniel 64c0d52928 Change the test of pcap_dispatch returned value
which might be -1.

svn path=/trunk/; revision=465
1999-08-10 11:30:03 +00:00
Laurent Deniel 923bc52dc6 Fix the -S option timeout handling:
- when in a live capture mode no packet is received
during a timeout, the displayer process is notified
about any remaining captured packets. Note that this
fix works on Linux only with a patched libpcap.
- remove unnecessary time() call and sync_time
loop_data field.

Thanks to John McDermott for his help during fixing
and testing.

svn path=/trunk/; revision=464
1999-08-10 11:08:38 +00:00
Guy Harris 3f14fd3d7e More whitespace fixups, and fix a typo in a comment.
svn path=/trunk/; revision=463
1999-08-10 07:54:07 +00:00
Guy Harris 16e3dd2e48 Fix up whitespace.
svn path=/trunk/; revision=462
1999-08-10 07:52:54 +00:00
Guy Harris 2dc4a15076 Fix up some comments.
svn path=/trunk/; revision=461
1999-08-10 07:37:38 +00:00
Guy Harris 8eb998e360 Add the ability to specify a filter to be used when reading the file to
the "Open File" dialog box (the "Open File" dialog box equivalent of the
"-R" flag).  Have "load_cap_file()" take the filter expression as an
argument, and make the global "rfilter" into a member of a
"capture_file" structure.

When reading a temporary capture file after a live capture, don't apply
any filter.

Move the code that pops up error boxes on file opens when reading a
capture file back to "load_cap_file()"; it also pops up error boxes if
the filter expression can't be parsed.

Don't enable "File/Save" or "File/Save As..." if an attempt to read a
capture file fails - if there was already an open capture file, it was
closed by "load_cap_file()", so we no longer have an open file to save.

svn path=/trunk/; revision=460
1999-08-10 07:16:47 +00:00
Guy Harris 7ec128ccb2 Initialize the "next" pointer of a "frame_data" structure to NULL before
putting it on the list of frames.

svn path=/trunk/; revision=459
1999-08-10 06:54:12 +00:00
Guy Harris 2563e672c8 Fix the list of descriptions of codes in ICMP Unreachable messages.
svn path=/trunk/; revision=458
1999-08-10 04:57:47 +00:00
Guy Harris 86a8ad1dcd Building a GList by adding elements to the end with "g_list_append()" is
N^2 in the ultimate size of the list (as "g_list_append()" is linear in
the size of the list, at least when used in the way the GLib
documentation says to use it); instead, maintain our own linked list of
"frame_data" structures for all packets read, including a pointer to the
last element.

"gtk_clist_set_row_data()" is linear in the row number, so if it's used
to attach a pointer to the "frame_data" structure for a packet to the
packet list GtkClist row for each packet, that's also N^2 in the number
of packets in that packet list; instead, store the row number in the
"frame_data" structure, and find the packet for a given row by scanning
the list for it (we were already scanning the list linearly to find that
packet's index in the list of all packets; that's only done when a
packet's selected, so it's not *too* bad, but it might be nice to avoid
having to do that scan).

svn path=/trunk/; revision=457
1999-08-10 04:13:37 +00:00
Gilbert Ramirez 5ad4d240bb Fixed a bug in displaying RIF ring/bridge pairs.
svn path=/trunk/; revision=456
1999-08-10 02:54:59 +00:00
Gilbert Ramirez e3e125878f Added John McDermott's patch for handling ICMP Unreachable|Fragmentation
Required packets.

svn path=/trunk/; revision=455
1999-08-09 18:18:38 +00:00
Guy Harris 059d89e65b Jochen Friedrich's patch to add a "-R" flag, which takes a
display-filter syntax expression as an argument, and causes that filter
to be applied to all packets when a capture file is read in; packets
that don't match the filter are discarded.

svn path=/trunk/; revision=454
1999-08-08 01:29:24 +00:00
Laurent Deniel 9f8898726d Allow compilation of ethereal in a directory different than
the source directory. The doc makefile is still broken however.
Thanks to Jan Bernard van Doorn for raising this problem.

svn path=/trunk/; revision=453
1999-08-07 17:28:21 +00:00
Guy Harris 89ff148fd2 A further memory leak fix from Jochen Friedrich.
svn path=/trunk/; revision=452
1999-08-07 01:34:29 +00:00
Guy Harris a7061b9abd Move a comment, to correctly reflect which code in
"clear_tree_and_hex_views()" clears the hext dump window and which code
clears the protocol tree window.

svn path=/trunk/; revision=451
1999-08-07 01:25:04 +00:00
Guy Harris e75a3a4509 Use "strrchr()", rather than "strchr()", to find the '/' in "argv[0]"
before the last component; thanks to Laurent Deniel for catching that one.

svn path=/trunk/; revision=450
1999-08-05 18:20:41 +00:00
Gilbert Ramirez a4f1072770 Changed version to 0.7.1
svn path=/trunk/; revision=448
1999-08-05 17:08:13 +00:00
Gilbert Ramirez ecff53a0de Added a progress bar to the display filter computation. Unfortunately,
try as I might, I couldn't get gtk_timeout_add to work. I read all the docs,
but no luck. So for now I call dfilter_progress_cb for every 20 packets
that are filtered. I'd rather have *something* for the next Ethereal
release than nothing.

I also modified file_progress_cb to use it's local copy of cf rather
than the global copy.

svn path=/trunk/; revision=447
1999-08-05 16:46:04 +00:00
Gilbert Ramirez 6a823008b7 Logical operands needed to set the yylval as well as return the
token to the yacc parser.

svn path=/trunk/; revision=446
1999-08-05 16:42:31 +00:00
Laurent Deniel 2bd5536a7f Use execlp instead of execl to scan the PATH for the
ethereal executable (but this is only performed if
ethereal_path (i.e. arg[0]) does not contain any '/').

svn path=/trunk/; revision=445
1999-08-05 11:12:14 +00:00
Guy Harris eca1e74373 Have Ethereal, when invoked as "ethereal-dump-fields", dump out a
glossary of display filter symbols, just as it does with "-G", except
that, as it can discover that it was so invoked before even looking at
the command-line arguments, it needn't even bother calling "gtk_init()"
to process those command-line arguments GTK+ cares about, and thus
needn't do any X stuff at all when so invoked.

That allows Ethereal to be built in an environment where you don't have
an X server, and, if your connection to your X server is slow, allows
you to built it faster.

Get rid of the "-G" flag, as it had only a somewhat specialized use.

svn path=/trunk/; revision=444
1999-08-05 06:34:43 +00:00
Guy Harris d7dc426092 Patch from Olivier Abad to make it correctly display non-extended
informatino frames.

svn path=/trunk/; revision=443
1999-08-05 06:30:05 +00:00
Guy Harris bbca6ac57a Put in an RCS ID.
svn path=/trunk/; revision=442
1999-08-05 02:26:21 +00:00
Guy Harris 96c27fcae5 Before displaying a packet, clear the tree and hex views; if you
double-click on a packet, it'll select that packet without necessarily
first un-selecting it (this may be a GTK+ 1.0[.x] vs. GTK+ 1.2[.x]
difference; Jeff Jahr said he first saw it when going from Ethereal
0.6.3 to 0.7.0 and going from GTK+ 1.0[.x] to GTK+ 1.2.3, but I saw it
on 0.6.3 with GTK+ 1.2.3 as well).

svn path=/trunk/; revision=441
1999-08-05 00:23:07 +00:00
Guy Harris 621c56ed1e "packet-udp.c" and "packet-x25.c" both have global variables named
"hash_table", but each of them is used only in the file in question;
make them static, so that they don't collide.

svn path=/trunk/; revision=440
1999-08-05 00:05:01 +00:00
Guy Harris 50dbd34d6d Fix a "proto_tree_add_text()" call that should've been a
"proto_tree_add_item()" call (and fix the length passed to it, which, it
appears, has been wrong for ages).

svn path=/trunk/; revision=439
1999-08-05 00:02:55 +00:00
Guy Harris 41a8a32b7b Fix a couple of memory leaks.
svn path=/trunk/; revision=438
1999-08-04 23:43:42 +00:00