Commit graph

12928 commits

Author SHA1 Message Date
Jeff Morriss
d1573b53c0 Don't pass a NULL pointer to what is supposed to be (according to the format) a string: some implementations of vsnprintf() will core on that. (Unfortunately it seems that g_vsnprintf() doesn't protect us from this...)
svn path=/trunk/; revision=32848
2010-05-17 21:49:09 +00:00
Jaap Keuter
5140e8f44e From Lars Ruoff:
Add some more robustness to Alcatel-Lucent vendor specific 
DHCP options and add some new option values.

It now supports all currently implemented option values, i.e.:
{Option Opcode Length (bytes) Content}
AVA 58 (0x3A) 2 Vlanid
IP Touch TFTP1 64 (0x40) 4 IPv4 address
IP Touch TFTP2 65 (0x41) 4 IPv4 address
APPLICATION_TYPE 66 (0x42) 1 0 (noe) / 1 (sip)
SIP URL 67 (0x43) x bytes url string

svn path=/trunk/; revision=32845
2010-05-17 18:48:44 +00:00
Bill Meier
1f1a38f961 From Torrey Atcitty: IEEE 1722(AVB Transport Protocol) Dissector
See Bug #4764 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4764)

svn path=/trunk/; revision=32841
2010-05-17 04:08:08 +00:00
Jeff Morriss
4749e0f19f Move most of the contents of the header file into the .c file.
svn path=/trunk/; revision=32840
2010-05-17 03:01:03 +00:00
Jeff Morriss
8225d821da Remove trailing white space
svn path=/trunk/; revision=32839
2010-05-17 03:00:37 +00:00
Jeff Morriss
a229509b85 From Robert Hogan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3922 :
Add support for the IBM TN5250 data stream protocol.

http://wiki.wireshark.org/TN5250

From me:

Move most of the contents of the header file to the .c file.

Replace blurbs that match the hf name with NULL.
Replace empty-string blurbs with NULL.
Fix some abbreviations (hf_tn5220_xxx -> tn5220.xxx).
Make some functions static.
Cast some offset increments to unsigned to make sure we don't go backwards
(which could create a loop).  This includes making most of the subdissection
functions return an unsigned number.

Use find_or_create_conversation().

svn path=/trunk/; revision=32838
2010-05-17 02:55:51 +00:00
Gerald Combs
667fae7498 [Automatic manuf and enterprise-numbers update for 2010-05-16]
svn path=/trunk/; revision=32832
2010-05-16 15:04:06 +00:00
Jaap Keuter
55528cacba From Chidambaram Arunachalam:
Currently, H.264 dissector in Wireshark allows only one value for the "H264 
dynamic payload type" preference value.
This patch allows users to specify a value range for this parameter (96-127) 
so that both streams can be decoded for a video call with asymmetric rtp 
payload types.

svn path=/trunk/; revision=32831
2010-05-16 10:58:50 +00:00
Jaap Keuter
39e687a79f From Robert Lickenbrock:
Wireshark does not extract the vendor identifier (i.e. the 7th and 8th bytes)
from the header of YMSG packets. The current implementations skips over these
bytes during dissection, presumably because they were believed to be padding.

svn path=/trunk/; revision=32830
2010-05-16 10:28:14 +00:00
Guy Harris
149ccb3b68 Attempt to handle isochronous descriptors between the 64-byte header and
the payload.  Should fix bug 4401.

svn path=/trunk/; revision=32828
2010-05-16 03:19:40 +00:00
Gerasimos Dimitriadis
682b962e72 Use binary search when scanning the SANC and ISPC lists; correct a couple of
double entries in the ISPC lists.

svn path=/trunk/; revision=32822
2010-05-15 20:14:52 +00:00
Guy Harris
ac1b50ba2c Export prefs_capture_device_monitor_mode().
svn path=/trunk/; revision=32821
2010-05-15 20:00:09 +00:00
Guy Harris
e1e576c11b Support monitor mode in the capture preferences.
Use prefs_is_capture_device_hidden() to find out whether a device should
be hidden - don't scan the list of hidden devices ourselves.

svn path=/trunk/; revision=32820
2010-05-15 19:38:13 +00:00
Anders Broman
2de348060c Update to V9.2.0 (2010-03)
svn path=/trunk/; revision=32819
2010-05-15 10:27:45 +00:00
Anders Broman
ef9129b5e6 Update to V9.1.0 (2010-03).
svn path=/trunk/; revision=32818
2010-05-15 09:04:28 +00:00
Anders Broman
874a518ed6 Update to V9.2.0 (2010-03).
svn path=/trunk/; revision=32817
2010-05-15 08:49:39 +00:00
Bill Meier
7a0a969036 From Torrey Atcitty: IEEE 802.1Qat (Multiple Stream Reservation Protocol) dissector
See: Bug #4757: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4757

svn path=/trunk/; revision=32816
2010-05-14 22:55:55 +00:00
Jeff Morriss
a8ca1bb630 From David Aggeler via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4762 :
- Fixed HF to separate signed & unsigned values and to have BASE_DEC all signed 
- Fixed private sequences with undefined length in ILE
- Fixed some spellings in comments

svn path=/trunk/; revision=32815
2010-05-14 21:54:48 +00:00
Anders Broman
f270451b3c Update to V9.2.3 (2010-03)
svn path=/trunk/; revision=32814
2010-05-14 21:50:23 +00:00
Gerasimos Dimitriadis
728f1c516c MNC, SANC and ISPC lists updated up to the latest OB, No 955
svn path=/trunk/; revision=32813
2010-05-14 21:12:48 +00:00
Jeff Morriss
e62b60be7c Rework SMS reassembly:
- Take out the if(tree) because for reassembly to work we need to do the
  reassembly on the first pass.
- Remove the (confusing) "try_dissect_message_fragment" preference (which
  caused us to dissect the message fragments) and replace it with a "reassembly"
  preference.  Dissect the message fragments regardless of whether reassembly is
  enabled or not (it's just SMS).  This solves the user confusion reported in
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4232 .
- Add the text of the SMS using proto_tree_add_string*() so that we an filter on
  the text.

svn path=/trunk/; revision=32812
2010-05-14 19:27:11 +00:00
Bill Meier
e1420c0799 Fix a few usages of "" in the hfp] array 'blurb' field.
svn path=/trunk/; revision=32811
2010-05-14 18:56:28 +00:00
Jeff Morriss
a21b548200 Set SVN properties
svn path=/trunk/; revision=32809
2010-05-14 17:05:50 +00:00
Jeff Morriss
54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out.
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
Guy Harris
68ee036bd2 We already have a link to the IBM version of the 3270 manual; just refer
to that.

svn path=/trunk/; revision=32800
2010-05-14 00:16:59 +00:00
Guy Harris
dcf49bf092 Handle the Set Buffer Address command differently; this gets rid of the
macro with the "give credit" license, so back that out of COPYING.

svn path=/trunk/; revision=32798
2010-05-13 23:56:31 +00:00
Bill Meier
9d44f7c950 (Trivial) A little more whitespace cleanup.
svn path=/trunk/; revision=32797
2010-05-13 22:16:28 +00:00
Bill Meier
44b53b4a50 From Torrey Atcitty: [Dissector Enhancement] Added new functionality to existing 1588v2 dissector to also support IEEE802.1AS.
svn path=/trunk/; revision=32796
2010-05-13 21:47:38 +00:00
Jeff Morriss
e00323a55f Fix up some indentation
svn path=/trunk/; revision=32795
2010-05-13 20:39:56 +00:00
Jeff Morriss
99aa11c6ed Reindent a bit
svn path=/trunk/; revision=32794
2010-05-13 20:31:53 +00:00
Jeff Morriss
81da8e0b6b Use find_or_create_conversation() in some ASN.1 dissectors
svn path=/trunk/; revision=32791
2010-05-13 18:55:31 +00:00
Jeff Morriss
729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Jaap Keuter
951485bf35 From Hadar Shohami:
Add support to option 17 sub option 2171 for Packet Cable 2.0 according to
CL-SP-CANN-DHCP-Reg-I03-090811.doc

svn path=/trunk/; revision=32788
2010-05-13 17:22:53 +00:00
Jeff Morriss
e5372ffb44 Remove some unused hf_ entries
svn path=/trunk/; revision=32786
2010-05-13 15:22:55 +00:00
Jeff Morriss
acc410ae87 From Robert Hogan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4257 :
Correctly decode and display the buffer address in SBA orders.


Note: This includes a macro with a new license which is added to COPYING.

svn path=/trunk/; revision=32785
2010-05-13 15:19:40 +00:00
Anders Broman
2fcc6996c9 Update to V9.2.1 (2010-04)
svn path=/trunk/; revision=32784
2010-05-13 13:29:31 +00:00
Jeff Morriss
d201b3d873 From Tamas Regos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4760 :
Harmless typo bug in diam_dict.l

applictation_start <-> application_start

svn path=/trunk/; revision=32783
2010-05-13 13:29:13 +00:00
Anders Broman
d693d37904 Update to V9.1.0 (2010-03)
svn path=/trunk/; revision=32779
2010-05-13 07:41:35 +00:00
Anders Broman
30ebf4af24 Update to V9.1.0 (2010-03)
svn path=/trunk/; revision=32778
2010-05-13 07:40:31 +00:00
Guy Harris
998677339e Create a new REP_NA value for fields where there are no representations
from which to choose; use that for protocol fields in some protocols
(modify the CORBA generator to use it, and manually update the generated
CORBA dissectors accordingly).

svn path=/trunk/; revision=32777
2010-05-13 00:20:40 +00:00
Guy Harris
308bb550da Instead of using private #defines for the last argument to
proto_tree_add_item(), use the new REP_BIG_ENDIAN and REP_LITTLE_ENDIAN
values.

Use those #defines in variables that represent the byte order, as well.

svn path=/trunk/; revision=32776
2010-05-12 23:45:16 +00:00
Guy Harris
4ff4ebe3c5 Add REP_{BIG,LITTLE}_ENDIAN #defines, for possible future use in
proto_tree_add_item() and field definitions, and for current use if
somebody finds it more self-documenting (some dissectors already have
their own #defines for that purpose).

svn path=/trunk/; revision=32775
2010-05-12 22:35:56 +00:00
Bill Meier
8f7aa8dfd8 (Trivial) Use consistent indentation.
svn path=/trunk/; revision=32773
2010-05-12 17:34:11 +00:00
Jeff Morriss
c8cecb9133 From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4758 :
The HTTP dissector uses strtoll() to convert the Content-Length string into a
64bit variable. But that string can contain a number larger (or less) than
64bit, which lets the strtoll() return INT_MAX (or INT_MIN). strtoll() then
indicates this with errno==ERANGE.

The attachted patch checks if errno is set this way and then treats that HTTP
Content-Length as unspecified, since we don't know the real size.

I haven't checked other occurences of strtoll() in the HTTP dissector if they
could benefit from the errno check, or if other dissectors could use it.

svn path=/trunk/; revision=32772
2010-05-12 13:24:42 +00:00
Anders Broman
96e9317c66 From Tamas Regos:
WSLUA improvement.

The existing ProtoField.bool looks like the following:
ProtoField.bool(abbr, [name], [desc])

But checking any protocol dissector with bool protofield, it can be seen that
in C code we have more options than thru the WSLUA interface.

E.g.: {&hf_gtp_qos_sig_ind,{"Signalling Indication", "gtp.sig_ind", FT_BOOLEAN,
8, TFS(&gtp_sig_ind), GTP_EXT_QOS_SIG_IND_MASK, NULL, HFILL}},

So I've extended ProtoField.bool to have more options like this:
ProtoField.bool(abbr, [name], [bitfield], [true_false_string], [mask], [desc])

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4700

svn path=/trunk/; revision=32771
2010-05-12 10:31:41 +00:00
Anders Broman
0107015266 From Tamas Regos:
Whitspace changes

svn path=/trunk/; revision=32770
2010-05-12 08:08:01 +00:00
Anders Broman
0798092b03 Update to V9.2.0 (2010-03)
svn path=/trunk/; revision=32769
2010-05-12 05:51:54 +00:00
Gerald Combs
eb92458522 From Chris Maynard via bug 4722:
When I submitted the USB and PPP changes, I had not previously tested with a
full insertion of a particular USB device.  Now that I have, I've found that
what used to be reported as an unknown interface class is now reported as a
vendor specific interface class.  Thus, in order for PPP/USB dissection to
work, the ppp dissector must register for that class as well.  The attached
trivial patch does just that.

svn path=/trunk/; revision=32768
2010-05-12 04:03:07 +00:00
Jaap Keuter
23b4509d1b Straighten out field type names.
svn path=/trunk/; revision=32765
2010-05-11 21:46:17 +00:00
Gerasimos Dimitriadis
6aca16986c Grinding through the Operational Bulletins:
SANC and ISPC lists updated up to OB No 949

svn path=/trunk/; revision=32764
2010-05-11 21:40:33 +00:00