Fixed a bug where a one character comment would skip the interface.
If syntax error in the comment just skip the comment instead of the interface.
svn path=/trunk/; revision=25413
testing version of GLib; it doesn't appear to exist in any current
versions. There's no need to "gracefully" handle NULL (whatever
"gracefully" means in this context - NULL compares less than any real
string?), as we already checked whether mac_name is null, and we're
comparing it against a string constant; just use strcmp().
In ssh_gslist_compare_strings(), check for null pointers for now.
strcmp() (and strcmp-alikes) don't return a boolean, they return a value
such that comparing strings with a particular operator is done by
comparing the result of strcmp() with 0 using that operator; do that, to
make it clearer that the strings are being compared for equality.
svn path=/trunk/; revision=25402
g_mallocated string, so it's not const.
Fix a comment to reflect reality (err_info is some additional
information about the error returned by Wiretap, e.g. some gory details
about the error, mainly useful to developers and support people).
svn path=/trunk/; revision=25401
are expected to return a g_mallocated error string; that's why they fill
in a gchar **, not a const gchar **. g_strdup() the argument to
KERROR(), so it's g_mallocated.
svn path=/trunk/; revision=25398
the types of read and seek_read routines in Wiretap are supposed to be,
and get rid of the casts of pointers to those functions (type problems
should be fixed, not papered over with casts, whenver possible).
svn path=/trunk/; revision=25393
argument, as
1) it doesn't modify the string that argument points to
and
2) it's a buffer of "char".
Use g_ascii_xdigit_value() and put the values of the two bytes together
ourselves; strtoul() is a bit of overkill for two-hex-digit pairs.
While we're at it, check for invalid hex digits, and for bytes where
only one hex digit is present.
svn path=/trunk/; revision=25392
clamped at TIME_T_MIN and TIME_T_MAX, but newer versions of GCC
"helpfully" warn that the usual checks for overflow or underflow "can't
fail").
svn path=/trunk/; revision=25391
since rev 17756, meant that attempts to read iSeries files would fail in the
"Make sure it [pkt_encap] is not WTAP_ENCAP_PER_PACKET" assertion in
wtap_read().
Also set file_encap to WTAP_ENCAP_ETHERNET (instead of WTAP_ENCAP_PER_PACKET)
since it seems that all the packets in iSeries files are Ethernet (or at least
this module currently only supports Ethernet).
svn path=/trunk/; revision=25388
I was counting the length without the terminating NULL, and didn't want one to be written to the string and copied into the file.
svn path=/trunk/; revision=25383
Dissector for given SNAC has a bug with actual sizeof of rate_class and
rate_group structure. So in UI clicking on 'Available Rate Classes' and
concrete 'Rate Group 0x??' items in decoded packet window higlight incorrect
bytes in hexdump window.
svn path=/trunk/; revision=25374
Wimax vals_tek_encryption_ids does not confirm the latest spec. Zero should be
"No TEK encryption" instead of "Reserved".
svn path=/trunk/; revision=25367
Stig Bjørlykke