Commit Graph

21 Commits

Author SHA1 Message Date
Bill Meier 77d86cadf5 From Yaniv Kaul:
Some fixes for 'set but not used' errors that GCC 4.6 emits.
From me:
  Remove uneeded #include <stdlib.h>, <gmodule.h>;
  Do some whitespace cleanup.

svn path=/trunk/; revision=36902
2011-04-27 16:29:09 +00:00
Stephen Fisher e7a716144d Use _U_ for unused function parameters instead of assigning a variable
to itself.  Found by clang compiler.


svn path=/trunk/; revision=36813
2011-04-22 15:53:34 +00:00
Bill Meier 51bae2f9f8 Use {'0', ...} type initializer for fixed length character arrays.
svn path=/trunk/; revision=35735
2011-01-31 21:45:16 +00:00
Jeff Morriss abe40cfaf1 Remove a break that makes other following statements unreached.
svn path=/trunk/; revision=35388
2011-01-05 22:26:43 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Guy Harris bfe08e2b9f Squelch a compiler warning.
Just make dtmf_digits and bcd_digits arrays; no need for the extra level
of indirection.

svn path=/trunk/; revision=32413
2010-04-07 00:39:35 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Anders Broman 440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Gerald Combs 0cceb40317 Remove some unused variables.
svn path=/trunk/; revision=29242
2009-07-30 00:40:32 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman e9b0866d94 From Michael Lum:
Fixed SPC digit translation
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3213

svn path=/trunk/; revision=27275
2009-01-20 19:41:29 +00:00
Guy Harris cb07614fec Fix some warnings.
svn path=/trunk/; revision=27251
2009-01-16 22:20:10 +00:00
Anders Broman 234b31b986 From Michael Lum:
Brought up to date with version C of the specification
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3204

svn path=/trunk/; revision=27250
2009-01-16 20:20:21 +00:00
Stig Bjørlykke d0e33bc3c5 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26646
2008-10-31 14:07:23 +00:00
Bill Meier 61465d4141 Fix some of the Errors/warnings detected by checkapi
svn path=/trunk/; revision=25274
2008-05-11 17:27:41 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jörg Mayer b8d33c4add Fix >2600 warnings by doing char -> const char changes.
Additionally in dissectors/packet-ansi_map.c:
        Flag unused parameters as such and remove dummy
        param = param;
        statements.

svn path=/trunk/; revision=15114
2005-07-27 07:57:01 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Ulf Lamping 7589aef14f packet-ansi_683.c(93) : warning C4090: 'return' : different 'const' qualifiers
svn path=/trunk/; revision=14769
2005-06-26 10:48:27 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00