Commit graph

12143 commits

Author SHA1 Message Date
Anders Broman
d86c200706 From Martin Isaksson:
PDCP PDU number extension header support.

svn path=/trunk/; revision=37880
2011-07-03 19:16:21 +00:00
Guy Harris
338af96b2e Add a tvb_get_ephemeral_string_enc() routine that's like
tvb_get_ephemeral_string() but takes an ENC_ value for the character
encoding.  Use it in the MQ dissector to fetch strings to put, for
example, into the Info column, so we properly handle EBCDIC strings
there.

svn path=/trunk/; revision=37876
2011-07-03 17:08:25 +00:00
Anders Broman
8b303cc61a From Roland Knall:
The way heuristic dissection was handled by the openSAFETY plugin, could lead
to out-of-memory problems with large files (>50.000 packets). The new version
does not use ep_alloc anymore, but a static boolean instead.

Also, the code registering for the SercosIII dissector got simplified, as the
SercosIII dissector is no longer a plugin.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6061

svn path=/trunk/; revision=37874
2011-07-03 16:03:46 +00:00
Guy Harris
ae7f40cbfc Add ENC_ values for UTF-8 and EBCDIC, support them for FT_STRINGZ
values, and use them in the MQ dissector, so EBCDIC strings are
displayed as such.

Fix up some other final arguments to proto_tree_add_item().

svn path=/trunk/; revision=37872
2011-07-03 01:40:12 +00:00
Chris Maynard
5f2f261f52 Since the TCP Flags tree encompasses 12 bits including the 3 reserved bits and
the nonce bit, we should display 3 nibbles on the Flags summary line in order
to represent all flag bits.  While arguably we need not worry about reserved
bits, the nonce bit is not currently represented, so that bit alone pushes us
into the next nibble.


svn path=/trunk/; revision=37856
2011-07-01 19:40:35 +00:00
Chris Maynard
220341f369 I decode_tcp_ports(), don't abort processing zero window probe packets, even if the payload is only a single byte. Also, for the keep-alives, display any payload that might be present.
svn path=/trunk/; revision=37854
2011-07-01 19:17:02 +00:00
Chris Maynard
d927b60f21 Initialize the TCP windows to the maximum value instead of 0 to avoid false zero window conditions, especially at the beginning of a capture or if only one side of a conversation is captured. This resolves bug 4716: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4716.
svn path=/trunk/; revision=37853
2011-07-01 19:00:14 +00:00
Stig Bjørlykke
c026f4b01c Avoid absurdly large values used in for-loops.
svn path=/trunk/; revision=37842
2011-06-30 09:31:11 +00:00
Chris Maynard
2d99c2dbb4 Although technically not needed, for clarity, explicity catch invalid Ethernet frames, increment the "other" count and return. Previously, code execution would have fallen through to the ETHERNET_II case and capture_ethertype() would have incremented the "other" count.
svn path=/trunk/; revision=37835
2011-06-29 17:22:18 +00:00
Chris Maynard
e27a75ac39 Indicate TCP fast retransmissions as an expert info note, rather than a warning,just as TCP retransmissions are. This was a user request from Sharkfest '11.
svn path=/trunk/; revision=37834
2011-06-29 16:59:37 +00:00
Chris Maynard
3dd1b0c0de Based on Guy's suggestion from the user mailing list, dissect Ethernet frames with a type/len field in the range of 1501-1535 as invalid, and add an expert info to make it that much easier to find such invalid frames.
Also did some whitespace cleanup, converting tabs to spaces since most of the file was spaced, not tabbed, and swapped the order that the lg and ig bits get added to the tree because I think it looks better reading bits left-to-right.

TODO: I'm not entirely sure what to do in capture_eth() if that invalid range is encountered, so for now I just added some #if 0'd code as a placeholder.

Ref: http://www.wireshark.org/lists/wireshark-users/201106/msg00127.html


svn path=/trunk/; revision=37832
2011-06-29 16:05:56 +00:00
Jakub Zawadzki
abe9ce28a5 Update my email address.
svn path=/trunk/; revision=37831
2011-06-29 11:03:41 +00:00
Stig Bjørlykke
958919b8ca Strengthen heuristics for Packets.
This fixes bug 6073.

svn path=/trunk/; revision=37828
2011-06-29 07:02:04 +00:00
Guy Harris
c5a413c569 Don't return an offset that you won't later use.
The length fields in a pcap_pkthdr are unsigned, so presumably the
equivalent fields in the rpcap protocol are also unsigned.

Make sure the captured data length isn't bigger than the remaining data
in the packet before attempting to construct a tvbuff for the packet
data.  If it is, report that as an error, and don't even try to
construct the tvbuff; that'll fail.  This fixes bug 6073.

svn path=/trunk/; revision=37826
2011-06-29 05:21:10 +00:00
Stig Bjørlykke
8443bbbf75 Replace all strerror() with g_strerror().
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812
2011-06-28 09:00:11 +00:00
Stig Bjørlykke
4244ec0357 Remove Makefile.in when 'make maintainer-clean'.
svn path=/trunk/; revision=37796
2011-06-27 08:02:46 +00:00
Jaap Keuter
eaa3542ae7 Update the dissector_add call to use the current API.
svn path=/trunk/; revision=37782
2011-06-24 19:57:14 +00:00
Jaap Keuter
c9809b51dc From Peter Nahas:
This patch adds support for the two-way Sythetic Loss Measurement 
opcodes (SLM & SLR) defined in the latest ITU-T Y.1731. 

svn path=/trunk/; revision=37781
2011-06-24 06:49:20 +00:00
Jaap Keuter
f1bb0e1735 From Dejan Bucar:
Added support new multicore header in the LINX Ethernet protocol.
Added linx/tcp.

svn path=/trunk/; revision=37777
2011-06-23 21:52:58 +00:00
Jaap Keuter
9832ff5657 From Andrey Kulikov:
Patch to show GOST certificate types in CertificateRequest message.

svn path=/trunk/; revision=37776
2011-06-23 21:33:29 +00:00
Jaap Keuter
525b5fb796 From Andrey Kulikov:
Patch to TLS dissector to show GOST ciphesuites names. 

svn path=/trunk/; revision=37775
2011-06-23 21:17:42 +00:00
Bill Meier
2994dae6d4 From Ivan Lawrow: GTS Descriptor count is a 3 bit field;
The IEEE 802.15.4 GTS descriptor count is a 3-bit field (see page 144
of attached spec).

The mask for this field is incorrectly defined as a 2-bit field in
epan/dissectors/packet-ieee802154.h line 74:


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6055

svn path=/trunk/; revision=37771
2011-06-23 15:40:34 +00:00
Stig Bjørlykke
12214c85d0 Added missing $Id$
svn path=/trunk/; revision=37767
2011-06-23 13:48:38 +00:00
Anders Broman
2465e8e92d Add a protocol decode.
svn path=/trunk/; revision=37764
2011-06-23 13:03:37 +00:00
Jakub Zawadzki
beca9ba57a Remove not needed forward declaration.
svn path=/trunk/; revision=37759
2011-06-23 08:23:39 +00:00
Bill Meier
fb54240c34 Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;
Also: misc minor cleanup: unneeded #include; whitespace, tvb_length-->tvb_reported_length

svn path=/trunk/; revision=37757
2011-06-22 23:03:56 +00:00
Bill Meier
f11f450bf0 From Xiao Xiangquan: A new dissector for Vuze DHT;
Vuze, called Azureus before, is a great BT client and has a lot of users,
 while its DHT implementation is different from the official one.

From me: New-style dissectors are supposed to to always return
         "bytes dissected" (not just when tree != NULL);

svn path=/trunk/; revision=37755
2011-06-22 19:52:13 +00:00
Gerald Combs
05d9997311 tvb_format_text → tvb_format_stringzpad.
svn path=/trunk/; revision=37754
2011-06-22 16:02:26 +00:00
Anders Broman
7fd3360e84 Use ENC_BIG_ENDIAN.
svn path=/trunk/; revision=37753
2011-06-22 15:46:24 +00:00
Anders Broman
5ba5385c74 Protect the columns from beeing overwritten.
svn path=/trunk/; revision=37752
2011-06-22 14:49:26 +00:00
Anders Broman
e502bbaafd Add a dissector table for CDR:s
svn path=/trunk/; revision=37751
2011-06-22 13:58:04 +00:00
Alexis La Goutte
43b6279966 Fix a checkhf Warning
Unused entry: epan/dissectors/packet-skinny.c, hf_skinny_modifyConfRes

svn path=/trunk/; revision=37750
2011-06-22 12:30:07 +00:00
Alexis La Goutte
ccd94a3e88 From mtwire via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6041
Added party numbers and party names in message CM5CallInfoMessage

svn path=/trunk/; revision=37748
2011-06-22 08:09:55 +00:00
Bill Meier
83b642557a tvb_reported_length_remaining() can return -1;
Remove a few lines of not really req'd code;
Minor whitespace cleanup.

svn path=/trunk/; revision=37744
2011-06-22 04:20:46 +00:00
Bill Meier
19bc84f3b0 From Martin Kaiser: Fix forBug #6048 (fuzztest crash)
"this is caused by my newly added DVB-CI MMI code

endless loop when dissect_dvbci_text() returns 0 because the text pseudo-apdu
is invalid"

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6048

svn path=/trunk/; revision=37743
2011-06-22 01:20:20 +00:00
Anders Broman
4c219ee855 From Stéphane Gorse:
The menu gets a new item (Statistics -> RTSP -> Packet Counter).

Like HTTP, filter can be set and then the dialog windows shows the result of the RTSP analysis.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6042

svn path=/trunk/; revision=37741
2011-06-21 12:45:37 +00:00
Anders Broman
e9e32d7844 We need to start reassembly on a segment boundary.
svn path=/trunk/; revision=37740
2011-06-21 11:53:33 +00:00
Anders Broman
84cef97505 From Roland Knall:
Two changes for openSAFETY over Modbus/TCP:

1. Changing the default preference for Big Endian encoding from TRUE to FALSE
2. Changing the position in the tree for the dissection to the top-level,
therefore, the openSAFETY entries no longer will show up as children of the
Modbus entry. This is the same behaviour as the other variants for openSAFETY
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6038

svn path=/trunk/; revision=37739
2011-06-21 05:21:15 +00:00
Anders Broman
a6e3b54d15 From Martin Kaiser:
adds dissection
of the Card Information Structure (CIS). It shows the CIS as a list of tuples
without going into the details of each tuple.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6036

svn path=/trunk/; revision=37738
2011-06-21 05:16:23 +00:00
Anders Broman
51c77ea450 From Martin Kaiser:
adds the MMI resource as defined in
the DVB-CI specification (EN50221), section 8.6 (low-level MMI is excluded as
it's not used in practice).

The patch allows dissection of all text boxes that a DVB-CI host displays on
behalf of the CI module.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6034

svn path=/trunk/; revision=37737
2011-06-21 05:12:14 +00:00
Gerald Combs
61915bdfb1 Fix a type.
svn path=/trunk/; revision=37735
2011-06-20 22:36:39 +00:00
Gerald Combs
93f81a78cd From Jon Ellch via bug 5175:
Please see the attached patch which updates the ppi-geolocation support
to v2.0 of the specification. This iteration adds a new tag (sensor) and
removes support for velocity/acceleration from the vector tag. Most of
the changes center on the Vector tag. Everything that takes place
elsewhere is cosmetic.

I ran this iteration through fuzz-test and check-APIs just like last
time.


From me:

Replace tvb_get_ephemeral_string with tvb_format_text. Move dissector
registration to the bottom of each file.

svn path=/trunk/; revision=37733
2011-06-20 20:51:42 +00:00
Anders Broman
a5839116d3 Pretyfy APN display and make it filterable as a string.
svn path=/trunk/; revision=37731
2011-06-20 10:29:46 +00:00
Martin Mathieson
5f95d18d59 Some fixes to UM sequence analysis.
svn path=/trunk/; revision=37729
2011-06-20 08:55:51 +00:00
Bill Meier
da13f9f8e3 Remove some unneeded #includes;
Use consistent indentation;
Reformat some long lines.

svn path=/trunk/; revision=37724
2011-06-20 02:27:31 +00:00
Bill Meier
91191c6c00 Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;
(Code commented out since it may be required in the future (at least in some cases).

svn path=/trunk/; revision=37723
2011-06-20 01:13:21 +00:00
Sake Blok
de4354d05d Show and and a filter to non-zero ACK numbers and URG pointers whenever their respective flags are not set. As discussed at Sharkfest with Laura Chappell (OK Laura, go ahead and create some more butt-ugly filters now!).
svn path=/trunk/; revision=37721
2011-06-19 20:39:08 +00:00
Bill Meier
26c721b7c9 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;
Also: whitespace cleanup.

svn path=/trunk/; revision=37718
2011-06-19 19:13:26 +00:00
Bill Meier
d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Alexis La Goutte
fab566d69f Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Use 2-space indenting

svn path=/trunk/; revision=37712
2011-06-19 16:05:29 +00:00