Commit graph

86 commits

Author SHA1 Message Date
Stig Bjørlykke
87d24c9101 From Kovarththanan Rajaratnam:
Remove trailing spaces in protocol/field names

svn path=/trunk/; revision=28978
2009-07-07 11:37:15 +00:00
Anders Broman
1853380559 Decode error for network-id in BICC BCU-ID
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3648

svn path=/trunk/; revision=28947
2009-07-06 12:50:12 +00:00
Anders Broman
508d91b358 A fix for:
"ANSI ISUP Cause indicators with coding standard=ANSI fail to dissect."
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3654

svn path=/trunk/; revision=28939
2009-07-04 15:15:51 +00:00
Stig Bjørlykke
9391dce6b2 From Kovarththanan Rajaratnam via bug 3548:
More header_field_info cleanup.

svn path=/trunk/; revision=28772
2009-06-19 02:09:52 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Guy Harris
cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Gerald Combs
3e39be6cea From Terry Hardie via bug 3080:
In ISUP, if the redirecting or original called number parameters are present,
but have a zero length number in them, the dissector (incorrectly) marks them
as malformed packets.

Also, the precedence decoder is very terse (Doesn't even display the precedence
level correctly)

svn path=/trunk/; revision=28448
2009-05-22 16:05:30 +00:00
Anders Broman
4465e9d053 From Michael Lum:
ISUP - added support for Calling Geodetic Location parameter.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3322

svn path=/trunk/; revision=27692
2009-03-11 06:14:18 +00:00
Ulf Lamping
f904f42f9d Remove an ugly hack:
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created.

Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group.

svn path=/trunk/; revision=27407
2009-02-10 03:54:55 +00:00
Anders Broman
cb231972f1 Add dissection of Charging ASE in ISUP APM messages.
svn path=/trunk/; revision=27405
2009-02-09 20:46:59 +00:00
Anders Broman
0e26b510ea Remove a debug output.
svn path=/trunk/; revision=27142
2008-12-31 16:39:39 +00:00
Bill Meier
c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier
a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Bill Meier
33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Guy Harris
48343abfdf Get rid of no-longer-used variables.
svn path=/trunk/; revision=26266
2008-09-25 02:57:58 +00:00
Anders Broman
33ad445703 Packet-isup.c &packet-q931.[ch]:
In case of cause pointing out ie "faults" use the correct "ie value_string".
in packet-isup.c use packet-e164.c for country code translation.

svn path=/trunk/; revision=26264
2008-09-24 21:59:50 +00:00
Bill Meier
383b5e9723 Fix from christopher maynard as reported in bug 2822
svn path=/trunk/; revision=26053
2008-08-21 18:48:26 +00:00
Bill Meier
38eb4d6ce3 Use const with value_string array definitions
svn path=/trunk/; revision=26028
2008-08-14 23:51:52 +00:00
Jeff Morriss
71c1e4faf0 Change the stats tree API to use signed chars instead of guint8s for all its
strings; this should fix a number of signed/unsigned char warnings.
Reindent a bunch, too.

svn path=/trunk/; revision=25716
2008-07-11 21:13:39 +00:00
Bill Meier
931cc922a1 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25305
2008-05-15 01:44:53 +00:00
Anders Broman
1638e46df2 From Vasil Velichkov:
Fix dissection of Location and Generic Number in CAMEL
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2494

svn path=/trunk/; revision=25149
2008-04-23 05:16:53 +00:00
Stig Bjørlykke
28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Anders Broman
1144c36b11 Fix reassembly.
svn path=/trunk/; revision=24205
2008-01-27 11:03:56 +00:00
Jeff Morriss
20a98a36f3 From Cliff Romash: TMR is not a mandatory parameter on an ANSI IAM but USI is.
svn path=/trunk/; revision=23773
2007-12-05 19:55:40 +00:00
Jaap Keuter
74825dbc9b Properly decode "South Africa"
svn path=/trunk/; revision=23212
2007-10-17 06:24:43 +00:00
Anders Broman
0b4529008d Implement some of the minor possible speed improvment patches.
svn path=/trunk/; revision=23150
2007-10-11 21:23:14 +00:00
Jaap Keuter
1a8fb7a459 Fix for bug 1244:
hf_isup_event_ind contains incorrect fieldbase.

svn path=/trunk/; revision=22760
2007-08-31 05:37:43 +00:00
Jeff Morriss
3dec62b85c - s/ntohs/g_ntohs
- s/ntohl/g_ntohl
- s/free/g_free
- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string()
- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode()
- Change some tvb_get_string() calls that were clearly memory leaks (like
  atoi(tvb_get_string(...))) into tvb_get_ephemeral_string()

svn path=/trunk/; revision=22515
2007-08-15 22:27:52 +00:00
Anders Broman
b8d8f0ce1b From Neil Ostroff:
The enclosed patch updates the ansi isup dissector to support the following parameters:  

 

1. Generic Name  

2. Originating Line Info  

3. Jurisdiction  

4. Charge Number  

5. Forward Call Indicator (bits M and N are now being decoded)  

6. Cause Code (all values are now being decoded)

svn path=/trunk/; revision=21966
2007-05-28 06:13:03 +00:00
Guy Harris
1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Jeff Morriss
3f68c1395b Fix a couple warnings
svn path=/trunk/; revision=21446
2007-04-16 08:37:39 +00:00
Jeff Morriss
755698ebcf Fix bug 1508:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1508

Dissect ISUP CIC as 14 bits in ANSI (instead of 12 bits like in ITU)


svn path=/trunk/; revision=21310
2007-04-03 06:27:18 +00:00
Gerald Combs
063621f11b Fix potential buffer overruns in address_to_str_buf() found by Andrej
Mikus.  Add a buf_len parameter to ip_to_str_buf(), and make sure it's 
enforced.  Copy the release notes over from the 0.99.5 trunk and add a
note about the ISUP dissector (which is affected by the overrun).

svn path=/trunk/; revision=20607
2007-01-29 20:25:26 +00:00
Anders Broman
dc10ba22e6 Fix Event dissection which was broken when going to V3.
and add a few parameters.

svn path=/trunk/; revision=19544
2006-10-15 22:11:26 +00:00
Anders Broman
ed0cf1e0bb H248:
Lost a line in last commit.

ISUP Export a value string.

svn path=/trunk/; revision=19454
2006-10-08 20:57:20 +00:00
Anders Broman
1785428d4c Add a few packages and fix dissecton of a_codecs and handle the case when
hf_param = -1.

svn path=/trunk/; revision=19445
2006-10-06 19:48:00 +00:00
Anders Broman
2c39ec122c From Jeff Morriss:
- changes the ISUP dissector preference to follow MTP3's preference 
rather than having its own (similar to SCCP, M3UA, etc.).  I did not 
obsolete the old preference because it was never put out in a release 
(only SVN users would have seen it).  I can change that if desired.

- add dissection of ANSI CRM message

svn path=/trunk/; revision=18661
2006-07-05 05:11:22 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman
7c4b8c8b88 Fix Bug 938 ISUP IAM message marked as Malformed packet - Location number without address digits
wrongly decoded.

svn path=/trunk/; revision=18138
2006-05-11 20:32:43 +00:00
Anders Broman
0167df6139 col_append_str() instead of col_set_str() by mistake.
svn path=/trunk/; revision=18087
2006-05-03 19:32:27 +00:00
Anders Broman
f9468fe33f Add some more ANSI Message types and Parameters dissect ANSI cause.
svn path=/trunk/; revision=18000
2006-04-25 19:12:08 +00:00
Anders Broman
75b44d4de7 Preparations to include ANSI ISUP dissection.
svn path=/trunk/; revision=17981
2006-04-24 19:11:33 +00:00
Jaap Keuter
ada5c36ff3 From: Shashidhar Bhandare
I have added ISUP dissector support for decoding four ANSI ISUP messages for decoding: CRM, CRA, CVT and CVR

svn path=/trunk/; revision=17939
2006-04-20 21:17:18 +00:00
Jaap Keuter
b21337192c From Olivier Jacques:
- to_str.c: add support of "AT_NONE" address type in address_to_str_buf (avoid the assert failed later on
when messages have address type of AT_NONE - which can be the case for an MTP2 capture with FISU messages)
- packet-isup.c: changed source and destination addresses from (net_src and net_dst) to (src and dst) so 
that addresses taken into account in the statistics are the SS7 point codes

svn path=/trunk/; revision=17720
2006-03-24 14:26:01 +00:00
Anders Broman
ee72a05d9c Fix bug 786
There is error when ethereal dissects UMTS AMR codec info.
The "Initial Codec Mode" does not exist in 3GPP TS 26.103(v4.a.0)
but OM(Optimization Mode) is correct parameter.

svn path=/trunk/; revision=17458
2006-03-04 10:07:19 +00:00
Anders Broman
47b86c517e Bugfix: Dissect BAT ASE Signal IE properly.
svn path=/trunk/; revision=17428
2006-02-28 17:01:29 +00:00
Jörg Mayer
f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman
8d05164bec Get rid of duplicted dissector tables for MTP3 Service indicator and SCCP ssn:s
svn path=/trunk/; revision=16815
2005-12-16 07:05:50 +00:00
Guy Harris
66c394806a "a & b == c" is, in C, parsed as "a & (b == c)" - and if b and c are the
same, and have only one bit set, "(a & b) == c", which is what is
intended, is the same as "a & b".

In addition, we don't want to do desegmentation if "isup_apm_desegment"
isn't set, so that test should be ANDed with the other two tests.

svn path=/trunk/; revision=16792
2005-12-14 07:33:07 +00:00
Anders Broman
da8debc2ec Change reassembly to include first empty segment, check if SLR exists.
Change pinfo->src/dst to use SS7 address for reassembly to use the correct key.

svn path=/trunk/; revision=16781
2005-12-13 21:14:54 +00:00