Commit graph

9765 commits

Author SHA1 Message Date
Ulf Lamping
359fb7d5f6 added a tooltip to explain the behaviour of the syntax check in the filter string
svn path=/trunk/; revision=9862
2004-01-26 18:51:04 +00:00
Ulf Lamping
c1a7c24df3 added a tooltip to explain the behaviour of the syntax check in the filter toolbar
svn path=/trunk/; revision=9861
2004-01-26 18:40:44 +00:00
Ulf Lamping
276930f3f9 slightly changed the menuitem names in View->Show->Packet xy
svn path=/trunk/; revision=9860
2004-01-26 18:35:56 +00:00
Guy Harris
d9a836175f On Windows OT, interface names *can* have spaces in them; to find the
interface name, look forward in the interface string for "\Device\", not
backwards for a space, on Windows.  (Continue to look backwards for a
space on UNIX; names don't start with "\Device\", or even "/dev/", and
don't have spaces in them on any UNIX-flavored OS I know of.)

svn path=/trunk/; revision=9859
2004-01-26 09:05:59 +00:00
Ulf Lamping
fdc839f11b filter_packets: don't refilter all the packets,
if the new filter string is identical to the old one (as it's useless then)

svn path=/trunk/; revision=9858
2004-01-26 06:43:00 +00:00
Guy Harris
bbf3806ba7 Don't muck with the Ethernet pseudo-header if we have an 802.11 capture.
svn path=/trunk/; revision=9857
2004-01-25 23:50:48 +00:00
Guy Harris
f78b963082 Don't use "cf_read_error_message()" when reporting errors not from
Wiretap.

svn path=/trunk/; revision=9856
2004-01-25 22:27:12 +00:00
Guy Harris
d6c17f144b Free the error info string after using it.
svn path=/trunk/; revision=9855
2004-01-25 22:21:39 +00:00
Guy Harris
d20e50f996 Get rid of an unused variable.
svn path=/trunk/; revision=9854
2004-01-25 22:21:01 +00:00
Guy Harris
e608fdfda3 In "main_filter_packets()", use the "cf" argument rather than always
passing "&cfile" to "filter_packets()".

Mark the "w" argument to "filter_activate_cb()" as unused.

svn path=/trunk/; revision=9853
2004-01-25 22:20:21 +00:00
Guy Harris
d6cd61061e Have the Wiretap open, read, and seek-and-read routines return, in
addition to an error code, an error info string, for
WTAP_ERR_UNSUPPORTED, WTAP_ERR_UNSUPPORTED_ENCAP, and
WTAP_ERR_BAD_RECORD errors.  Replace the error messages logged with
"g_message()" for those errors with g_strdup()ed or g_strdup_printf()ed
strings returned as the error info string, and change the callers of
those routines to, for those errors, put the info string into the
printed message or alert box for the error.

Add messages for cases where those errors were returned without printing
an additional message.

Nobody uses the error code from "cf_read()" - "cf_read()" puts up the
alert box itself for failures; get rid of the error code, so it just
returns a success/failure indication.

Rename "file_read_error_message()" to "cf_read_error_message()", as it
handles read errors from Wiretap, and have it take an error info string
as an argument.  (That handles a lot of the work of putting the info
string into the error message.)

Make some variables in "ascend-grammar.y" static.

Check the return value of "erf_read_header()" in "erf_seek_read()".

Get rid of an unused #define in "i4btrace.c".

svn path=/trunk/; revision=9852
2004-01-25 21:55:17 +00:00
Ulf Lamping
34bddb3c1a adding a function to the help dialog, showing a specific topic (context help),
beautifying the placement of the help button in the button_row,
using the context help for the filter dialog

svn path=/trunk/; revision=9851
2004-01-25 21:27:16 +00:00
Gerald Combs
d69016e552 Delete generated files during distclean instead of maintainerclean, so
that we pass distcheck.

svn path=/trunk/; revision=9850
2004-01-25 18:52:33 +00:00
Ulf Lamping
c890e29a99 apply automatically generated filters strings to the recent dropdown list,
e.g. when applying a "Follow TCP stream",
fix a bug in the recent function, discarding the newest entries when
saving a full list (now discarding the oldest).

svn path=/trunk/; revision=9849
2004-01-25 18:51:26 +00:00
Ulf Lamping
b023bf8c7d fix some filter dialog things
svn path=/trunk/; revision=9848
2004-01-25 18:39:55 +00:00
Gerald Combs
a8348ec990 Make the definition of tvb_format_text() match what's in tvbuff.h.
svn path=/trunk/; revision=9847
2004-01-25 17:53:55 +00:00
Gerald Combs
09bf45ab36 Capitalize "Ethereal.icns" to fix a distclean error. Add its description
to README.image.

svn path=/trunk/; revision=9846
2004-01-25 17:51:54 +00:00
Jörg Mayer
4189858920 Fix 'warning: cast discards qualifiers from pointer target type' by removing cast
svn path=/trunk/; revision=9845
2004-01-25 17:33:20 +00:00
Jörg Mayer
111f977cfa Remove the cast again and do the proper fix (add right type to union)
svn path=/trunk/; revision=9844
2004-01-25 17:22:57 +00:00
Jörg Mayer
21c1c34c02 Add a cast to avoid a signedness warning
svn path=/trunk/; revision=9843
2004-01-25 17:07:57 +00:00
Jörg Mayer
c61e9f6ed0 Change the first arg to hex_str_to_bytes from guchar* -> char*
svn path=/trunk/; revision=9842
2004-01-25 16:58:25 +00:00
Jörg Mayer
153f554b01 A few signedness warning fixes
svn path=/trunk/; revision=9841
2004-01-25 15:56:04 +00:00
Jörg Mayer
a2634a1ed3 The octets in an ip address are unsigned
svn path=/trunk/; revision=9840
2004-01-25 15:35:45 +00:00
Ulf Lamping
24eb4363ef add syntax check and an "Add Expression" button to the filter toolbar
svn path=/trunk/; revision=9839
2004-01-25 15:10:36 +00:00
Ulf Lamping
f7dbf0f940 added/changed some tooltips
svn path=/trunk/; revision=9838
2004-01-25 13:47:09 +00:00
Ulf Lamping
ad7bc1e358 changed the behaviour of the edit buttons to make more sense,
removed the no longer needed "Edit and "Copy" buttons,
do a lot of code cleanup

svn path=/trunk/; revision=9837
2004-01-25 12:25:57 +00:00
Ulf Lamping
74d16224c4 make resized prefs_dlg look better
svn path=/trunk/; revision=9836
2004-01-25 12:22:20 +00:00
Ulf Lamping
7f0f64c272 minor GTK2 layout change
svn path=/trunk/; revision=9835
2004-01-25 12:10:27 +00:00
Jörg Mayer
61581fb780 Fix a warning by using a function typedef
svn path=/trunk/; revision=9834
2004-01-25 09:49:50 +00:00
Guy Harris
a0528c5f82 Report open errors when saving the contents of an RTP stream. Check for
and report write errors as well.

svn path=/trunk/; revision=9833
2004-01-25 02:24:44 +00:00
Guy Harris
557d5430af Check for write errors when writing CSV data as well.
Check for write errors when opening the CSV file to write the reverse
data information.

For some reason (perhaps having to do with the sort indicators in
titles, the column titles don't show up in the GtkCList structure, so
they don't get printed; just directly use the table of column titles.

svn path=/trunk/; revision=9832
2004-01-25 02:14:05 +00:00
Guy Harris
10552e3169 Check whether the "fopen()" that creates a CSV file fails and, if so,
report the error and don't dismiss the file selection dialog box.

svn path=/trunk/; revision=9831
2004-01-25 01:58:58 +00:00
Guy Harris
a2c53bff75 Don't have "follow_print_text()" display the error message, leave that
up to its caller.

Show errors as such, not as warnings, and show the right error message
for failures to open/create output files.

svn path=/trunk/; revision=9830
2004-01-25 01:53:24 +00:00
Guy Harris
6efa00c5f4 Add another check for output errors when printing.
svn path=/trunk/; revision=9829
2004-01-25 01:19:48 +00:00
Guy Harris
7502ac216a There's no need to keep a "FILE *" for the file being printed to in a
"capture_file" structure.  Keep it locally, instead.

Check for errors when printing packets.

Report failure to open a print destination and failure to write to a
print destination differently.

Don't have the "print preamble" and "print final" routines return
success/failure indications - revert to the old scheme where they
didn't, and have the callers use "ferror()" to check for errors.

Report write errors when printing dissections in Tethereal.

Report print errors as errors, not warnings.

svn path=/trunk/; revision=9828
2004-01-25 00:58:13 +00:00
Ulf Lamping
064d5e5e07 Added the ability to compile both GTK versions 1 and 2 at the same time.
svn path=/trunk/; revision=9827
2004-01-24 20:01:36 +00:00
Jörg Mayer
6e59f95ceb Fix all fixable warnings
Move addional warnings from extra-gcc-checks to normal compilation flags

svn path=/trunk/; revision=9826
2004-01-24 16:48:12 +00:00
Guy Harris
65f18bb833 As with "file_write_error_message()", so with
"file_close_error_message()" - but just use "file_write_error_message()"
for UNIX-style errors, under the assumption that a close will only fail
because a buffer-flushing write fails or because "close()" itself fails
when, for example, pushing unsynced NFS client-side writes out over the
wire.

Make several routines in "print.c" return success/failure indications.

Check for write errors when printing "Follow TCP Stream" stuff or saving
it to a file.

svn path=/trunk/; revision=9825
2004-01-24 10:53:25 +00:00
Jörg Mayer
7180513677 Trivial signed/unsigned warning fixes
svn path=/trunk/; revision=9824
2004-01-24 02:07:05 +00:00
Guy Harris
d8d91ff347 As with "cf_open_error_message()"/"file_open_error_message()", so with
"cf_write_error_message()"/"file_write_error_message()".

Use "file_open_error_message()" instead of "cf_open_error_message()" in
some places we missed in the previous checkin.

Catch ENOSPC and EDQUOT in "file_open_error_message()".

Use "file_open_error_message()" rather than "file_write_error_message()"
to report errors when creating the file to which we're saving the
"Follow TCP Stream" data.

svn path=/trunk/; revision=9823
2004-01-24 02:01:44 +00:00
Jörg Mayer
4377e456d4 Trivial warning fixes
svn path=/trunk/; revision=9822
2004-01-24 01:53:59 +00:00
Guy Harris
46848f0a9e Add a new "file_open_error_message()" routine in "epan/filesystem.c", to
translate UNIX errno values to a somewhat friendly message format
string.

Rename "file_open_error_message()" in "file.c" to
"cf_open_error_message()", make "cf_open_error_message()" use the new
"file_open_error_message()" for UNIX errno values, have "do_capture()"
in "capture.c" use "file_open_error_message()" to report errors from
"open()", and make "cf_open_error_message()" static as nothing outside
"file.c" uses it.

Do similar stuff in "tethereal.c".

svn path=/trunk/; revision=9821
2004-01-24 01:44:29 +00:00
Jörg Mayer
49093048ac Remove extra , at end of enum, change C++ style comment
svn path=/trunk/; revision=9820
2004-01-24 01:30:20 +00:00
Guy Harris
88535b9a99 From Lars Ruoff (who also contributed the previous change; my apologies
to both Larses):

	- Comfort noise (CN) packets and packets following them
	  immediately are excluded from maximum delay calculation (as
	  well as marked packets are)
	- Payload changes between CN and regular packets are ignored.
	- Added a "Marker missing?" status warning for packets following
	  CN that don't have the marker bit set (cf. RFC1890 4.1)
	- Changed status "Ok" to "[ Ok ]", so that when sorting by status
	  column, all non-Oks are grouped together.
	- Minor GUI updates: reduced size of box, borders, spacing,
	  changed highlight colors.

svn path=/trunk/; revision=9819
2004-01-24 01:15:24 +00:00
Guy Harris
89c529db8e Have "font_apply()" return an indication as to whether it succeeded or
failed and, if it failed, how it failed.  Have it leave up to its caller
the job of reporting that it couldn't load the requested font; have its
callers do that, and have them set the zoom level on failure so that we
have a zoom level that is at least more likely to work.  Make the alert
boxes for "font_apply()" failures be error boxes, not warning boxes.

svn path=/trunk/; revision=9818
2004-01-24 01:02:54 +00:00
Guy Harris
89edd94cb3 Do the font loading code as two larger sections of code, one for GTK+
1.2[.x] and one for GTK+ 2.x, rather than as one section peppered with
#ifdefs.

svn path=/trunk/; revision=9817
2004-01-23 21:22:18 +00:00
Guy Harris
b64241c4a6 Include the AddStyleName information in the zoomed font name.
svn path=/trunk/; revision=9816
2004-01-23 20:34:11 +00:00
Guy Harris
52faded8d8 If we call "font_apply()", we don't need to call
"redraw_hex_dump_all()".

svn path=/trunk/; revision=9815
2004-01-23 20:13:23 +00:00
Guy Harris
32e5a4bdbc If the zoom factor is zero, don't construct a new font name - the
supplied font name is correct.  That lets us handle fonts whose size we
can't change because this is GTK+ 1.2[.x] and the name isn't an XLFD
name so we don't know where the size is.

In "font_zoom()", remove some code from the GTK+ 1.2[.x] vs. GTK+ 2.x
#ifdefs.

Fix the comment for "font_zoom()".

Get rid of a no-longer-used "simple_dialog()" argument.

svn path=/trunk/; revision=9814
2004-01-23 20:11:59 +00:00
Guy Harris
d10d0f20f2 Clean up indentation.
Make "font_zoom()" static - it's not used outside gtk/main.c.

Use "g_strdup()" rather than "strdup()", as we use "g_free()" to free
the result.

Put in a little more information when "font_zoom()" fails due to the
font name not being an XLFD font name, and don't continue if it fails.

Don't continue if the attempt to load the fonts fails, either.

svn path=/trunk/; revision=9813
2004-01-23 19:53:10 +00:00