Commit Graph

25 Commits

Author SHA1 Message Date
Jaap Keuter b7659fdc74 Follow up for revision 32670.
Straighten out is_acn() function.

svn path=/trunk/; revision=32690
2010-05-06 18:41:23 +00:00
Anders Broman 91a8a75a59 From Jim Schaettle:
Add Ratified DMX to ACN Dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4745

svn path=/trunk/; revision=32670
2010-05-05 05:52:37 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Anders Broman aaa917be72 remove check_col
svn path=/trunk/; revision=32089
2010-03-03 13:52:17 +00:00
Stig Bjørlykke 9c7aabb196 Fixed abbrev for PDU Length.
Removed unused hf entries.

svn path=/trunk/; revision=31420
2010-01-03 14:55:35 +00:00
Bill Meier 7245b43dde Rework is_acn to use tvb_memeql insted of doing a tvb_get_epemeral_string and a memcmp;
Remove some unneeded calls to col_clear().

svn path=/trunk/; revision=30211
2009-09-30 13:19:14 +00:00
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Guy Harris 59677ebed0 Use g_strreverse() to reverse strings.
svn path=/trunk/; revision=27783
2009-03-18 20:45:57 +00:00
Stig Bjørlykke 7ea3b489fe From Bill Florac (bug 3048):
Calling proto_tree_add_int_format() with a unsigned value can cause dissection
failure. Correctly switched to proto_tree_add_uint_format().

svn path=/trunk/; revision=26827
2008-11-23 14:28:36 +00:00
Stig Bjørlykke d0e33bc3c5 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26646
2008-10-31 14:07:23 +00:00
Guy Harris ac88e96246 Thou shalt not "print" a string with a printf-like function by using it
as the format string; thou shalt, instead, use "%s" as the format string
and use the string as the argument to "%s".  Thanks and a tip of the
Hatlo hat to the version of GCC that comes with Ubuntu 8.10 for catching
this.

svn path=/trunk/; revision=26640
2008-10-31 02:41:45 +00:00
Bill Meier ffa7320de2 Minor cleanup related to proto_register & proto_reg_handoff
svn path=/trunk/; revision=26280
2008-09-26 20:06:40 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Bill Meier e6334320c5 Remove unnecessary prefs callback; simplify reg_handoff; minor cleanup
svn path=/trunk/; revision=26074
2008-08-25 16:59:38 +00:00
Bill Meier c93ba4d596 Fix a few typos & spelling errors
svn path=/trunk/; revision=26014
2008-08-14 16:28:56 +00:00
Jeff Morriss 689e8bd855 From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 :
Hexadecimal and octal are unsigned.  Don't let dissectors register signed
fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX)
or octal.  Fix dissectors that do that mostly by changing the fields to
unsigned though in PANA it appears the fields are meant to be signed so
change those fields to be displayed in decimal.

This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries
to create a filter using one of these mixed signed/unsigned fields (because
that routine does not know how to present the user with a signed value in
hex).

Also add FT_*INT64 to the "make sure it's not BASE_NONE" check.

svn path=/trunk/; revision=24643
2008-03-15 22:41:57 +00:00
Jaap Keuter 17a358e19c From Bill Florac:
When dissecting any message containing a "transport layer address", if the
address was NULL (which is valid), the offset pointer was not incremented by 1
and the remaining fields would not be dissected correctly.

svn path=/trunk/; revision=24162
2008-01-22 06:49:49 +00:00
Jaap Keuter 5ea09479ce From Bill Florac:
1) DMP "range" addresses can cause packet dissection failure.
2) A NULL return of match_strval() is not handled.
3) DMP addresses should be displayed in hex.
4) ep_alloc should not be used, use static variables.

svn path=/trunk/; revision=22850
2007-09-12 05:57:53 +00:00
Sebastien Tandel 76a9512a73 remove some g_malloc/g_free
svn path=/trunk/; revision=21280
2007-03-30 08:22:08 +00:00
Jaap Keuter 376c54d343 Removed executable property.
svn path=/trunk/; revision=20119
2006-12-11 21:28:07 +00:00
Anders Broman c8837b810a From Bill Florac:
Here is a patch for the ACN dissector. It fixes a bug in
acn_add_expiry() and cleans up some cosmetic things.

svn path=/trunk/; revision=19951
2006-11-21 21:00:25 +00:00
Guy Harris a19025c3f6 Bitfields are bad - the C language spec does *NOT* guarantee which bits
will correspond to which bit fields.  Don't use them.

Use #defines rather than numbers in the appropriate places.

Constify some arguments.

Get rid of C++ comments.

svn path=/trunk/; revision=19854
2006-11-07 09:06:53 +00:00
Ronnie Sahlberg 258b3af063 new acn dissector from Bill Florac
svn path=/trunk/; revision=19830
2006-11-06 20:13:32 +00:00