Commit Graph

121 Commits

Author SHA1 Message Date
Stig Bjørlykke 8b21f50474 Added hint about "TCP segmentation offload" when IP length == 0.
Added expert info item for bogus IP length.
Added hint about "IP checksum offload" for invalid IP checksum.
Describe TSO in the preference setting. 

svn path=/trunk/; revision=34830
2010-11-10 13:49:55 +00:00
Bill Meier 9675740701 Use value_string_ext fcns to access certain value_string arrays;
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34766
2010-11-03 22:08:49 +00:00
Jaap Keuter 694383d4a8 From Simon Leinen:
The IP Timestamp Option (RFC 781) has three variants.  One (flag=0) just stores
a sequence timestamps in the option, but the other two (flag=1 and flag=3)
store alternate IP addresses and timestamps.

From me:
Mark option full when offset (pointer) is set to one, as per RFC 781.

svn path=/trunk/; revision=34750
2010-11-02 08:48:06 +00:00
Gerald Combs 0e64b1749c Enable "Support packet-capture from IP TSO-enabled hardware" by default.
Like checksum offloading this seems to be common on modern systems.

svn path=/trunk/; revision=34383
2010-10-05 16:32:12 +00:00
Stig Bjørlykke 2d93bc5e9a Make "4 NOP in a row" work again after changing the NOP name for TCP and IP
in revisions 34095 and 34097.

svn path=/trunk/; revision=34134
2010-09-16 12:29:22 +00:00
Stig Bjørlykke 894941e532 Only check for 4 NOP in a row within a uint32 boundary.
svn path=/trunk/; revision=34100
2010-09-10 21:24:32 +00:00
Stig Bjørlykke f2e302eee0 Follow TCP and expand description for "NOP" and "EOL" options to "No-Operation (NOP)"
and "End of Options List (EOL)" respectively.

svn path=/trunk/; revision=34097
2010-09-10 16:48:00 +00:00
Stig Bjørlykke aca8a4d989 Update dsfield ECN according to RFC3168.
svn path=/trunk/; revision=34092
2010-09-10 11:16:29 +00:00
Stig Bjørlykke e71daa1fc1 Revert revision 33780, because the checksum is only calculated
from the header and not the content.

svn path=/trunk/; revision=34080
2010-09-08 13:38:47 +00:00
Stig Bjørlykke dfb24f48d8 From Chris Maynard via bug 5105:
IP should not compute the header checksum if within an error packet
such as ICMP.

svn path=/trunk/; revision=33780
2010-08-12 06:26:21 +00:00
Stig Bjørlykke 8aaa5b8ec7 Added description of ECT and ECN-CE, added TFS for the bit values
and some item cleanup.

svn path=/trunk/; revision=33313
2010-06-24 11:37:03 +00:00
Jaap Keuter 8bba8bf460 Fix for bug 4888:
Restore setting DSCP column value, when relevant.

svn path=/trunk/; revision=33270
2010-06-20 18:24:25 +00:00
Stig Bjørlykke 1069c8dccf Added an expert info for "4 NOP in a row" in IP and TCP.
svn path=/trunk/; revision=33265
2010-06-20 16:22:51 +00:00
Stig Bjørlykke d051e79a81 Revert back to the old Flags entry.
Add number of bits used for Flags in the description.

svn path=/trunk/; revision=33264
2010-06-20 16:17:10 +00:00
Gerald Combs 1bac7c2610 From Chris Maynard via bug 4014:
This trivial patch merely displays the ICMP ID and sequence # in the Info
column.

svn path=/trunk/; revision=33056
2010-06-02 18:13:00 +00:00
Anders Broman 2b90c98a1a Use value_string_ext for ip protocol.
svn path=/trunk/; revision=32914
2010-05-22 22:04:18 +00:00
Anders Broman 3c51d54e83 Fix:
packet-ip.c:1311: warning: 'field_tree' may be used uninitialized in this function

svn path=/trunk/; revision=32635
2010-05-02 17:02:11 +00:00
Anders Broman d528b62777 From Jakub Zawadzki:
patch for ip.flags (using proto_tree_add_bits_item).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

svn path=/trunk/; revision=32633
2010-05-02 15:36:44 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Jaap Keuter 6e795990fb The evil bit IS a security issue.... ;)
svn path=/trunk/; revision=31915
2010-02-18 20:58:04 +00:00
Jaap Keuter c084355412 From Chris Maynard:
Take into account PIM protocol specifics with regards to TTL when colorizing packets.

svn path=/trunk/; revision=31807
2010-02-05 22:39:14 +00:00
Stig Bjørlykke 47e732e29e Changed "reassembled_length" -> "reassembled.length".
svn path=/trunk/; revision=31776
2010-02-03 08:47:15 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Bill Meier e49599c588 Fix Bug #4177: Analyze ! Expert... doesn't show IP "Bad Checksum" errors.
svn path=/trunk/; revision=31471
2010-01-08 23:53:46 +00:00
Stephen Fisher c5fdb8edae From Chris Maynard via bug #4287: Display IP protocol number in decimal
instead of hexadecimal.


svn path=/trunk/; revision=31165
2009-12-03 19:10:43 +00:00
Stig Bjørlykke 005049bebb Changed hf_ip_proto to use ipproto_val[].
Removed some unneeded includes.

svn path=/trunk/; revision=31017
2009-11-19 15:30:06 +00:00
Jaap Keuter 324b7484d9 Implement RFC 3514.
svn path=/trunk/; revision=30926
2009-11-10 21:46:14 +00:00
Jaap Keuter 03730e3bc1 From Filipe David Borba Manana:
Since it was named Ethereal and up to today, Wireshark wrongly parses 
the IPv4 header flags field:
* it considers it as a 4 bits wide field - according to RFC 791 its a 3 bits
wide field (first 3 bits of the 6th octect of the IPv4 header).
* if for example the DF bit is set, Wireshark displays the flag value as 0x04
(0100) when it should be 0x02 (010), idem for the MF flag.
Attached to this bug report, you can find a patch to fix the issue.

svn path=/trunk/; revision=30855
2009-11-07 11:24:05 +00:00
Anders Broman 88bb44a51e From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Jörg Mayer 8bd7ebc6a1 - Fix for bug 3965 as reported by Ivan Sy <ivan_jr@yahoo.com>
mDNS and LLMNR also deviate from the TTL=1 for 224.0.0.0/24

- Fix two warnings about removing const by casting.

svn path=/trunk/; revision=29644
2009-08-31 22:34:25 +00:00
Kovarththanan Rajaratnam 51ca1739ae Custom columfication:
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield

svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Gerald Combs 842d1be224 Fix the build.
svn path=/trunk/; revision=29363
2009-08-10 15:33:54 +00:00
Jörg Mayer 1e7031f1c0 Ivan Sy <ivan_jr@yahoo.com> via bug 3814
TTL-Check for local network group addresses: Normally the
only valid TTL is 1. Add a check for VRRP and GLBP, where
the only valid TTL is 255.

Me: change the logic so the funtion returns the valid ttl
    instead of true/false.


svn path=/trunk/; revision=29362
2009-08-10 14:55:47 +00:00
Anders Broman 0b0ff6cdcf Get rid of check_col() in some of the more frequently used dissectors.
svn path=/trunk/; revision=29170
2009-07-22 21:33:47 +00:00
Stig Bjørlykke 046a329a66 Split packet-ip into packet-ip and packet-icmp.
Some cleanup in handles and ett entries.

svn path=/trunk/; revision=29035
2009-07-09 11:32:50 +00:00
Jörg Mayer c43391cd08 Currently, the expert code notifies if a packet is addressed
to 224.0.0.x with a TTL>1. Some protocols (notably VRRP and GLBP)
send out a TTL of 255 and thus cause a notice. That should be fixed,
so for now: Add a FIXME about that.

svn path=/trunk/; revision=29024
2009-07-08 15:29:37 +00:00
Stig Bjørlykke 4d8dd01e8e Changed flags_set_truth -> tfs_set_notset
svn path=/trunk/; revision=28989
2009-07-07 14:54:15 +00:00
Stig Bjørlykke 85c8e31574 From Kovarththanan Rajaratnam via bug 3548:
More header_field_info cleanup.

From me:
Don't fix the empty name for hf_nisplus_dummy.

svn path=/trunk/; revision=28792
2009-06-21 18:45:56 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Gerald Combs e2c0d132e1 From Jakub Zawadzki via bug 3421:
e_ip->ip_ttl is currently always set to 0, in attachment fix. 

I also (in same patch, sorry) submit cleanup to use ep_alloc() instead
of static e_ip buffers, I didn't test it, but I hope it's ok.

There's note about static buffers in doc/README.tapping, which should
also be updated, but I don't feel so good with my English :)

From me:

Rename e_ip to ws_ip. Update the static buffers note in README.tapping.

svn path=/trunk/; revision=28425
2009-05-20 15:50:40 +00:00
Bill Meier d6a5a7c761 P64 changes: Fix some cases for which size_t is not required
svn path=/trunk/; revision=27822
2009-03-22 20:55:31 +00:00
Jaap Keuter dc0426a532 Redesign GeoIP information presentation.
svn path=/trunk/; revision=27655
2009-03-08 14:11:01 +00:00
Stig Bjørlykke c84b8b1c4b Add expert info when bad checksum.
svn path=/trunk/; revision=27593
2009-03-03 21:38:49 +00:00
Ulf Lamping d5d3e1fa92 add display of GeoIP latitude/longitude
This is a crude hack, as the current Wireshark interface to GeoIP is not really suitable for reading several values of a single GeoIP database :-(

svn path=/trunk/; revision=27365
2009-02-04 01:02:59 +00:00
Gerald Combs c30c410fa5 Add GeoIP to the Windows build. Fix a remaining geoip_ -> geoip_db_
conversion.

svn path=/trunk/; revision=27098
2008-12-23 18:56:31 +00:00
Gerald Combs 218ec164c6 GeoIP expects IPv4 addresses in host byte order.
svn path=/trunk/; revision=27097
2008-12-23 18:17:01 +00:00
Gerald Combs 7d22c0fb7f Rename geoip.[ch] to geoip_db.[ch] so we don't collide with GeoIP.h. Rename
some functions to match.

Add GeoIP lookups to the IP dissector. Add a preference for GeoIP lookups,
which is disabled by default.

svn path=/trunk/; revision=27063
2008-12-19 23:49:03 +00:00
Jörg Mayer ab7331c393 If a packet is fragmented, show the packet id in the info column.
svn path=/trunk/; revision=27021
2008-12-16 12:28:49 +00:00
Guy Harris 198e48fe85 Don't set the tvbuff actual length based on the IP total length until
after we've checked whether the total length is less than the header
length, so that we don't believe an obviously bogus total length.  (This
doesn't catch all cases of bogus total lengths, but it catches, for
example, a total length of 0.)

svn path=/trunk/; revision=26901
2008-12-02 09:42:57 +00:00