Commit Graph

21975 Commits

Author SHA1 Message Date
Jeff Morriss 2f77efce7d Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 :
Try to call get_interface_descriptive_name() as little as possible (storing
the result in capture_opts) to avoid a performance hit during live capture
(especially if you have lots of interfaces) and to avoid leaking memory.

One issue with this is that capture_opts.c cannot (without adding significant
dependencies) set the iface_descr so readers of that field (only gtk/main.c
and tshark.c) use a macro to (set if not already set and) get the value of
that field.

svn path=/trunk/; revision=22587
2007-08-22 16:30:16 +00:00
Martin Mathieson 914e885354 Show which bits 'fragment offset' comes from (I had to look it up :( )
svn path=/trunk/; revision=22586
2007-08-22 14:43:26 +00:00
Jaap Keuter a4f2082eb8 The reserved field is now 16 bits. Treat it as such.
svn path=/trunk/; revision=22585
2007-08-22 13:58:39 +00:00
Guy Harris ae8b29ec53 More timestamp calculation fixes similar to the previous ones.
svn path=/trunk/; revision=22584
2007-08-22 07:14:08 +00:00
Jaap Keuter 4533ff34a0 From Victor Fajardo:
Updated patches to support draft-ietf-pana-pana-18.txt.

svn path=/trunk/; revision=22583
2007-08-22 06:59:28 +00:00
Guy Harris a18a6233d1 Oops, have to regenerate this after changing its template.
svn path=/trunk/; revision=22582
2007-08-22 04:31:32 +00:00
Guy Harris e994584040 Cast away shortening conversions that are presumed not to lose any data.
Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all
compilers we use support LL as a suffix for that (MSVC++ 6, for one).

svn path=/trunk/; revision=22581
2007-08-22 04:25:00 +00:00
Guy Harris 2c041a8fa4 Cast away shortening conversions that are presumed not to lose any data.
Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all
compilers we use support LL as a suffix for that (MSVC++ 6, for one).

svn path=/trunk/; revision=22580
2007-08-22 02:45:42 +00:00
Jeff Morriss 6dd41716b2 Fix a known- and marked-by-a-comment memory leak: replace g_strdup() with se_strdup(). (The address in question is stored in a conversation structure so it's "seasonal".)
svn path=/trunk/; revision=22579
2007-08-21 22:18:27 +00:00
Richard van der Hoff 62569354fe From yin sun <sunyin51@gmail.com> / bug 1722:
When a subdissector on top of TCP set ... DESEGMENT_UNTIL_FIN ... then
the subdissector should receive the whole reassembled TCP stream in tvb.
But the bug is it is missing the last payload from the FIN packet.


svn path=/trunk/; revision=22578
2007-08-21 22:15:17 +00:00
Richard van der Hoff e6002deb3e From Shaun Jackman <sjackman@gmail.com> / bug 1753:
* asn1/mpeg/packet-mpeg-pes-template.c: Improved decoding of PES
        extension header and Pack header. Decode SCR, PTS, and DTS.
        * asn1/mpeg/mpeg-pes.asn (Pack): Remove.
        * epan/dissectors/packet-mpeg-pes.c: Regenerate.
        * wiretap/mpeg.c (mpeg_read): Decode the SCR using integer
        arithmetic instead of double float arithmetic to prevent rounding
        error.
        * wiretap/wtap-int.h (mpeg_t) <t0>: Use time_t instead of double.


svn path=/trunk/; revision=22577
2007-08-21 22:00:06 +00:00
Richard van der Hoff 32d5537966 From Francois-Xavier Le Bail <fx.lebail@yahoo.com> / bug 1724:
The following patch decode DHCP option 249 (Classless Static Route) used by
some Microsoft systems. Same decoding as option 121 (RFC 3442).


svn path=/trunk/; revision=22576
2007-08-21 21:40:18 +00:00
Luis Ontanon 76658ef0f1 A further iteration in the code, things start to look good!
svn path=/trunk/; revision=22575
2007-08-21 21:32:00 +00:00
Richard van der Hoff 80f24e2cc6 fix usage message for -o option
svn path=/trunk/; revision=22574
2007-08-21 21:25:53 +00:00
Jeff Morriss 7a57f956b8 Change COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have "seasonal" scope (e.g., they are used in conversations or similar).
svn path=/trunk/; revision=22573
2007-08-21 21:23:37 +00:00
Richard van der Hoff 0c3e8b7c31 From Florent DROUIN <florent.drouin@alcatel.fr>, bug 1518:
Fix for g_assert when clicking 'OK' on colour filters dialogue whilst
individual filter edit window is open. 


svn path=/trunk/; revision=22572
2007-08-21 21:15:57 +00:00
Jeff Morriss f8e0d53ecf Use SET_ADDRESS (instead of COPY_ADDRESS) for an address that has "ephemeral" scope. Use SE_COPY_ADDRESS when the address is copied to the template cache (with "seasonal" scope.)
svn path=/trunk/; revision=22571
2007-08-21 21:03:59 +00:00
Richard van der Hoff 969bb158f6 From Mike Duigou <wireshark@duigou.org> (bug 1698):
Enclosed is a patch with fixes problems with the desegmentation of chunked HTTP
message bodies.

...

Changing the value of pinfo->desegment_len to DESEGMENT_ONE_MORE_SEGMENT rather
than the current 1 or 2 seems to make everything work. (I'm kind of confused as
to why the headers resassembly code already used DESEGMENT_ONE_MORE_SEGMENT and
the body reassembly code did not).


svn path=/trunk/; revision=22570
2007-08-21 20:57:52 +00:00
Richard van der Hoff 25f64f9d27 fix a signedness-in-comparison warning
svn path=/trunk/; revision=22569
2007-08-21 20:32:22 +00:00
Jeff Morriss caf9f71cee When saving off a temporary copy of an address, use SET_ADDRESS instead of COPY_ADDRESS so as to avoid a memory leak (or adding g_free() calls to fix said memory leak).
svn path=/trunk/; revision=22568
2007-08-21 20:24:17 +00:00
Guy Harris 2305f9e389 Give the full pathname of the wireshark.nsi file, and add information on
what to do for the U3 win32/makefile.nmake file.

svn path=/trunk/; revision=22566
2007-08-21 18:09:33 +00:00
Guy Harris da5a4dac33 Add the UNISTIM plugin, and put the plugins in alphabetical order (to
simplify checking whether we have the full list).

svn path=/trunk/; revision=22565
2007-08-21 18:04:09 +00:00
Guy Harris 8ed8be19f3 Add more information on adding a plugin to the NSIS installer.
svn path=/trunk/; revision=22564
2007-08-21 17:59:08 +00:00
Guy Harris 4bf2ada77f Update the NSIS files to add the UNISTIM plugin.
svn path=/trunk/; revision=22563
2007-08-21 17:49:54 +00:00
Jaap Keuter 7b593acb18 From Neil Piercy:
This patch set provides a an API for out of band signalling protocols to
register flows as SRTP/SRTCP using extended versions of the existing
rt(c)p_add_address functions. At present the encrypted portions of the payloads
are simply skipped, and the auth tags etc added as fields.

svn path=/trunk/; revision=22562
2007-08-21 07:23:34 +00:00
Jaap Keuter 3d75f7a2a6 Fix the build.
svn path=/trunk/; revision=22561
2007-08-20 21:48:25 +00:00
Anders Broman 76a0564376 Dissect End-to-End and Link-by-Link messages.
svn path=/trunk/; revision=22560
2007-08-20 20:58:02 +00:00
Anders Broman ee86c4c30e From Cyrille Colin:
gsm_a :
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1754
SMS CP (gsm_a_dtap), RP (gsm_a_rp) and T-PDU (gsm_sms) protocol stacks are
decoded in Wireshark when called by BSSAP or RANAP.
Same protocol stack can be called by GPRS-LLC (sapi 7). Simple modification
needed in packet-gsm_a.c to add dtap dissector to llcgprs.sapi 7.

Me a comment in gprs-llc.

svn path=/trunk/; revision=22559
2007-08-20 20:55:06 +00:00
Jaap Keuter b65cc92385 Add the UNISTIM plugin to Wireshark.
svn path=/trunk/; revision=22558
2007-08-20 20:50:29 +00:00
Ronnie Sahlberg 331d267b50 we need to track the fid in the rwdata structure so that reassembly of
connectionoriented dcerpc over smb pipes will be able to find the fid 
used for reassembly


svn path=/trunk/; revision=22557
2007-08-20 08:09:52 +00:00
Luis Ontanon a5efe69a79 Filtering on snmp variables starts to work so I put it there in case anyone wants to start playing with it. I'll leave the generated dissector in place and the rest off the Makefiles so that others are not bothered by this.
TODO:
- Global
   - add libsmi to autoconf (I modified CFLAGS and LDADDs in the makefile.ams appending my own values, that's good only for me)
   - have other users of oid_resolv.h get to use the new functions in oids.h
   - add a menu item or preference setting for the smi_modules UAT ( the smi_modules file has one dquoted string per line with the name of each module to be loaded)
- SNMP
  - put complete information in the labels of the VarBind Items
  - add oids to COL_INFO
  - negative testing (Well, testing in general)
- OIDS
  - implement "ALL" modules 
  - some functions are not yet tested or implemented

I'll put a TO-DO list on the wiki for people (incl. me) to add more items




svn path=/trunk/; revision=22556
2007-08-19 23:00:47 +00:00
Stig Bjørlykke 696bcf8b2d Mark pinfo as unused to make buildbot happy again.
svn path=/trunk/; revision=22555
2007-08-19 21:56:11 +00:00
Anders Broman 782240831c Fix copy-paste errors.
svn path=/trunk/; revision=22554
2007-08-19 20:41:16 +00:00
Anders Broman eafb792669 Disscet CC messages.
svn path=/trunk/; revision=22553
2007-08-19 20:26:08 +00:00
Stig Bjørlykke 10752972ea Check for COTP if Call Request has not been captured.
Fixed an offset for diagnostic in COL_INFO.

This file should really be rewritten to use more proto_tree_add_item's
instead of proto_tree_add_text's.

svn path=/trunk/; revision=22552
2007-08-18 22:56:44 +00:00
Graeme Lunt d36abc4549 Handle unknown Universal and BMP strings.
svn path=/trunk/; revision=22551
2007-08-18 17:39:44 +00:00
Bill Meier bcdaba288f Bug #1446 work-around from Toralf Förster
svn path=/trunk/; revision=22550
2007-08-18 15:48:10 +00:00
Bill Meier 64d7c80f56 Add #include needed to get defs for PT_PCMU & etc
svn path=/trunk/; revision=22549
2007-08-18 04:28:40 +00:00
Bill Meier c71c4af57c Fix some gcc warnings so buildbots can proceed.
svn path=/trunk/; revision=22548
2007-08-18 03:19:44 +00:00
Guy Harris e104794902 Use #defines, rather than raw numbers, for RTP payload types.
Note that we should return an error for payload types we don't support,
so the user knows we can't handle the audio.

svn path=/trunk/; revision=22547
2007-08-18 01:46:14 +00:00
Luis Ontanon fab09c9575 accept 64bit integers where 8 <= len <= 1
svn path=/trunk/; revision=22546
2007-08-18 00:14:52 +00:00
Gerald Combs 6db456ba1d Fix a couple of signedness mismatches.
svn path=/trunk/; revision=22545
2007-08-17 23:53:41 +00:00
Anders Broman c7fd82dbbe Add code for finding sub dissectors.
svn path=/trunk/; revision=22544
2007-08-17 23:23:36 +00:00
Anders Broman 9f35c24eb5 Add a rudimentarry DPNSS dissector - work in progress.
svn path=/trunk/; revision=22543
2007-08-17 21:31:22 +00:00
Jeff Morriss d47443ba38 Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string(). 2 of the 3 replacements fix memory leaks.
svn path=/trunk/; revision=22542
2007-08-17 21:21:50 +00:00
Ashok Narayanan a692269fc9 Added support for 802.1ad and 802.1ah ethernet frames
svn path=/trunk/; revision=22541
2007-08-17 21:21:18 +00:00
Guy Harris c193066114 At least some LAPB Windows Sniffer captures have 4 bytes of extra stuff
at the ends of packets.

svn path=/trunk/; revision=22540
2007-08-17 20:04:31 +00:00
Graeme Lunt 98688eb828 Further tidy up for preference.
svn path=/trunk/; revision=22539
2007-08-17 19:40:40 +00:00
Gerald Combs 72daa58e19 Instead of converting between 802.11 frequencies and channels umpteen
different ways, add a set of common conversion routines.  Add a
"Frequency/Channel" column and fill it in where we can.  Fix RSSI column
printing in PPI.

Fix up whitespace along the way.

svn path=/trunk/; revision=22538
2007-08-17 19:34:14 +00:00
Graeme Lunt 3d19c5130b Fix for OSX gremlin in PKCS12 template.
svn path=/trunk/; revision=22537
2007-08-17 19:23:15 +00:00