Commit Graph

26749 Commits

Author SHA1 Message Date
Anders Broman 2c1c572d08 Code cleanup.
svn path=/trunk/; revision=27576
2009-03-02 07:31:06 +00:00
Jeff Morriss 8320827203 Fix conversation tracking bug noticed in:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3216#c2

(Basically: how the dissector was dissecting frames--in the GUI--changed based
on the order you had clicked on them.)

... by rewriting how the frame states are maintained: rather than maintaining
a g_hash table of frames and their states, hang the (now se_alloc'd) frame
data off the frame (using p_*_proto_data()).

svn path=/trunk/; revision=27575
2009-03-01 21:37:30 +00:00
Anders Broman dc83437e56 Add more IE dissection.
svn path=/trunk/; revision=27574
2009-03-01 20:39:44 +00:00
Gerald Combs 7ff0d484c8 [Automatic manuf update for 2009-03-01]
svn path=/trunk/; revision=27572
2009-03-01 16:03:39 +00:00
Jaap Keuter 607981ea05 From Carles Kishimoto:
Dissector for the proprietary protocol FEFD (Far End Failure Detction) from Force10networks.

svn path=/trunk/; revision=27571
2009-03-01 15:32:17 +00:00
Guy Harris 067d476556 Clean up display of QoS PS Buffer State field.
svn path=/trunk/; revision=27570
2009-03-01 08:24:24 +00:00
Guy Harris 04072a4202 Show bit 4 of the QoS field for frames not coming from an AP.
Make the TXOP Limit, Queue Size, and TXOP Duration Request part of the
QoS field separate named fields, and show them in a bit better fashion.

svn path=/trunk/; revision=27569
2009-03-01 07:26:59 +00:00
Jeff Morriss 6ce992885e From Toralf Forster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3216 :
Implement mysql_dissect_row_packet().

From me: change all tvb_length_remaining() calls to
tvb_reported_length_remaining() so the dissector will throw an exception if
the packets are truncated.

svn path=/trunk/; revision=27568
2009-02-28 19:30:56 +00:00
Jeff Morriss 2a516cfe4d Remove a whole bunch of if(tree)'s that were protecting single
proto_tree_add_*() calls: those APIs check if tree is NULL too and taking
out the dissector's ifs makes the code easier to read.

svn path=/trunk/; revision=27567
2009-02-28 19:14:14 +00:00
Jeff Morriss 29e1dd0dc4 From Alex Turbov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3291 :
SNAC(4,2) actually have uint32_t type of last field and its mean time in
milliseconds

svn path=/trunk/; revision=27566
2009-02-28 18:26:46 +00:00
Jeff Morriss ed96ef8e03 From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3281 :
The LCS Client Type parameter in a BSSMAP Perform Location Request is not being
dissected (1.1 trunk).

The LCS Priority and LCS QoS are fine.

svn path=/trunk/; revision=27565
2009-02-28 04:27:43 +00:00
Martin Mathieson eeba728afb Fix counting of 'predefined' bytes.
svn path=/trunk/; revision=27564
2009-02-27 17:36:06 +00:00
Stig Bjørlykke 759b8ea9b1 Update the services file from IANA's port-numbers.
svn path=/trunk/; revision=27563
2009-02-27 12:51:11 +00:00
Martin Mathieson 887b68c64e Some context names now do include '-', so allow it.
svn path=/trunk/; revision=27562
2009-02-27 11:18:15 +00:00
Anders Broman 4602e4850d Add GTK deprecated functions.
svn path=/trunk/; revision=27561
2009-02-27 07:09:25 +00:00
Stig Bjørlykke 570722dab3 Remember the last used profile and restore this on startup.
svn path=/trunk/; revision=27560
2009-02-26 22:26:42 +00:00
Stig Bjørlykke adfda29e38 Don't write the recent file when leaving a deleted profile.
svn path=/trunk/; revision=27559
2009-02-26 22:24:18 +00:00
Anders Broman aa3b687793 gtk_menu_append is deprecated and should not be used in newly-written code. Use gtk_menu_shell_append().
svn path=/trunk/; revision=27558
2009-02-26 21:41:07 +00:00
Stig Bjørlykke 500b9039bd Use same coloring rule for icmp and icmpv6.
svn path=/trunk/; revision=27557
2009-02-26 21:30:33 +00:00
Anders Broman 04837ca7f2 gtk_label_set -> gtk_label_set_text
"gtk_label_set is deprecated and should not be used in newly-written code.
Aliases gtk_label_set_text()."

svn path=/trunk/; revision=27556
2009-02-26 21:11:06 +00:00
Anders Broman 25e8795a06 gtk_list_store_insert_with_values() requires GTK+ 2.6 or later.
From Jakub Zawadzki further optimisations.

svn path=/trunk/; revision=27555
2009-02-26 20:55:19 +00:00
Anders Broman 0d0d6c6621 Another small performance boost.
svn path=/trunk/; revision=27554
2009-02-26 16:46:00 +00:00
Stig Bjørlykke 56384aaa10 Removed some spaces in BCH Bytes and PCH Bytes.
svn path=/trunk/; revision=27553
2009-02-26 14:49:13 +00:00
Martin Mathieson 18b4db2852 More layout improvements (thanks Stig).
svn path=/trunk/; revision=27552
2009-02-26 11:47:37 +00:00
Stephen Fisher a0b1dcb2a1 Fix (private) bug #3278: When first opening the RTP stream analysis window,
it  hangs for a while before allowing the user to interact with the window.

Fixed by setting columns to fixed height and fixed width.

Also: Don't display columns we were hiding in the CList version of this
window.


svn path=/trunk/; revision=27551
2009-02-26 07:55:09 +00:00
Jaap Keuter 6895406b11 From Didier Gautheron:
ECWmin and ECWmax in the Beacon WME Information Element are not displayed correctly.
They appear as equal each to the other. It should be: byte2 & 0x0f, (byte2 & 0xf0) >> 4.

svn path=/trunk/; revision=27550
2009-02-26 05:42:55 +00:00
Jaap Keuter b47e7619e6 From Mark C. Brown:
Added support for HPVM (Integrity Virtual Machines) guest AVIO (Accelerated Virtual IO) driver IGSSN.
Cleaned up the trace record checks.  
Made the default ethernet if the nettl subsystem is not recognized.

svn path=/trunk/; revision=27549
2009-02-25 23:19:56 +00:00
Stig Bjørlykke 88b8066be3 Added make-tap-reg.py
svn path=/trunk/; revision=27548
2009-02-25 21:28:40 +00:00
Stig Bjørlykke f8b4868230 Added a few service values.
svn path=/trunk/; revision=27547
2009-02-25 20:28:36 +00:00
Martin Mathieson e39897e30d More updates to LTE MAC stats. Layout working better now.
svn path=/trunk/; revision=27546
2009-02-25 18:02:09 +00:00
Bill Meier 281c4d0f5d Prefs callback not req'd; hf[]: Use NULL (not "") for empty blurb.
svn path=/trunk/; revision=27545
2009-02-25 16:23:38 +00:00
Stig Bjørlykke 8e2068eb86 Added initial support for Canon BJNP.
svn path=/trunk/; revision=27544
2009-02-25 14:12:38 +00:00
Martin Mathieson 8728071ae9 Add a preference to control checking of reserved bits.
svn path=/trunk/; revision=27543
2009-02-25 11:33:47 +00:00
Guy Harris 260f06a9df Put in a comment discussing ways of better handling the FCS in various
protocols.

Clean up white space.

svn path=/trunk/; revision=27542
2009-02-25 11:25:12 +00:00
Guy Harris 0b013dbb5a Explain conversations and circuits.
svn path=/trunk/; revision=27541
2009-02-25 10:05:04 +00:00
Guy Harris eeae7f9ff0 Clean up the comments in the L2TP dissector about RFCs.
Clean up indentation a bit.

Clean up the L2TPv3 dissection a bit.

Make an OAM cell dissector, and have the L2TP dissector call it.

svn path=/trunk/; revision=27540
2009-02-25 09:26:27 +00:00
Jaap Keuter c265b3003d From Alex Turbov:
Decoding SNAC(13,1a) leads to DISSECTOR_ASSERT_NOT_REACHED in proto.c:1006
because of invalid call to proto_tree_add_item() in 
dissect_aim_snac_ssi_auth_reply() (@ packet-aim-ssi.c).

svn path=/trunk/; revision=27539
2009-02-25 06:33:56 +00:00
Guy Harris a721172b47 Port Mapping Protocol, not Plug-'n-Play.
Give the I-D number and a URL to the (now-expired) draft.

svn path=/trunk/; revision=27538
2009-02-25 00:36:31 +00:00
Stig Bjørlykke 248ca24f4f Removed mark for unused pinfo, its in use.
svn path=/trunk/; revision=27537
2009-02-25 00:28:19 +00:00
Stig Bjørlykke ee08eca67b Added support for NAT Port Mapping Protocol (NAT-PMP).
svn path=/trunk/; revision=27536
2009-02-25 00:22:47 +00:00
Jaap Keuter 4c277d1642 Get the Windows build going again.
svn path=/trunk/; revision=27535
2009-02-24 18:09:27 +00:00
Martin Mathieson dec6a82c10 Fix some of the UE issues in this window.
- don't use table with one row for common channel counts
- the UEs table now grows to fill vertical space as window is resized
- 4 rows UE details still don't all show...

svn path=/trunk/; revision=27534
2009-02-24 17:57:25 +00:00
Jaap Keuter d27c92e496 Add posibility to mark protocol as private. This prevents inadvertent Wiki access.
svn path=/trunk/; revision=27533
2009-02-24 17:24:03 +00:00
Anders Broman 0e38ede281 From Vincent Helfre:
Build the register routines for wtap plugins.

svn path=/trunk/; revision=27532
2009-02-24 07:04:41 +00:00
Jaap Keuter 860a6d7f95 From Jerry Kotland:
There's a slight error with one of the 802.11n SM Power Save labels.
Currently, when SM Power save == 3, the label is "SM enabled".
According to 802.11n Draft 2.07 it should be "SM Power Save disabled".

svn path=/trunk/; revision=27531
2009-02-24 06:37:45 +00:00
Stephen Fisher ae82bccc32 The beginnings of a World of Warcraft (WoW) protocol dissector.
svn path=/trunk/; revision=27530
2009-02-23 23:50:03 +00:00
Jaap Keuter 5d9a041d91 Fix for bug 3247:
Incorrect index adjustment causes failure to dissect multiple capabilities in optional parameters.

svn path=/trunk/; revision=27529
2009-02-23 22:07:19 +00:00
Stig Bjørlykke 60fd0aaf0b From Kip McAtee (bug 3274):
Don't indicate incorrect Payload Length when having trailing FCS.

svn path=/trunk/; revision=27528
2009-02-23 20:44:11 +00:00
Jaap Keuter 3eddf57266 From Steve Karg:
The ConfirmedEventNotification decoding was only done as far as context tag 8,
so BACnetNotificationParameters 9, 10, and 11 displayed as malformed packet.  
Added context tag decoding for BACnetNotificationParameters 9, 10, and 11. 
Added missing breaks in several switch statements.
Corrected some dissector aborts.
Added several new enumerations from the latest BACnet 135-2008 standard, and
updated the list of BACnet Vendor IDs.

svn path=/trunk/; revision=27527
2009-02-23 20:01:00 +00:00
Guy Harris 1514fcff5f Have the minimum snapshot length be 1 byte, and have a snapshot length
of 0 mean 65535, similar to what tcpdump does.

Fixes bug 2731.

svn path=/trunk/; revision=27526
2009-02-23 19:00:30 +00:00