If there are cleaner ways (better regex) to represent the logic, please feel free to update.
The key is to improve the "defaults" detected so less manual editting of the proto_tree_input file (and subsequent dissector file) is necessary.
I'll be testing it more (and probably updating) as I try to work through the checkAPIs.pl "naughty list" (now that the list has expanded)
svn path=/trunk/; revision=50559
I'm flexible on the definition of "small" (20 "fields"), but I think checkAPIs should flag the "all proto_tree_add_text" dissectors.
svn path=/trunk/; revision=50385
just define WS_DLL_PUBLIC_NOEXTERN inside the ifdefs, and define
WS_DLL_PUBLIC as WS_DLL_PUBLIC_NOEXTERN followed by "extern".
Then rename WS_DLL_PUBLIC_NOEXTERN to WS_DLL_PUBLIC_DEF, to clarify that
it's what should be used for definitions; at least on Windows, you
*have* to use it when declaring arrays without a size, and, whilst you
might be able to use WS_DLL_PUBLIC for definitions of functions and
perhaps data definitions other than no-size arrays, it might be clearer
to rename WS_DLL_PUBLIC to WS_DLL_PUBLIC_DECL and use it only for
declarations.
svn path=/trunk/; revision=50334
-Werror here but Autotools doesn't. Which is correct?)
epan/dissectors/dcerpc: idl2wrs isn't an installed executable in
Autotools so don't make it one in CMake.
svn path=/trunk/; revision=49871
to the tree (to separate this case from the generic DISSECTOR_BUG case).
Enable this environment variable when fuzz testing.
Enable the 3rd (without tree but with a read filter) check (added in r49643)
when testing capture files but not when fuzz testing--not sure if we want to
add even more to the fuzzbot's work load now (OTOH I've been running it for
a while and it hasn't buried me in bugs).
svn path=/trunk/; revision=49784
Running tshark with a read filter ("-R") and without building the full tree
("-V") causes it to run into some more bugs (usually loops adding more than
100000 items to the tree). Add some (commented out for now) code to do
this...
svn path=/trunk/; revision=49643
the same everywhere I've tested except my mac setup where it works better
(since the libtool in PATH doesn't have --mode=execute for some strange reason).
This is fairly experimental - feel free to revert if it breaks something.
svn path=/trunk/; revision=49604
the build-bot's valgrind pass wasn't running with/without tree. It's still
broken, but the debug output wasn't giving us any useful information.
svn path=/trunk/; revision=49464
- support testing multiple files at once
- use tools/test-common.sh to make sure we have the most up-to-date environment
variables set (the old version was missing the WMEM_ one for example)
- rename to test-captures.sh since it works just fine on non-fuzzed files
svn path=/trunk/; revision=49412
core, epan, and ui, and link them to each other to varying degrees. This
seems to be the best way to organize our documentation. The alternative
is to switch to a single doxygen.cfg and manually add files to different
groups or sections.
Add a wireshark.dox file which contains markup for the main page. Add
.dox and .txt to svnadd. Clean up our tag files. Force wsar_html to
rebuild each time.
svn path=/trunk/; revision=49091
backport-rev attempts to merge a revision from the trunk in the current
directory (presumably one of the release branches).
gen-bugnote fetches a bug title from bugs.wireshark.org and formats it
for inclusion in the release notes.
svn path=/trunk/; revision=49004
us to carry.
Add an exception of our own for tools/pidl since that is GPL but the headers
are not in a format that licensecheck will pick up, and fixing them all would
just introduce a delta with upstream for no reason.
svn path=/trunk/; revision=48896
- parser no longer use abort() after failing
- initial support for attributes
- symbol hashing to avoid strcasecmp()
- misc other fixes
svn path=/trunk/; revision=48672
development. Both the development and runtime packages are installed
although the latter aren't strictly necessary.
Ideally this could automatically pull the packages out of
packaging/rpm/SPECS/wireshark.spec.in but given the variance in package names
between distributions, this seems painful...
Tested on Fedora/Redhat and openSUSE.
svn path=/trunk/; revision=48624
The 'make-manuf'perl script gets the IEEE 22-bit OUI and IAB registries, but not OUI-36.
patch to get the OUI-36 listings.
From me:
Update header text in template to list the sources actually used.
svn path=/trunk/; revision=48572
(removed in r48218) which did nothing particularly useful. Also lets us remove
another debugging environment variable.
svn path=/trunk/; revision=48219
glib memory slices.
- We weren't doing anything with the emem slab that couldn't be done with glib
slices.
- Removes a fair bit of code as well as one debugging environment variable.
- Glib slices are much cache-friendlier and are multi-threading friendly (if
we ever go there).
- Allows glib to actually return slices to the OS on occasion. The emem slab
would hold onto its memory forever which resulted in a great deal of wasted
memory after closing a large file.
svn path=/trunk/; revision=48218
Parser pass almost all npl files from Network Monitor Parsers 3.4.2774 package,
but but not all data is stored in AST.
Work on wireshark code enerator has been started, but it need much more work.
Beware! It's ugly, putting it to wireshark repo, just to not lose sources :)
(feel free to improve/review it).
svn path=/trunk/; revision=48033
preferences (currently hidden) to disable updates, set the update
frequency, and set the update "channel" (stable vs development). Add a
"Help" menu item to manually check for updates.
svn path=/trunk/; revision=47748
Essentially:
Detect when an hf_... var is effictively initialized
via the use of proto_registrar_get_id_byname() or
proto_get_id_by_filter_name() (instead of
proto_register_field_array()).
svn path=/trunk/; revision=47542
(Commented out for now since a few false positives are currently generated).
Fix a few minor bugs;
Tweak the calling sequences for various subs.
svn path=/trunk/; revision=47476
- Handle preprocessed (as well as original) .c source files.
(Running checkhf on the source after it has been pre-processed
should give few false positives).
- Remove blank lines, comments & quoted text strings before
doing the hf_... tests: reduces false positives/negatives.
svn path=/trunk/; revision=47458
- Remove comments from the input string before checking hf[] entries;
- Remove code under '#if 0' before doing API checks.
svn path=/trunk/; revision=47447
Main objective: reduce the number of false positives.
(Committed as a patch to the original
checkhf.pl written by Joerg Mayer so as to
keep the history for the original program).
svn path=/trunk/; revision=47331
Main objective: reduce the number of false positives.
Normal usage: the same as for checkhf.pl.
For now: named checkhf-v2.pl
svn path=/trunk/; revision=47326
------------------------------------------------------------------------
r47305 | gerald | 2013-01-26 12:12:52 -0800 (Sat, 26 Jan 2013) | 6 lines
Changed paths:
M /trunk-1.8/tools/fuzz-test.sh
Instead of setting resource limits on the fuzz-test.sh process itself,
set limits on the TShark subprocess. This should hopefully take care
of the strange fuzz failures we've seen lately.
Reduce the maximum CPU time to 5 minutes while we're at it.
------------------------------------------------------------------------
svn path=/trunk/; revision=47307
For .../dissectors/(non-generated dissectors):
Reduces the number of "unused" false positives (and
adds about 2 different false positives).
svn path=/trunk/; revision=47280
Try to convince Coverity that the passed in item pointer is appreciated,
but not used.
This time see if it pleases the Windows compiler too.
svn path=/trunk/; revision=47217
variable (WIRESHARK_DEBUG_USE_SLICES) which turns off the slab allocator and uses
g_slices instead (which can themselves be turned off by setting
G_SLICE=always-malloc).
This makes debugging problems in slab-allocated memory easier to find
(hopefully including https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8197 ).
Set WIRESHARK_DEBUG_USE_SLICES when running Valgrind on *shark.
Remove unused structure member: emem_chunk_t.org.
svn path=/trunk/; revision=47110
"const char *", as it is now expected to be. Regenerate the dissectors.
Update the URL for OmniOrb.
In README.parlay, use idl2wrs in the sample command.
svn path=/trunk/; revision=46765
GTK+: Shorten the packet comment menu item name. Remove a couple of
unneeded includes.
Both: Add an arbitrary 20 MB limit when fetching all packet comments.
Use a color from the Tango palette for comments.
svn path=/trunk/; revision=46709
determine the desired type. This has two advantages over the old way:
- just one environment variable for valgrind to override in order to guarantee
that ALL allocators use memory it can track, and just one place to check that
variable
- allocator owners no longer have to include headers specific to their
allocator, allowing them to change allocators without adjusting all their
#includes
svn path=/trunk/; revision=46604
Michael Mann