231f36be53
(Trivial) Fix a typo in a comment.
...
svn path=/trunk/; revision=39089
2011-09-22 15:57:41 +00:00
4a3d86e46c
Be careful about reporting number of missing SNs when wrapping around SN range.
...
svn path=/trunk/; revision=39088
2011-09-22 15:28:46 +00:00
86878844b6
Show if per packet info is missing.
...
svn path=/trunk/; revision=39087
2011-09-22 08:59:24 +00:00
ded5c901fa
Store a pointer to frame_data rather than the time.
...
svn path=/trunk/; revision=39086
2011-09-22 08:46:09 +00:00
fd2f818353
Use ENC_ values in proto_tree_add_item() calls.
...
In the AgentX dissector, make the "flags" arguments guint8, to match
what's passed in.
In the AIM dissector, use val_to_str() in col_add_str() calls - it gives
the same result if there's a match, and puts a note in the Info column
if there isn't, and is less complicated.
In the AJP13 dissector:
update the URL for the protocol documentation;
add #defines for message types, and use them;
for "enumerated data type" fields, make the fields numerical
rather than strings and give them the value_string tables;
get rid of col_check() calls;
make a Boolean item an FT_BOOLEAN.
svn path=/trunk/; revision=39085
2011-09-22 03:10:30 +00:00
ad1efb6b9c
(Trivial) Remove trailing whitespace from lines for a few files.
...
svn path=/trunk/; revision=39084
2011-09-21 23:42:55 +00:00
d4a982fd1f
Use '%" G_GINT64_MODIFIER "u' iso '%llu'. Fixes checkapi fail and (presumably) compile errors.
...
svn path=/trunk/; revision=39083
2011-09-21 21:07:07 +00:00
e6bd9d1a8c
Whitespace cleanup:
...
Use consistent indentation;
Convert "4 space tabs" to spaces;
Remove trailing whitespace.
svn path=/trunk/; revision=39082
2011-09-21 18:55:03 +00:00
781129806f
Fix ex "modeline" so it works;
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748
svn path=/trunk/; revision=39081
2011-09-21 17:49:11 +00:00
ee167d7363
Don't pop up an error dialog box for every file that can't be saved. Before, this could have potentially meant having to manually close far too many of them.
...
svn path=/trunk/; revision=39080
2011-09-21 17:41:12 +00:00
6e66257c5d
Fix ex "modeline" so it works;
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748
Convert "4 space tabs" to spaces;
Use consistent indentation.
svn path=/trunk/; revision=39079
2011-09-21 17:32:35 +00:00
16f162eb5d
Fix ex "modeline" so it works;
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748
Convert '4 space tabs' to spaces;
svn path=/trunk/; revision=39078
2011-09-21 17:14:14 +00:00
d41594e01b
Report as expert/malformed if the same SN appears as ACK and NACK in same status PDU.
...
svn path=/trunk/; revision=39077
2011-09-21 16:45:03 +00:00
a58121db53
Fix vi "modeline" so it works;
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748
svn path=/trunk/; revision=39076
2011-09-21 16:44:10 +00:00
14dd4c3c8d
Convert "4 space tabs" to spaces;
...
Fix vi edtor modeline so it works.
svn path=/trunk/; revision=39075
2011-09-21 16:41:14 +00:00
4c46725c2c
Fix vi "modeline" so it works;
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748
svn path=/trunk/; revision=39074
2011-09-21 16:28:53 +00:00
37e7fec6cd
Explicit #include <epan/value_string.h> not required.
...
svn path=/trunk/; revision=39073
2011-09-21 16:14:18 +00:00
dc75d97b91
Fix and suppress some warnings
...
svn path=/trunk/; revision=39072
2011-09-21 10:10:00 +00:00
665de07254
Remove Makefile.in
...
Set default svn:ignore targets.
svn path=/trunk/; revision=39071
2011-09-21 08:44:49 +00:00
215d3611ed
Remove check_col and use ENC_BIG_ENDIAN.
...
svn path=/trunk/; revision=39070
2011-09-21 08:33:38 +00:00
947d3c9fa2
Add asn/t124/Makefile to configure.in and remove it from the repository.
...
svn path=/trunk/; revision=39069
2011-09-21 08:16:33 +00:00
5f332e47e2
Fix for unary minus warning on Windows
...
svn path=/trunk/; revision=39068
2011-09-21 08:09:04 +00:00
c0c4fb5f21
Make query_length a gint as the lenght argument to proto_tree_add_text() is a gint.
...
svn path=/trunk/; revision=39067
2011-09-21 07:36:26 +00:00
9db6d40656
Basic RDP dissection, which can dissect the connection sequence.
...
A work in progress.
Can be used with the SSL dissector to decrypt Enhanced RDP Security SSL.
With Standard RDP Security (e.g those on Wiki), the PDUs are all encrypted
after the SecurityExchange PDU.
Wiki to be updated with an example SSL protected capture and associated
key material.
svn path=/trunk/; revision=39066
2011-09-21 07:35:51 +00:00
3e7c0390d7
From Frank Lahm: Complete dissection of AFP FPSpotlightRPC function.
...
From me: don't use global variables in FPSpotlightRPC dissection.
svn path=/trunk/; revision=39065
2011-09-20 19:24:07 +00:00
0989347195
Add an ENC_ASCII; right now, it's the same as ENC_UTF_8, but it should
...
eventually cause all bytes with the 8th bit set to be displayed as error
indications.
svn path=/trunk/; revision=39064
2011-09-20 17:42:27 +00:00
98bbf4578d
Use ENC_ values in proto_tree_add_item() calls. Use ENC_UTF_8 for
...
strings, and note that, for older AFP clients and servers, we might need
a way to say to use some Mac encoding instead.
Use tvb_strsize() rather than tvb_get_ephemeral_stringz() to just get
the length of a null-terminated string.
Use FT_GUID for UUIDs.
The low-order bit in the MessageBitmap in the FPGetSrvrMsg reply does
not, at least according to the current AFP spec, specify whether there's
a message at all, it specifies whether it's a server message or a login
message. The spec *does* now mention the "message is UTF-8" bit; use
it.
Fix a blurb.
svn path=/trunk/; revision=39063
2011-09-20 17:23:16 +00:00
283a957ee0
Add DeCount for his contribution in bug 6362.
...
svn path=/trunk/; revision=39062
2011-09-20 16:42:22 +00:00
46ded6ec8f
From DeCount via bug 6362: Increase maximum allowable number of duplicate filesi from 10 to 1000. I modified his patch to avoid appending anything to the first filename, and other minor changes.
...
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6362
svn path=/trunk/; revision=39061
2011-09-20 16:28:21 +00:00
ec41ae8a1b
From Sylvain Munaut:
...
Add support for signed types in _proto_tree_add_bits_ret_val
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6363
svn path=/trunk/; revision=39060
2011-09-20 11:29:53 +00:00
0554530407
From Dirk via bug 6361:
...
Use File/Directory Dialog as a field type for UAT preferences.
svn path=/trunk/; revision=39059
2011-09-20 10:15:09 +00:00
c3cb0e6dd9
From Dirk via bug 6361:
...
Add a File/Directory Dialog as a field type for UAT preferences.
svn path=/trunk/; revision=39058
2011-09-20 10:14:58 +00:00
e672fdc60f
Since the call to expert_add_info_format() was commented out, 'ti' isn't needed, so get rid of it. Fixes Coverity CID's 1260 and 1261.
...
svn path=/trunk/; revision=39057
2011-09-19 20:49:28 +00:00
9059904629
Don't assign the return value of proto_tree_add_text() if it's not going to be used. Fixes Coverity CID 1232.
...
svn path=/trunk/; revision=39056
2011-09-19 20:41:17 +00:00
fb19d6ab0f
Since the call to proto_tree_add_text() was #if 0'd out, there's no need to assign the return value of tvb_new_subset to wlan_tvb. Actually, there's probably no need to call tvb_new_subset() in the first place, but for now let's just tackle the unused value warning and leave the FIXME for someone who knows more about this. Fixes Coverity CID 864.
...
svn path=/trunk/; revision=39055
2011-09-19 20:37:20 +00:00
a4d1ae6547
Don't assign return value of proto_tree_add_text() to rrsc_item if it's not going to be used. Fixes Coverity CID 863.
...
svn path=/trunk/; revision=39054
2011-09-19 20:28:10 +00:00
5b85e16735
Move the return out of the for() loop so all values are freed. Fixes Coverity CID 1277 (loop increment j++ is unreachable).
...
svn path=/trunk/; revision=39053
2011-09-19 20:19:43 +00:00
7012c496c9
The change in r37371 fixed the clv_tree unused assignment and pointless use, but caused another unused assignment to 'ti'. Fixed. (Coverity CID 1233)
...
svn path=/trunk/; revision=39052
2011-09-19 20:09:31 +00:00
bbc7a98ea6
Don't assign the return value of proto_tree_add_item() if it's not going to be used. Fixes Coverity CID's 1278-1280 (UNUSED VALUE).
...
svn path=/trunk/; revision=39051
2011-09-19 19:59:00 +00:00
417e8f7469
Delete duplicate line of code. Fixes Coverity CID 1281 (UNUSED VALUE).
...
svn path=/trunk/; revision=39050
2011-09-19 19:49:06 +00:00
f47ccd73c1
Close fp before checking if private_key is NULL to avoid memory leak. Fixes Coverity 597.
...
svn path=/trunk/; revision=39049
2011-09-19 19:32:46 +00:00
eead84d53a
Fix static overrun bug introduced in r37506. Fixes Coverity CID 1216.
...
svn path=/trunk/; revision=39048
2011-09-19 19:14:41 +00:00
49822d9dae
Various Cleanups...
...
- Don't use 'l' as a variable name;
- Use 'tvb_strsize();proto_tree_add_item();' iso 'tvb_get_ephemeral_stringz(); proto_tree_add_string();'
- Use ENC_NA/ENC_BIG_ENDIAN iso FALSE as appropriate for proto_tree_add_item().
svn path=/trunk/; revision=39047
2011-09-19 19:13:34 +00:00
099624f319
Fix compile error: just link to expert_group_vals[] in expert.c (no need for a copy in tap-expert.c).
...
svn path=/trunk/; revision=39046
2011-09-19 17:59:20 +00:00
c34335ebef
Add expert 'Group' to output.
...
svn path=/trunk/; revision=39045
2011-09-19 13:53:29 +00:00
59eb943780
Use ENC_NA and ENC_BIG_ENDIAN rather than FALSE in proto_tree_add_item()
...
calls and tvb_get_guid() calls.
For strings, add ENC_UTF_8.
svn path=/trunk/; revision=39044
2011-09-19 11:02:35 +00:00
fbe6cdc5db
Fix a crash when zooming into a TSN plot.
...
Provided by Irene Ruengeler.
From me: remove tailing whitespaces.
svn path=/trunk/; revision=39043
2011-09-19 10:23:36 +00:00
0bb00a2e64
RFC 4282 says the NAI is UTF-8.
...
svn path=/trunk/; revision=39042
2011-09-19 10:17:27 +00:00
5f854948d4
Use ENC_NA and ENC_LITTLE_ENDIAN rather than TRUE or FALSE in
...
proto_tree_add_item() calls.
For strings, add ENC_UTF_8. (Yes, the byte order is irrelevant for
those - but they should arguably be FT_UINT_STRING, as they're counted
strings, and the byte order *is* relevant for FT_UINT_STRING.)
svn path=/trunk/; revision=39041
2011-09-19 10:10:14 +00:00
38b78a16a3
Some probably-erroneous TRUEs as the last argument to
...
proto_tree_add_item(); the items were one byte long, so the byte order
is irrelevant.
svn path=/trunk/; revision=39040
2011-09-19 09:55:36 +00:00
Bill Meier