21bed98150
Fix several [-Wunused-const-variable] warnings (using '#if 0').
...
svn path=/trunk/; revision=52866
2013-10-26 03:16:57 +00:00
70cf133bf5
Cleanups to the TPNCP database parser/loader:
...
- use and free glib memory instead of ep_ memory - another dissector down
- propogate errors correctly
- produce a warning if an error occurs loading the DB
- add XXX comments about realloc handling that may or may not be a memory leak
in failure cases
svn path=/trunk/; revision=52865
2013-10-26 02:54:58 +00:00
2ebf40a1c2
Bluetooth: SDP: Decode all types of UUIDs. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 ).
...
From Michal Labedzki
svn path=/trunk/; revision=52864
2013-10-26 02:36:56 +00:00
3cc6957fa8
Bluetooth: Use items for logical block objects. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
Bluetooth protocols use items, so dissect it to improve filtering and better user experience - text object cannot be filterable or comparable.
From Michal Labedzki
svn path=/trunk/; revision=52863
2013-10-26 02:24:04 +00:00
6dd42b581a
Fix some [-Wunused-const-variable] warnings (using '#if 0')
...
svn path=/trunk/; revision=52862
2013-10-26 02:09:14 +00:00
63869c4037
Bluetooth: SDP: Add MultiProfile UUIDs. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52861
2013-10-26 00:53:23 +00:00
d8f1af511f
Mark a bunch of no-longer-used parameters as unused. Remove a couple of
...
unused parameters.
svn path=/trunk/; revision=52860
2013-10-26 00:41:54 +00:00
250568ca91
Bluetooth: SDP: Fix PBAP features presentation. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52859
2013-10-26 00:36:16 +00:00
68a5e46e9d
OBEX: Fix Presentation of Reserved Fields. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52858
2013-10-26 00:31:42 +00:00
5030e21822
Replace tabs by spaces. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52857
2013-10-26 00:26:41 +00:00
1e0405a3a3
Remove SMB's use of private_data and just pass the data through all of the dissection functions
...
svn path=/trunk/; revision=52856
2013-10-25 23:59:30 +00:00
7a2de9f471
More sequence dialog updates.
...
Draw item labels and port numbers. Update the hint text. Make items
selectable. Resize fonts similar to the GTK+ version. Add scrollbars.
Update the cursor. Use pango_layout_set_ellipsize() in the GTK+ code.
Fixup comments.
svn path=/trunk/; revision=52855
2013-10-25 23:16:56 +00:00
95f484a91e
Add a very small hack to make the UAT update callback error string freeable, and
...
convert all existing UAT update callbacks to use glib memory instead of
ephemeral memory for that string.
UAT code paths are entirely distinct from packet dissection, so using ephemeral
memory was the wrong choice, because there was no guarantees about when it would
be freed.
The move away from emem still needs to be propogated deeper into the UAT code
itself at some point.
Net effect: remove another bunch of emem calls from dissectors, where replacing
with wmem would have caused assertions.
svn path=/trunk/; revision=52854
2013-10-25 22:14:25 +00:00
7a3febacac
Exit if we're building with Qt and we can't find macdeployqt.
...
svn path=/trunk/; revision=52853
2013-10-25 21:37:30 +00:00
a049a2027c
Sync up with packet-pana.c.
...
svn path=/trunk/; revision=52852
2013-10-25 21:16:39 +00:00
9fd46d8299
wmemify.
...
svn path=/trunk/; revision=52851
2013-10-25 21:04:22 +00:00
b190de385a
Fix CID 281375 (dead code) while hopefully fixing detection of Class-2 ERR
...
messages.
Also fix a couple of incorrect MTP3 standard detections that I found.
svn path=/trunk/; revision=52850
2013-10-25 20:38:50 +00:00
ce22ab5ef6
Add an exception to the license-checker for Samba's special IDL license which
...
appears to be compatible as far as I can tell (not a lawyer). See:
https://www.wireshark.org/lists/wireshark-dev/201310/msg00234.html
svn path=/trunk/; revision=52849
2013-10-25 18:14:36 +00:00
274596eaab
Fix up some formatting and white space.
...
svn path=/trunk/; revision=52848
2013-10-25 15:25:46 +00:00
ce23d50028
Fix CID 715143: assert that the preference we were looking for was found. It
...
should be which is why this is an assertion not a NULL check.
svn path=/trunk/; revision=52847
2013-10-25 15:00:00 +00:00
81b0681c12
Fix CID 715144: assert that the preference we were looking for was found. It
...
should be which is why this is an assertion not a NULL check.
svn path=/trunk/; revision=52846
2013-10-25 14:57:55 +00:00
4cfc0f27cb
Kafka's CRC is 4 bytes long and is added with ENC_BIG_ENDIAN. Make the hf
...
FT_UINT32 instead of FT_BYTES to match.
svn path=/trunk/; revision=52845
2013-10-25 14:41:12 +00:00
3440dd73f2
Fix CID 1080758: be prepared for tvb_child_uncompress() failing (and returning
...
NULL).
svn path=/trunk/; revision=52844
2013-10-25 14:38:39 +00:00
2aae7bc4a6
Fix CID 280081: ENC_NULL can't be used as an array index into ciphers[], rather
...
ENC_NULL-0x30 needs to be used.
(This could probably use some cleanup...)
svn path=/trunk/; revision=52843
2013-10-25 14:15:28 +00:00
ab97b9d50b
Fix CID 1111806: it's not safe to check if "tag < sizeof(tag_to_type)" before
...
accessing tag_to_type[tag]: while the array is made of enums and the values of
the enum will fit in a guint8 (making the conditional safe) compilers don't
*have* to "right size" the storage for the enum. They very well could be lazy
and store the enum in int's.
Replace it with a macro that tells us the size of the array.
svn path=/trunk/; revision=52842
2013-10-25 14:04:22 +00:00
02784747f7
Make sure "mp2t-dsmcc" dissector is registered by name so it can be picked up by etv dissector.
...
svn path=/trunk/; revision=52841
2013-10-25 13:37:10 +00:00
3e4c954fd8
Fix checkAPIs: don't add hf_zbee_beacon_protocol with
...
proto_tree_add_uint(..., ENC_NA); use proto_tree_add_item() as it appears
was intended.
svn path=/trunk/; revision=52840
2013-10-25 13:24:29 +00:00
86b6659210
Fix CID 1111814: segment_item is set but not used (in one conditional).
...
Move a URL from in the middle of the copyright notice to up where it (appears
to) belong.
svn path=/trunk/; revision=52839
2013-10-25 13:23:17 +00:00
62b66aca7c
Display the frame number on the packet summary line if it's one of the configured columns. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9317
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=52838
2013-10-25 12:51:16 +00:00
cf1f098afb
Improvements for the KDSP dissector. Bug 8891 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8891 )
...
From Yuri Schaeffer
svn path=/trunk/; revision=52837
2013-10-25 02:41:47 +00:00
c09b328e13
Pass ieee802154_packet data into the heuristic check instead of using private_data.
...
svn path=/trunk/; revision=52836
2013-10-25 02:02:02 +00:00
ab0ad4aa1c
Make TAPA dissector heuristic instead of "ugly hack" now that IP dissector supports heuristics.
...
IP heuristics pass in IP header to help subdissectors decide what to do.
svn path=/trunk/; revision=52835
2013-10-25 01:54:53 +00:00
0cc2c88c2e
Fix more SVN properties.
...
svn path=/trunk/; revision=52834
2013-10-25 01:25:23 +00:00
ed7af16d9f
Handle *.rtf and *.qm files.
...
svn path=/trunk/; revision=52833
2013-10-25 01:25:00 +00:00
787bca8ea0
Add SVN properties.
...
svn path=/trunk/; revision=52832
2013-10-25 00:56:17 +00:00
29a4ebc5d4
Mark unused parameter, remove moved .h file from Makefile.common
...
svn path=/trunk/; revision=52831
2013-10-25 00:08:07 +00:00
9563de93a3
AIM doesn't ever use it's private_data structure, so remove it. If it ever does, just pass the data into the subdissectors.
...
svn path=/trunk/; revision=52830
2013-10-24 23:59:47 +00:00
8a707b0af5
Fix properties
...
svn path=/trunk/; revision=52829
2013-10-24 23:52:58 +00:00
61c7a1bc04
Make things compile again.
...
svn path=/trunk/; revision=52828
2013-10-24 23:47:30 +00:00
e83fe18fcc
Have ZigBee dissectors pass data through subdissector parameter instead of using struct _packet_info.
...
svn path=/trunk/; revision=52827
2013-10-24 23:40:58 +00:00
6131c00358
Add sequence_dialog.ui.
...
svn path=/trunk/; revision=52826
2013-10-24 23:11:09 +00:00
cb3cfd1cf9
Add a missing dependency.
...
svn path=/trunk/; revision=52825
2013-10-24 23:01:30 +00:00
1a4033b63b
Initial and woefully incomplete flow graph support.
...
Copy common code from ui/gtk/flow_graph.c and ui/gtk/graph_analysis.[ch]
to ui/tap-sequence-analysis.[ch]. Start using the name "sequence" in
places.
svn path=/trunk/; revision=52824
2013-10-24 22:52:30 +00:00
39fd5f29af
Fix copy paste errors
...
svn path=/trunk/; revision=52823
2013-10-24 21:11:00 +00:00
bc8006b224
fix offset calculation
...
highlight the correct payload bytes for unknown sub-descriptors
svn path=/trunk/; revision=52822
2013-10-24 20:59:32 +00:00
8601a75d51
Finish implementing https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7263 :
...
Change cflow.sysuptime from an FT_UINT32 (milliseconds since the router booted)
to an FT_RELATIVE_TIME (seconds since the router booted). I don't imagine
anyone will care if we show them seconds or milliseconds and it satisfy the
user's request (in that bug) to compare cflow.sysuptime to cflow.timeend (which
is already an FT_RELATIVE_TIME).
(If someone does care, we could always display the field twice, once in
milliseconds and once in seconds.)
svn path=/trunk/; revision=52821
2013-10-24 20:52:00 +00:00
1b69a6a94d
CID 700176: Dereference null return value (NULL_RETURNS)
...
Not sure whether this is really possible, but add a dissector_assert
just to be safe.
svn path=/trunk/; revision=52820
2013-10-24 20:35:53 +00:00
5303e144a3
Confirm the license as well.
...
svn path=/trunk/; revision=52819
2013-10-24 17:24:07 +00:00
f5492ad94a
Enable QtMultimedia. We'll need it for VoIP playback at some point.
...
(The current Qt packages in wireshark-win{32,64}-libs still have
QtMultimedia disabled. This will hopefully make sure it's enabled next
time around.)
svn path=/trunk/; revision=52818
2013-10-24 17:23:13 +00:00
86790a6471
Add a command code.
...
svn path=/trunk/; revision=52817
2013-10-24 16:50:14 +00:00
Bill Meier