Commit graph

28244 commits

Author SHA1 Message Date
Gerald Combs
1e93d53b56 Use "svn info" to fetch the version by default. Fetch the repository path as
well. Add the repository path to the version strings.

svn path=/trunk/; revision=29171
2009-07-22 23:59:15 +00:00
Anders Broman
0b0ff6cdcf Get rid of check_col() in some of the more frequently used dissectors.
svn path=/trunk/; revision=29170
2009-07-22 21:33:47 +00:00
Anders Broman
213a926bd9 From kovarththanan Rajaratnam:
Pass column_info as a pointer (new packet list).

svn path=/trunk/; revision=29169
2009-07-22 17:35:28 +00:00
Anders Broman
69e79617ef From Jakub Zawadzki:
This patch fix return value in new_packet_list_find_row_from_data when !select

From Me: Change back the cell coloring and remove the horizontal-separator making the colorinjg look the same as in the old packet list.

svn path=/trunk/; revision=29168
2009-07-22 15:23:08 +00:00
Martin Mathieson
41b86b26b8 Improve/expand checks on reserved bit values.
svn path=/trunk/; revision=29167
2009-07-22 13:21:15 +00:00
Anders Broman
45c1df205f From Jakub Zawadzki:
This patch makes row coloring alike GtkCList version
 (remove white space between cells/columns)

svn path=/trunk/; revision=29166
2009-07-22 08:54:38 +00:00
Anders Broman
c9b459f8e6 Take 2:
From Jakub Zawadzki:
This patch is cut&paste code from gtk/main_packet_list.c:packet_list_compare()
to new function frame_data_compare()
+ it make use of new function inside packet_list_compare() and
packet_list_compare_records()

svn path=/trunk/; revision=29165
2009-07-22 08:11:50 +00:00
Anders Broman
f186fba577 From Jakub Zawadzki:
This patch is cut&paste code from gtk/main_packet_list.c:packet_list_compare()
to new function frame_data_compare()
+ it make use of new function inside packet_list_compare() and
packet_list_compare_records()

svn path=/trunk/; revision=29164
2009-07-22 08:09:22 +00:00
Anders Broman
203fb3f25f Minor indentation fixes.
svn path=/trunk/; revision=29163
2009-07-22 06:00:53 +00:00
Stephen Fisher
c570bf42e2 Change some g_malloc() calls to g_new() to make the code easier to read.
svn path=/trunk/; revision=29162
2009-07-22 05:02:24 +00:00
Stig Bjørlykke
7e99557d05 Another try to fix the compiler warnings on win64.
svn path=/trunk/; revision=29161
2009-07-21 22:23:34 +00:00
Stig Bjørlykke
49cb1d37ee Cummulative number of packets lost is a signed 24 bits value.
This fixes bug 3763.

Cleanup some proto_tree_add_uint() -> proto_tree_add_item().

svn path=/trunk/; revision=29160
2009-07-21 22:09:31 +00:00
Stig Bjørlykke
8c4abdfb47 From didier gautheron via bug 3762:
This patch removes col_expr in frame_data structure,
it can be recomputed when needed.

svn path=/trunk/; revision=29159
2009-07-21 16:48:16 +00:00
Guy Harris
8300e59b2f More gsizery.
svn path=/trunk/; revision=29158
2009-07-21 09:05:16 +00:00
Guy Harris
a864f7d89a GLib documentation says the 3rd and 5th arguments to g_iconv are "gsize
*"s.

svn path=/trunk/; revision=29157
2009-07-21 08:53:39 +00:00
Anders Broman
f610ec3c46 size_t -> int to make the Win64 build bot happy.
svn path=/trunk/; revision=29156
2009-07-21 08:35:24 +00:00
Stig Bjørlykke
6dbdc38c53 Initialize bacapp_invoke_id to avoid a compiler warning.
svn path=/trunk/; revision=29155
2009-07-21 08:07:40 +00:00
Martin Mathieson
a2d0ad942f Stop using the C++ 'true' and 'false'.
I still get a compilation error...

packet-bacapp.c: In function `dissect_bacapp':
packet-bacapp.c:6350: warning: 'bacapp_invoke_id' might be used uninitialized in this function

... although I've followed the paths (including the setting of 'segment'), and it looks bogus to me.


svn path=/trunk/; revision=29154
2009-07-21 07:59:16 +00:00
Guy Harris
dafbc0abf3 Fix typo.
svn path=/trunk/; revision=29153
2009-07-21 07:44:04 +00:00
Guy Harris
b6953e2c26 Don't use tvb_length_remaining() - that just reports how much captured
data is available, not how big the packet really is.

Clean up white space.

Get rid of an unused parameter and two unused variables.

svn path=/trunk/; revision=29152
2009-07-21 07:28:47 +00:00
Anders Broman
3e1365cc15 From Herbert Lischka:
Added some new features to BACnet dissection:
- ListOfObjectPropertyReferences in scheduler
- RestartReason
- Properties for loop-object
- LogDeviceObjectProperty in trend-log object
- log-buffer entries in trend-log object

- reassemby of fragmented messages
- fallback changed if iconv-library is not here

Me: Moved includes from .h to .c as thats how we normaly do it.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3736

svn path=/trunk/; revision=29151
2009-07-21 06:20:47 +00:00
Anders Broman
617077e94a From Benjamin Meyer:
Profinet dissector does not decode all defined error codes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753

svn path=/trunk/; revision=29150
2009-07-21 06:08:45 +00:00
Anders Broman
c526a96ec5 From Gerasimos Dimitriadis:
Enhancement to E.212 MCC/MNC decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3759

svn path=/trunk/; revision=29149
2009-07-21 06:02:12 +00:00
Anders Broman
7c0fb707a5 Implement new_packet_list_find_row_from_data()
Goto frame should work now.

svn path=/trunk/; revision=29147
2009-07-20 16:09:50 +00:00
Stig Bjørlykke
f900d9c3a5 From Jakub Zawadzki via bug 3701:
Fix regressions in r29130 and r29133
In r29130 formating for DSECS was changed. (old: %01d now: %02d)
In r29133 adding sign was removed (old: buf[0] = '-' now: buf[0] = '\0')

svn path=/trunk/; revision=29146
2009-07-20 12:40:55 +00:00
Stig Bjørlykke
d0a970fb72 Changed to use "Field type" instead of "Format", to be more descriptive.
Moved "Filed name" fields below "Field type", to improve the layout.
Always show the "Field name" fields, disable when field type is not custom.
Remember field name even when changing field type, so the user can change his
mind without losing the data entered.
Some small adjustments to "Add" and "Remove" buttons.
Added some tooltips.

svn path=/trunk/; revision=29145
2009-07-20 11:42:28 +00:00
Anders Broman
9de6f58cff Redraw the list when color filters are enabled/disabled.
svn path=/trunk/; revision=29144
2009-07-20 11:33:02 +00:00
Anders Broman
30c88f818c Avoid a crash if no color filter exists (SCTP trace).
svn path=/trunk/; revision=29143
2009-07-20 09:06:47 +00:00
Stephen Fisher
edc8ae64f1 Introduce packet list coloring for the NEW_PACKET_LIST. One caveat: when
enabling/disabling the coloring of the packet list from the menus, the user
has to drag the mouse cursor over each displayed row to take away/add the
coloring.  Dragging the scroll bar up or down will also take care of this as
only the displayed rows are colored.


svn path=/trunk/; revision=29142
2009-07-20 06:21:35 +00:00
Gerald Combs
96be1a38da [Automatic manuf and enterprise-numbers update for 2009-07-19]
svn path=/trunk/; revision=29138
2009-07-19 15:03:36 +00:00
Stig Bjørlykke
221225e0f3 From Kovarththanan Rajaratnam via bug 3719:
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.

From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.

svn path=/trunk/; revision=29137
2009-07-18 20:10:14 +00:00
Gerald Combs
72e160eb4d Set the extension channel correctly. Fixup whitespace.
svn path=/trunk/; revision=29135
2009-07-17 22:59:59 +00:00
Bill Meier
095f4a5c12 From Robert Hogan: "no need to register tn3270 for 'decode-as'".
svn path=/trunk/; revision=29134
2009-07-17 19:41:34 +00:00
Gerald Combs
25e7cac69d Fix an ep buffer overrun introduced in r29130.
svn path=/trunk/; revision=29133
2009-07-17 15:59:24 +00:00
Bill Meier
891d655e8a Minor changes: Move protocol_register & etc to end;
Use find_dissector instead of create_dissector_handle.

svn path=/trunk/; revision=29132
2009-07-17 14:25:56 +00:00
Anders Broman
2d76d327e1 make it possible to retreive the record with packet_list_get_value().
svn path=/trunk/; revision=29131
2009-07-17 13:42:46 +00:00
Anders Broman
3278582767 From Kovarththanan Rajaratnam:
Optimize column fill path.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3701

svn path=/trunk/; revision=29130
2009-07-17 08:24:06 +00:00
Jaap Keuter
f9177273d8 From Robert Hogan:
I'm working on a tn3270 dissector. 
See: http://roberthogan.net/stuff/tn3270-dissector/

svn path=/trunk/; revision=29129
2009-07-17 06:49:58 +00:00
Gerald Combs
75e048491a Check for an overflow. This should hopefully fix bug 3672.
svn path=/trunk/; revision=29128
2009-07-16 22:25:06 +00:00
Gerald Combs
bad647581b Initialize a variable and remove a check_col.
svn path=/trunk/; revision=29127
2009-07-16 22:24:31 +00:00
Gerald Combs
b0aa9d9696 Use SE_COPY_ADDRESS instead of trying to attach ep_alloced data to an
se_alloced struct.

svn path=/trunk/; revision=29126
2009-07-16 21:35:54 +00:00
Anders Broman
1196da707d From Rajasekhar Reddy Gali:
packet-wimaxasncp.c file need to update with latest wimax spec.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730

svn path=/trunk/; revision=29125
2009-07-16 21:27:56 +00:00
Anders Broman
af3ad92c81 From Sean Yunjnz:
Problem in packet-per.c for ASN.1 PER Encoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3733

svn path=/trunk/; revision=29124
2009-07-16 21:09:18 +00:00
Gerald Combs
fcac7c5695 Make sure some variables are initialized so that Valgrind quits
complaining.  Use se_memdup to copy memory.

svn path=/trunk/; revision=29123
2009-07-16 21:03:39 +00:00
Gerald Combs
753e9f65e5 Zero out the packet_info struct for each packet instead of trying to
initialize everything by hand. Fixes a Valgrind warning.

svn path=/trunk/; revision=29122
2009-07-16 20:52:36 +00:00
Jaap Keuter
05babef3b4 From David Dahlberg:
As for now, Wireshark supports only 96-bit (or 0-bit for NULL authentication)
integrity control values (ICVs) for IPsec ESP. While the autentication field is
of variable length, this may lead to situations where the whole packet is not
parsable.

To solve this, I added generic classes (not checked) for 128, 192 and 256 bit
ICVs to the ESP dissector. I also split the HMAC-SHA-256 autentication
algorithm to HMAC-SHA-256-128 (128 bit as defined in RFC 4868) and
HMAC-SHA-256-96 (from the very first draft, nevertheless unpatched Linux and
BSDs do it this way).

svn path=/trunk/; revision=29121
2009-07-16 19:57:15 +00:00
Gerald Combs
517d9cec5f Don't crash if we happen to load a bad MIB file.
svn path=/trunk/; revision=29118
2009-07-16 17:00:58 +00:00
Jeff Morriss
bca2a16879 /MP also works with 2008EE
svn path=/trunk/; revision=29116
2009-07-16 12:39:50 +00:00
Stig Bjørlykke
e9066532cf From Kahou via bug 3739:
New DLT value is added for Fibre Channel FC2.

svn path=/trunk/; revision=29115
2009-07-16 10:45:14 +00:00
Anders Broman
67d6f5976e Move th /MP flag setting to LOCAL_CFLAGS set in configure.nmake
for MSVC variant 2008 only. As suggested by Bill Meier.

svn path=/trunk/; revision=29114
2009-07-16 08:27:18 +00:00