osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
56,525 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

294 Commits

Author SHA1 Message Date
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Martin Mathieson 7e88a07e71 proto_item_append_string() doesn't work this case, so stop using it. 
I am tempted though to chage proto_item_append_string() just be like
proto_item_append_text() without the call to g_vsnprintf(), which is the
expensize part I was hoping to avoid.

svn path=/trunk/; revision=44614
 2012-08-22 19:01:01 +00:00
Martin Mathieson 1470f4a6b7 Call proto_item_append_string() rather than proto_item_append_text() 
when there are no specifiers.

svn path=/trunk/; revision=44609
 2012-08-21 21:36:59 +00:00
Martin Mathieson 973be664bb Use proto_item_append_string() rather than proto_item_append_text() with 
%s.

svn path=/trunk/; revision=44606
 2012-08-21 17:12:13 +00:00
Martin Mathieson cc0130e809 Save time by not appending byte values to the SDU item if will be hidden anyway (as happens 
when RLC dissector is called).

svn path=/trunk/; revision=44574
 2012-08-19 01:56:39 +00:00
Guy Harris 659cf0527a UATs could be put into "categories". The categories were defined only 
implicitly by the #define name and string they were defined to; not all
UATs neatly fit into any of the categories, so some of them were put
into categories that weren't obviously correct for them, and one - the
display filter macro UAT - wasn't put into any category at all (which
caused crashes when editing them, as the GUI code that handled UAT
changes from a dialog assumed the category field was non-null).

The category was, in practice, used only to decide, in the
aforementioned GUI code, whether the packet summary pane needed to be
updated or not.  It also offered no option of "don't update the packet
summary pane *and* don't redissect anything", which is what would be
appropriate for the display filter macro UAT.

Replace the category with a set of fields indicating what the UAT
affects; we currently offer "dissection", which applies to most UATs
(any UAT in libwireshark presumably affects dissection at a minimum) and
"the set of named fields that exist".  Changing any UAT that affects
dissection requires a redissection; changing any UAT that affects the
set of named fields that exist requires a redissection *and* rebuilding
the packet summary pane.

Perhaps we also need "filtering", so that if you change a display filter
macro, we re-filter, in case the display is currently filtered with a
display filter that uses a macro that changed.

svn path=/trunk/; revision=43603
 2012-07-08 01:00:46 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
pascal 2787ebf988 Upgrade MAC LTE dissector to Release 10 (V10.5.0) 
svn path=/trunk/; revision=42240
 2012-04-25 20:02:12 +00:00
pascal 1cc3ca7aa1 Use extended value strings for BSR and PHR and remove a useless hf entry 
svn path=/trunk/; revision=42135
 2012-04-18 16:55:06 +00:00
Martin Mathieson 65ddfa9e3a Add a field for the number of SRs indicated in one frame. 
svn path=/trunk/; revision=41764
 2012-03-25 23:46:01 +00:00
Bill Meier 198c9ba55f FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE; 
In some cases:
 Use val_to_str_const() instead of val_to_str();
 Reformat long lines;
 Do some general whitespace changes.


svn path=/trunk/; revision=41587
 2012-03-16 02:00:29 +00:00
Martin Mathieson 3a7cc2b725 Change the way the count of subheaders is displayed in the header. 
svn path=/trunk/; revision=41434
 2012-03-08 13:20:33 +00:00
Martin Mathieson c516211eb9 Include direction in some malformed expert info strings. 
svn path=/trunk/; revision=41418
 2012-03-08 04:49:59 +00:00
Martin Mathieson 915eb315d6 Oh dear, had that test the wrong way around... 
svn path=/trunk/; revision=40733
 2012-01-26 19:25:08 +00:00
Martin Mathieson 246ed9be9d When telling RLC whether a frame is a retx, use direct setting if set 
for DL.
Also, check limits during subheader loop.

svn path=/trunk/; revision=40729
 2012-01-26 15:19:32 +00:00
Martin Mathieson 3751e782dd Check for DL HARQ retx before calling RLC dissector to avoid sequence 
number analysis problems.

svn path=/trunk/; revision=40647
 2012-01-22 02:52:50 +00:00
Martin Mathieson 1b33c5f3f5 Add a dissector "mac-lte-framed" that uses the same framing format as 
the existing "mac-lte" UDP heuristic dissector. It is hoped that it will be
possible to register a DLT for use with this format.

svn path=/trunk/; revision=40580
 2012-01-19 02:58:53 +00:00
Bill Meier 439adbdbcc Remove obsolete comments referring to mem_chunks. 
svn path=/trunk/; revision=40507
 2012-01-14 20:14:43 +00:00
Martin Mathieson 4dbf893401 Display the meaning of the special values of the Stop MTCH field. 
From Pascal Quantin

svn path=/trunk/; revision=40296
 2011-12-27 00:27:46 +00:00
Martin Mathieson 412385e6fd Support for MCH PDUs (introduced in R9 for MBMS). 
From Pascal Quantin.

svn path=/trunk/; revision=40276
 2011-12-22 18:05:48 +00:00
Martin Mathieson 8f871c472d Allow configuration protocol to configure UL priority for channels in mapping. 
This value then gets used in call_rlc_dissector().

svn path=/trunk/; revision=40021
 2011-11-28 14:52:11 +00:00
Martin Mathieson 899155a563 Add the reason for a UL ReTx (PDCCH retx grant or PHICH NACK). 
svn path=/trunk/; revision=40001
 2011-11-25 11:19:03 +00:00
Martin Mathieson ab9ede8e8f Add the system frame number (SFN) to the context fields logged along with LTE MAC frames. 
svn path=/trunk/; revision=39971
 2011-11-21 16:18:33 +00:00
Chris Maynard 647c5c0b27 packet_info's in_error_pkt is now a bitfield like in_gre_pkt. 
svn path=/trunk/; revision=39764
 2011-11-08 18:39:11 +00:00
Bill Meier 54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier 293049dfba Do some conversions of proto_tree_add_item() 'encoding' arg. 
(previously missed).

    57   FT_BOOLEAN:       FALSE-->ENC_BIG_ENDIAN
    31   FT_BOOLEAN:       TRUE-->ENC_LITTLE_ENDIAN

    10   FT_BYTES:         ENC_BIG_ENDIAN-->ENC_NA
     1   FT_BYTES:         ENC_LITTLE_ENDIAN-->ENC_NA
    21   FT_BYTES:         FALSE-->ENC_NA
     2   FT_BYTES:         TRUE-->ENC_NA

     2   FT_IPXNET:        ENC_BIG_ENDIAN-->ENC_NA

     6   FT_IPv6:          ENC_BIG_ENDIAN-->ENC_NA
     1   FT_IPv6:          FALSE-->ENC_NA

     6   FT_NONE:          ENC_BIG_ENDIAN-->ENC_NA
    19   FT_NONE:          FALSE-->ENC_NA
     3   FT_NONE:          TRUE-->ENC_NA

     1   FT_STRING:        ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA
     1   FT_STRING:        ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA
     5   FT_STRING:        FALSE-->ENC_ASCII|ENC_NA
     1   FT_STRING:        TRUE-->ENC_ASCII|ENC_NA

     4   FT_STRINGZ:       ENC_NA-->ENC_ASCII|ENC_NA
     8   FT_STRINGZ:       FALSE-->ENC_ASCII|ENC_NA

     1   FT_INT32:         FALSE-->ENC_BIG_ENDIAN
     1   FT_INT32:         TRUE-->ENC_LITTLE_ENDIAN

    11   FT_UINT8:         0-->ENC_BIG_ENDIAN
   111   FT_UINT8:         FALSE-->ENC_BIG_ENDIAN
    17   FT_UINT8:         TRUE-->ENC_LITTLE_ENDIAN
     1   FT_UINT16:        0-->ENC_BIG_ENDIAN
    68   FT_UINT16:        FALSE-->ENC_BIG_ENDIAN
    18   FT_UINT16:        TRUE-->ENC_LITTLE_ENDIAN
     4   FT_UINT24:        FALSE-->ENC_BIG_ENDIAN
    70   FT_UINT32:        FALSE-->ENC_BIG_ENDIAN
     1   FT_UINT32:        TRUE-->ENC_LITTLE_ENDIAN
     4   FT_UINT64:        FALSE-->ENC_BIG_ENDIAN
     1   FT_UINT64:        TRUE-->ENC_LITTLE_ENDIAN

     1   FT_UINT_STRING:   FALSE-->ENC_ASCII|ENC_BIG_ENDIAN


svn path=/trunk/; revision=39442
 2011-10-16 23:38:49 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Martin Mathieson 4eccc98bbc Show in info line if predefined contents lines are truncated. 
svn path=/trunk/; revision=38365
 2011-08-05 14:40:47 +00:00
Martin Mathieson 0e83124e46 Fix the SR state report for when get SR following SR with no grant or failure in-between. 
svn path=/trunk/; revision=38322
 2011-08-03 17:05:30 +00:00
Martin Mathieson 2c877da104 Make links forward from DL tx to retx frames. 
svn path=/trunk/; revision=38242
 2011-07-28 16:52:02 +00:00
Martin Mathieson be1334ed8f Fix bug 6160. 
Use correct string to search for RRC BCH dissectors.

svn path=/trunk/; revision=38198
 2011-07-25 13:34:40 +00:00
Martin Mathieson 7d7f7d870e Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP. 
svn path=/trunk/; revision=38131
 2011-07-20 12:19:22 +00:00
Martin Mathieson b1eb5b9a1a For UL retx, show links forward to next Tx as well as backwards to previous. 
svn path=/trunk/; revision=38077
 2011-07-18 11:57:38 +00:00
Martin Mathieson b3cbce492a Warn if there are > 2 padding subheaders at the beginning of a frame. 
svn path=/trunk/; revision=37570
 2011-06-06 16:07:09 +00:00
Martin Mathieson 9c0ba9fc85 Detect when padding non-final padding comes after other control subheaders. 
svn path=/trunk/; revision=37367
 2011-05-23 16:11:32 +00:00
Martin Mathieson bfb7f0cf94 Set subheader root length to 1, so if contentsinvalid will already be correctl length. 
svn path=/trunk/; revision=37271
 2011-05-19 01:03:56 +00:00
Martin Mathieson 9a4b6db704 Support multiple Scheduling Requests in one PDU. 
svn path=/trunk/; revision=37060
 2011-05-11 11:10:30 +00:00
Martin Mathieson a02a2eed3b Properly (re)initialise structs used for keeping track of UEs/TTI. 
svn path=/trunk/; revision=36734
 2011-04-20 10:23:41 +00:00
Martin Mathieson a4b6665653 Retire a preference that can be always on now. 
svn path=/trunk/; revision=36693
 2011-04-17 21:43:20 +00:00
Martin Mathieson d4e9304fd2 Add a way for configuration protocol (e.g. RRC) to configure MAC-> RLC mappings, and add a preference to use this or the static UAT. 
API is not yet called by RRC.

svn path=/trunk/; revision=36676
 2011-04-17 11:22:03 +00:00
Martin Mathieson 960376a8f3 Show max UEs/TTI in MAC stats window (UL/DL separately). 
svn path=/trunk/; revision=36658
 2011-04-16 10:56:18 +00:00
Martin Mathieson ae149510e6 Keep track of how many UL/DL UEs in a TTI, and attach this info to each UL-SCH/DL-SCH frame.. 
svn path=/trunk/; revision=36657
 2011-04-15 23:32:44 +00:00
Martin Mathieson a8f1a17b68 - for UL/DL HARQ, show number of ms since previous tx 
- for SR state-machine problems, show UEId in report
- incomplete beginnings of support for grouping/counting UEs per TTI

svn path=/trunk/; revision=36564
 2011-04-11 21:33:33 +00:00
Martin Mathieson 4611533752 There can be up to 15 DL HARQ processes (depending upon TDD config index). 
svn path=/trunk/; revision=36250
 2011-03-22 14:39:02 +00:00
Martin Mathieson d36178cd5d Improve expert info output when detect Scheduling Request 'state machine' problem. 
svn path=/trunk/; revision=36147
 2011-03-06 22:52:33 +00:00
Martin Mathieson 2f6486166f Allow linking back to previous UL tx 32 ms ago. 
svn path=/trunk/; revision=36119
 2011-03-02 11:33:46 +00:00
Martin Mathieson c5c0195362 Don't overwrite isPhyRetx field for UL frames with DL check. 
svn path=/trunk/; revision=36118
 2011-03-02 11:16:28 +00:00
Martin Mathieson 3fac9089cb After SR failure, allow for another attempt in SR state machine (presumably with a subsequent RACH happening in-between...) 
svn path=/trunk/; revision=36109
 2011-03-01 14:58:51 +00:00
Martin Mathieson 93333d8fa1 Make UL retx use warning, rather than error, expert level. 
svn path=/trunk/; revision=36090
 2011-02-28 12:24:45 +00:00
Martin Mathieson 1660ed63ab Previous UL frame may be 8 OR 16 subframes ago. 
svn path=/trunk/; revision=36020
 2011-02-21 14:43:16 +00:00
Martin Mathieson f30d00e00a Show subheaders summary in subheader root item. 
svn path=/trunk/; revision=35908
 2011-02-11 00:29:40 +00:00
Jeff Morriss 50e1634f4c Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value() 
so that if the start_ptr is NULL the bytes are extracted from the given TVB
using the given offset and length.

Replace a bunch of:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...])

with:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...])

svn path=/trunk/; revision=35896
 2011-02-10 16:31:00 +00:00
Martin Mathieson 82cbbca3e5 Add and use accessors to get/set per-packet data for LTE MAC. 
This will allow plugins to use the dissector.

svn path=/trunk/; revision=35774
 2011-02-02 23:21:16 +00:00
Martin Mathieson b5a32fe8ef Improve/rework the way we look for the original frame when there is a DL. retransmission. 
svn path=/trunk/; revision=35682
 2011-01-27 16:09:24 +00:00
Martin Mathieson 7205313026 - Use correct data pointer during a comparison. 
- Add expert info to show when DRX command is received
- Get rid of some tabs


svn path=/trunk/; revision=35568
 2011-01-17 15:01:22 +00:00
Jeff Morriss 8d32d2066a There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

svn path=/trunk/; revision=35558
 2011-01-16 20:51:21 +00:00
Martin Mathieson 51170aa0fc When looking for previous frame for UL/DL retx, use harq-id + ndi bit. 
svn path=/trunk/; revision=35535
 2011-01-14 14:25:24 +00:00
Martin Mathieson b1dd79a122 Rather than repairing out-of-range subframe numbers, make sure error gets reported (and then are not used to access beyond subframe arrays). 
svn path=/trunk/; revision=35531
 2011-01-14 11:21:28 +00:00
Gerald Combs 73f5cb2503 From non-customers via bug 5530: Fix a buffer overflow in the MAC LTE 
dissector.  From me: Add a define, ep_allocate the buffer.

svn path=/trunk/; revision=35292
 2010-12-28 20:47:48 +00:00
Martin Mathieson ee714ffac4 Only a new transmission grant should end a Scheduling Request. 
svn path=/trunk/; revision=35268
 2010-12-26 23:40:22 +00:00
Martin Mathieson 7cd3ff263b Add more PHY attributes to MAC frames. 
svn path=/trunk/; revision=35125
 2010-12-05 23:34:11 +00:00
Martin Mathieson a8b6aca90c From Pascal Quantin: 
- Set a default RNTI value for each type, in case optional RNTI value isn't supplied.
- Improve range checking of given type against acceptable range of values
- fix misplaced return (this fixed bug 5392)

svn path=/trunk/; revision=34859
 2010-11-13 15:32:29 +00:00
Martin Mathieson a067c3bb8a Check given RNTI value is consistent with given RNTI-type. 
As suggested in bug 5382.  The reported crash didn't happen for me...

svn path=/trunk/; revision=34852
 2010-11-12 16:59:22 +00:00
Martin Mathieson fb0bfc17da Show some reserved bits as hex, not decimal. 
svn path=/trunk/; revision=34792
 2010-11-05 16:47:22 +00:00
Martin Mathieson 829ee8752b Add 'ndi' and 'harq-id' as new MAC-PHY DL attributes. 
svn path=/trunk/; revision=34753
 2010-11-02 15:20:38 +00:00
Jeff Morriss f5d3a16225 Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts. 
svn path=/trunk/; revision=34725
 2010-10-30 18:18:12 +00:00
Guy Harris 17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of 
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
 2010-10-29 21:11:33 +00:00
Martin Mathieson 81a49eec81 In heuristic dissector, don't check/allocate struct until/unless signature pattern matches. 
svn path=/trunk/; revision=34582
 2010-10-20 09:58:40 +00:00
Martin Mathieson 7e938c7071 Don't clear info column when showing MAC or RLC-level info. 
svn path=/trunk/; revision=34559
 2010-10-18 17:02:19 +00:00
Martin Mathieson 1077ec28f6 Improve info column when showing PHY info for MAC frames. 
svn path=/trunk/; revision=34529
 2010-10-15 21:32:35 +00:00
Martin Mathieson 62e6b6aceb Add more CRC failure codes. 
svn path=/trunk/; revision=34401
 2010-10-07 14:44:00 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL. 
svn path=/trunk/; revision=34227
 2010-09-23 21:46:31 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
 2010-09-21 03:14:49 +00:00
Martin Mathieson 4b5c69c0d9 Add bandwidth figures per UE. 
svn path=/trunk/; revision=34061
 2010-09-03 16:45:05 +00:00
Martin Mathieson c642bae035 From Pascal Quantin: 
The decoder expects to do not have any extra byte after the RAR bodies.

But according to 3GPP 36.321 8.8.0 chapter 6.1.5, the eNodeB is allowed to put padding at the end of the RAR PDU:

" A MAC PDU consists of a MAC header and zero or more MAC Random Access Responses (MAC RAR) and optionally padding as described in figure 6.1.5-4.
[...]

Padding may occur after the last MAC RAR. Presence and length of padding is implicit based on TB size, size of MAC header and number of RARs."

svn path=/trunk/; revision=33783
 2010-08-12 09:03:05 +00:00
Jörg Mayer 8c03a4472a Updading opensuse 11.2 -> 11.3 updated gcc to 4.5.0, which created 
a few warnings that needed fixing when compiling with -Werror.

svn path=/trunk/; revision=33587
 2010-07-20 08:27:34 +00:00
Martin Mathieson 703635b979 Give up dissecting a MAC PDU if we see control LCIDs after data ones. 
This saves us getting into a mess trying to keep track of PDU sizes in an array...

svn path=/trunk/; revision=33582
 2010-07-19 14:14:47 +00:00
Martin Mathieson db478debbd Allocate tap structs rather than using one static struct. 
svn path=/trunk/; revision=33503
 2010-07-13 16:25:34 +00:00
Martin Mathieson b2a872cd9f Show grant-subframe from context info. 
svn path=/trunk/; revision=33437
 2010-07-05 16:45:36 +00:00
Martin Mathieson b7f136ae41 Check range of supplied subframe number. If out, set back to max (9) and 
add expert info error.  Should fix bug 4970.

svn path=/trunk/; revision=33432
 2010-07-05 10:50:27 +00:00
Martin Mathieson 735ec2d6d2 For DL HARQ retx, support knowing result or not. 
svn path=/trunk/; revision=33431
 2010-07-05 10:35:17 +00:00
Martin Mathieson 97df849b98 Add new strings/dissector function for signalling RRC messages that will add 
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

svn path=/trunk/; revision=33251
 2010-06-18 07:07:55 +00:00
Martin Mathieson 4fcd48495f Add the direction to so expert info texts. 
svn path=/trunk/; revision=33207
 2010-06-10 15:28:41 +00:00
Martin Mathieson 98c68fc8ec Check that the PDU isn't bigger than the reported grant size. Thought I was already doing this... 
svn path=/trunk/; revision=32934
 2010-05-24 16:28:34 +00:00
Martin Mathieson 5ed2e2f914 Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting 
svn path=/trunk/; revision=32611
 2010-04-30 17:15:59 +00:00
Martin Mathieson 0d7425872e Set TA control element expert info based on improved understanding of spec. 
svn path=/trunk/; revision=32539
 2010-04-22 17:46:12 +00:00
Martin Mathieson 5a39a9ef39 - Lower severity on expert items about Timing Advance if <= 31 
- Detect original frame for DL HARQ retx also 9 SFs ago (have even seen 10...)
- Getting ready to log 'grant subframe' for UL frames (only interesting for TDD)

svn path=/trunk/; revision=32538
 2010-04-22 13:54:30 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Martin Mathieson cfb6f1531a Improve reporting of Scheduling Request failure. 
svn path=/trunk/; revision=32272
 2010-03-23 13:24:01 +00:00
Martin Mathieson 90b1fb287d Show oob items outside of context tree. 
svn path=/trunk/; revision=32269
 2010-03-22 19:20:37 +00:00
Martin Mathieson 64d949c97e Trivial reformatting 
svn path=/trunk/; revision=32226
 2010-03-17 19:40:34 +00:00
Martin Mathieson b3a29fcb32 Add some extra (optional) physical layer attributes to logged MAC frames. 
svn path=/trunk/; revision=32190
 2010-03-14 17:56:37 +00:00
Martin Mathieson 5aaf90b753 Put context info in own subtree. 
Use common function to append text to info column and tree items

svn path=/trunk/; revision=32151
 2010-03-09 01:41:36 +00:00
Stig Bjørlykke 2f8830b4d0 From LEGO via bug 3459: 
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.

svn path=/trunk/; revision=32112
 2010-03-04 12:50:18 +00:00
Martin Mathieson 5baac1de18 Fix crash where was overwriting buffer for large PDUs when tracking retxs. 
svn path=/trunk/; revision=32095
 2010-03-03 16:04:12 +00:00
Martin Mathieson eba3b41978 Fix a test. 
svn path=/trunk/; revision=32092
 2010-03-03 15:38:37 +00:00
Martin Mathieson 80d7644409 Its convenient to be able to filter on mac-lte.ulsch or mac-lte.dlsch. 
svn path=/trunk/; revision=32088
 2010-03-03 11:57:21 +00:00
Martin Mathieson ebd8c30044 When looking at time differences between frames, round to nearest number of ms. 
svn path=/trunk/; revision=32086
 2010-03-02 18:41:35 +00:00
Martin Mathieson 862dd48d35 Improve RLC AM sequence analysis by taking MAC retx into account. 
svn path=/trunk/; revision=32071
 2010-03-01 22:52:34 +00:00
Martin Mathieson 360077ae74 Calculate/show time between Msg3 and Msg4 
svn path=/trunk/; revision=31970
 2010-02-23 22:28:42 +00:00
Martin Mathieson 6a0c3ecaaf Include detected DL retx in stats. 
Each row is now a uniqe RNTI/UEId pair.
Added a filter button to filter by selected RNTI + UEId

svn path=/trunk/; revision=31931
 2010-02-20 16:58:48 +00:00
Martin Mathieson 7b2a3c26e6 Recognise update string for SR failure, and show ueid in MAC if set. 
svn path=/trunk/; revision=31916
 2010-02-18 21:24:47 +00:00
Martin Mathieson 2e08a73235 Add preference that allows RLC PDUs embedded inside MAC info to be seen nicely in the info column 
svn path=/trunk/; revision=31828
 2010-02-08 15:01:08 +00:00
Martin Mathieson 35a4c0b3d6 Add UEId to MAC tap struct and stats window. 
svn path=/trunk/; revision=31788
 2010-02-04 16:30:43 +00:00
Martin Mathieson 1146a40844 From Pascal Quantin: show decoding of the Power Headroom Level field as specified in 3GPP 36.133 table 9.1.8.4-1. 
svn path=/trunk/; revision=31705
 2010-01-27 18:42:40 +00:00
Martin Mathieson 61c6c08861 Undo previous change to avoid crashing. 
The test for NULL was to see whether struct had ever been allocated,
not for detecting a failed allocation...

svn path=/trunk/; revision=31681
 2010-01-26 14:55:26 +00:00
Martin Mathieson f1f528deeb From Pascal Quantin: fid some LTE MAC and PDCP typos 
svn path=/trunk/; revision=31661
 2010-01-25 16:45:46 +00:00
Stig Bjørlykke c198fc6546 From Didier Gautheron via bug 4419: 
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
 2010-01-25 11:47:39 +00:00
Bill Meier c5614625ee Fix some gcc -Wshadow warnings .... 
svn path=/trunk/; revision=31559
 2010-01-18 23:16:10 +00:00
Anders Broman 1f6a39eae9 Use g_snprintf() 
svn path=/trunk/; revision=31507
 2010-01-12 20:08:30 +00:00
Martin Mathieson d5c96e34e7 Use snprintf() to pass checkAPI 
svn path=/trunk/; revision=31506
 2010-01-12 18:43:18 +00:00
Martin Mathieson 23c5730798 Append to the SDU field only once (instead of for each byte!). 
svn path=/trunk/; revision=31503
 2010-01-12 16:12:27 +00:00
Martin Mathieson ccaca7c006 Show in stats % of UL traffic that is padding (subheader or payload). 
svn path=/trunk/; revision=31390
 2009-12-29 22:55:39 +00:00
Martin Mathieson 3b0a092b18 Fix crash bug by allocating correct size of struct (used with SR tracking). 
svn path=/trunk/; revision=31307
 2009-12-18 12:32:14 +00:00
Martin Mathieson d7f78d0627 Remove stray #if 1 
svn path=/trunk/; revision=31292
 2009-12-17 13:33:00 +00:00
Martin Mathieson 5574e77571 Adding FT_NONE item with proto_tree_add_item() causes crashes later, so use 
proto_tree_add_none_format() instead.

svn path=/trunk/; revision=31291
 2009-12-17 13:15:29 +00:00
Martin Mathieson d0260a142b Add a cast to try to keep the win64 compiler happy 
svn path=/trunk/; revision=31267
 2009-12-14 16:50:42 +00:00
Martin Mathieson 52163da600 Show the time between SR and failure or grant. 
svn path=/trunk/; revision=31265
 2009-12-14 16:04:14 +00:00
Martin Mathieson 469884ab44 Catch unexpected Scheduling Request state transitions as expert info. 
svn path=/trunk/; revision=31261
 2009-12-14 11:23:24 +00:00
Martin Mathieson 9a0c5d29c6 Fix length in loop (from Pascal Quantin). 
svn path=/trunk/; revision=31178
 2009-12-04 22:27:29 +00:00
Martin Mathieson 2267dcdd0e From Pascal Quantin via bug 4296. 
- make framing format work when there are no optional parameters present
- when showing raw SDU, show formatted info as well as data itself.  This is done in a horrible way, but I can't find a nice way.

svn path=/trunk/; revision=31174
 2009-12-04 17:39:39 +00:00
Martin Mathieson 27169c915c Provide frame links between grant or failure ind back to SR. 
svn path=/trunk/; revision=31169
 2009-12-04 11:13:20 +00:00
Martin Mathieson b3a836bc23 The beginnings of a state machine to track a UE's SR state and provide links between relevant frames. 
svn path=/trunk/; revision=31153
 2009-12-02 17:46:27 +00:00
Martin Mathieson 8713027d83 Obselete a couple of preferences that can always be on. 
svn path=/trunk/; revision=31123
 2009-11-29 22:45:06 +00:00
Martin Mathieson 57d5b991b5 Include ue id in expert info for retx. 
svn path=/trunk/; revision=31080
 2009-11-25 23:18:28 +00:00
Martin Mathieson bd3a966861 Track UL HARQ retx, look for original tx frame. 
svn path=/trunk/; revision=31072
 2009-11-25 16:00:58 +00:00
Martin Mathieson 2d2a1ef1cf Tweak expert info level/text. 
svn path=/trunk/; revision=31019
 2009-11-19 18:11:38 +00:00
Martin Mathieson 479fc76dc9 Expert warning about BSRs over a threshold configured in pref. 
svn path=/trunk/; revision=31003
 2009-11-18 13:47:08 +00:00
Martin Mathieson 04078dd997 Improve expert and info column strings reporting OOB events. 
svn path=/trunk/; revision=30859
 2009-11-08 00:39:22 +00:00
Martin Mathieson eab33c1bb9 Change a filter string for consistency. 
svn path=/trunk/; revision=30712
 2009-10-26 16:39:46 +00:00
Martin Mathieson afffcffff9 Add support for displaying/filtering some LTE MAC out-of-band events. 
svn path=/trunk/; revision=30711
 2009-10-26 15:39:00 +00:00
Martin Mathieson 4474e0d25b Label a short BSR as "short" 
svn path=/trunk/; revision=30699
 2009-10-25 23:03:11 +00:00
Martin Mathieson f5b4b6e32f Expert error if (non-padded) PDU is shorter than reported. 
svn path=/trunk/; revision=30666
 2009-10-22 17:22:27 +00:00
Martin Mathieson 0f8ee9cdf9 More long BSR fixes. 
svn path=/trunk/; revision=30664
 2009-10-22 11:45:40 +00:00
Martin Mathieson b3f5ccdae0 Fix issues with long BSR format, and attach expert info for non-zero RAR TA to correct item. 
svn path=/trunk/; revision=30663
 2009-10-22 10:31:13 +00:00
Martin Mathieson 61eda9b14e Improve DL HARQ resend detection by storing multiple frames per UE. 
svn path=/trunk/; revision=30557
 2009-10-14 10:43:17 +00:00
Martin Mathieson 7e8d401265 Add detection for suspected DL retx (due to HARQ). Needed if logging is done on UE side of link. 
svn path=/trunk/; revision=30554
 2009-10-13 13:36:58 +00:00
Martin Mathieson d8726d2a01 Try again... 
svn path=/trunk/; revision=29985
 2009-09-18 22:01:30 +00:00
Martin Mathieson 66e8e24373 Change type to try to fix win64 build breakage. 
svn path=/trunk/; revision=29984
 2009-09-18 17:10:35 +00:00
Martin Mathieson b6acfd804e Use a UAT table to map from LCIDs 3-10 to RLC drb channel. 
Call RLC dissector for mapped LCIDs.

svn path=/trunk/; revision=29983
 2009-09-18 16:27:02 +00:00
Martin Mathieson e09d89e145 Add the option to call RLC dissector for LCID 1&2. 
These should be srb1 & srb2 (AM).

svn path=/trunk/; revision=29852
 2009-09-10 22:53:57 +00:00
Martin Mathieson 019625d876 Re-arrange dissection of UL/DL-SCH so easier to test for ommitted SDUs. 
svn path=/trunk/; revision=29845
 2009-09-10 18:12:41 +00:00
Martin Mathieson 4c1be31824 Trivial: add direction to expert info string for CRC failures. 
svn path=/trunk/; revision=29802
 2009-09-08 17:13:55 +00:00
Martin Mathieson efd2ed4b51 Show UEId in info column for UL-SCH / DL-SCH frames. 
svn path=/trunk/; revision=29687
 2009-09-03 16:42:16 +00:00
Martin Mathieson 2ef4429761 Add Semi-Persistent Scheduling (SPS) RNTI. 
svn path=/trunk/; revision=29667
 2009-09-02 16:39:39 +00:00
Martin Mathieson 8437debcb6 Make UL grant size a (generated) field of its own (for easier use as a custom column or IO graph filter). 
svn path=/trunk/; revision=29562
 2009-08-26 09:13:14 +00:00
Martin Mathieson 5560cb61c0 Show CRC errors for RARs. 
svn path=/trunk/; revision=29548
 2009-08-25 11:01:51 +00:00