Commit graph

14638 commits

Author SHA1 Message Date
Guy Harris
18527dc22e Just pass &cfile to select_tcpip_session(); we don't need to pass
cfile.current_frame to it separately.

Note that we shouldn't ever get a "Selected packet isn't a TCP segment"
error any more; we can now handle all link layers.

Give a little more detail in the message shown if there's *more than
one* TCP header in the packet.

svn path=/trunk/; revision=14895
2005-07-10 18:29:43 +00:00
Guy Harris
47e79c4961 Fix some comment typos.
Don't regenerate the packet list when generating the TCP stream graph -
it won't be changing; just redissect and run the tap.

svn path=/trunk/; revision=14894
2005-07-10 10:10:40 +00:00
Guy Harris
79beab421d Put the data (print job contents) in LPD requests under the LPD protocol
item, rather than making it a top-level item.

svn path=/trunk/; revision=14893
2005-07-10 09:26:20 +00:00
Guy Harris
b6b0ee7cf8 Get rid of an unused argument.
svn path=/trunk/; revision=14892
2005-07-10 09:21:57 +00:00
Jörg Mayer
5b442f2279 After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
returned quite a list of files. Add them to MAINTAINERCLEANFILES.

Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.


svn path=/trunk/; revision=14891
2005-07-10 08:04:27 +00:00
Ronnie Sahlberg
85f38ef5fa For packets flagged as Retransmission
calculate RTO as the delta between the retransmitted frame and the last previous frame seen for this session (in the same direction).

while this is technically not the RTO  this delta is in most cases more important/useful than the tru RTO anyway since this measure represents the amount of thiime that the link went idle  while waiting for an RTO.




It would be nice with a statistics tap for TCP where one couls see, seeion by session :
Length in time of the session.
Total bytes transferred
Number of retransmissions
Time spent waiting for an RTO
Time spent waiting for an RTO in % of the total time.




svn path=/trunk/; revision=14890
2005-07-10 05:27:38 +00:00
Ronnie Sahlberg
847bb5af7f It works reasonably well with extensive testing so here goes :
tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file.

This makes tcp graph work for any type of capture and for any transport.




In the future someone with access to captures with TCP over something over TCP
to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph.



svn path=/trunk/; revision=14889
2005-07-10 02:59:50 +00:00
Ulf Lamping
dc6b471aad MSVC: fix some guint64 related compiler errors
strange enough, MSVC cannot convert from guint64 to float, so cast guint64 -> gint64 -> float

However, even gint64 might be big enough to prevent us from an overflow :-)

svn path=/trunk/; revision=14888
2005-07-09 11:28:13 +00:00
Ulf Lamping
832fc14ad8 MSVC: fix some guint64 related compiler warnings, could someone please review my comment(s), I don't think it's currently implemented correct
svn path=/trunk/; revision=14887
2005-07-09 11:26:46 +00:00
Guy Harris
8647bbf353 Make a bunch of items in encryption code arrays of guint8, and make some
pointers either "void *" or "guint8 *", to reduce the level of compiler
warnings (the data in question is largely binary in those cases).

svn path=/trunk/; revision=14886
2005-07-09 03:25:25 +00:00
Guy Harris
34ae8c850f Fix up a bunch of arguments to "dissect_ber_identifier()" to match its
current signature ("class" is a "gint8 *", not a "guint8 *", and "tag"
is a "gint32 *", not a "guint32 *").  Re-generate the dissectors from
the ASN.1 and the .cnf files in the cases where the arguments were fixed
in a .cnf file.

Give some dissectors the right svn:keywords and svn:eol-style settings.

svn path=/trunk/; revision=14885
2005-07-09 02:58:07 +00:00
Guy Harris
9cb86fda9c Squelch various signed vs. unsigned warnings by:
making pointers to byte data be "guint8 *" rather than "char *",
	and making buffers holding byte data arrays of "guint8" rather
	than arrays of "char";

	making pointers to text strings "char *" rather than "guchar *";

	appropriately casting pointers (cast to "guint8 *" when passing
	to routines expecting "guint8 *" or when assigning to "guint8
	*");

	making port-number preferences "guint";

	making enum preferences "gint";

	making hf_ variables "int".

Clean up white space.

svn path=/trunk/; revision=14884
2005-07-09 00:53:17 +00:00
Guy Harris
da80656d0e MAC addresses are arrays of bytes, not strings; make the destination MAC
address an array of guint8 - that squelches some compiler warnings.

Use -1 rather than tvb_length(tvb) to make the item for LWAPP go to the
end of the tvbuff.

svn path=/trunk/; revision=14883
2005-07-09 00:47:57 +00:00
Guy Harris
a05302b67a Find the BitTorrent dissector immediately after registering it, and save
the handle, rather than finding it every time we need it.

Just make a guint8 array with the BitTorrent magic string length
followed by the string, and use "tvb_memeql()" to test against that - it
handles checking to make sure there's enough data in the tvbuff (if
not, it returns -1 as a "no match" indication) and then checks all of
the first 20 bytes in one operation.

Clean up white space.

svn path=/trunk/; revision=14882
2005-07-09 00:44:44 +00:00
Guy Harris
68b1ab41d7 Use "tvb_get_string()" rather than duplicating its functionality by
hand.

Use "g_strdup()" rather than duplicating its functionality by hand.

Make the magic number an array of "guint8", as "tvb_memeql()" expects a
pointer to "guint8".

svn path=/trunk/; revision=14881
2005-07-09 00:35:13 +00:00
Ulf Lamping
2c30357c48 checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages
svn path=/trunk/; revision=14880
2005-07-08 22:11:13 +00:00
Ulf Lamping
6b0815ee9c Update the EDG screenshots to reflect the latest Ethereal GUI changes
svn path=/trunk/; revision=14879
2005-07-08 22:04:35 +00:00
Anders Broman
c50d7e229e Add some missing IMPLICIT tags, and use FN_PARS directive.
Add disection of some RR elements and command Handover.

svn path=/trunk/; revision=14878
2005-07-08 20:01:11 +00:00
Anders Broman
e46f6e0acc Add some missing IMPLICIT tags, and use FN_PARS directive.
svn path=/trunk/; revision=14877
2005-07-08 19:59:56 +00:00
Michael Tüxen
3d4375731a Fix a crash reported by Jeff Morris.
svn path=/trunk/; revision=14876
2005-07-08 11:47:59 +00:00
Guy Harris
979511b3fa Make the counters in the summary 64-bit, so they don't overflow on
Really Big Captures.

svn path=/trunk/; revision=14875
2005-07-08 09:12:11 +00:00
Guy Harris
f64a0aa20b Get rid of most unused arguments and variables (including some that are
set but not used).  (Leave "pi" around so the warning acts as a reminder
that the tap structure stuff needs a cleanup - currently, the tap
structures aren't freed; perhaps the new memory allocation scheme
proposed by Ronnie could be used for tap structures.)

Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace
packets and return the packet type for actrace packets, so that we don't
need a global variable for the packet type.

Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned
warning.

Use "col_set_str()" rather than "col_add_str()" when setting the
Protocol column.

We don't recognized packets as CAS packets unless they're 48 bytes long,
so we don't need to test whether they're 48 bytes long in the CAS packet
dissection code.

Use the reported length, not the captured length, when doing length
checks.

svn path=/trunk/; revision=14874
2005-07-08 02:31:45 +00:00
Guy Harris
7828470923 Make nettl file header items containing strings "gchar", to squelch
signed vs. unsigned compiler warnings.

svn path=/trunk/; revision=14873
2005-07-08 02:21:16 +00:00
Ronnie Sahlberg
897a12c305 make the packets/bytes counters 64bit integers to not wrap when using really large captures.
setting packet counter to 64bit is overkill but makes it consistent with the very similar bytes counter.



svn path=/trunk/; revision=14872
2005-07-07 22:24:28 +00:00
Gerald Combs
5b7df3128b Make sure "which" is present before we verify our tools. Add "env" to
the list of programs to check.  Make sure our python scripts start with
"#!/usr/bin/env python" as recommended at

  http://www.python.org/doc/faq/library.html#how-do-i-make-a-python-script-executable-on-unix

svn path=/trunk/; revision=14871
2005-07-07 21:26:09 +00:00
Anders Broman
37915b4dd7 Add parlay.dll and tango.dll to the installer.
svn path=/trunk/; revision=14870
2005-07-07 19:48:06 +00:00
Tomas Kukosa
cf9e596d86 avoid few warnings from asn2eth compiler
svn path=/trunk/; revision=14869
2005-07-07 05:45:51 +00:00
Guy Harris
a95d1209eb Squelch a compiler pointer vs. integer warning - NULL is for pointers,
'\0' is for characters.

svn path=/trunk/; revision=14868
2005-07-07 04:05:01 +00:00
Guy Harris
e2d750eab5 Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
warnings.  Use SET_ADDRESS in the VOIP calls code, rather than
explicitly filling in "pstn_add".

svn path=/trunk/; revision=14867
2005-07-07 04:03:35 +00:00
Guy Harris
2465355c7b Explicitly initialize all the elements of a voip_calls_tapinfo_t, to
squelch a compiler warning.

svn path=/trunk/; revision=14866
2005-07-07 03:20:43 +00:00
Guy Harris
2b086353a4 Fix a spelling error.
svn path=/trunk/; revision=14865
2005-07-06 23:55:19 +00:00
Tomas Kukosa
2c70677901 more usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter
svn path=/trunk/; revision=14864
2005-07-06 16:19:34 +00:00
Tomas Kukosa
3f36906e3a - #.FN_PARS implemented for BOOLEAN
- user defined body #.FN_BODY can be combined with default body using DEFAULT_BODY parameter (see e.g. H.225)

svn path=/trunk/; revision=14863
2005-07-06 16:15:12 +00:00
Jörg Mayer
d67ae33f0f Replace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch
svn path=/trunk/; revision=14862
2005-07-05 22:58:00 +00:00
Ulf Lamping
2f2ab41ea4 fix *several* dissector bugs, found by private fuzz-tests
svn path=/trunk/; revision=14861
2005-07-05 22:33:22 +00:00
Tomas Kukosa
ed7d638053 new directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors with new_dissector_t prototype
svn path=/trunk/; revision=14860
2005-07-05 21:42:13 +00:00
Gerald Combs
8434647836 Call proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274,
276, and 277.

svn path=/trunk/; revision=14859
2005-07-05 20:20:15 +00:00
Gerald Combs
276f179b0b Don't crash if we're handed a zero-length fragment. Fixes bug 272. Although
we don't crash now, we still don't handle zero-length fragments correctly.

svn path=/trunk/; revision=14858
2005-07-05 20:04:03 +00:00
Tomas Kukosa
f1cf503709 more usage of #.FN_PARS
svn path=/trunk/; revision=14857
2005-07-05 19:53:38 +00:00
Tomas Kukosa
648c7863cd - #.FN_PARS support for ENUMERATED type
- cleanup unused parameters for some methods

svn path=/trunk/; revision=14856
2005-07-05 19:47:04 +00:00
Tomas Kukosa
b579d77b9a GUID lowercase form seems to be preferred
svn path=/trunk/; revision=14855
2005-07-05 18:55:17 +00:00
Anders Broman
02a57cdfcc Add application/vnd.wv.csp.xml
svn path=/trunk/; revision=14854
2005-07-05 17:10:09 +00:00
Anders Broman
24c91af80f Add application/vnd.wv.csp.xml
svn path=/trunk/; revision=14853
2005-07-05 17:09:28 +00:00
Anders Broman
c8b69874cb From Alejandro Vaquero
- avoid the clist of the calls dlg to be refreshed multiple times when 
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
	{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.

svn path=/trunk/; revision=14852
2005-07-05 05:16:28 +00:00
Anders Broman
623f9057c1 From : David Frascone
These minor changes fix some errors, and add some messages to the LWAPP dissector.

svn path=/trunk/; revision=14851
2005-07-05 04:32:32 +00:00
Anders Broman
0b90c61ac8 From Ainsley Pereira:
If you have an RTP stream in which the first packet is duplicated, and has the marker bit set, then the RTP stream analysis will try to pad silence into a temporary file from 0 upto whatever the RTP timestamp is (which is enough to fill up my disk...). The  patch fixes this misbehaviour.

svn path=/trunk/; revision=14850
2005-07-05 04:30:59 +00:00
Anders Broman
de00180fe9 Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
svn path=/trunk/; revision=14849
2005-07-04 19:09:38 +00:00
Anders Broman
96389d268c Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
svn path=/trunk/; revision=14848
2005-07-04 19:07:02 +00:00
Tomas Kukosa
cdb09b497a usage of FT_GUID field type in H.225 dissector
svn path=/trunk/; revision=14847
2005-07-04 13:19:58 +00:00
Tomas Kukosa
b9703d0919 export of proto_tree_add_guid...() functions
svn path=/trunk/; revision=14846
2005-07-04 13:13:07 +00:00