Commit Graph

997 Commits

Author SHA1 Message Date
Gerald Combs 13a2e931b7 Remove more obsolete _MSC_VER code.
svn path=/trunk/; revision=45299
2012-10-03 20:23:51 +00:00
Gerald Combs bdd98d63cd Fix compilation on Windows. Add back and fix function definitions,
fix doxygen d ocumentation, other fixes.

svn path=/trunk/; revision=45298
2012-10-03 19:45:05 +00:00
Bill Meier c74466c744 (Trivial): add some whitespace for readability.
svn path=/trunk/; revision=45297
2012-10-03 19:43:36 +00:00
Gerald Combs bcd2cea774 Unify the GTK+ and Win32 versions of "Export Specified Packets". Add a
shared "file_add_extension" routine. We no longer support _MSC_VER <
1400 so get rid of some clutter. Add a gzip checkbox to the Win32 export
packets dialog. Windows code hasn't yet been tested (and is likely
broken). I'll fix it shortly.

svn path=/trunk/; revision=45296
2012-10-03 19:24:14 +00:00
Martin Mathieson bf370afa44 When drawing an axis, only call cairo_stroke once all lines are drawn.
svn path=/trunk/; revision=45281
2012-10-03 09:15:16 +00:00
Martin Mathieson a273e4a913 Submit Jacub's fix for bug 7771 (hanging while drawing graph types that
involved ellipses). cairo_save/restore is nicer than
cairo_create/destroy, and quite a bit quicker too.

svn path=/trunk/; revision=45280
2012-10-03 08:58:12 +00:00
Guy Harris 73dd0321ea Get rid of the always-null and unused argument to
host_name_lookup_process().  If, in the future, we find that we need an
argument for changes we're making, we can add it then.

svn path=/trunk/; revision=45269
2012-10-02 21:13:59 +00:00
Gerald Combs 409b405d7c Move the main window slots to main_window_slots.cpp.
svn path=/trunk/; revision=45259
2012-10-02 18:47:05 +00:00
Gerald Combs e46cf2a726 Don't bother setting a background gradient in the toolbar on Windows.
svn path=/trunk/; revision=45246
2012-10-01 22:57:34 +00:00
Gerald Combs 0ffe19134b Construct a proper directory URL.
svn path=/trunk/; revision=45245
2012-10-01 22:55:45 +00:00
Evan Huus 3e5ac249e9 Add new fileset ui file to cmake build.
svn path=/trunk/; revision=45244
2012-10-01 22:52:14 +00:00
Gerald Combs d02a2328ef Implement file sets.
Replace the original file set code with a UI form. Use more consistent
file names. List the files using a QTreeWidget instead of a grid.
fileset_is_file_in_set is only used in fileset.c so make it static.

In main_window.cpp reduce our usage of the global cfile variable.

svn path=/trunk/; revision=45243
2012-10-01 22:40:20 +00:00
Chris Maynard 724888c321 Widen the "Find text" dialog a bit so the entire title is visible.
svn path=/trunk/; revision=45241
2012-10-01 20:57:15 +00:00
Gerald Combs 447ade94b5 Add a window pointer so that we can figure out from whence we came.
Bring the timestamp output more in line with ISO 8601.

svn path=/trunk/; revision=45240
2012-10-01 20:14:47 +00:00
Martin Kaiser 0836b3b16b update the capture comment icon in the statusbar
when a capture comment was edited via Statistics/Summary

svn path=/trunk/; revision=45238
2012-10-01 19:11:14 +00:00
Jeff Morriss 2dc1b40a20 There is no longer the need to define HAVE_CONFIG_H.
svn path=/trunk/; revision=45232
2012-10-01 11:49:15 +00:00
Jeff Morriss 2fbf659e28 Stop defining HAVE_CONFIG_H on Windows builds too.
svn path=/trunk/; revision=45231
2012-10-01 11:47:36 +00:00
Martin Kaiser 8b7686e9b8 use the correct status bar icon for the capture comment
if we have an empty capture comment (an existing comment was deleted),
we should use the same icon as if no comment was present

svn path=/trunk/; revision=45227
2012-09-30 18:37:59 +00:00
Chris Maynard 296d2900a1 Add displayed and marked percent columns and percent calculations for dropped and ignored packets in summary dialog. Also display percent calculations for displayed, marked, ignored and dropped packets in statusbar. Like ignored packets, only display marked packet count and percent in the statusbar if there are any.
Fixes enhancement bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2377

svn path=/trunk/; revision=45226
2012-09-30 18:28:04 +00:00
Chris Maynard ee56ee5181 Revert r45185. While it looks better with an icon if "Filter toolbar style" is set to "Icons & Text", if the preference is set to "Icons only", all custom filters will have the same icon displayed and it will be difficult to know which is which w/out hovering on each for a tooltip. Maybe someone else can figure out how to add the icon, but only in the case of "Icons & Text"?
svn path=/trunk/; revision=45225
2012-09-30 18:15:40 +00:00
Chris Maynard 5d64bef6e1 Revert most of r45210. We don't use the return value of GetExitCodeProcess(), but it still needs to be called to get childstatus.
svn path=/trunk/; revision=45212
2012-09-29 15:49:06 +00:00
Evan Huus 560cdd7ed5 More unused variables caught by cppcheck.
svn path=/trunk/; revision=45211
2012-09-29 14:15:20 +00:00
Evan Huus 73e5c4e40f Don't fetch the exit code of our child process, we never use it.
svn path=/trunk/; revision=45210
2012-09-29 14:06:40 +00:00
Evan Huus c103c2fe04 Fix some memleaks caught by cppcheck.
svn path=/trunk/; revision=45209
2012-09-29 14:03:36 +00:00
Evan Huus 813781f18c Remove some unused variables caught by cppcheck.
svn path=/trunk/; revision=45208
2012-09-29 13:57:57 +00:00
Jakub Zawadzki d45d88d161 remove some very old comments about multithreaded tap implementation...
svn path=/trunk/; revision=45202
2012-09-28 21:48:28 +00:00
Jakub Zawadzki 49ce5e127b protect_thread_critical_region, unprotect_thread_critical_region are no-ops, cleanup code by removing them.
svn path=/trunk/; revision=45201
2012-09-28 21:36:21 +00:00
Chris Maynard 85ac1f3ffd Increase the default width of the capture options dialog so all columns are visible. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7766
svn path=/trunk/; revision=45199
2012-09-28 20:43:40 +00:00
Chris Maynard 2e2512209a The details tab looked lonely. Give it an icon too.
svn path=/trunk/; revision=45190
2012-09-28 12:52:05 +00:00
Chris Maynard a3f9f5f7da Add a filter icon to the custom filter button.
svn path=/trunk/; revision=45185
2012-09-28 04:21:20 +00:00
Evan Huus 2a29fee996 Only define a parameter name if we end up using it, to fix the
qtshark build on GCC.

svn path=/trunk/; revision=45164
2012-09-27 02:43:09 +00:00
Gerald Combs 3994ddc357 Call fileset_file_closed from cf_cb_file_closed.
svn path=/trunk/; revision=45163
2012-09-26 23:40:56 +00:00
Gerald Combs 998da54456 Add a cf_cb_file_opened callback and use it instead of calling
fileset_file_opened directly from file.c. This makes the code a bit more
consistenent and makes it easier to port the File Set dialog to Qt.

svn path=/trunk/; revision=45162
2012-09-26 23:33:11 +00:00
Gerald Combs b3ced49412 Fix compilation on Windows.
svn path=/trunk/; revision=45160
2012-09-26 21:16:59 +00:00
Guy Harris e67439118e Add the so-called "friendly name", as provided by NDIS; at least with
the tests I've done, if it's present at all, it's just a UTF-16 version
of the "vendor description" field, it's not the "friendly name" that
shows up in the Control Panel.

svn path=/trunk/; revision=45158
2012-09-26 20:40:34 +00:00
Gerald Combs 068815cc67 Implement "Save" and "Save As".
svn path=/trunk/; revision=45156
2012-09-26 19:52:53 +00:00
Chris Maynard b9c9b8bd31 Allow IPv6 addresses to be mapped.
svn path=/trunk/; revision=45149
2012-09-26 15:45:08 +00:00
Chris Maynard d70f250406 Revision 45146 fixed only the first map. This patch fixes all maps.
#BACKPORT(1.6, 1.8)

svn path=/trunk/; revision=45148
2012-09-26 12:54:46 +00:00
Chris Maynard 839862cd08 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5016 - No markers show up when maps are displayed.
#BACKPORT(1.8, 1.6)

svn path=/trunk/; revision=45146
2012-09-26 03:30:48 +00:00
Gerald Combs f60693dbea Fix error checking logic.
svn path=/trunk/; revision=45144
2012-09-25 23:29:47 +00:00
Alexis La Goutte 74d0df441e Add load of translate QLibraryInfo to have standart button (and other stuff) translated
svn path=/trunk/; revision=45140
2012-09-25 20:18:02 +00:00
Alexis La Goutte 3738ed7370 Use "common help_url function" for qtshark
Add links to Manual Pages...

svn path=/trunk/; revision=45139
2012-09-25 20:08:11 +00:00
Alexis La Goutte 2af09e863e Add modelines info for qtshark import file
svn path=/trunk/; revision=45136
2012-09-25 19:29:04 +00:00
Martin Kaiser 47cf08409d change the capture comment icon in the statusbar from "add" to "edit"
when a comment was added

(deletion of a comment is not recognized correctly)

svn path=/trunk/; revision=45109
2012-09-24 19:30:23 +00:00
Martin Kaiser eea9174bcf allow setting a capture comment from the statusbar when a capture was started
for the decision to allow input of a capture comment, we should make no
difference between the statusbar icon and Statistics / Summary menu item

svn path=/trunk/; revision=45108
2012-09-24 19:12:01 +00:00
Martin Kaiser 82654a12f0 fix compilation on linux
ui/gtk/capture_file_dlg.c needs ui/file_dialog.h

svn path=/trunk/; revision=45107
2012-09-24 18:59:44 +00:00
Gerald Combs e9d4c115b5 Fix compilation on Windows.
svn path=/trunk/; revision=45106
2012-09-24 17:44:11 +00:00
Gerald Combs 25eab1c383 Unify some of the GTK+ and Win32 "Save As" code and behavior. This will
likely break compilation on Windows. I'll take care of it shortly.

svn path=/trunk/; revision=45105
2012-09-24 17:04:50 +00:00
Guy Harris 8c174d2ae7 Just as we don't show the "Wireless Settings" button for non-AirPcap
adapters, we don't show the "Remote Settings" button for local adapters.
(Back when the buttons were in the Capture Options dialog, always having
the button there and making it sensitive or insensitive based on the
interface you specified may have made sense; now that it's in a dialog
popped up when you double-click on a particular interface, so the dialog
always applies to a particular interface, it no longer makes sense.)

Get rid of the unused E_OPT_REMOTE_BT_KEY key.

svn path=/trunk/; revision=45085
2012-09-24 07:41:19 +00:00
Jakub Zawadzki 29235b9d10 Glib type checking might be cheap, but there's no need to do it twice.
(Actually many GtkTreeModel don't check types at all).

svn path=/trunk/; revision=45073
2012-09-23 18:20:42 +00:00