osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
55,481 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

1476 Commits

Author SHA1 Message Date
Guy Harris 1119eb692b generate ALIGN_TO_x_BYTES instructions if the element has the align_x flag 
Pick up change from Samba:

    commit 93f262ee6d162bf007b79d2daf9de6c49c6163d1
    Author: Matthieu Patou <mat@matws.net>
    Date:   Fri Oct 18 00:04:28 2013 -0700

    pidl-wireshark: generate ALIGN_TO_x_BYTES instructions if the element has the align_x flag

Change-Id: I865eae69ea7a8200630d3ad69bda9ac7b1c12255
Reviewed-on: https://code.wireshark.org/review/5099
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 20:06:15 +00:00
Guy Harris 283b5cd708 if the structure has the flag no_align then set also no_align in the dceprc_info structure 
commit 3f6ca430b067705d556031d52736d5a5d5ae8f55
    Author: Matthieu Patou <mat@matws.net>
    Date:   Fri Oct 11 13:18:37 2013 -0700

    pidl-wireshark: if the structure has the flag no_align then set also no_align in the dceprc_info structure

    Some dissection function will try to do alignment if the no_align flag
    is not set.

    Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Change-Id: Ie2377f4d6c1c4f2fde7084ba666bd417568122dd
Reviewed-on: https://code.wireshark.org/review/5098
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 20:04:02 +00:00
Guy Harris 9299bf48ae Remove casts, make some whitespace changes in generated code. 
This is the part of this change from Samba:

    commit f0a6043fb201940f438f63c809df7186aa307f01
    Author: Matthieu Patou <mat@matws.net>
    Date:   Sun Oct 5 18:25:27 2014 -0700

    pidl-wireshark: handle 8 bits enum and change the signature of enum function to pass the exact type

    Instead of passing a uint32 in all cases we pass the exact type

    Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

that wasn't already in our version.

Change-Id: I7da99cb701c2eedadeb8acb68d32f657dfa85e5b
Reviewed-on: https://code.wireshark.org/review/5097
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:56:22 +00:00
Guy Harris 26d4fb0f39 add definition for IPV4/IPV6 types 
Pick up change from Samba:

    commit 49e0dc7ad0f3c29df20badacc4294f1adc375aaf
    Author: Matthieu Patou <mat@matws.net>
    Date:   Fri Oct 25 23:11:37 2013 -0700

    pidl-wireshark: add definition for IPV4/IPV6 types

Change-Id: I514f855370c1d9355ffc6ff9b31f8aedd70b9122
Reviewed-on: https://code.wireshark.org/review/5096
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:51:18 +00:00
Guy Harris d993cdd449 insure that we have an entire match for the variable name 
Pick up patch from Samba:

    commit fa331f64d1a40350496c7acf68c20cb3fead6eaf
    Author: Matthieu Patou <mat@matws.net>
    Date:   Thu Oct 3 09:45:19 2013 -0700

    pidl-wireshark: insure that we have an entire match for the variable name

Change-Id: I1e730dfb3b9eb96a4cda34659297fddeac7801c8
Reviewed-on: https://code.wireshark.org/review/5095
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:46:51 +00:00
Guy Harris 0139ac87d0 generate an error for the new Pipe type in typedef 
Pick up change from Samba:

    commit 5d0d45c9a71f137dc29ca79d49bd558f34bf1ff5
    Author: Matthieu Patou <mat@matws.net>
    Date:   Sun Sep 29 00:42:36 2013 -0700

    pidl-wireshark: generate an error for the new Pipe type in typedef

    Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Change-Id: I9e6da50b657f774fadf7c3777900d409999d4660
Reviewed-on: https://code.wireshark.org/review/5094
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:44:33 +00:00
Guy Harris 08a85b85ec add a function to change the type of a hf_field 
Pick up change from Samba:

    commit 755bc4ed29c89fc15d4230ce8b828b3afcfa2912
    Author: Matthieu Patou <mat@matws.net>
    Date:   Thu Oct 3 01:10:48 2013 -0700

    pidl-wireshark: add a function to change the type of a hf_field

    We can use this to change the type FT_BYTE when we realize that the
    object dissected is an array of bytes

Change-Id: I1f24ce834b6a5be0d933b1fdfd9a0baa88c3761a
Reviewed-on: https://code.wireshark.org/review/5093
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:34:56 +00:00
Guy Harris e0c727739e Handle the case when the DATA_TYPE is not a simple type 
Pick up change from Samba:

    commit 343db5326b369cbdef4b723e3056acc2a866a887
    Author: Matthieu Patou <mat@matws.net>
    Date:   Tue Sep 23 01:28:40 2014 -0700

    pidl-wireshark: Handle the case when the DATA_TYPE is not a simple type

    Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Change-Id: I511a60beb392e5e92701d5ace1260397fb4be851
Reviewed-on: https://code.wireshark.org/review/5092
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:30:53 +00:00
Guy Harris 58a325e282 Improve string delection in function ContainsString 
Pick up patch from Samba:

    commit 5740a06b320d56840439fb7fe3b8b27f341ddaa7
    Author: Matthieu Patou <mat@matws.net>
    Date:   Sat Oct 4 21:19:12 2014 -0700

    pidl: Improve string delection in function ContainsString

Change-Id: I702c12e4275315511728d5ef6db07e03be9c2b38
Reviewed-on: https://code.wireshark.org/review/5091
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:24:52 +00:00
Guy Harris 0713d35bcd Make the compilation of PIDL produce the same results if the content hasn't changed 
Pick up change from Samba:

    commit 4986359816704f38d4fad3ddd0d07a0f0a25b335
    Author: Matthieu Patou <mat@matws.net>
    Date:   Mon Sep 22 21:52:14 2014 -0700

    pidl: Make the compilation of PIDL producing the same results if the content hasn't change

    Newer perl versions don't generate stable results anymore.

    Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Change-Id: Ifced47229b3033d1fae494adff0dee6671304812
Reviewed-on: https://code.wireshark.org/review/5090
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:21:29 +00:00
Guy Harris f2269b4f37 Pass di to one more call to PIDL_dissect_uint8(). 
The case for type "char" wasn't fixed.

Change-Id: Ia745263cd4d11a3c00b1ecc72e044f4e404da283
Reviewed-on: https://code.wireshark.org/review/5088
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-11-03 19:08:22 +00:00
Michael Mann 54efe5dad1 Improve the "guessing" of the hf_ field and encoding values. 
Change-Id: Iaa042ef8b794c265870a04f6659720c321978697
Reviewed-on: https://code.wireshark.org/review/5026
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-10-31 13:02:35 +00:00
Jeff Morriss cc640f03b9 Prohibit ctype APIs (except toupper() which is still used by file.c - make 
that deprecated).

Also remove a few tabs that were in there.

Change-Id: I1bb2ad726828366a9f7d1a4064b1215b743ad3b5
Reviewed-on: https://code.wireshark.org/review/5000
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-10-30 17:57:00 +00:00
Jeff Morriss e0a352631d Tell the user which file __func__ was found in. 
Change-Id: Ia69ceaf320cb97447f80a7c090efe6d36262a1c1
Reviewed-on: https://code.wireshark.org/review/5001
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
 2014-10-30 16:02:28 +00:00
Michael Mann 62831ba914 convert_proto_tree_add_text.pl - missed adding an else statement to logic. 
Change-Id: I7f31e9ba47d2e94887bd01a84bab356c0c835d92
Reviewed-on: https://code.wireshark.org/review/4998
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-10-30 15:36:31 +00:00
Michael Mann fea733e82b Add logic to determine if a "tvb get" call is used as a parameter to a proto_tree_add_text call. convert_proto_tree_add_text.pl has an easier time determining hf_ field values with a "tvb get" call present, so it's more likely those dissectors will be picked first in eliminating their proto_tree_add_text calls. 
Change-Id: I3dd57a73c8e60d8075a6bb987efd52b96b38445c
Reviewed-on: https://code.wireshark.org/review/4997
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-10-30 15:20:48 +00:00
Anish Bhatt 439c0b88a6 [tools] Add missing GPL license to generate-bacnet-vendors.py 
Change-Id: I15336a5f759fea6b1fb4f6c5a05807d797a7f5aa
Reviewed-on: https://code.wireshark.org/review/4544
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
 2014-10-08 10:52:38 +00:00
Alexis La Goutte ceda0f9a40 Remove #pragma warning (MSVC) for PIDL generate dissector 
Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c
Reviewed-on: https://code.wireshark.org/review/4479
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
 2014-10-08 09:45:45 +00:00
Anish Bhatt 515f09fef0 [tools] add script to automatically generate bacnet vendors 
Requires beautifulsoup4 for parsing, translitcodec for converting accents/diaeresis etc to regular text

Change-Id: I4d400f15916ee3ab07fa14b09fca12beac2010f3
Reviewed-on: https://code.wireshark.org/review/4518
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-10-07 21:28:00 +00:00
Stig Bjørlykke 683165272f asn2wrs: Added support for #.SYNTAX_NEW 
This allows syntaxes to be registered as "new" dissectors.

Change-Id: Ibb76688d9d3cbf47222610956aa627fa374bcbce
Reviewed-on: https://code.wireshark.org/review/4524
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
 2014-10-07 20:28:10 +00:00
Alexis La Goutte 683d657d49 PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer 
packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined
packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined
packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined
packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined
packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value
packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized]

Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f
Reviewed-on: https://code.wireshark.org/review/4478
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-10-07 01:13:06 +00:00
Alexis La Goutte 4110bdead7 PIDL: fix indent (use 4 tabs) and remove trailing whitespace 
Change-Id: I0ee63a040867b44ac9915704f5e581483ed6f7e2
Reviewed-on: https://code.wireshark.org/review/4310
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-09-29 06:24:11 +00:00
Alexis La Goutte f6b9e7a79e PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
Change-Id: Ibae478771b30d6e9ae07315985f1e71bc6b65423
Reviewed-on: https://code.wireshark.org/review/4350
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-28 19:16:17 +00:00
Alexis La Goutte 28ec9c29ea PIDL (DCERPC winreg): enhance dissector 
* Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector)
* Fix indent (use tabs)
* Remove DCERPC winreg dissector from DIRTY list

Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7
Reviewed-on: https://code.wireshark.org/review/4322
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-28 16:41:20 +00:00
Alexis La Goutte e759d8272b PIDL: fix -Wmissing-prototype 
Change-Id: I4cae47450e8026b10bd373828f235184560e0a99
Reviewed-on: https://code.wireshark.org/review/4308
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-28 16:22:15 +00:00
Alexis La Goutte f0b5fb7a04 PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8
Reviewed-on: https://code.wireshark.org/review/4319
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
 2014-09-27 20:07:11 +00:00
Guy Harris 24ced90c7f White space and typo cleanups. 
Change-Id: If064178a383ce805ed6f440a1a9d3642a706496c
Reviewed-on: https://code.wireshark.org/review/4320
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 20:15:03 +00:00
Guy Harris ef106f4c19 Update to latest version from Samba Git repository. 
Comments from Samba Git log:

commit ee2148754e2e2604ac918343fa8769a25523eb49
Author: Stefan Metzmacher <metze@samba.org>
Date:   Tue Aug 26 21:33:05 2014 +0200

    pidl/wscript: remove --with-perl-* options

    These are not needed anymore as we have useful defaults now.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Michael Adam <obnox@samba.org>

commit b537c5a340bae2accbf35a4ec5eab7074b90f0b1
Author: Michael Adam <obnox@samba.org>
Date:   Mon Aug 25 23:57:23 2014 +0200

    pidl: fix the perl module search path (use lib ...) when installing pidl.

    This way, pidl can also run with modules installed under the $prefix.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Michael Adam <obnox@samba.org>

commit 191fc0e541e7c9d0a1095dc287402df9947ce779
Author: Michael Adam <obnox@samba.org>
Date:   Thu Sep 4 01:38:14 2014 +0200

    pidl/wscript: don't check for perl again.

    This is done at the toplevel now.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
    Signed-off-by: Michael Adam <obnox@samba.org>
    Signed-off-by: Stefan Metzmacher <metze@samba.org>

commit 9e591e3d619d127c5ec5f6ac86326c84f59878fa
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:59:45 2014 +0100

    pidl-waf: Check for system perl(Parse::Yapp::Driver).

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit 410ada45b7041be6976fcfefadccbb99212a15a3
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:59:41 2014 +0100

    pidl-waf: Add a function to check for a system perl module.

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit 17244ef750f699b30ff7ff3a71264f4c76adad6d
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:53:10 2014 +0100

    pidl-waf: Install pidl modules to the perl vendorlib directory.

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit 0bb6b0102f6fa21e6c9f8010421386a660c5a5e0
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:54:09 2014 +0100

    pidl-waf: Remove unused variable pidl_src.

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit 87976b4e45bd71b086e9201f0d0a563b9071ca4a
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:46:01 2014 +0100

    Revert "pidl: Install pidl files corrently."

    This reverts commit cee11cfa4544425099268cd32393169afb4bb107.

    Reviewed-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit c2d58c3c2059ef3d43f876df547cbc7256235563
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:45:51 2014 +0100

    Revert "waf: Add option to specify perl vendor dir."

    This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83.

    Reviewed-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit c46aaf1102da5e8ba53e9f89f2f756fe8dce83c5
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:45:35 2014 +0100

    Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional."

    This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838.

    Reviewed-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838
Author: Andreas Schneider <asn@samba.org>
Date:   Thu Feb 27 13:14:56 2014 +0100

    pidl: Make perl(Parse:Yapp:Driver) installation optional.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Jelmer Vernooij <jelmer@samba.org>

    Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
    Autobuild-Date(master): Thu Feb 27 18:47:03 CET 2014 on sn-devel-104

commit 9b200555fec2e33da9521db388d1839375aa8d83
Author: Andreas Schneider <asn@samba.org>
Date:   Tue Feb 25 17:16:37 2014 +0100

    waf: Add option to specify perl vendor dir.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Kai Blin <kai@samba.org>

    Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
    Autobuild-Date(master): Thu Feb 27 11:48:54 CET 2014 on sn-devel-104

commit cee11cfa4544425099268cd32393169afb4bb107
Author: Andreas Schneider <asn@samba.org>
Date:   Tue Feb 25 16:04:24 2014 +0100

    pidl: Install pidl files corrently.

    Globbing is a really bad idea in installtion system. One of them is if
    you use patch -b to create a backup, you will end up installing the
    backup file too!

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Kai Blin <kai@samba.org>

Change-Id: I9c4491f0d74c24d7c45a59e98825c789097a0c7b
Reviewed-on: https://code.wireshark.org/review/4318
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:31:15 +00:00
Guy Harris 6700a12a3c Update to current version from Samba Git repository. 
Changes from Samba Git log:

commit fac24e11655c554cd3113dfb6fc918a0fd3c880c
Author: Michael Adam <obnox@samba.org>
Date:   Mon Aug 25 23:58:48 2014 +0200

    pidl: remove superfluous "use lib ...".

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Michael Adam <obnox@samba.org>

Change-Id: I8a2460a9168ef5989e9f5e95b51cca73987b80a4
Reviewed-on: https://code.wireshark.org/review/4317
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:28:03 +00:00
Guy Harris 44551d39b8 Update to latest version from Samba Git repository. 
Changes from Samba Git log:

commit cf75ef9f73f2cdbf2a039bbc9468f5da6a14834e
Author: Stefan Metzmacher <metze@samba.org>
Date:   Fri May 9 11:49:10 2014 +0200

    pidl/lib/wscript_build: make use of PERL_LIB_INSTALL_DIR

    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andreas Schneider <asn@samba.org>

    Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
    Autobuild-Date(master): Sat May 10 01:37:33 CEST 2014 on sn-devel-104

commit ee8f98f26a3d6f02a0d10ceeac1194675d505246
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 16:00:54 2014 +0100

    pidl-waf: Only install Yapp::Driver if it is not available.

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

    Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
    Autobuild-Date(master): Thu Mar  6 23:30:47 CET 2014 on sn-devel-104

commit b7b0ca1ba9067362bb8a4b901f3a7f2f3bcbd6a1
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:55:46 2014 +0100

    pidl-waf: Do not glob to install pidl modules.

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit 17244ef750f699b30ff7ff3a71264f4c76adad6d
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:53:10 2014 +0100

    pidl-waf: Install pidl modules to the perl vendorlib directory.

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit 87976b4e45bd71b086e9201f0d0a563b9071ca4a
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:46:01 2014 +0100

    Revert "pidl: Install pidl files corrently."

    This reverts commit cee11cfa4544425099268cd32393169afb4bb107.

    Reviewed-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit c2d58c3c2059ef3d43f876df547cbc7256235563
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:45:51 2014 +0100

    Revert "waf: Add option to specify perl vendor dir."

    This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83.

    Reviewed-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit c46aaf1102da5e8ba53e9f89f2f756fe8dce83c5
Author: Andreas Schneider <asn@samba.org>
Date:   Fri Feb 28 15:45:35 2014 +0100

    Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional."

    This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838.

    Reviewed-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Stefan Metzmacher <metze@samba.org>

commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838
Author: Andreas Schneider <asn@samba.org>
Date:   Thu Feb 27 13:14:56 2014 +0100

    pidl: Make perl(Parse:Yapp:Driver) installation optional.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Jelmer Vernooij <jelmer@samba.org>

    Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
    Autobuild-Date(master): Thu Feb 27 18:47:03 CET 2014 on sn-devel-104

commit 9b200555fec2e33da9521db388d1839375aa8d83
Author: Andreas Schneider <asn@samba.org>
Date:   Tue Feb 25 17:16:37 2014 +0100

    waf: Add option to specify perl vendor dir.

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Kai Blin <kai@samba.org>

    Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
    Autobuild-Date(master): Thu Feb 27 11:48:54 CET 2014 on sn-devel-104

commit cee11cfa4544425099268cd32393169afb4bb107
Author: Andreas Schneider <asn@samba.org>
Date:   Tue Feb 25 16:04:24 2014 +0100

    pidl: Install pidl files corrently.

    Globbing is a really bad idea in installtion system. One of them is if
    you use patch -b to create a backup, you will end up installing the
    backup file too!

    BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472

    Signed-off-by: Andreas Schneider <asn@samba.org>
    Reviewed-by: Kai Blin <kai@samba.org>

Change-Id: I4372f2c0854743a0339c7d85ace9e67ce9f8bd02
Reviewed-on: https://code.wireshark.org/review/4316
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:22:12 +00:00
Guy Harris 788de8d558 Update to current version from Samba Git repository. 
Changes from Samba Git log:

commit d29c143fae4b67c9680a0b9773db3461f2d0d2b7
Author: Stefan Metzmacher <metze@samba.org>
Date:   Thu Mar 27 14:56:23 2014 +0100

    pidl:Samba4/Python: add interface.abstract_syntax() to each interface

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Change-Id: I9f4650c603ea8b2eff05e7b79d7f44452e1337ab
Reviewed-on: https://code.wireshark.org/review/4315
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:17:40 +00:00
Guy Harris d720fe8f77 Update to the latest version from the Samba Git repository. 
Changes from the Samba Git log:

commit 2ba9453e9ff5d911a146e786ff8878ef67717366
Author: Stefan Metzmacher <metze@samba.org>
Date:   Thu Sep 26 20:38:12 2013 +0200

    pidl:NDR/Client: avoid useless memcpy()

    If the src and dest pointer of memcpy would be the same
    we should avoid it in order to avoid valgrind warnings.

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andreas Schneider <asn@samba.org>

commit f50b561336c7b6c08300e6e477859d1f9fab62c2
Author: Stefan Metzmacher <metze@samba.org>
Date:   Thu Sep 26 01:20:10 2013 +0200

    pidl:NDR/Client: fix dcerpc_function() with [out,ref] pointers

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andreas Schneider <asn@samba.org>

commit 662fc2de8c2896503026a2a4052ed1ea8ce78af5
Author: Stefan Metzmacher <metze@samba.org>
Date:   Fri Aug 30 08:54:10 2013 +0200

    pidl:NDR/Client: simplify tevent_req_nterror() usage

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andreas Schneider <asn@samba.org>

commit 02c34fe4e51b5e62157eaf2de1d0aaf9fc6b8d72
Author: Stefan Metzmacher <metze@samba.org>
Date:   Fri Aug 30 08:53:18 2013 +0200

    pidl:NDR/Client: add missing TALLOC_FREE(subreq) after dcerpc_binding_handle_call_recv()

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andreas Schneider <asn@samba.org>

Change-Id: I19017fd216df8d8d202b995305f4eb7b7a8b9a35
Reviewed-on: https://code.wireshark.org/review/4314
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:11:09 +00:00
Guy Harris df685fc94e Update to the latest version from the Samba Git repository. 
Changes from the Samba log:

commit 3a0fa3605b8eb995a8cc4696256129893e1f6f7e
Author: Stefan Metzmacher <metze@samba.org>
Date:   Sat Sep 21 23:46:01 2013 +0200

    pidl:Samba3/ServerNDR: skip DCERPC pipe elements and leave NULL pointers.

    We don't support them anyway, but this lets us adding them to the idl
    file and only ignore it on the server.

    Signed-off-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Andreas Schneider <asn@samba.org>

Change-Id: Idbe742fa13e5d3892343fde2b3943f38a6e90a8c
Reviewed-on: https://code.wireshark.org/review/4313
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:07:05 +00:00
Guy Harris bcae0488fc Update to the latest version from the Samba Git repository. 
From the Samba log:

commit bfdc874e8b98c8ea147dbcc986f96ad4f73d800f
Author: Jelmer Vernooij <jelmer@samba.org>
Date:   Sat Aug 30 01:59:26 2014 +0200

    Various updates to the pidl README file.

    Remove samba3/samba4-specific comments, add comments about backends and files.

    Change-Id: Id2253ce85eab7a684b2c50d25f6f2604dc146a8e
    Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
    Reviewed-by: David Disseldorp <ddiss@samba.org>

    Autobuild-User(master): David Disseldorp <ddiss@samba.org>
    Autobuild-Date(master): Sun Aug 31 23:47:49 CEST 2014 on sn-devel-104

commit 6824f1aa67f0a75df5c94921e334c2b7c7771611
Author: Jelmer Vernooij <jelmer@samba.org>
Date:   Sat Aug 30 01:59:25 2014 +0200

    Remove trailing whitespace.

    Change-Id: I1e0948da34bac278edc62cd63dedd08112426e7a
    Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
    Reviewed-by: David Disseldorp <ddiss@samba.org>

Change-Id: Ifd445bf32aca2d30a6e501fc8c8dd030471ad284
Reviewed-on: https://code.wireshark.org/review/4312
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-09-26 19:02:42 +00:00
Bill Meier 19d55ca5a2 fix-encoding-args.pl: Don't use a feature available only starting with perl 5.14 
Specifically: Window msys git uses an earlier version of Perl (5.8) and thus
	      invoking fix-encoding-args.pl in the pre-commit hook script
	      gives a Perl syntax error.

See https://code.wireshark.org/review/4172 for details

(Also see following for Perl info:
 http://www.perl.com/pub/2011/05/new-features-of-perl-514-non-destructive-substitution.html)

Change-Id: I95a222eaa31942cc6e873ffbde57c5fa5bd2a625
Reviewed-on: https://code.wireshark.org/review/4245
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-09-22 14:32:16 +00:00
Alexis La Goutte 047bd369a8 PIDL: fix trailing tabspace 
Change-Id: If3b623d82d6bbbf9943a35c8885620881eedb091
Reviewed-on: https://code.wireshark.org/review/4204
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-20 20:08:01 +00:00
Michael Mann 06237e4878 proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors. 
Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d
Reviewed-on: https://code.wireshark.org/review/4199
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-20 11:59:25 +00:00
Michael Mann a58c986f62 Update generated DCE/RPC dissectors. 
Now all generated dissectors can successfully compile.

Change-Id: I74728926915d5a9f1694cc49c753b80f213df767
Reviewed-on: https://code.wireshark.org/review/2598
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-19 13:07:11 +00:00
Bill Meier 4bdf514512 fix-encoding-args.pl: Add a few additional fixups; 
Specifically: A number of cases of the use of the encoding arg
              "ENC_ASCII | ENC_NA" for FT_BYTES FIELDTYPEs seem to
              have crept into Wireshark source.

Also: Add a ToDo comment as to code rework needed to be able to
      better *validate* encoding args.

Change-Id: I9d4b10b869fe2aef3f20bcd2d7ad6531375aba87
Reviewed-on: https://code.wireshark.org/review/4183
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-09-19 01:37:38 +00:00
Bill Meier 051b0000f9 fix-encoding-args.pl: Add a few fixups for FT_UINT_STRING 
Change-Id: Ic22e154859877c48a85b808d0029e10e07876b73
Reviewed-on: https://code.wireshark.org/review/4174
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-09-18 15:08:39 +00:00
Bill Meier dbb01af72f fix-encoding-args.pl: Fix bug: certain patterns found only in 1st,3rd,... file checked 
Another perl "You can't DO that" ...

Change-Id: I56e11bec19515f883f15286c6aa45018a255ab53
Reviewed-on: https://code.wireshark.org/review/4172
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-09-18 15:06:25 +00:00
Evan Huus 27d1b6addf Bump the time limit for valgrind fuzzing 
Some captures are still hitting the limit as a false positive.

Bug: 10122
Change-Id: I12dd26ba0f96f44799f5ae642b1f9b0487f86a8a
Reviewed-on: https://code.wireshark.org/review/3982
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-09-04 12:54:16 +00:00
Роман Донченко 95cd6b76bd Remove make-tapreg-dotc and its uses, since Python is now mandatory 
Change-Id: I13fd57a288be68d18819826bf566ed7b5688ebaa
Reviewed-on: https://code.wireshark.org/review/3926
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
 2014-08-31 22:14:15 +00:00
Diederik de Groot 0622e3439e Skinny: 
Fix: ensure that string created in dissect_skinny_displayLabel is always NULL terminated (Fixing Bug: 10429 (Pascal))
Fix: MiscCommandType should use videoFastUpdateGOB Union when command enum is videoFastUpdatePicture
Manual Merge PatchSet 4 (Me) and Patchset 7 (Pascal)
Fix Merged PatchSet 8 (Pascal)

Bug: 10429
Change-Id: I87bc7c6eaff976d7a70856f5fbe8c0ded6257064
Reviewed-on: https://code.wireshark.org/review/3893
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-08-29 17:44:41 +00:00
Bill Meier 1b3bc9b71e checkhf.pl: (Trivial) remove trailing whitespace. 
Change-Id: I37ece54d936541b5d92e8c323ffeb429d9cc5f33
Reviewed-on: https://code.wireshark.org/review/3879
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-08-27 16:18:34 +00:00
Diederik de Groot d6aa77d83b Skinny: 
Do not try to create a wmem_strbuf whose size is bigger than the max size allowed -> using wmem_strbuf_new instead of wmem_strbuf_sized_new (Evan Huus)
While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized -> Did not get any, can you specify which errors ? (Pascal Quantin)
FT_IPv6: 'ENC_BIG_ENDIAN | ENC_NA' -> 'ENC_NA' only (2) (Pascal Quantin)
Revert back to wmem_strbuf_sized_new instead of wmem_strbuf_new (Pascal Quantin)
Use wmem_strbuf_sized_new maxlength = 0  (Pascal Quantin)

Bug: 10409
Bug: 10410
Change-Id: Iebfcb53bc0a6289e02d10c38ecb717aa5c89389e
Reviewed-on: https://code.wireshark.org/review/3862
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-08-26 18:58:39 +00:00
Alexis La Goutte efd95341e8 Add custom_layer_chm.xsl to UNKNOWN (fix checklicence) 
Change-Id: I4c336f21f721443e83eca7b9bf8d7a6138b367f4
Reviewed-on: https://code.wireshark.org/review/3827
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
 2014-08-26 15:22:28 +00:00
Pascal Quantin 7836a714ab Skinny: do not try to create a wmem_strbuf whose size is bigger than the max size allowed 
While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized

Bug: 10409
Change-Id: Ic84632e0563f801239603534121e3487cf0d6d24
Reviewed-on: https://code.wireshark.org/review/3861
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-08-26 12:07:44 +00:00
Diederik de Groot 7749263be6 Skinny Dissector: 
Source Fix: Trailing Whitespace (Reported by Graham Bloice).
Dissection Fix: ProtocolVer needed to be split up into two fields to display the protocol version correct during device registration
Segfault Fix: Null Pointer Check required after returning from tvb_memdup, before calling strlen (Reported by Evan Huus)
Fix: Whitespace (again)

Bug: 10409
Change-Id: Ib253ea843363792f678f2e724359f83f12ebfadc
Reviewed-on: https://code.wireshark.org/review/3844
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-08-25 23:58:24 +00:00
Bill Meier cdc80af27e checkhf.pl: (Trivial) fix two typos 
Change-Id: I2a63127dcf819d671a4c814dcbd82b2dca5022d3
Reviewed-on: https://code.wireshark.org/review/3838
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-08-25 15:46:10 +00:00