Commit Graph

35 Commits

Author SHA1 Message Date
Ronnie Sahlberg 4f9c68984e make hf_nfs_nfsstat externaly visible so other dissectors can use nfs
status codes


svn path=/trunk/; revision=22123
2007-06-18 00:01:24 +00:00
Ronnie Sahlberg ab740c7f6d add some missing error codes
svn path=/trunk/; revision=22118
2007-06-17 17:39:30 +00:00
Guy Harris e5f3d4af31 Better hash function for file handles, as suggested by Brent Callaghan
(the old one was mapping file handles that differed only by one bit to
the same hash value; the new one mapped them to different hash values).

svn path=/trunk/; revision=22065
2007-06-08 02:45:30 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris b98d651b21 In calls to the emem_tree routines, forcibly align items not known to be
aligned on 32-bit boundaries.

svn path=/trunk/; revision=21611
2007-04-28 21:09:20 +00:00
Ulf Lamping 7994794ad9 fix a lot more warnings
svn path=/trunk/; revision=21142
2007-03-23 01:29:52 +00:00
Jaap Keuter b536022566 From J. Bruce Fields:
Fix an obvious error in the nfs4 stateid parsing.  The stateid is used in a number of common operations (such as open and setattr), so this caused a lot of misparsing.

svn path=/trunk/; revision=20700
2007-02-03 20:31:40 +00:00
Ronnie Sahlberg d8c269be98 From Alex B
Added support for upcoming Netapp's ONTAP-GX nfsv3 filehandle.

Alex.




svn path=/trunk/; revision=19875
2006-11-10 23:36:57 +00:00
Ronnie Sahlberg 6fee9a41f0 From Alex Burlyga
This patch adds support for dissecting ontap's nfsv4 filehandle,
as well as some updates to nfsv3 filehandle as well in the nfs
dissector.

Alex.


checked in with minor changes


svn path=/trunk/; revision=19345
2006-09-28 07:52:46 +00:00
Ronnie Sahlberg 8ce8e719e0 rename some structures and defines from the se_tree to the emem_tree prefix
svn path=/trunk/; revision=18894
2006-08-14 08:29:29 +00:00
Gerald Combs 1f8334d9e9 Two more bugs from Ilja van Sprundel.
packet-ndmp.c:
  Fix our payload length check.

packet-nfs.c:
  Check for a maximum bitmap length.

Fix up whitespace.

svn path=/trunk/; revision=18699
2006-07-10 19:54:41 +00:00
Ronnie Sahlberg 332df10d7e coverity warning 177 deadcode
replace overly convoluted code with much simpler code.

stateid is a simple 16 byte structure and there is no need to make it more complex than it is.



svn path=/trunk/; revision=18555
2006-06-23 09:02:54 +00:00
Ronnie Sahlberg f27bb044dd two things have irritated me immensly with nfs filehandles
1, (minor) the heuristics are too weak and everyting is always decoded either as netapp filehandles or one of the others   even when just capturing ibetween say two classic unix boxens
2, (major) you can not filter on specific subfields of the filehandle


observation: 5 people or less in the world care about implementation specific storage of data inside an opaque blob.


remove the too weak heuristics for nfs filehandles.
make decoding of filehandles accorrding to specific implementations controlled by a preference setting.
default this setting to "unknown"

display unknown filehandles using proto_tree_add_item()  FT_BYTES/BASE_HEX to make it fitlerable instead of a useless proto_tree_add_text()


wiki needs to be updated tomorrow


svn path=/trunk/; revision=18530
2006-06-21 09:45:50 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg 2376539aab the hash,name,fullname of an nfs filehandle are all
generated items

mark them as generated items in the dissect pane


svn path=/trunk/; revision=17785
2006-04-02 23:24:00 +00:00
Ronnie Sahlberg d9227587f0 prettify dissection of nfsv3 fattr3 structure
put useful info like type,mode,uid,gid on the expansion lines so we dont have to open the expansion to see these values.

allow it to push this info multiple expansion lines upward
and optionally (such as for GETATTR replies) put this info in the info column as well




svn path=/trunk/; revision=17783
2006-04-02 21:04:11 +00:00
Ronnie Sahlberg 329b915b66 coverity bug 139
actually allow dissection of RELEASE_LOCKOWNER call
instead of letting it hang as dead code



svn path=/trunk/; revision=17626
2006-03-14 08:11:18 +00:00
Ronnie Sahlberg 27de4cfd39 give se_trees names so that it is easier to debug and to log how often certain trees are accessed
svn path=/trunk/; revision=17587
2006-03-11 13:02:41 +00:00
Ronnie Sahlberg b4c4d56509 remove some harmless but redundant code
coverity  cid 31


svn path=/trunk/; revision=17516
2006-03-08 08:35:13 +00:00
Ronnie Sahlberg 07c2845fe7 get rid of another slow hashtable and one global variable and
replace it with a better and memleak free se_tree



svn path=/trunk/; revision=17480
2006-03-06 14:30:34 +00:00
Ronnie Sahlberg 51f8a228f6 replace one hashtable storing filehandles with a new se tree
this should make it quite a bit faster than before.



svn path=/trunk/; revision=17479
2006-03-06 13:45:30 +00:00
Ronnie Sahlberg 4caa47a1ac replace a g_malloc()/g_free() pair with ep_alloc() instead
svn path=/trunk/; revision=17478
2006-03-06 10:39:31 +00:00
Ronnie Sahlberg 745994c364 add helper to build (red/black) trees from a key that is a vector of guin32 arrays.
test this functionality by calling these vector insert/lookup tree functions from the nfs dissector for when filehandles are used as a key.

these vector functions could also be used to efficiently store conversations :
se_tree_key_t[6] = {
	{ addr_len/4,   &src_addr },
	{ addr_len/4,	&dst_addr },
	{ 1,		&src_port32 },
	{ 1,		&dst_port32 },
	{ 1,		&protocol32 },
	{ 0, NULL }
}


(the nfs dissector needs a LOT of work. It is very painful to work with 
very large nfs traces with all the memory it wastes (and eats) as well as how slow all the tables make it)



svn path=/trunk/; revision=17477
2006-03-06 10:25:19 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Ronnie Sahlberg b0cdcf40ab get rid of the last two strcpy from epan/dissectors
svn path=/trunk/; revision=16342
2005-10-27 10:11:22 +00:00
Ronnie Sahlberg 05dbe84db8 gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15326
2005-08-12 23:57:01 +00:00
Jörg Mayer 54861853a8 More char -> const char warning fixes
svn path=/trunk/; revision=15155
2005-07-30 07:13:27 +00:00
Ronnie Sahlberg 6aaaedd633 we no longer need to g_free() teh string returned by dissect_rpc_string.
when checking the calls in packet-ndmp.c  we must have had a memleak there since it never freed those strings.



svn path=/trunk/; revision=15005
2005-07-23 00:22:02 +00:00
Guy Harris a42c4bc656 Have separate fields for NFSv2, NFSv3, and NFSv4 return statuses, using
the names in the v2, v3, and v4 specs for values, so that they display
correctly and can be filtered on correctly.

Have "nfs.status" as a hidden field, with a name table giving just "OK"
and "ERR_" values, and having items for v2, v3, and v4 status values
(the only collision is that the v3 JUKEBOX error is the v4 DELAY error),
so that filters on "nfs.status" will still work, but will now be able to
filter symbolically on values from v2, v3, and v4.

Show 33 status values in the Info column and the summary entry using the
table of v3 status values and names, not the table of v2 status values
and names.

Fix some v3 dissectors to use the v3 return status field rather than the
v2 return status field.

svn path=/trunk/; revision=14831
2005-07-02 08:18:17 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Ronnie Sahlberg 1d2c39cc60 make file name snooping use information from READDIRPLUS replies when building the filehandle to name mapping
svn path=/trunk/; revision=14074
2005-04-14 06:45:32 +00:00
Ulf Lamping 78ff68d4b5 a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros
svn path=/trunk/; revision=12832
2004-12-25 13:49:30 +00:00
Guy Harris bbe7f89742 Move prefs.c and prefs.h into the epan subdirectory.
svn path=/trunk/; revision=12115
2004-09-27 22:55:15 +00:00
Guy Harris c68f62210f Add "tvb_get_ntoh64()" and "tvb_get_letoh64()" routines to fetch 64-bit
integers.

Make FT_INT64 and FT_UINT64 add numerical values, rather than byte-array
values, to the protocol tree, and add routines to add specified 64-bit
integer values to the protocol tree.

Use those routines in the RSVP dissector.

svn path=/trunk/; revision=11796
2004-08-22 00:31:58 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00