99d0404b73
replaced decode_enumerated_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45176
2012-09-27 16:49:31 +00:00
3b6428bb44
Don't pass a null pointer to strcmp.
...
svn path=/trunk/; revision=45175
2012-09-27 16:23:06 +00:00
d003cdf66e
Allow dissection of partial jpegs by a modification of the heuristics.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6230
#BACKPORT(1.8, 1.6)
svn path=/trunk/; revision=45174
2012-09-27 14:02:37 +00:00
a23c3aae3c
Fix duplicated field: nmpi.name_flags
...
svn path=/trunk/; revision=45170
2012-09-27 10:42:03 +00:00
65ef9e9d6b
replaced decode_numeric_bitfield calls with filterable item or removed it if it didn't mathematically do anything.
...
svn path=/trunk/; revision=45166
2012-09-27 04:36:40 +00:00
0063cc00c8
remove decode_numeric_bitfield + cleanup.
...
I wanted to just remove the decode_numeric_bitfield calls, but the dissector needs some MAJOR work. Cleaned up some with the power of value_strings, but I just got overwhelmed. There has got to be existing APIs to make this dissection simpler (besides being more filterable).
svn path=/trunk/; revision=45165
2012-09-27 04:05:01 +00:00
9636d1655d
Put the individual property flags under the properties item, rather than
...
at the top level.
svn path=/trunk/; revision=45159
2012-09-26 20:43:58 +00:00
141200fa86
Show the PID field of the transport feedback NACK as "RTCP Transport
...
Feedback NACK PID", not just as "RTCP Transport Feedback NACK", and give
the field a name for that.
Use it in the protocol tree for the bits of the BLP field, rather than
making it a hidden field there.
Clean up the tags appended to the BLP field.
svn path=/trunk/; revision=45157
2012-09-26 20:19:20 +00:00
0ac06207ce
Just append the ": " to the generic NACK BLP item, don't replace its
...
text.
Don't put empty items into the bitfield tree.
Show the BLP field as hex, as it's a bitfield.
(What should *really* happen is that it should display each 1 bit in the
usual fashion, with the ".... ...1 .... ...." display, but have that bit
be an *integral* field with the appropriate PID for the NACKed packet -
i.e., display hf_rtcp_rtpfb_nack_pid, with the value
rtcp_rtpfb_nack_pid + i + 1, and with the bitfield stuff in the
displayed representation.)
svn path=/trunk/; revision=45155
2012-09-26 19:23:33 +00:00
6b4ffe18d4
add the the necessary tfs variables for rev 45152
...
svn path=/trunk/; revision=45153
2012-09-26 18:19:15 +00:00
97c808c75c
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45152
2012-09-26 18:10:29 +00:00
2edc3c1822
minor endian bugfix
...
svn path=/trunk/; revision=45151
2012-09-26 18:09:04 +00:00
60626e8fd2
In get_unicode_or_ascii_string(), check if the length is odd/even, not the offset. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5778 - Volume label field ... is not displayed correctly ...
...
#BACKPORT(1.8, 1.6)
svn path=/trunk/; revision=45150
2012-09-26 16:48:20 +00:00
0b194f98ad
Control the heuristic dissector with a preference. It is only a 7-bit
...
CRC, so was firing too readily...
svn path=/trunk/; revision=45147
2012-09-26 10:10:27 +00:00
be0a9dcfa2
Note that it's a smart card standard.
...
svn path=/trunk/; revision=45141
2012-09-25 21:00:10 +00:00
82f78f6ed6
trival: replaced tabs with spaces, added modelines
...
svn path=/trunk/; revision=45138
2012-09-25 19:57:10 +00:00
7da8dfc0b8
From Michal Labedzki
...
make ISO 7816 Answer To Reset (ATR) a separate dissector
call it from Bluetooth SAP
from me
- change protocol name to iso7816.atr to be consistent with existing
filter names
- subtree for atr
- always call atr dissector via handle
- reject the packet if it has no valid init char
- don't use boolean data parameter, fill the info column with the data
required by Bluetooth SAP
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715
svn path=/trunk/; revision=45137
2012-09-25 19:46:10 +00:00
5cb75e808d
replaced decode_boolean_bitfield, decode_numeric_bitfield, and decode_enumerated_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45135
2012-09-25 18:41:41 +00:00
edf882913e
Decode some more elements.
...
svn path=/trunk/; revision=45119
2012-09-25 01:21:19 +00:00
4f9707469d
replaced decode_boolean_bitfield calls with itemized filters
...
added tfs_no_yes to tfs.[ch]
svn path=/trunk/; revision=45115
2012-09-25 01:00:41 +00:00
3f16280e9b
From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7753 :
...
Fix display of WRITE BUFFER and SEND DIAGNOSTIC fields in SCSI dissector
svn path=/trunk/; revision=45111
2012-09-24 19:42:12 +00:00
7a9d27c33f
Regenerate asn.1 dissectors.
...
svn path=/trunk/; revision=45110
2012-09-24 19:38:46 +00:00
8499871d96
Beginnings of the Foundry Discovery Protocol (FDP) dissector.
...
While FDP is (mostly) deprecated, it is still in use.
svn path=/trunk/; revision=45103
2012-09-24 16:20:31 +00:00
d424f3949a
Get rid of ../../epan/address.h:65:19: warning: comma at end of enumerator list [-pedantic]
...
svn path=/trunk/; revision=45102
2012-09-24 15:08:46 +00:00
0bbd6d4616
Try to passify the buildbots by:
...
- Using G_GINT64_CONSTANT for 64 bit constants.
- Using guint64 and G_GINT64_MODIFIER where apropriate
- set individual struct members.
- cast time_t to guint i two places.
svn path=/trunk/; revision=45101
2012-09-24 13:54:45 +00:00
44e5ddb9c9
packet-btavctp.c:107: warning: 'number_of_packets' may be used uninitialized in this function
...
packet-btavctp.c:105: warning: 'pid' may be used uninitialized in this function
svn path=/trunk/; revision=45100
2012-09-24 12:51:34 +00:00
3bc8e5ff68
From Michal Labedzki:
...
Add Bluetooth Profile AVRCP. Supported version: 1.5.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740
svn path=/trunk/; revision=45099
2012-09-24 12:46:30 +00:00
577dec01c5
From Michal Labedzki:
...
Add Bluetooth Protocol AVCTP. Supported version: 1.4.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7675
svn path=/trunk/; revision=45097
2012-09-24 12:30:30 +00:00
a64c8ab1ac
Whitespace fixes
...
svn path=/trunk/; revision=45095
2012-09-24 11:39:28 +00:00
516f0c6e5c
Also avoid some unnecessary calls to strcmp() here, where the release
...
number at the end isn't important to know.
svn path=/trunk/; revision=45092
2012-09-24 10:34:27 +00:00
ef4ecaa38b
Use proto_tree_add_item() and value_strings in a couple of more places.
...
svn path=/trunk/; revision=45087
2012-09-24 08:38:45 +00:00
88ee7291cf
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45082
2012-09-24 01:59:34 +00:00
69905db57c
Move potential dereference until *after* the null-check.
...
Caught by cppcheck.
svn path=/trunk/; revision=45081
2012-09-23 21:02:32 +00:00
7dd916459e
Let's be consistent and display lte_rrc root for all LTE RRC messages
...
svn path=/trunk/; revision=45080
2012-09-23 21:01:05 +00:00
c4d449cbff
expert_add...() shouldn't be called under 'if (tree)'.
...
svn path=/trunk/; revision=45072
2012-09-23 18:15:09 +00:00
72ca9d0e61
Store pointers to previously displayed and captured packet, not nstime_t deltas.
...
This commit reduces size (from 144B to 128B on AMD64) of frame_data structure.
Part of bug 5821: Reduce per-packet memory requirements.
svn path=/trunk/; revision=45071
2012-09-23 16:25:28 +00:00
9cde3e1a44
Add lua_nstime_to_sec()
...
svn path=/trunk/; revision=45070
2012-09-23 15:57:11 +00:00
7719d4e84a
Cleanup wslua PINFO_GET_* macros. It's portable, right?
...
svn path=/trunk/; revision=45067
2012-09-23 14:46:43 +00:00
2fc8270439
[Automatic manuf, services and enterprise-numbers update for 2012-09-23]
...
svn path=/trunk/; revision=45065
2012-09-23 14:03:25 +00:00
a9bb9186dd
Fix some unused variable warnings from GCC.
...
svn path=/trunk/; revision=45064
2012-09-23 12:45:03 +00:00
b89a06a3e1
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45059
2012-09-23 00:12:14 +00:00
6b3b90bde7
Fixup vlan_flags bug introduced with r45054
...
svn path=/trunk/; revision=45055
2012-09-22 18:47:11 +00:00
6516edc022
replaced decode_boolean_bitfield calls with itemized filters
...
svn path=/trunk/; revision=45054
2012-09-22 17:41:07 +00:00
ad32e468bf
Note that Banyan don't exist any more, so you can't order a dead-tree
...
version of the VINES documentation from them. However, there appear to
be online versions available; give the URLs for them.
svn path=/trunk/; revision=45052
2012-09-22 10:28:21 +00:00
a5d1394953
Remove incorrect extra hf_vines_ip_length - what's being constructed
...
there is the Transport Control field and subfields thereof, not the
packet length field.
Update some URLs.
svn path=/trunk/; revision=45051
2012-09-22 10:21:05 +00:00
006f022fea
Upgrade PDCP LTE dissector to v11.0.0
...
svn path=/trunk/; revision=45049
2012-09-21 20:12:32 +00:00
a8f9cd6593
Upgrade MAC LTE dissector to v11.0.0
...
svn path=/trunk/; revision=45048
2012-09-21 20:11:11 +00:00
8b6bc1630a
Dissect Update UE Location Information message
...
svn path=/trunk/; revision=45047
2012-09-21 20:00:12 +00:00
6dedc6628b
Test Procedures messages should be also integrity protected
...
svn path=/trunk/; revision=45046
2012-09-21 19:58:34 +00:00
201380fd33
Detected typos in speech codec value.
...
- Refactored code to use proto_tree_add_item() and use a value string.
svn path=/trunk/; revision=45044
2012-09-21 13:36:07 +00:00
5376508e7d
Fix bug #7669 : Preference editor removes (does not save) column definitions after the 27th.
...
put_string_list() was generating string with list of columns to be saved to preference file,
but buffer is limited to MAX_FMT_PREF_LEN (1024 bytes). It looks like 1024 bytes is not enough.
Fix bug by writting directly to file.
svn path=/trunk/; revision=45043
2012-09-21 12:29:04 +00:00
467976f37f
Assuming transport_protocol is a guint8.
...
svn path=/trunk/; revision=45042
2012-09-21 11:54:30 +00:00
ff1a7d93bf
From Michal Labedzki:
...
Bluetooth: Provide PSM for higher layers
This is needed by AVRCP, HCRP and AVDTP to recognize other substreams.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740
svn path=/trunk/; revision=45041
2012-09-21 11:30:53 +00:00
1684c38d44
From Michal Labedzki:
...
Add SAP dissector
Add Bluetooth Profile SAP. Supported version: 1.1.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715
svn path=/trunk/; revision=45040
2012-09-21 11:14:33 +00:00
aa3c9034f5
From Michal Labedzki:
...
Bluetooth: Cleanup headers
Remove redundant headers and sort existing to chosen convention.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
svn path=/trunk/; revision=45039
2012-09-21 10:49:44 +00:00
8974a27357
From Michal Labedzki:
...
FCS is not part of "Control" subtree so move it.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
svn path=/trunk/; revision=45038
2012-09-21 10:39:15 +00:00
0382e69331
From Michal Labedzki:
...
Bluetooth: Improve internal Decode By Channel for RFCOMM
Use UAT to allow user to force set top dissector per channel.
Only first found dissection for specified channel is used,
the rest can be used as well-known protocol on channel, but not for
current logs. Also user can turn on/off this dissection by one-click
preference.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
svn path=/trunk/; revision=45037
2012-09-21 08:52:45 +00:00
b36016fc1d
I guess the IETF is now keeping expired I-Ds around; alternic doesn't
...
have that one any more.
svn path=/trunk/; revision=45030
2012-09-20 20:17:53 +00:00
fad5d18b8b
Add URL for WCCP V2 revision 1
...
svn path=/trunk/; revision=45028
2012-09-20 18:36:12 +00:00
0bacfd7ec9
started a dissector for DTCP-IP
...
(Digital Transmission Content Protection over IP)
svn path=/trunk/; revision=45027
2012-09-20 17:46:42 +00:00
8f0d5f99c6
As suggested by Xavier Raynaud in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6425 :
...
scanner.c includes (depends on) grammar.h so mark it so in the Makefiles.
svn path=/trunk/; revision=45020
2012-09-20 03:04:48 +00:00
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
3729335973
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45016
2012-09-20 01:48:30 +00:00
300eb81514
Fix up some indentation and trailing white space.
...
svn path=/trunk/; revision=45009
2012-09-19 19:34:17 +00:00
4b5a9a2663
Since r41681, IPv6 sets pinfo->ip_ttl as the hop limit, so display that in the
...
INFO column, similar to how IPv4 displays the TTL.
svn path=/trunk/; revision=45008
2012-09-19 19:12:25 +00:00
86db174948
Fix request/response tracking with checksum corner case.
...
svn path=/trunk/; revision=45007
2012-09-19 17:57:54 +00:00
d729f21ad2
Revert r45005.
...
svn path=/trunk/; revision=45006
2012-09-19 16:56:59 +00:00
a232ae9242
Make proto_item_append_string() behave sanely, and use it in a few more
...
dissectors.
svn path=/trunk/; revision=45005
2012-09-19 11:58:32 +00:00
0543f20a15
From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7736 :
...
Fix dissection error of D-RELEASE and D-CONNECT in TETRA dissector
svn path=/trunk/; revision=45004
2012-09-19 11:02:19 +00:00
30b7b74dde
Remove #defines that provided backward source compatibility
...
for deprecated dissector add/remmove/... functions.
svn path=/trunk/; revision=45000
2012-09-19 07:20:49 +00:00
bce733e4d8
SCSI: Dont show two reserved bytes in the decode pane for standard INQ page
...
svn path=/trunk/; revision=44999
2012-09-19 02:12:38 +00:00
b6e0cc28a5
From Daniel via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7716
...
Adding VHT Radiotap fields support
Parsing and UI representation for recently adopted VHT Radiotap fields for
802.11ac specification
http://www.radiotap.org/defined-fields/VHT
From me :
* Make checkAPIs happy
* Fix wrong last argument for some proto_tree_add_item
* Use proto_tree_add_item when it is possible
svn path=/trunk/; revision=44985
2012-09-18 20:46:05 +00:00
a016cd7740
Revert r44978: dissector_add_uint: Legalize formerly improper use of the API when calling it with pattern value of 0
...
dissector_add_uint() is *not only* used by tcp.port/udp.port dissector tables where 0 is not valid port number,
in some dissector tables 0 is valid protocol number, packet type, etc..
Sample dissectors using dissector_add_uint(.pattern = 0):
packet-ansi_637.c:2348: dissector_add_uint("ansi_a.sms", 0, ansi_637_trans_handle);
packet-cip.c:6017: dissector_add_uint("cip.class.iface", 0, cip_class_generic_handle );
packet-lon.c:723: dissector_add_uint("cnip.protocol", 0, lon_handle);
packet-q931.c:3599: dissector_add_uint("lapd.sapi", LAPD_SAPI_Q931 /* 0 */, q931_handle);
svn path=/trunk/; revision=44980
2012-09-18 19:29:00 +00:00
6e81599840
If all ports are set to 0, then register the handle so "Decode As..." works.
...
svn path=/trunk/; revision=44979
2012-09-18 19:28:44 +00:00
ce7c79c0a3
dissector_add_uint:
...
Legalize formerly improper use of the API when calling it with
pattern value of 0
svn path=/trunk/; revision=44978
2012-09-18 19:04:04 +00:00
183cbe9af1
Fix up proto_reg_handoff_hazelcast(), setting "initialized" to TRUE once initialized and also avoiding duplicate "tcp.port" registration.
...
svn path=/trunk/; revision=44977
2012-09-18 18:20:02 +00:00
f870e83fb3
Don't register to udp port 0.
...
svn path=/trunk/; revision=44976
2012-09-18 18:15:21 +00:00
e746d8091d
Don't register to udp/tcp port 0, but use dissector_add_handle() instead.
...
svn path=/trunk/; revision=44975
2012-09-18 18:14:24 +00:00
cb5b915840
Fix dissection of Scheduling Information MAC Control Element when it is the only LCID in the MCH PDU
...
svn path=/trunk/; revision=44973
2012-09-18 17:26:00 +00:00
fd6b314416
parse nfsv4.1 SEQUENCE status flags ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7726 )
...
svn path=/trunk/; revision=44970
2012-09-18 14:12:17 +00:00
f218d66053
Only provide the parameter data in the tvb used when calling subdissector for private extensions.
...
Add vendor ID to item.
Show flags in hex.
svn path=/trunk/; revision=44967
2012-09-18 07:39:14 +00:00
15dca08b65
Fix uninitialized value warnings from GCC.
...
svn path=/trunk/; revision=44966
2012-09-18 02:17:24 +00:00
7d31b63dbc
Do some reformatting.
...
svn path=/trunk/; revision=44965
2012-09-18 01:34:08 +00:00
07a1067f26
From Michael Lum: Fix typo.
...
svn path=/trunk/; revision=44964
2012-09-18 00:47:37 +00:00
048c68529c
Initialize all hf's to -1, not 0.
...
svn path=/trunk/; revision=44962
2012-09-18 00:33:19 +00:00
f8506c50c9
Two hf's were not initialized to -1. They are now.
...
svn path=/trunk/; revision=44961
2012-09-18 00:25:57 +00:00
7334bc59e5
Initialize ett's and hf's to "-1", not "- 1".
...
svn path=/trunk/; revision=44959
2012-09-18 00:16:01 +00:00
eb08c40b09
There is no proto_reg_handoff_data() so don't prototype it. Remove unnecessary include (glib.h).
...
svn path=/trunk/; revision=44953
2012-09-17 21:26:19 +00:00
cc4e2d3566
#include <epan/prefs.h> not req'd.
...
svn path=/trunk/; revision=44951
2012-09-17 18:05:21 +00:00
8a82b7a361
Cleanup:
...
- fix two cases of potential infinite loop while dissecting;
[for (guint8 i; i <= guint8 end; i++)]
- col_...() fcns should not be called under 'if (tree)'
- remove unneeded initializers;
- move proto_reg_handoff...() to the end of the file as per convention;
- remove some boilerplate comments;
- use consistent indentation and whitespace style;
- remove some trailing whitespace.
svn path=/trunk/; revision=44950
2012-09-17 17:47:43 +00:00
b29ae79cf6
Cleanup:
...
- fix several instances of a potential infinte loop while dissecting TLVs;
(it would be nice to have a valid capture file so this dissector can be fuzz-tested)
- move proto_reg_handoff...() to the end of the file as per convention;
- do find_dissector() only once in proto_reg_handoff...();
- reformat some long lines;
- replace some tabs by spaces and do other whitespace changes.
svn path=/trunk/; revision=44949
2012-09-17 16:05:43 +00:00
d530983a67
Update dissection of Request type IE
...
svn path=/trunk/; revision=44948
2012-09-17 16:04:36 +00:00
d3334cb21d
Handle SDP_CRYPTO optional parameters better.
...
svn path=/trunk/; revision=44946
2012-09-17 15:37:28 +00:00
31c1f7d11d
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
...
Enhance DNS Dissector
Enhance DNS : make DNSKEY type filterable
svn path=/trunk/; revision=44945
2012-09-17 15:19:18 +00:00
e057832c84
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
...
Enhance DNS Dissector
Enhance DNS : make RRSIG type filterable
svn path=/trunk/; revision=44944
2012-09-17 15:18:54 +00:00
0002fd11b5
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
...
Enhance DNS Dissector
Enhance DNS : make TXT, SPF type filterable
svn path=/trunk/; revision=44943
2012-09-17 15:18:32 +00:00
9e5e7b75df
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
...
Enhance DNS Dissector
Enhance DNS : make MX filtereable
svn path=/trunk/; revision=44942
2012-09-17 15:17:48 +00:00
c5826e292a
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
...
Enhance DNS Dissector
Enhance DNS : make HINFO filtereable
svn path=/trunk/; revision=44941
2012-09-17 15:16:34 +00:00
8e74cd8d16
Fix errors in the packet length checks.
...
svn path=/trunk/; revision=44939
2012-09-17 12:13:34 +00:00
9db969ded1
Add IPv6 heuristic.
...
svn path=/trunk/; revision=44938
2012-09-17 10:46:56 +00:00
Michael Mann