osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
35,071 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

11704 Commits

Author SHA1 Message Date
Bill Meier cca5904550 Don't assign to a proto_item * if the value won't be used: Coverity 923-927; 
Add braces around around certain code sections for indentation purposes;
Do some indentation & whitespace cleanup.

svn path=/trunk/; revision=36529
 2011-04-09 17:11:13 +00:00
Bill Meier 2674aeb1ff Don't assign to a proto_item * if the value won't be used: Coverity 891 & 892; 
Also: #include <stdlib.h> & <string.h> not req'd;  fix some indentation.


svn path=/trunk/; revision=36528
 2011-04-09 13:44:00 +00:00
Bill Meier 1667de16c5 Don't assign to a proto_item * if the value won't be used: Coverity 990; 
Add some missing code: improves display of "main_opcode" field: Coverity 991, 993 & 994;
Fix bug introduced a while back: "changeinfo4" field details aren't displayed: Coverity 992;
Add missing code so READDIR (V4) details  are shown in a subtree (as presumably was originally intended);
Fix some indentation.

svn path=/trunk/; revision=36525
 2011-04-08 20:06:56 +00:00
Alexis La Goutte fbe119c3c5 Enhance Vendor Specific Atheros IE 
* Replace proto_tree_add_ether/boolean by proto_tree_add_item
* use BASE_CUSTOM for XR beacon interval 
* use ENC_* macro for encoding
* replace if(...) by switch(...) for type and subtype (more extensible if new (sub)type)
* add expert info when tag_len is incorrect

Fix also a minor issue with tag_end...


svn path=/trunk/; revision=36523
 2011-04-08 19:52:04 +00:00
Gerald Combs a5b20fbdf6 Add a relative path to the "#line" directives we produce. Regenerate the 
SNMP and SPNEGO dissectors to see if it helps Coverity locate the
original source files.

svn path=/trunk/; revision=36522
 2011-04-08 19:51:39 +00:00
Anders Broman da3f7673db From Pascal Quantin: 
Upgrade LTE RRC ASN.1 description to V9.6.0

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5815

svn path=/trunk/; revision=36520
 2011-04-08 17:36:53 +00:00
Stephen Fisher 374558c830 From Juliusz Chroboczek via bug #5812: Dissector for the Babel Routing 
Protocol (RFC 6126)


svn path=/trunk/; revision=36518
 2011-04-08 16:53:02 +00:00
Anders Broman f5c1fc47af Use tvb_get_ephemeral_string() 
prefix hf vars with hf_sip

svn path=/trunk/; revision=36516
 2011-04-08 11:58:33 +00:00
Gerald Combs f989235a87 Use a unique variable name. Fixes Coverity CID 593. 
svn path=/trunk/; revision=36512
 2011-04-07 23:52:37 +00:00
Anders Broman 538b62429d Make it possible to have a sub dissector dissect the status line diagnostic string should it contain more than a string. 
svn path=/trunk/; revision=36509
 2011-04-07 21:39:49 +00:00
Alexis La Goutte 99ff83cffc Enhance Tag Measurement Request & Report 
* Replace proto_tree_add_uint*/boolean/text by proto_tree_add_item
* use ENC_* macro for encoding
* ...

My first commit !

svn path=/trunk/; revision=36506
 2011-04-07 16:16:47 +00:00
Bill Meier df0f97844e (Trivial) Fix a typo & some indentation. 
svn path=/trunk/; revision=36505
 2011-04-07 14:07:54 +00:00
Stephen Fisher 59a5ab8788 Enhancement bug #5796: Add Atheros vendor specific 802.11 IE parsing 
svn path=/trunk/; revision=36502
 2011-04-06 19:57:39 +00:00
Anders Broman cd8af5a050 Add RoHC to the ethertypes. 
svn path=/trunk/; revision=36499
 2011-04-06 18:48:07 +00:00
Anders Broman 2251b8d331 From Johan Wåhl: 
Add dissection of feature list flags.

svn path=/trunk/; revision=36497
 2011-04-06 15:01:42 +00:00
Bill Meier 964690903f Use the correct handle when registering "media_type" "application/vnd.3gpp2.sms": Coverity 835. 
svn path=/trunk/; revision=36496
 2011-04-06 12:19:38 +00:00
Stig Bjørlykke 1fd17eb0d9 Fixed blurb for BER Error. 
svn path=/trunk/; revision=36495
 2011-04-06 09:59:21 +00:00
Stig Bjørlykke 3a1673c04c Made "BER Error" filterable. 
svn path=/trunk/; revision=36494
 2011-04-06 08:52:42 +00:00
Anders Broman c039f9f8a8 Add a comment 
svn path=/trunk/; revision=36490
 2011-04-06 06:24:19 +00:00
Tomas Kukosa 4e8c772d11 RFC5806 Diversion header 
svn path=/trunk/; revision=36489
 2011-04-06 06:20:50 +00:00
Anders Broman cb0e7f80da Missing decoding for CalledPartyBCD number in CAMEL 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5788

svn path=/trunk/; revision=36488
 2011-04-06 06:20:32 +00:00
Stephen Fisher 250aa8810f Fix Coverity 1062: UNUSED_VALUE 
svn path=/trunk/; revision=36486
 2011-04-06 00:07:52 +00:00
Bill Meier 982decd6b2 Set the correct properties .... 
svn path=/trunk/; revision=36485
 2011-04-05 23:26:56 +00:00
Chris Maynard 595e5e1c1d Add ICMP tap support, and add a tshark tap to measure such things as: 
* Number of ICMP echo requests, replies, lost replies and percent loss.
  * Min, Max, Average SRT (Service Response Time), and standard deviation.
(This is my first tap, so hopefully I didn't miss something, but we'll see ...)
TODO: Add a Wireshark tap.


svn path=/trunk/; revision=36480
 2011-04-05 20:21:59 +00:00
Stig Bjørlykke c13f84b345 Compile fix: camel_obj_id -> obj_id. 
svn path=/trunk/; revision=36475
 2011-04-05 15:49:56 +00:00
Anders Broman 909a166343 Actually get the oid string ... 
svn path=/trunk/; revision=36474
 2011-04-05 15:43:15 +00:00
Bill Meier 91991145de Don't assign to a proto_item * if the value won't be used: Coverity 858; 
Fix two cases where items appear to be added to the wrong tree: Coverioty 856 & 857.
Also: remove some unneeded #includes& do some whitespace cleanup.

svn path=/trunk/; revision=36473
 2011-04-05 15:33:56 +00:00
Bill Meier 40892a0f27 Don't assign to a proto_item * if the value won't be used: Coverity 882; 
Also: #include <string.h> not req'd

svn path=/trunk/; revision=36472
 2011-04-05 15:09:32 +00:00
Jeff Morriss dcdbb29bed Remove some unused hf_ variables. 
svn path=/trunk/; revision=36469
 2011-04-05 02:35:32 +00:00
Jeff Morriss a148a936b1 From Felix Kraemer: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 : 
This patch adds the capability to create BACnet statistics trees. 
Find the respective menu items under 'Statistics->BACnet'.
Packets can be sorted by different criteria:
- Src/Dst IP adresses
- Instance ID
- Object Type
- Service

From me:
- Don't use C++/C99-style comments.
- Name variables for tick_stat_node() don't need to be static.
- Change updateBacnetInfoValue() to require 'data' to be ep_ allocated.  Change
  the couple of calls that did not send in ep_ allocated data to do so.
- Change one or two functions to be static.
- Do not use (memory-unsafe) g_sprintf().
- Use ep_strconcat() instead of leaking memory with g_strconcat().
- Put back one if(tree) that doesn't appear to do any harm.
- Remove variable declarations and #includes from the header file.

svn path=/trunk/; revision=36468
 2011-04-05 02:18:28 +00:00
Bill Meier 49ac29b682 Don't assign to a proto_item * if the value won't be used: Coverity 850; 
Also: remove some unneeded #includes.

svn path=/trunk/; revision=36466
 2011-04-04 20:03:27 +00:00
Bill Meier 0820763edb Fix "MISSING_BREAK"; Coverity 436. 
svn path=/trunk/; revision=36465
 2011-04-04 19:41:51 +00:00
Bill Meier 747477c7ab Don't assign to a proto_item * if the value won't be used: Coverity 846 & 848; 
Also: remove some unneeded #includes


svn path=/trunk/; revision=36464
 2011-04-04 19:23:39 +00:00
Bill Meier db925b3bfb Don't assign to a proto_item * if the value won't be used: Coverity 836; 
Also: remove some unneeded #includes.

svn path=/trunk/; revision=36460
 2011-04-04 18:41:49 +00:00
Bill Meier 07e325bf63 Don't assign to a proto_item * if the value won't be used: Coverity 832-834. 
Also: white space cleanup.

svn path=/trunk/; revision=36459
 2011-04-04 18:13:22 +00:00
Stephen Fisher 5499d2a6bd Fix Coverity 1137, 1138, 1139: UNUSED_VALUE 
svn path=/trunk/; revision=36457
 2011-04-04 17:56:16 +00:00
Bill Meier c6c91f8e76 Don't assign to a proto_item * if the value won't be used: Coverity 829 & 830; 
Fix a minor bug wherein a number of proto_tree_add_...() used the wrong tree: Coverity 831;
Remove some unneeded #includes.

svn path=/trunk/; revision=36456
 2011-04-04 17:49:32 +00:00
Stephen Fisher 39699efe92 Fix compilation error: 
packet-amqp.c:5617:5: error: "/*" within comment

Cause:

Previous comment wasn't terminated right


svn path=/trunk/; revision=36454
 2011-04-04 17:42:37 +00:00
Bill Meier 8b0a085250 Don't assign to a proto_item * if the value won't be used: Coverity 827; 
Comment out some currently unused code: Coverity 828.

svn path=/trunk/; revision=36453
 2011-04-04 17:24:17 +00:00
Bill Meier e2ee0e52d8 Don't assign to a variable if the value won't be used: Coverity 826; 
Also: Remove some uneeded #includes & use consistent indentation.

svn path=/trunk/; revision=36451
 2011-04-04 16:54:02 +00:00
Bill Meier cf20622668 Don't assign to a proto_item * if the value won't be used: Coverity 823 & 824; 
Fix a minor bug wherein a proto_tree_add_text used the wrong tree: Coverity 825;
Remove some unneeded #includes;
Use consistent indentation.

svn path=/trunk/; revision=36449
 2011-04-04 16:13:42 +00:00
Bill Meier aec98c121a Don't assign to a proto_item * if the value won't be used: Coverity 820/821; 
Also: #include <stdio.h> & <string.h> not required;


svn path=/trunk/; revision=36447
 2011-04-04 15:38:19 +00:00
Bill Meier ede51600c7 Don't assign to a variable if the value won't be used: Coverity 817-821. 
svn path=/trunk/; revision=36446
 2011-04-04 15:31:33 +00:00
Anders Broman a7d7365f4a Mark pinfo as unused. 
svn path=/trunk/; revision=36445
 2011-04-04 15:09:22 +00:00
Anders Broman aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman 72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Bill Meier f3af25f270 Don't assign to a proto_item* if the value won't be used: Coverity 885-889 
Also: Significant code rework including:
  - Fix bug wherein a timestamp was incorrectly reported as being an Error;
  - Replace many proto_tree_add_text()/proto_item_set_text() sequences each by a
    single proto_tree_add_text().
  - remove unneeded #include <string.h>
  - Whitespace clanup including replacing mixed space/tab indentation by spaces.


svn path=/trunk/; revision=36437
 2011-04-03 15:39:01 +00:00
Anders Broman e645e3c4d0 -Whitespace fix in gsm_map-template(no need to regenerate). 
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

svn path=/trunk/; revision=36435
 2011-04-02 09:18:18 +00:00
Jeff Morriss 43f966a0ea From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 6 :
Enhance the MySQL collation

Patch 7 :
Enhance MySQL : add dissection of command Binlog Dump (replicate command).

svn path=/trunk/; revision=36433
 2011-04-01 19:50:50 +00:00
Chris Maynard 4233a227ef Avoid potential buffer overruns when sscanf'ing strings. 
Should resolve CID's 656 and 657.

svn path=/trunk/; revision=36432
 2011-04-01 18:16:47 +00:00
Chris Maynard 2db46ad8d4 Remove const type qualifier from cast. Resolves CID's 582-585. 
svn path=/trunk/; revision=36430
 2011-04-01 16:30:59 +00:00
Martin Mathieson 5344e9f3d9 Take care not to append RLC mode to proto_item twice. 
svn path=/trunk/; revision=36429
 2011-04-01 13:41:08 +00:00
Chris Maynard 6760848315 Fix 11 occurrences of returned pointer never used. Fixes CID's 1064-1067. 
svn path=/trunk/; revision=36426
 2011-03-31 19:17:06 +00:00
Chris Maynard f8737dfbcc From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were: 
"warning: Value stored to 'offset' is never read".  The 'offset' is now used.

svn path=/trunk/; revision=36419
 2011-03-31 15:17:49 +00:00
Chris Maynard 0db9556757 Delete unused header fields found by running tools/checkhf.pl. 
svn path=/trunk/; revision=36418
 2011-03-31 14:35:40 +00:00
Chris Maynard f88037ac41 From Yair via bug 5779: Add option to leave AAL5 in unspecified format. 
(... with whitepsace changes by me.)

svn path=/trunk/; revision=36416
 2011-03-31 14:23:07 +00:00
Chris Maynard 1e71ccef15 From Andrew Feren via bug 5775: Correct types on several info elements. 
svn path=/trunk/; revision=36415
 2011-03-31 14:03:23 +00:00
Stig Bjørlykke 8d62b393a4 Register tcp by name. 
To be used in User DLT's and Lua scripts.

svn path=/trunk/; revision=36414
 2011-03-31 12:18:14 +00:00
Stig Bjørlykke a54e28e2ec Use correct functions to fetch protocol name for a dissector registered 
by register_dissector().

svn path=/trunk/; revision=36413
 2011-03-31 12:16:41 +00:00
Stig Bjørlykke 0b8be02229 Use correct length for clientaddr4 callback address entry. 
svn path=/trunk/; revision=36411
 2011-03-31 11:01:06 +00:00
Ronnie Sahlberg 13f6b77d92 remove two pointless const in casts 
coverity 580 and 581

svn path=/trunk/; revision=36407
 2011-03-30 04:36:09 +00:00
Ronnie Sahlberg f3512de0a9 remove some assignments we dont use 
svn path=/trunk/; revision=36406
 2011-03-30 03:39:58 +00:00
Chris Maynard a4452f43fa Change TCP_PORT_MANGO to TCP_PORT_MONGO. 
svn path=/trunk/; revision=36405
 2011-03-29 21:40:54 +00:00
Chris Maynard 83dc9446ec From Alexis La Goutte via bug 5790: Add partial bit flag in query. 
svn path=/trunk/; revision=36399
 2011-03-29 20:58:57 +00:00
Anders Broman ba8a739f4c Remove check_col(). 
svn path=/trunk/; revision=36396
 2011-03-29 14:23:21 +00:00
Stig Bjørlykke f7c84ad094 From Pascal Quantin: 
Added guard against proto_name's not resolved as protocols.

svn path=/trunk/; revision=36392
 2011-03-29 11:08:15 +00:00
Tomas Kukosa 7c083c0966 RTP: display payload type name from dynamic payload type table 
H.223: use just one protocol for bot dissectors for more clear protocol disabling 

svn path=/trunk/; revision=36391
 2011-03-29 10:56:30 +00:00
Chris Maynard d69a7dac79 Cast to guint to avoid a Windows compiler warning. 
svn path=/trunk/; revision=36389
 2011-03-28 22:22:05 +00:00
Stephen Fisher d4649392d8 Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul. 
svn path=/trunk/; revision=36386
 2011-03-28 20:53:20 +00:00
Jeff Morriss c977007591 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 : 
Fix a Clang warning, add email address, and add some stuff to COL_INFO.

svn path=/trunk/; revision=36381
 2011-03-28 15:28:03 +00:00
Jeff Morriss c39c25ce9c From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 : 
Register the reload-framing dissector by name.  Needed when RELOAD is not used
over udp/tcp (but tls, for example)

svn path=/trunk/; revision=36380
 2011-03-28 15:23:27 +00:00
Jeff Morriss 569c3d9014 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 5

Enchance MySQL : 
* Add expert info of when undecoded data 
* Fix some white space

svn path=/trunk/; revision=36379
 2011-03-28 15:20:16 +00:00
Chris Maynard ba9dc9f45f Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in 
the value="..." attribute.  Fixes bug 1520.

svn path=/trunk/; revision=36378
 2011-03-28 14:53:35 +00:00
Stig Bjørlykke b95c4cb6a2 Added payload, header and trailer information to the DLT tree entry. 
svn path=/trunk/; revision=36377
 2011-03-28 14:18:29 +00:00
Bill Meier 0da2042447 Fix Coverity 393: "DEADCODE"; Add an XXX comment 
svn path=/trunk/; revision=36373
 2011-03-27 16:15:19 +00:00
Gerald Combs 8cc32fd535 Add the IPv4 address, not the first 4 bytes of its name, to the 
resolution table.

svn path=/trunk/; revision=36370
 2011-03-27 15:58:52 +00:00
Bill Meier 7a77cdf0f1 1. Fix bug in dissection of a field; Add two missing lines of code. 
2. #if 0 if test "which will never be true"; Add XXX comment

svn path=/trunk/; revision=36369
 2011-03-27 15:39:06 +00:00
Stig Bjørlykke e43c9a35e4 Added a FALLTHRU comment to avoid a "missing break" warning. 
Coverity 472.

svn path=/trunk/; revision=36366
 2011-03-27 14:11:40 +00:00
Anders Broman 129f07a949 Added FALLTHRU comment to avoid a "missing break" warning. 
svn path=/trunk/; revision=36365
 2011-03-27 14:02:42 +00:00
Stig Bjørlykke 3c533baf45 Added a missing break. 
Coverity 452.

svn path=/trunk/; revision=36364
 2011-03-27 13:56:53 +00:00
Stig Bjørlykke 71c369611a Added a missing break. 
Coverity 461.

svn path=/trunk/; revision=36363
 2011-03-27 13:54:53 +00:00
Stig Bjørlykke 473b25301e Added some missing breaks. 
Coverity 462 & 463.

svn path=/trunk/; revision=36362
 2011-03-27 13:51:47 +00:00
Stig Bjørlykke c9468a80be Added some missing breaks. 
Coverity 443 & 444.

svn path=/trunk/; revision=36361
 2011-03-27 13:40:54 +00:00
Stig Bjørlykke 8ce65d5dee Added some missing breaks. 
Coverity 447.

svn path=/trunk/; revision=36360
 2011-03-27 13:35:30 +00:00
Stig Bjørlykke 31b37eec2d Added a FALLTHRU comment to avoid a "missing break" warning. 
Coverity 458.

svn path=/trunk/; revision=36359
 2011-03-27 13:33:28 +00:00
Stig Bjørlykke d79ac3d6b8 Added some missing breaks. 
Coverity 466.

svn path=/trunk/; revision=36358
 2011-03-27 13:30:39 +00:00
Stig Bjørlykke a39c0d9577 Added a missing break. 
Coverity 492.

svn path=/trunk/; revision=36356
 2011-03-27 13:15:14 +00:00
Bill Meier 21d34d05b9 Don't assign to a proto_item* if the value won't be used: Coverity 895-897 
Also: Fix some indentation & whitespace.

svn path=/trunk/; revision=36355
 2011-03-26 16:39:30 +00:00
Jaap Keuter 391b328a6b From Alexis La Goutte: 
A patch to add ATM over TCP Dissector.
The dissector dissect only the ATMTCP header (VCI, VPI, Payload Length) 
The data are not yet dissect, it is necessary to add a "UAT" (As with the K12
dissector) to indicate the type (ILMI, AAL, ATM...) of data (based on VCI/VPI)

svn path=/trunk/; revision=36354
 2011-03-26 16:07:30 +00:00
Stig Bjørlykke ff40ab2174 Added a sanity check to remove a coverity warning. 
Coverity 537.

svn path=/trunk/; revision=36353
 2011-03-26 15:59:57 +00:00
Jaap Keuter ab3fbb4d31 From Hadar Shoham: 
Add support to correlation ID under DHCPv6 according to 
"CL-SP-CANN-DHCP-Reg-I06-110210" 
DHCPv6 option 17 Vendor-specific Information, sub option 2172 (paragraph 5.4.3)

svn path=/trunk/; revision=36347
 2011-03-26 11:23:46 +00:00
Ronnie Sahlberg aa01f6e0f6 remove a proto_item variable we never use 
coverity 866

svn path=/trunk/; revision=36346
 2011-03-26 05:39:45 +00:00
Ronnie Sahlberg f00cc53adb remove a proto_item variable we dont need 
coverity 1046


svn path=/trunk/; revision=36345
 2011-03-26 05:18:09 +00:00
Jeff Morriss 28939cef5c Simplify the generation of the 'name' passed to tick_stat_node(). 
svn path=/trunk/; revision=36342
 2011-03-26 01:22:31 +00:00
Jeff Morriss dd9f86c38d The 'name's passed to tick_stat_node() do not need to be static. 
svn path=/trunk/; revision=36341
 2011-03-26 01:21:43 +00:00
Jeff Morriss 5e1b6cf408 Reword the comments from rev 36304. 
Replace the tabs in the file (mostly added by me) with spaces (for consistency).

svn path=/trunk/; revision=36338
 2011-03-25 22:20:27 +00:00
Stephen Fisher 3a8bd554fe Fix coverity 268, 269, 546, 547, 548, 549 by checking for null return 
from p_get_proto_data() since it should have been set already by the
calling function.  Any other case would be a bug, so call
DISSECTOR_ASSERT in those cases.  Hopefully Coverity realizes that this
is a null return value check.


svn path=/trunk/; revision=36337
 2011-03-25 22:16:23 +00:00
Bill Meier 23eaca915b Don't assign to a proto_item* if the value won't be used: Coverity 941 
svn path=/trunk/; revision=36336
 2011-03-25 22:13:33 +00:00
Bill Meier ea10c028b1 Don't assign to a proto_item* if the value won't be used: Coverity 958-961. 
svn path=/trunk/; revision=36335
 2011-03-25 21:52:56 +00:00
Bill Meier 7d8633af66 Don't assign to a proto_item* if the value won't be used: Coverity 852,854; 
Add a hidden item to the correct subtree: Coverity 853.

svn path=/trunk/; revision=36334
 2011-03-25 21:09:28 +00:00
Jeff Morriss 38b9f1cfbd As suggested by Didier in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 : 
Apply rev 25869 to some more dissectors.

svn path=/trunk/; revision=36333
 2011-03-25 20:04:54 +00:00
Jeff Morriss cc6fc23812 From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 : 
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)

A couple of the patches had to be manually applied.

From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)

svn path=/trunk/; revision=36332
 2011-03-25 19:02:18 +00:00
Chris Maynard 28ef67fb39 Change urb_type from FT_STRING to FT_UINT8. This fixes the display filtering 
for this field.  This change was prompted because of the following query:
    http://ask.wireshark.org/questions/3113/usburb_type-values

Also, remove 2 unused fields found by running tools/checkhf.pl.

svn path=/trunk/; revision=36331
 2011-03-25 18:51:12 +00:00
Jeff Morriss 2c8e2564f6 Fix the problem reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3785#c14 : 
If we thought we finished reassembly (and called the subdissector) only to find
out that the subdissector asked for more data, handle the case where the
subdissector asked for DESEGMENT_UNTIL_FIN.  Previously we only handled the
possibility that the subdissector would ask for a specific number of bytes or
DESEGMENT_ONE_MORE_SEGMENT.

svn path=/trunk/; revision=36330
 2011-03-25 15:45:37 +00:00
Ronnie Sahlberg f4a8e83704 remove two unused assignments 
coverity 1050


svn path=/trunk/; revision=36329
 2011-03-25 07:26:17 +00:00
Ronnie Sahlberg 79e0b02dcd use the newly created tree to store the new items instead of the parent tree 
coverity 842


svn path=/trunk/; revision=36328
 2011-03-25 07:22:23 +00:00
Ronnie Sahlberg b48b51293d remove unused variable 
coverity 229


svn path=/trunk/; revision=36327
 2011-03-25 07:19:15 +00:00
Ronnie Sahlberg 8d93bec973 remove an unused variable 
coverity 1044


svn path=/trunk/; revision=36326
 2011-03-25 07:15:48 +00:00
Ronnie Sahlberg d8f7b6f1ae remove assignment of an unused value 
coverity 1178

svn path=/trunk/; revision=36324
 2011-03-25 03:07:05 +00:00
Gerald Combs 2ea9b63ee7 If a segment looks like a retransmission, don't mark it out-of-order. 
svn path=/trunk/; revision=36323
 2011-03-25 00:28:47 +00:00
Bill Meier e402e91dd1 Don't assign to a proto_item* if the value won't be used: 
Also: Fix a bug wherein PPP_RTP_CUD8 was being registered
 to "ppp.protocol" with the cudp16 handle rather than the cudp8 handle.

Coverity 1004-1013

svn path=/trunk/; revision=36322
 2011-03-24 23:34:13 +00:00
Bill Meier 845612e450 Fix a compile warning: unused variable 
svn path=/trunk/; revision=36320
 2011-03-24 23:05:36 +00:00
Bill Meier 57833dc778 Don't assign to a proto_item* if the value won't be used: Coverity 942-951 
Also: minor Code & Whitespace cleanup.

svn path=/trunk/; revision=36317
 2011-03-24 22:27:20 +00:00
Stephen Fisher df50d409fb Only display the 3 digits of precision after the decimal that we have 
from the ICMP conversation response time tracking. 


svn path=/trunk/; revision=36316
 2011-03-24 21:22:07 +00:00
Bill Meier 78dda7cc7e Don't assign to a proto_item* if the value won't be used: Coverity 1124-1128; 
Also: minorwhitespace cleanup.


svn path=/trunk/; revision=36314
 2011-03-24 20:17:22 +00:00
Chris Maynard 9493ebe8e9 Display the value of the ICMP echo request/reply response time in milliseconds. 
svn path=/trunk/; revision=36313
 2011-03-24 18:05:10 +00:00
Jeff Morriss 01ec42762f From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 3 :
Enhance MySQL : Request/Response sub-dissector/function 
(white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()...)

Patch 4 :
Enhance MySQL : packet_ok, server, capa sub-dissector/function (white space
changes, use ENC_NA when appropriate, use proto_tree_add_item()...)

Split mysql_dissect_caps in mysql_dissect_caps_client and
mysql_dissect_caps_server

Rename mysql_dissect_ext_caps to mysql_dissect_ext_caps_client

svn path=/trunk/; revision=36309
 2011-03-24 15:31:52 +00:00
Anders Broman db3a34973a Beutify IMEISV IE output. 
svn path=/trunk/; revision=36308
 2011-03-24 10:36:39 +00:00
Anders Broman d11e6439cd Fix Checkapi errors 
Error: the name for field " N32" ("gsm_rlcmac_dl.n32") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N51" ("gsm_rlcmac_dl.n51") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N26" ("gsm_rlcmac_dl.n26") has leading space in packet-gsm_rlcmac.c

svn path=/trunk/; revision=36307
 2011-03-24 10:35:29 +00:00
Anders Broman 4cd37afb6c From Vincent Helfre: 
I updated again the csn1 dissector to associate hf_field to each element.

svn path=/trunk/; revision=36306
 2011-03-24 09:20:14 +00:00
Jeff Morriss bb61772be7 From Dirk: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2930 : 
Make the image (png, gif, jfif) dissectors "new style" so that they don't
dissect data that does not belong to them.

Modify the HTTP dissector to call heuristic dissectors on the body if the
registered subdissector does not accept/dissect the data.

From me: don't use assert() and don't add a preference to the HTTP dissector
for this behavior: it makes sense to behave like that by default.

svn path=/trunk/; revision=36305
 2011-03-24 02:49:05 +00:00
Jeff Morriss 8c73d0c6f4 If we've already seen a segment which starts a multi-segment pdu (i.e., it's 
a retransmission), don't add it to the list (tree) of multi-segment pdus.

Otherwise, if we'd already seen the rest of the pdu and the other segments
were not retransmitted, the retransmission would break dissection of the pdu
because lookups for the segment would find the retransmission (to which the
other segments were not attached).

Since we know this segment is a retransmission, don't bother handing it off
to the subdissector either.

Use PINFO_FD_VISITED().
Add some white space in the desegmentation routine to improve readability.

Apply the same changes to the SSL dissector.

svn path=/trunk/; revision=36304
 2011-03-24 02:10:04 +00:00
Ronnie Sahlberg 5f502a5bfb remove a conditional that can never be true 
coverity 247


svn path=/trunk/; revision=36301
 2011-03-23 21:17:29 +00:00
Chris Maynard 276e9cced3 Add ICMP echo request/reply conversation tracking. Closes bug 5770. 
svn path=/trunk/; revision=36298
 2011-03-23 20:20:40 +00:00
Jeff Morriss e7a6230eca From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 1 :
Enhance MySQL : Reorder hf and Proto_reg

Patch 2 :
Enhance MySQL : white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()

svn path=/trunk/; revision=36296
 2011-03-23 19:12:24 +00:00
Bill Meier 95402cf9de Fix bug: 'if ((octet & 0x80) == 80)' ==> 'if ((octet & 0x80) == 0x80)' 
Coverity 345

svn path=/trunk/; revision=36293
 2011-03-23 15:21:18 +00:00
Bill Meier ae465d5d39 Fix bugs: 'if ((flags & 0x2) == 1)' ==> 'if ((flags & 0x2) != 0)' 
Coverity 346 & 347

svn path=/trunk/; revision=36292
 2011-03-23 15:15:02 +00:00
Bill Meier fc11b62891 Fix bug: 'guint8 |=0x8000'. 
Coverity 350

svn path=/trunk/; revision=36289
 2011-03-23 14:51:40 +00:00
Jeff Morriss 50c8f0f80a Don't use C++/C99-style comments. 
svn path=/trunk/; revision=36288
 2011-03-23 13:18:38 +00:00
Martin Mathieson d620640a70 Remove some unncessary assignments to proto_item pointers. 
Coverity 904 & 905.

svn path=/trunk/; revision=36287
 2011-03-23 11:35:03 +00:00
Martin Mathieson b47c36a4bd Don't assign proto_item pointers that are not used. 
Coverity CIDs 1021 & 1022.

svn path=/trunk/; revision=36286
 2011-03-23 10:58:24 +00:00
Martin Mathieson 473b578880 Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack. 
svn path=/trunk/; revision=36285
 2011-03-23 10:12:35 +00:00
Anders Broman fd782e736c From Vincent Helfre: 
- added documentation in packet-csn1.h
- fixed a bug in packet-csn1.c
- fixed a BSIC description in packet-gsm_a_rr.c
- removed the "_v" suffix in packet-gsm_rlcmac element description

svn path=/trunk/; revision=36284
 2011-03-23 09:14:50 +00:00
Stig Bjørlykke aca69d699a Removed "comparing an array to null", with no effect. 
Coverity 532.

svn path=/trunk/; revision=36279
 2011-03-23 07:25:08 +00:00
Ronnie Sahlberg 0832de6b8e value&0x03 does not need to be shifted to the right by two. 
cut-n-paste bug from a few lines above where value&0x0c do need to be shifted by two
before printing as a value

coverity 342


svn path=/trunk/; revision=36278
 2011-03-23 06:50:09 +00:00
Anders Broman 691c566900 CID 453,454 
Missing break

svn path=/trunk/; revision=36277
 2011-03-23 05:48:58 +00:00
Ronnie Sahlberg 89d3156883 Shift the correct number of steps when masking the UAAERP bit to 0/1 
coverity 348

svn path=/trunk/; revision=36274
 2011-03-23 04:55:22 +00:00
Ronnie Sahlberg 24eb2e7b6e The NSG bits in the login pdu are 0x0c not 0xc0 
coverity 344


svn path=/trunk/; revision=36273
 2011-03-23 04:50:17 +00:00
Ronnie Sahlberg feaf55330e Coverity 989 
Remove some item=  assignments we dont need since we never use the value
of the created item.


svn path=/trunk/; revision=36269
 2011-03-22 20:48:36 +00:00
Bill Meier 1f5bfa75b1 Remove two tests for fail return from g_malloc(); Fixes Coverity #424 "FORWARD_NULL" 
svn path=/trunk/; revision=36267
 2011-03-22 19:27:48 +00:00
Stig Bjørlykke fac93b08b2 Allocate correct size of nwk_keyring. 
Coverity 715.

svn path=/trunk/; revision=36265
 2011-03-22 19:16:19 +00:00
Stig Bjørlykke 41d5c9b750 Allocate correct size of hash_key. 
Coverity 713.

svn path=/trunk/; revision=36264
 2011-03-22 19:13:48 +00:00
Stig Bjørlykke f51139e659 Allocate correct size of reload_frame. 
Coverity 714.

svn path=/trunk/; revision=36263
 2011-03-22 19:13:05 +00:00
Stig Bjørlykke 2cc2403a33 Initialize al_cto before usage. 
Coverity 808.

svn path=/trunk/; revision=36260
 2011-03-22 18:42:02 +00:00
Bill Meier fda538056f Fix potential array overrun: Coverity CID #565. 
svn path=/trunk/; revision=36258
 2011-03-22 18:26:36 +00:00
Martin Mathieson 46857df13e Fix mask when extracting FACH Indicator. 
Coverity CID 349.

svn path=/trunk/; revision=36257
 2011-03-22 18:24:38 +00:00
Martin Mathieson 0370a7977d Remove redundant comparison. 
Coverity CID 361.

svn path=/trunk/; revision=36256
 2011-03-22 18:06:58 +00:00
Martin Mathieson 034820599a Make a struct static to avoid growing the stack too much. 
Coverity CID 753.

svn path=/trunk/; revision=36255
 2011-03-22 17:46:59 +00:00
Martin Mathieson bed50222ac Don't assign top_ti - delete it for now. 
Coverity CID 862

svn path=/trunk/; revision=36254
 2011-03-22 17:37:47 +00:00